From nobody Thu Apr 9 21:52:26 2026 Received: from mail-pl1-f225.google.com (mail-pl1-f225.google.com [209.85.214.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B00441C0B4 for ; Thu, 5 Mar 2026 20:01:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772740902; cv=none; b=DTCIDnaD23rT4J3YxWhKv438Me8mluaNkPeVZMy0M2eM6BliadruPo90uXUfs6UwFEXoyiXdlOpJ0pdrGyo25RabDJC/5xbB5Z861gGr9ktBxdXnwpJ9DGlxuJbIiqJSId53TJOH+B22/Up3pElItq+ajLgzhwGySy0ufSd19ec= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772740902; c=relaxed/simple; bh=9AGF9XBFZghn+Ips10ZkQuoIQMsvGj2VhGcNFsPlZic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JsJlYnLuES0eoAzURzBdISm6GQop0TPVkide3wTLGNYtEpmQHx8w8QidFgddQDd0UovIBCccKioLA5YvUcuXrgqkDo9L9luJ6eSM2ltVOz1QQQjl/QD4UZMxGbhIfQ1u+2srHiOWvpEYzcYzfwFM6wHtq3nOzmbkB0BnuZ64dlM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=PK5o3JuU; arc=none smtp.client-ip=209.85.214.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="PK5o3JuU" Received: by mail-pl1-f225.google.com with SMTP id d9443c01a7336-2ae4d919f9bso30007255ad.0 for ; Thu, 05 Mar 2026 12:01:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772740901; x=1773345701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RNQeU+4LebvP/QMzlSZElEzQh9gAOoO2ziXaLHa9JPc=; b=SdTqwuaadgxJjPMpOibB7arEUUQT6v2MoMh0xbhEWLdpJksWVfe3GxGVOKTBfPFo7f tayIa78PSgpeKMgGfpKrzdJI7T+P30XmoZ4q/ghIj50V+Duf5p9tV1KAu8U57oXt5FJu jOz2TElcJUXp/pDEsBVjR63itop6WMJH28WaFL4MRqmgRcs1Vrk/Wee6xAZshFDm8A8K CeeccZRFh+0P8tfBwyJPCYGwEcKteNB1FDmVJSClUrkq+5PN0OHOxMnxxkZo6Kj6oOgn KN/i2yxUYDRgDQE4hsGDyBlQpND+zGMcr7PpvSjvyn11JmcB1AFgypsyIv9UskLrQAas 1pqw== X-Forwarded-Encrypted: i=1; AJvYcCXTrdOMl7I1RiMBDzux4k41D5uALaLkjf2PQlyc1q7/HRWJiR3r/OzTd1PAezRPf2XX5cFqQo320NVW5kQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+tIHvl+RsdpB6kHL7XeoLFAVVWyfpVbsjQzqeWZXc9s/57KhD 7CpeRDS/ar6FMlyRocgJJK2+P93vtYbjslfewGzX3UzcRAF5LRE0OIi+jikjkGqY5drw7BTs7do R5ZYU8Y6NB0E5ogKJvXvEV82CDcFNqSH1xA4hYik9Zrom4vbWU3V1JSx4QkDur/APAZl7gNsDIy ClF/5V0pqvsatprF6ecP69BNUOqGl2TemDKROhPTAXNnRkpGs9Fa/pSaOcjntFSwJIFlnGuVdGu wPfPDLS4BXw2OR1Co7A2XQzEQ== X-Gm-Gg: ATEYQzw63nKzVURtxb1wkWFqBDR3cTXy2Bxu+ZNsgHFaOe74S9jZVgnA+2lKRdweAn4 wPzaZJQDrjd4MBD62OJu+SJxcDmANdrZ7aWN/0tjG9/2bVHQf64dBkWqJeUcTgfTcG32TcBks69 SDIKR06Uln81ZOgBaVhftGSKXakyQW8hpQo8mB8uIwranFWQAbLA+jC9OktU39FkcTj6NHCerdl jFm76z+tDbSKQKwMWZuKGZeBzfy/dAg0AAwW3oD7jzp4NijaMpdB7pVlKBsQ2Umz6eh41O1aF9/ i0QNyNTcZ+pJMeddvcWLS+mgWH6TWf0G8lvXSL9kGs69cmX6iYY5Oq08QPFjky9sYH9uTN4SSeM H4olpE7SvOMaeLmK/p4rA4+121E0o/mLKU/FFHQHddQxffoy74DI0RLd2HufStTmNUWXxGsm3mp C7BkGI8gYRO1AY73If1jzM+ApPx2RwWjcigS263uZXitvMBjlM+jpWf1pEgjRoPnHkJg== X-Received: by 2002:a17:902:cf05:b0:2ae:3fb2:ec9a with SMTP id d9443c01a7336-2ae80154bfamr7651985ad.16.1772740900610; Thu, 05 Mar 2026 12:01:40 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-102.dlp.protect.broadcom.com. [144.49.247.102]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2ae51bb9fd3sm15949105ad.28.2026.03.05.12.01.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2026 12:01:40 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ae50463ba8so223063075ad.0 for ; Thu, 05 Mar 2026 12:01:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1772740899; x=1773345699; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RNQeU+4LebvP/QMzlSZElEzQh9gAOoO2ziXaLHa9JPc=; b=PK5o3JuUQQeDg4bRNCegQNHmXCc7KWXXJxxdMqFCHlBSO92eoab1kq1+hP1UxODGKa JchnVoFw3oXJtRcWJE976pKRIueSk/hkjDg0mOGrJfepXUAMTRqYxaheCy4bXDPvyqZY CkLI/PLVrmgJOZJakxYtMtvTIm/qjKRsmwVSk= X-Forwarded-Encrypted: i=1; AJvYcCWjC5esug68RptcYuAAB69Y4XINOMYqR+h/yjPCgt98MZ00w8xY/vu1dZb1maTa8qM/N12hd9mTISy0cHA=@vger.kernel.org X-Received: by 2002:a17:903:2409:b0:2ae:5063:b3e2 with SMTP id d9443c01a7336-2ae8012d6femr6717425ad.9.1772740898932; Thu, 05 Mar 2026 12:01:38 -0800 (PST) X-Received: by 2002:a17:903:2409:b0:2ae:5063:b3e2 with SMTP id d9443c01a7336-2ae8012d6femr6717115ad.9.1772740898353; Thu, 05 Mar 2026 12:01:38 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb69ef1csm247398505ad.53.2026.03.05.12.01.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 12:01:37 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Ajit Kumar Khaparde Subject: [PATCH net-next v4 08/10] bng_en: implement ndo_get_stats64 Date: Fri, 6 Mar 2026 01:30:15 +0530 Message-ID: <20260305200018.111728-9-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260305200018.111728-1-bhargava.marreddy@broadcom.com> References: <20260305200018.111728-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement the ndo_get_stats64 callback to report aggregate network statistics. The driver gathers these by accumulating the per-ring counters into the provided rtnl_link_stats64 structure. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 110 +++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 109 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 29c072e38a7..ec0a8c5e28d 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2924,6 +2924,102 @@ static int bnge_shutdown_nic(struct bnge_net *bn) return 0; } =20 +static void bnge_get_ring_stats(struct bnge_dev *bd, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr =3D &bnapi->nq_ring; + u64 *sw =3D nqr->stats.sw_stats; + + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->rx_missed_errors +=3D + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + + stats->multicast +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + + stats->tx_dropped +=3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + + stats->rx_dropped +=3D + nqr->sw_stats->rx.rx_netpoll_discards + + nqr->sw_stats->rx.rx_oom_discards; + } +} + +static void bnge_add_prev_stats(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct rtnl_link_stats64 *prev_stats =3D &bn->net_stats_prev; + + stats->rx_packets +=3D prev_stats->rx_packets; + stats->tx_packets +=3D prev_stats->tx_packets; + stats->rx_bytes +=3D prev_stats->rx_bytes; + stats->tx_bytes +=3D prev_stats->tx_bytes; + stats->rx_missed_errors +=3D prev_stats->rx_missed_errors; + stats->multicast +=3D prev_stats->multicast; + stats->rx_dropped +=3D prev_stats->rx_dropped; + stats->tx_dropped +=3D prev_stats->tx_dropped; +} + +static void bnge_get_stats64(struct net_device *dev, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_dev *bd =3D bn->bd; + + rcu_read_lock(); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + rcu_read_unlock(); + *stats =3D bn->net_stats_prev; + return; + } + + bnge_get_ring_stats(bd, stats); + bnge_add_prev_stats(bn, stats); + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + u64 *rx =3D bn->port_stats.sw_stats; + u64 *tx =3D bn->port_stats.sw_stats + + BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + + stats->rx_crc_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_fcs_err_frames); + stats->rx_frame_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_align_err_frames); + stats->rx_length_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_undrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_ovrsz_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_runt_frames); + stats->rx_errors =3D + BNGE_GET_RX_PORT_STATS64(rx, rx_false_carrier_frames) + + BNGE_GET_RX_PORT_STATS64(rx, rx_jbr_frames); + stats->collisions =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_total_collisions); + stats->tx_fifo_errors =3D + BNGE_GET_TX_PORT_STATS64(tx, tx_fifo_underruns); + stats->tx_errors =3D BNGE_GET_TX_PORT_STATS64(tx, tx_err); + } + rcu_read_unlock(); +} + static void bnge_close_core(struct bnge_net *bn) { struct bnge_dev *bd =3D bn->bd; @@ -2931,14 +3027,23 @@ static void bnge_close_core(struct bnge_net *bn) bnge_tx_disable(bn); =20 clear_bit(BNGE_STATE_OPEN, &bd->state); - /* Ensure BNGE_STATE_OPEN is cleared before checking drv_busy */ - smp_mb__after_atomic(); + /* No explicit barrier needed - synchronize_rcu() provides full + * ordering between clear_bit() above and drv_busy() below. + */ + synchronize_rcu(); while (bnge_drv_busy(bn)) msleep(20); =20 timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + + /* Save ring stats before shutdown */ + if (bn->bnapi) { + bnge_get_ring_stats(bd, &bn->net_stats_prev); + bnge_get_ring_err_stats(bn, &bn->ring_err_stats_prev); + } + bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); @@ -2988,6 +3093,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, + .ndo_get_stats64 =3D bnge_get_stats64, .ndo_features_check =3D bnge_features_check, }; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index f160ba9b69c..5a2defa970c 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -382,6 +382,7 @@ struct bnge_net { =20 u64 flags; =20 + struct rtnl_link_stats64 net_stats_prev; struct bnge_total_ring_err_stats ring_err_stats_prev; =20 struct bnge_stats_mem port_stats; --=20 2.47.3