From nobody Thu Apr 9 21:52:25 2026 Received: from mail-pl1-f228.google.com (mail-pl1-f228.google.com [209.85.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16E673F23BE for ; Thu, 5 Mar 2026 20:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772740898; cv=none; b=c3lNnLG3PigBgQrvz/CWYVbPXBfJumRCfeMr5BYlToUGXrLBKaROWwdAzViRM4NuMjueeIgS58WDF2S4ZCA/9I1qTnjhLKLa0JHA7GqpAvf19e5MNfFqyKmKYzYp1tZ9ySU0s5LW46M07gV1U4nYZlG1aMJh/WAN3eMyfXyVMUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772740898; c=relaxed/simple; bh=qKDKHBItqjlnp8iifqqtVQdCi5Fm/RBPg5qa3TEt4zk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Yb1QH7HESTf1toGGy6luJ+xtgfB28ysZ5pAIx4wWFYKqnGRMMU9FZa9eStuO1rAVFBEZ6dD1btReD0/oMGCq2V02yIiXVilIhT6eGHY5KcgovBIY1M7jc/sPCWkcSH/I2ryzRJKitEroAEh0wvz13dmUZ+Rt2GkODEqlUQ+GQaM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=IAabhEFM; arc=none smtp.client-ip=209.85.214.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="IAabhEFM" Received: by mail-pl1-f228.google.com with SMTP id d9443c01a7336-2ae5636ab04so48612995ad.3 for ; Thu, 05 Mar 2026 12:01:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772740896; x=1773345696; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9NQ9BrBInuBHEDXnVhh5tO7NgvGRCwjBMLMeJv/Jy6A=; b=RI2MtiOyr0iaAizmP/rwcIyTE6J/WOLFHwdKY3ddvd+7De9/JEu7TjwqhSI+xnHk4t 7Hh8Yzq0hlBrERPw0piQA+HilZHl5qanYSixMwY8gYE9vs1UGR1vLxjkd8nxRiwtmFs0 /D18eSRgeu7sWdMp/pe0Zhtn8iHr+s4enXLowTzcJa8O/QRVsmpckNDVthzhnUZkJ2Em cDzzJlvUGkwu9vASF7Y/RqR8S0164U6MCjhp8V4qXAgSWF/tZNt2howHUr0jagNsj9L5 kkPkKCPLnTkvdhU0+1N7oftdKWs/zUISjYV99xUlnFlN4qT5Uy47oQjqBDhRbNEZTXa1 IYNw== X-Forwarded-Encrypted: i=1; AJvYcCWKIE1cO0dQubWVYj5gswD9w09Qo9d3HkY7vq3gwll5DRkjfbtr5VBBfoEDlB7RNfl+6h5kb0aHY+K/LSw=@vger.kernel.org X-Gm-Message-State: AOJu0YxgpUdq3D+o5OB5GlQXLZLaQysr/uzifDm3N2gop6Jmhq16Xhz4 1TnfzHldRGjkSYqmv2KHPqQVbiGBwsSvFLc/YF2oohg42boMvH3GlU+YkShCQg8P+KkVIM59Wc9 QE5Wb5uZoAhG25kNjTWfZzdI6tRMColeHgLDIkeBJQdaIhJuIX7WaJ/5UMBRhD0Kv1VYP8Qxx/b zpw4BT2tj1YDw3k9m8kfRLJ/ul0OoXxaK0vRpT3Sb9sD31ZUAbu/bXegl8X06xbJjB02zZUCHRr RN2mr0J9PiVYD2K3PwySSxDaQ== X-Gm-Gg: ATEYQzyG7cc4V+RG9o0DWZtOBZ8nuTgTTStnuoGkkTbOuazWfiub0MlJn8aFk3e7Da2 LIkMt9VV69x3A3CwFLwzpH83mcv7H1LeC5ku7NLEg51OZGqYURCEBUjzK4xqeoYiSn7WaHtF8JT qMw6+Fwcgesg+1wtC7BDIdvWUYTQ5cpaLh5uaEdE/9E4aLbk2cDV1ssvVuArDEioz4zz9EsU5is zyrgTsR6h4OTIPBb+gi/cnCoPSTwPuXot9J0fiey6kOMgMf0Hde0e0SWy3amj166u3A7NN6N3ey WaTvYTxJl1ZPWq86o7/da6NC9kXMJTXKXvr/ZPWofR+wZmR4eho0slhIcTq5Xb7JqcQUo733ef7 iFXFmiSekmkBLRPDHjONyvcvBeAcPr+5BeIKkU3PppPEXv8yMtm6YG2k/mfWJVbYsdY1tYSPlkz 8UCGrWCtg8kio9To7sJsqgqrvdEoHrNMQYFwaT2+Hz7g7XdgI2lChEIN7Ph9PXKoq7rA== X-Received: by 2002:a17:903:2ac4:b0:2ae:45b3:b688 with SMTP id d9443c01a7336-2ae6ab66b68mr69152115ad.45.1772740896281; Thu, 05 Mar 2026 12:01:36 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2adfb25f86esm28815135ad.19.2026.03.05.12.01.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2026 12:01:36 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ae61939fa5so79839025ad.0 for ; Thu, 05 Mar 2026 12:01:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1772740895; x=1773345695; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9NQ9BrBInuBHEDXnVhh5tO7NgvGRCwjBMLMeJv/Jy6A=; b=IAabhEFMaD6aHnXfcUXZklTmjh5ae06oLq5GxFtw1DuvTuGdCnpEvHhB2pRjAzTNkv z0EpeMRT6CkEixsh/5i9vMqrEnX6jOp6DHwDlc3s4aI3oZU4uEoCGsUH6PoNDDonamh5 dSODg1VPzlsv+4mfeJWqr4fSx7XfHtGonZY8M= X-Forwarded-Encrypted: i=1; AJvYcCXknNyYer5ijivr9cdtlf58vUExJ9blzNdc+kp7lAB2ap9/gRF2YSu3tTaSaoKPgqFglDO9LDMf21aUPgQ=@vger.kernel.org X-Received: by 2002:a17:903:2b0b:b0:2aa:d608:ec55 with SMTP id d9443c01a7336-2ae6aae9955mr72397005ad.28.1772740894480; Thu, 05 Mar 2026 12:01:34 -0800 (PST) X-Received: by 2002:a17:903:2b0b:b0:2aa:d608:ec55 with SMTP id d9443c01a7336-2ae6aae9955mr72396595ad.28.1772740893968; Thu, 05 Mar 2026 12:01:33 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb69ef1csm247398505ad.53.2026.03.05.12.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 12:01:33 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rahul Gupta , Ajit Kumar Khaparde Subject: [PATCH net-next v4 07/10] bng_en: periodically fetch and accumulate hardware statistics Date: Fri, 6 Mar 2026 01:30:14 +0530 Message-ID: <20260305200018.111728-8-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260305200018.111728-1-bhargava.marreddy@broadcom.com> References: <20260305200018.111728-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Use the timer to schedule periodic stats collection via the workqueue when the link is up. Fetch fresh counters from hardware via DMA and accumulate them into 64-bit software shadows, handling wrap-around for counters narrower than 64 bits. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rahul Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 90 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 91 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index fff31f85e17..29c072e38a7 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -322,9 +322,93 @@ static void bnge_timer(struct timer_list *t) } } =20 + if (BNGE_LINK_IS_UP(bd) && bn->stats_coal_ticks) + bnge_queue_sp_work(bn, BNGE_PERIODIC_STATS_SP_EVENT); + mod_timer(&bn->timer, jiffies + bn->current_interval); } =20 +static void bnge_add_one_ctr(u64 hw, u64 *sw, u64 mask) +{ + u64 sw_tmp, sw_val; + + hw &=3D mask; + sw_val =3D READ_ONCE(*sw); + sw_tmp =3D (sw_val & ~mask) | hw; + if (hw < (sw_val & mask)) + sw_tmp +=3D mask + 1; + WRITE_ONCE(*sw, sw_tmp); +} + +static void __bnge_accumulate_stats(__le64 *hw_stats, u64 *sw_stats, u64 *= masks, + int count) +{ + int i; + + for (i =3D 0; i < count; i++) { + u64 hw =3D le64_to_cpu(READ_ONCE(hw_stats[i])); + + if (masks[i] =3D=3D -1ULL) + sw_stats[i] =3D hw; + else + bnge_add_one_ctr(hw, &sw_stats[i], masks[i]); + } +} + +static void bnge_accumulate_stats(struct bnge_stats_mem *stats) +{ + if (!stats->hw_stats) + return; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + stats->hw_masks, stats->len / 8); +} + +static void bnge_accumulate_all_stats(struct bnge_dev *bd) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + struct bnge_stats_mem *ring0_stats =3D NULL; + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + struct bnge_stats_mem *stats; + + nqr =3D &bnapi->nq_ring; + stats =3D &nqr->stats; + + if (!ring0_stats) + ring0_stats =3D &bn->bnapi[0]->nq_ring.stats; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + ring0_stats->hw_masks, + ring0_stats->len / 8); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + struct bnge_stats_mem *stats =3D &bn->port_stats; + __le64 *hw_stats =3D stats->hw_stats; + u64 *sw_stats =3D stats->sw_stats; + u64 *masks =3D stats->hw_masks; + u16 cnt; + + cnt =3D sizeof(struct rx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + + hw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + sw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + masks +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + cnt =3D sizeof(struct tx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS_EXT) { + bnge_accumulate_stats(&bn->rx_port_stats_ext); + bnge_accumulate_stats(&bn->tx_port_stats_ext); + } +} + static void bnge_sp_task(struct work_struct *work) { struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); @@ -338,6 +422,12 @@ static void bnge_sp_task(struct work_struct *work) return; } =20 + if (test_and_clear_bit(BNGE_PERIODIC_STATS_SP_EVENT, &bn->sp_event)) { + bnge_hwrm_port_qstats(bd, 0); + bnge_hwrm_port_qstats_ext(bd, 0); + bnge_accumulate_all_stats(bd); + } + if (test_and_clear_bit(BNGE_UPDATE_PHY_SP_EVENT, &bn->sp_event)) { int rc; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 324db55fc7d..f160ba9b69c 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -305,6 +305,7 @@ enum bnge_sp_event { BNGE_LINK_SPEED_CHNG_SP_EVENT, BNGE_LINK_CFG_CHANGE_SP_EVENT, BNGE_UPDATE_PHY_SP_EVENT, + BNGE_PERIODIC_STATS_SP_EVENT, }; =20 struct bnge_net { --=20 2.47.3