From nobody Thu Apr 9 21:52:27 2026 Received: from mail-pg1-f227.google.com (mail-pg1-f227.google.com [209.85.215.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF1963EBF2D for ; Thu, 5 Mar 2026 20:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772740871; cv=none; b=dfca44Z6AqphbjFyU/S7TUiPB1/vbMjqDqKgPv3nQfjv9yKlUrRbTy86frmUCHl+SGBcxE5sreqn/QGa56wiZBkfOVMPu0Siy6U0yhigXRtWNO9Z5vBT6g6UTdBUWWbywScuSkVxgSVo9KcCJaS3Q8rP/kmr8YTb0B1FlKSbDJs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772740871; c=relaxed/simple; bh=JxO81/weFyc459OMqAugvZdWK5EbJ/Ld7je/eSdGL+A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q2oF9r7SDpcXgbJ2+yk/O9XE1u8PPbnmETGGgXkaREwM21M74il+G4xOUAvDcfEHIoDQb7uja5nh6Jv54Qhx+E3L+1X0Zt56eWheFxKWGwuVJme5ou8Ao+W2FjfoCjBv6JKpTJYP0XKmWuSFC9XRpO+75eq4aYn+moJ0uFIoCDs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=VgUKeWaF; arc=none smtp.client-ip=209.85.215.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VgUKeWaF" Received: by mail-pg1-f227.google.com with SMTP id 41be03b00d2f7-c738b98bfd9so608884a12.3 for ; Thu, 05 Mar 2026 12:01:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772740869; x=1773345669; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FLbZWpd5u/NFnfx5DlhA19ecuXsYw/JuQ0/iZQbB610=; b=PqjUk0BQ/UG40IMRhGTxTJRFG2CHR0dF68tBFrzqCpdhSisU5EMfCTkcYliDD+tuEy zuIXcCbH9LWFBHmcqVvMfyWlMWfTxgYE4IeIiyyRNBCKYSlp2AW4DTh4PSzhzL3nk/iU n8sVV5ZRL9fYHiJl2TlLLMRm96fUfnLCPnvoxjuy/X++mkVWFb3gRCD/dfftDwdrDtfM A2gelrHDJIjVXA8VTRpAe2u8oMHTI4jjWcs4lWDV+EnoNy/+aUw1HFggHvdaR0KukeL7 K7UQpzhINdTSxf+uePXfoNWXc8f0QNnCvXocFcv2rGCBDyCA7BrTYbp0Mp2t2ao1Iaac qEhA== X-Forwarded-Encrypted: i=1; AJvYcCUueKMW2D9DtwYRvvY9gZ9HtkglR3a3+iDhpLs8GwPsrYZ63nWOLSkw6Skr5YZ9labD0kp4tRdftY+tI0Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxmLF5DTk+C1Ya8Rtv6RYhaZhl73qelwLeczBaw/UBaNptoq2ig mCrzQzTA+hBXo8dLPSUsnHNwbxhl+97Tw47I62tfKrE2XUKjeBVfqW0Azy9x+QZqEatYZatJ4vI 4gOXxTE21Q2Xzci0TtZDUHEr5YKkMhI/nrOebR/iOx78vsfDVkbcsmm4a9OVyqtjFp3QfMNj94p AyVdUD6BOwNMV6PjZjLwhE9fG4zmBqaxEfVakbZHQylvCdDBjhvhPABgmYrd03nIiy16zc4gpUM JHeZsZdFxESoSZ3ziyNZQulnw== X-Gm-Gg: ATEYQzzwYbqr1ZvXsnyEnv4YkTLBTgpBbRmCPufNXzA8Cl1mcqQRIv85+rV7dVi9lv3 2JoXttOJ5V4T3E+dT8E40D0EpwYsfjqJcy6Cc43m0F6lKicGh55B0mU3M3qIxqReqQFYKnsSJ/X /5FVHfgBaSDoRK9TAudHMJMhEzxqz+TEu+AVWyPDy0uXCVXvAK8gRCCaTBGUJw46Vj3XdEt+AY8 xcEieqC7OsRFMjWkgAssM5Ho28yLXJml14FN0w9HtR2osQp2qkiMBN+bRAiAHI4tyb1OjYAB7G7 u7RA0mz8Pv8RDx4XhWhF2I5Jnulx0owpCdZNXfjND1nHzkYyaqDO12y8GN78uVLkf6UoGRQaCty 8ofvYJYyL8fvX6XCVig00WMaUAhbwtHY6fm3X3z79KAsnwFmoeDoru485iOdHd45Xi5KQIHJ5xb 63Bb3f+7Q+uzJCiyLDi7Uow8KHRPGFclmY8DN2/N4cVAaOmoeJN5IMygOksy7pb1P8cg== X-Received: by 2002:a17:90b:5104:b0:359:8564:dc0e with SMTP id 98e67ed59e1d1-359bb367c31mr677313a91.3.1772740868650; Thu, 05 Mar 2026 12:01:08 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-359b2d7f612sm327153a91.7.2026.03.05.12.01.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2026 12:01:08 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ae4f27033cso48528355ad.3 for ; Thu, 05 Mar 2026 12:01:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1772740867; x=1773345667; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FLbZWpd5u/NFnfx5DlhA19ecuXsYw/JuQ0/iZQbB610=; b=VgUKeWaFBi7/hms41U8Ib0M9pHHPVi11R7YUDJy60Ym4RO2NQmL9gtvHbxpEd8dxOq e7Z+JbGUELe6B0j1zvgn59+avp+8AD2twlphjspXA4xesNZ5T1v4RPoS2J6kYzbsHBgr zajJ1vftXcaLg5EUJW2OlXmzPYD8LA6AX6T4w= X-Forwarded-Encrypted: i=1; AJvYcCV4SLpgGYda9l5zfygCvb3NZYEsM5M0fZ6gQ9lgnqPu/C+gQLj0QezxS+c8kGvo3f2de1psDsqBU0P4coA=@vger.kernel.org X-Received: by 2002:a17:902:e788:b0:2ae:5aed:1f51 with SMTP id d9443c01a7336-2ae80257d16mr6542275ad.43.1772740866307; Thu, 05 Mar 2026 12:01:06 -0800 (PST) X-Received: by 2002:a17:902:e788:b0:2ae:5aed:1f51 with SMTP id d9443c01a7336-2ae80257d16mr6541735ad.43.1772740865573; Thu, 05 Mar 2026 12:01:05 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb69ef1csm247398505ad.53.2026.03.05.12.01.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 12:01:05 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Ajit Kumar Khaparde Subject: [PATCH net-next v4 01/10] bng_en: add per-PF workqueue, timer, and slow-path task Date: Fri, 6 Mar 2026 01:30:08 +0530 Message-ID: <20260305200018.111728-2-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260305200018.111728-1-bhargava.marreddy@broadcom.com> References: <20260305200018.111728-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add a dedicated single-thread workqueue and a timer for each PF to drive deferred slow-path work such as link event handling and stats collection. The timer is stopped via timer_delete_sync() when interrupts are disabled and restarted on open. The open and close paths now start and drain these resources. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 87 ++++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 13 ++- 2 files changed, 98 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index a20dc3ca640..ee77b29f5b9 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -101,6 +101,45 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } =20 +static void bnge_timer(struct timer_list *t) +{ + struct bnge_net *bn =3D timer_container_of(bn, t, timer); + struct bnge_dev *bd =3D bn->bd; + + if (!netif_running(bn->netdev) || + !test_bit(BNGE_STATE_OPEN, &bd->state)) + return; + + /* Periodic work added by later patches */ + + mod_timer(&bn->timer, jiffies + bn->current_interval); +} + +static void bnge_sp_task(struct work_struct *work) +{ + struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); + struct bnge_dev *bd =3D bn->bd; + + set_bit(BNGE_STATE_IN_SP_TASK, &bn->state); + /* Ensure sp_task state is visible before checking BNGE_STATE_OPEN */ + smp_mb__after_atomic(); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + clear_bit(BNGE_STATE_IN_SP_TASK, &bn->state); + return; + } + + /* Event handling work added by later patches */ + + /* Ensure all sp_task work is done before clearing the state */ + smp_mb__before_atomic(); + clear_bit(BNGE_STATE_IN_SP_TASK, &bn->state); +} + +static bool bnge_drv_busy(struct bnge_net *bn) +{ + return test_bit(BNGE_STATE_IN_SP_TASK, &bn->state); +} + static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr) { struct bnge_ring_struct *ring =3D &nqr->ring_struct; @@ -2507,6 +2546,9 @@ static int bnge_open_core(struct bnge_net *bn) bnge_enable_int(bn); =20 bnge_tx_enable(bn); + + mod_timer(&bn->timer, jiffies + bn->current_interval); + return 0; =20 err_free_irq: @@ -2542,6 +2584,12 @@ static void bnge_close_core(struct bnge_net *bn) bnge_tx_disable(bn); =20 clear_bit(BNGE_STATE_OPEN, &bd->state); + /* Ensure BNGE_STATE_OPEN is cleared before checking drv_busy */ + smp_mb__after_atomic(); + while (bnge_drv_busy(bn)) + msleep(20); + + timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); bnge_free_all_rings_bufs(bn); @@ -2690,6 +2738,23 @@ static void bnge_init_ring_params(struct bnge_net *b= n) bn->netdev->cfg->hds_thresh =3D max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); } =20 +static struct workqueue_struct * +bnge_create_workqueue_thread(struct bnge_dev *bd, const char *thread_name) +{ + struct workqueue_struct *wq; + char *wq_name; + + wq_name =3D kasprintf(GFP_KERNEL, "%s-%s", thread_name, + dev_name(bd->dev)); + if (!wq_name) + return NULL; + + wq =3D create_singlethread_workqueue(wq_name); + kfree(wq_name); + + return wq; +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2774,6 +2839,17 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) if (bd->tso_max_segs) netif_set_tso_max_segs(netdev, bd->tso_max_segs); =20 + INIT_WORK(&bn->sp_task, bnge_sp_task); + timer_setup(&bn->timer, bnge_timer, 0); + bn->current_interval =3D BNGE_TIMER_INTERVAL; + + bn->bnge_pf_wq =3D bnge_create_workqueue_thread(bd, "bnge_pf_wq"); + if (!bn->bnge_pf_wq) { + netdev_err(netdev, "Unable to create workqueue.\n"); + rc =3D -ENOMEM; + goto err_netdev; + } + bn->rx_ring_size =3D BNGE_DEFAULT_RX_RING_SIZE; bn->tx_ring_size =3D BNGE_DEFAULT_TX_RING_SIZE; bn->rx_dir =3D DMA_FROM_DEVICE; @@ -2789,11 +2865,13 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_= irqs) rc =3D register_netdev(netdev); if (rc) { dev_err(bd->dev, "Register netdev failed rc: %d\n", rc); - goto err_netdev; + goto err_free_workq; } =20 return 0; =20 +err_free_workq: + destroy_workqueue(bn->bnge_pf_wq); err_netdev: free_netdev(netdev); return rc; @@ -2802,8 +2880,15 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) void bnge_netdev_free(struct bnge_dev *bd) { struct net_device *netdev =3D bd->netdev; + struct bnge_net *bn; + + bn =3D netdev_priv(netdev); =20 unregister_netdev(netdev); + + cancel_work_sync(&bn->sp_task); + destroy_workqueue(bn->bnge_pf_wq); + free_netdev(netdev); bd->netdev =3D NULL; } diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 70f1a7c2481..b00d2e3922d 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -224,6 +224,13 @@ struct bnge_tpa_info { #define BNGE_NQ_HDL_TYPE(hdl) (((hdl) & BNGE_NQ_HDL_TYPE_MASK) >> \ BNGE_NQ_HDL_TYPE_SHIFT) =20 +enum bnge_net_state { + BNGE_STATE_NAPI_DISABLED, + BNGE_STATE_IN_SP_TASK, +}; + +#define BNGE_TIMER_INTERVAL HZ + struct bnge_net { struct bnge_dev *bd; struct net_device *netdev; @@ -281,13 +288,17 @@ struct bnge_net { u32 stats_coal_ticks; =20 unsigned long state; -#define BNGE_STATE_NAPI_DISABLED 0 =20 u32 msg_enable; u16 max_tpa; __be16 vxlan_port; __be16 nge_port; __be16 vxlan_gpe_port; + + unsigned int current_interval; + struct timer_list timer; + struct workqueue_struct *bnge_pf_wq; + struct work_struct sp_task; }; =20 #define BNGE_DEFAULT_RX_RING_SIZE 511 --=20 2.47.3