From nobody Thu Apr 9 21:54:12 2026 Received: from mail-vk1-f227.google.com (mail-vk1-f227.google.com [209.85.221.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A94CF3EBF16 for ; Thu, 5 Mar 2026 20:01:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772740908; cv=none; b=dp56KwYZk1X3CYRWDF1lBFyEUUK1IIXbUZaTo265/OYyfjJUCGez2yGhr8OAniDZp5rlntQeH348oh3Ji7vNfgvDJsOzB73k3Nf/UAdJvybjywVkxOtlebgIwuacuwrdyTzjlNhFTglqs7B7JeoO1wieiCf5AWSajTIT5abKdJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772740908; c=relaxed/simple; bh=s+shqdSUHh1XHcUoJ+GLd9bGludiwY1qRuIcKd7JX6g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AnnTpVv/EGO8d063z6mP0RKwBWJKGcSEvLwFguY1PBV/Y8q6gaheCOUn2zu0MOlIAMpBZDqOEybel8jzXkyDUf0T4JOyiUR/zdZcFTiOOfbZTRJ5jKsqZXCodK7k/gIffOa4C3zM8QEHuyrYqYT84tfsSgO/wttLtKG1fHxmrwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=FKLRilv1; arc=none smtp.client-ip=209.85.221.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="FKLRilv1" Received: by mail-vk1-f227.google.com with SMTP id 71dfb90a1353d-56aeaa75cadso782051e0c.3 for ; Thu, 05 Mar 2026 12:01:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772740905; x=1773345705; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X742MM3bjRLLkPQn57crOg7YhGYxGkXa3E19p0llyss=; b=FioTu/ukuA3ueH7znUICK3CRfTe4Swf7K5zlg9khGyyGt6sx9O2X75IGZhx6eMZmmI bUynxbG95JE+qcBrxSbT9cEymzZEZsL2MN60ToGtysTb0gS8Q44TgGZ5Ws6fLVDECPa6 rxMHqFuyO+ddkkeaAe1bQ2i4iqlhdUrKBamDRrm3qymkvb2DzYYYfEe824DwTS9uvpoR EopZs9Rw8WfyxRMFyUd6gUxYerp/Vo5wCh0Md8kK2mQxgGaG6ZklvPVmPKoq00PhlCfG DeDHlZwq6X3Uwyjr37KWEmH/znTh8TI5/p2I0GEvOIpTyyzm5+F0GZ2yCRi4RhCQd7H7 Q4fQ== X-Forwarded-Encrypted: i=1; AJvYcCWedyCgqvYmvzKIZhIzavXbjDtb48NonYUD+H18ptlA8xxTQHXkibNwH0lsTlrEy7PS4gjQEMaRwLyCerw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4mMfpz8THRetD59+bB2fHtZoAtDmPo7KYHnG+UTxrNzqC23jQ pPBDgCO66HpPjskeqDGS66blak8TBzHrnw5Lbas3yN/5ZxoDvj8jp5URAOUE0MCys6fvdBPAWf6 97NwEcGrrlvFSssQth+qS2LdEkX0DvrXxQyzLeg56fGg5t31zVtUZ3l+TneUepPK/qs1LMGM5Kj n79C36C6TDrVz0aQMsHbIkvokdCtFF/Gkmh6tRy+K2htwXe5pSU67p7lMhupTVpq8quMuGe4Hvt HNER6R+GZdQ5P+hY94dn8+oLQ== X-Gm-Gg: ATEYQzzlcgGy8I7MjE1J+J6oLt5JOPZZO1C9AREIMHRgZHeEkLGS446UB8qM5lCFu6e UBThfVovjv6fBIv41dkWshh2IVLXQqVTshN+7+uBAPXT0xjDqXss4zE9bFiEapO/zVLA0fdSC3V BzL+ubxvUIr1vkZXmxemhyj0PzqVlh1VSQVwV3Dgeye/OlIgIsZPhum8MgTPfy5Y+UXbPMxcoYP z7vLGHGS5iBVU1YdikbzLvJaGEJOyv6EXRYrV53z5Rc4grOl18pj/LVKYdRetS//v2JDrMNvBUa k8Sf5CoRPUbgvQsbWYDbz/aRUWf91VGoO/JlmdyS6W3K58ccH+ZMpiTsFNz454hIHN4PJBRFT0O J9oy2nLOOKH7GiSaN+gmL6zvJp09poixp+MYqXw7Ip2TjNmvVJfdGYPA6fD3IGOKtGl90ULkYUQ sWJZ7m8B2l7z74/+y9oqoR9hj9hUlc2oGvev/UR8L4p5jAAxqNtHQIsrHJ163H2xqAYw== X-Received: by 2002:a05:6122:32c8:b0:56a:9841:efd4 with SMTP id 71dfb90a1353d-56ae74d2ea9mr3167258e0c.1.1772740904600; Thu, 05 Mar 2026 12:01:44 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-102.dlp.protect.broadcom.com. [144.49.247.102]) by smtp-relay.gmail.com with ESMTPS id d75a77b69052e-5074cdcda57sm30380051cf.3.2026.03.05.12.01.44 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2026 12:01:44 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2ae65d5cc57so133057885ad.2 for ; Thu, 05 Mar 2026 12:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1772740903; x=1773345703; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X742MM3bjRLLkPQn57crOg7YhGYxGkXa3E19p0llyss=; b=FKLRilv1R1r5SGyJcfgLHDrmNaGymmpJS3Sol6+6naMjJrIpURrjxOqqh43bAZnUVB si8zDpgFA9651l8HyuUhp14TUI8lAkOxFK4XP0M28pMrBXWvkFnZHX/0tJNBLMKI4tKj vygeEt3+MNd8Bn3oG+QmWgm+QpbOetiKwkaVA= X-Forwarded-Encrypted: i=1; AJvYcCXsQ1383Rz+xxL0NglV8vhWecw0y9bklqAgZ2Wil18Z7E7hR5AOmCiRbvUQDFejGW5308ypE2kLp50hxTM=@vger.kernel.org X-Received: by 2002:a17:902:d486:b0:2ae:5ab4:f4c7 with SMTP id d9443c01a7336-2ae6a9ff1f4mr69240675ad.15.1772740903182; Thu, 05 Mar 2026 12:01:43 -0800 (PST) X-Received: by 2002:a17:902:d486:b0:2ae:5ab4:f4c7 with SMTP id d9443c01a7336-2ae6a9ff1f4mr69240315ad.15.1772740902545; Thu, 05 Mar 2026 12:01:42 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb69ef1csm247398505ad.53.2026.03.05.12.01.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 12:01:42 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy Subject: [PATCH net-next v4 09/10] bng_en: implement netdev_stat_ops Date: Fri, 6 Mar 2026 01:30:16 +0530 Message-ID: <20260305200018.111728-10-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260305200018.111728-1-bhargava.marreddy@broadcom.com> References: <20260305200018.111728-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement netdev_stat_ops to provide standardized per-queue statistics via the Netlink API. The implementation was verified using the ynl tool: $ ./cli.py --spec netlink/specs/netdev.yaml --dump \ qstats-get --json '{"ifindex":5, "scope":"queue"}' [{'ifindex': 5, 'queue-id': 0, 'queue-type': 'rx', 'rx-alloc-fail': 0, 'rx-bytes': 1024, 'rx-packets': 10}, {'ifindex': 5, 'queue-id': 1, 'queue-type': 'rx', 'rx-alloc-fail': 0, 'rx-bytes': 2048, 'rx-packets': 20}, {'ifindex': 5, 'queue-id': 0, 'queue-type': 'tx', 'tx-bytes': 512, 'tx-packets': 5}, {'ifindex': 5, 'queue-id': 1, 'queue-type': 'tx', 'tx-bytes': 1536, 'tx-packets': 15}] Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 71 +++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index ec0a8c5e28d..9710113b51f 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -3089,6 +3089,76 @@ void bnge_get_ring_err_stats(struct bnge_net *bn, &bn->bnapi[i]->nq_ring); } =20 +static void bnge_get_queue_stats_rx(struct net_device *dev, int i, + struct netdev_queue_stats_rx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_nq_ring_info *nqr; + u64 *sw; + + if (!bn->bnapi) + return; + + nqr =3D &bn->bnapi[i]->nq_ring; + sw =3D nqr->stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->alloc_fail =3D nqr->sw_stats->rx.rx_oom_discards; +} + +static void bnge_get_queue_stats_tx(struct net_device *dev, int i, + struct netdev_queue_stats_tx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_napi *bnapi; + u64 *sw; + + if (!bn->tx_ring) + return; + + bnapi =3D bn->tx_ring[bn->tx_ring_map[i]].bnapi; + sw =3D bnapi->nq_ring.stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); +} + +static void bnge_get_base_stats(struct net_device *dev, + struct netdev_queue_stats_rx *rx, + struct netdev_queue_stats_tx *tx) +{ + struct bnge_net *bn =3D netdev_priv(dev); + + rx->packets =3D bn->net_stats_prev.rx_packets; + rx->bytes =3D bn->net_stats_prev.rx_bytes; + rx->alloc_fail =3D bn->ring_err_stats_prev.rx_total_oom_discards; + + tx->packets =3D bn->net_stats_prev.tx_packets; + tx->bytes =3D bn->net_stats_prev.tx_bytes; +} + +static const struct netdev_stat_ops bnge_stat_ops =3D { + .get_queue_stats_rx =3D bnge_get_queue_stats_rx, + .get_queue_stats_tx =3D bnge_get_queue_stats_tx, + .get_base_stats =3D bnge_get_base_stats, +}; + static const struct net_device_ops bnge_netdev_ops =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, @@ -3252,6 +3322,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) bd->netdev =3D netdev; =20 netdev->netdev_ops =3D &bnge_netdev_ops; + netdev->stat_ops =3D &bnge_stat_ops; =20 bnge_set_ethtool_ops(netdev); =20 --=20 2.47.3