From nobody Thu Apr 9 21:52:27 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39EFA3DEAE6 for ; Thu, 5 Mar 2026 19:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772739662; cv=none; b=dTWwxCJ023Vu1UvGxtWqARsaJIPEeVcjPUen20Xjof59lt20ld3+EPxKAjjx1ivxApOsi3Sdq39W6VMzfSpi+l+vxw64UnOwf1sMpD6pA3kQtYbUo62ZZkUHhJX8TXhWrMK9CnjW1n7B4KYQqX6w8WF793vmbUtyIU5bhcOz3jI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772739662; c=relaxed/simple; bh=/QGGg48sn9sKA1F8TWZlfBuzKMx3jTk/2UYyPAjLJh4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a9SHWq007NpzDsnnLNlX8vq+ruZ49WUJ+Bwat7ucDh/E8MaiDlReD5E8JX94UD1XK+O/aIU8J/1IbOHafAxwgABVFr4wxKrc5zgc8EgRjkzNxC1Y9k+0QqQj13fP9n7rWmJ4LtwHTkHBiwP5taYvQln4e3/FPL/szjBqfgqeseg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems; spf=pass smtp.mailfrom=starlabs.systems; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b=KwYKcoaF; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=starlabs.systems Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=starlabs-systems.20230601.gappssmtp.com header.i=@starlabs-systems.20230601.gappssmtp.com header.b="KwYKcoaF" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4833115090dso86092155e9.3 for ; Thu, 05 Mar 2026 11:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=starlabs-systems.20230601.gappssmtp.com; s=20230601; t=1772739658; x=1773344458; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kq4shlsXpyVXkpp2qtgEESfDg63q+osNt2mDVKvT2FU=; b=KwYKcoaFtp3Cc7lf2nPF2UwHPyq9mWXgRzRnDTMxFl65pW/1WC/JI35zssXlWKmPca xNISZnQFeVn5qzYImlYn406We5i8C0TCYSKblI/m6fHIDwytGn07cscaKJgPlrlVEqz4 VBUMjRa28JVhQpa4JchjiE/JV7zSfkWV3gxE8k7gY11maolJkZiDXkzwnhrHgehbjQ1G kX8OxUdwNgihNHL+sAxzrU7eGS5px87nd1CHwCXr4sz27Lp93/DbGzOZHK8OpVQzrhjP iObss4qH66Vq0/RGtoWmR9/0PIkyS0ejBPLqhGp2X/DO9skaNA/fiVXFSTV74PFuUb/O oY2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772739658; x=1773344458; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Kq4shlsXpyVXkpp2qtgEESfDg63q+osNt2mDVKvT2FU=; b=hmnCAWMT0S4BWmEo1avB7nHgzFlSqJnF1igpS9uwnyNa0X4IOKmUafgnLJ0CsefarY dTmCsfVja05R0JvA+xzMOoXFSQCOo5OwVRHqH+xX84MScYAIFWe2/hAZPSHWCQEqHPOF hUDWyOcZjIGoHxDbfTWI0Ek8zEFZbzBHGZE9Kqu3NyWPjaETAjltBLsotMBcn8CnHABT n767TUI8fU383kYuc+ShNII1Ep5/Y83cc3asn/QwvCLPGe6Tanx9kBofHXIWa0oB91vf sWUVQIZCQG4lEye0MrY7jg2Vv5qIGxrM82rOItdso9HK69hpQqFX5WAHPkWK0e38MkmU tFeQ== X-Forwarded-Encrypted: i=1; AJvYcCWEcDBxGsWTg3MzjWszHXiVQTKZV9vgdvAOfOxGjysslaDnt+1M/v9ofyJuzelPAzCsZirAaGaGYfOnWsE=@vger.kernel.org X-Gm-Message-State: AOJu0Yytc/yeZzL0BiCRC8iOn1px4afDVCjbtHWmSWPnNxGmFqOQKeFk Sp+IPK2ipF9hocqPec3G/IYf3JaAshU9LHYY31bH4hi7CXMTXLB188e98qa261MuKA== X-Gm-Gg: ATEYQzzfmoXbcadJ2uQjYVrvPDX2IG3G1XYzpEXtEiZInKwy+Ll5lLlv2QOB/XhomLl NBUol6j9wP0XwN2yqHp3es/BgMtdzfkN7MfB9vOBII9xmTr7IhQo7V/5DROhZO1KmQETyoNiINK deJC5nzY1ivORbqwI3FUCJUTezG/VBQM4xl7Gn2IVfm9YizTsQRfeOnp+610xBC1FauTlxGThUi banW/3P65Qldoilbkkg60VhG4b0POIPnwbfKkSEZu/u8F2BbmKlaBCeWTlecSVHSHexfPVDOp4Z esxXSvmMCVIPOOZcDgr9aNceWfsQRKpwYcH2icl1bGC8wudYLoGzWbrrziuHM5ahhY5t7eSkAyk NZgRgcJGoW91Hl3jNnpK99KAXYaacuRW+/njUX4LNv582SyoyVAoiBlXTKWfAdQPqXtXrnlSrCc 8GAPwZ9UqK0+BJ9TBf9R7QVICL3RVBJOUIicnpzSdf35qXkCpwFuM= X-Received: by 2002:a05:600c:1e8c:b0:483:79a6:e7e1 with SMTP id 5b1f17b1804b1-48523589b03mr12597475e9.7.1772739658401; Thu, 05 Mar 2026 11:40:58 -0800 (PST) Received: from starbook ([217.155.46.38]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485246fd127sm3265e9.6.2026.03.05.11.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 11:40:57 -0800 (PST) From: Sean Rhodes To: linux-mmc@vger.kernel.org, Ulf Hansson , Greg Kroah-Hartman Cc: Ricky Wu , Avri Altman , Binbin Zhou , Dan Carpenter , Jisheng Zhang , Nathan Chancellor , Arnd Bergmann , Huacai Chen , Ingo Molnar , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: [PATCH v2 4/6] mmc: rtsx_usb_sdmmc: program SD30 mode for UHS SDR12/SDR25 Date: Thu, 5 Mar 2026 19:40:50 +0000 Message-ID: <20260305194052.5120-5-sean@starlabs.systems> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260305194052.5120-1-sean@starlabs.systems> References: <1ca7b488a11e03b3f107f1829a40cf2c92c7d5fd.1771533586.git.sean@starlabs.systems> <20260305194052.5120-1-sean@starlabs.systems> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver advertises UHS SDR12 and SDR25 support, but sd_set_timing() only programs SD_30_MODE for SDR50/SDR104. When the core selects SDR12 or SDR25 this leaves the controller in SD 2.0 mode. Program SD_30_MODE for SDR12 and SDR25 too. Tested: Realtek RTS5129 (0bda:0129) + tray + Lexar 2TB SDXC Tested: timing spec SDR104 @ 208 MHz, signal voltage 1.8 V (2026-02-24) Signed-off-by: Sean Rhodes --- drivers/mmc/host/rtsx_usb_sdmmc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_= sdmmc.c index 8d5ebe92018e..62f6b3f76c7b 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -1231,6 +1231,8 @@ static int sd_set_timing(struct rtsx_usb_sdmmc *host, =20 switch (timing) { case MMC_TIMING_UHS_SDR104: + case MMC_TIMING_UHS_SDR12: + case MMC_TIMING_UHS_SDR25: case MMC_TIMING_UHS_SDR50: rtsx_usb_add_cmd(ucr, WRITE_REG_CMD, SD_CFG1, 0x0C | SD_ASYNC_FIFO_RST, @@ -1298,13 +1300,14 @@ static void sdmmc_set_ios(struct mmc_host *mmc, str= uct mmc_ios *ios) =20 switch (ios->timing) { case MMC_TIMING_UHS_SDR104: + case MMC_TIMING_UHS_SDR12: + case MMC_TIMING_UHS_SDR25: case MMC_TIMING_UHS_SDR50: host->ssc_depth =3D SSC_DEPTH_2M; host->vpclk =3D true; host->double_clk =3D false; break; case MMC_TIMING_UHS_DDR50: - case MMC_TIMING_UHS_SDR25: host->ssc_depth =3D SSC_DEPTH_1M; break; default: --=20 2.51.0