From nobody Thu Apr 9 20:25:37 2026 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F4F4481B1 for ; Thu, 5 Mar 2026 19:33:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772739224; cv=none; b=tEHRKMrK3eyggFT9wD5sgy9G+/qQEK++Mo9n1jB9aWvLpGg9+6A/ZGc2HBLLw1mVc/XqFVHVcOY9tr6XBfchQHPke1739pLBu/gXm7DJsfLABR7NjnIs8mbp+YNKe3E6leRANItQ73c9m5qorMBdkD5hYcF6rblgYEVTorRNg6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772739224; c=relaxed/simple; bh=hrLaGjKTbbL02GgZ6CDoFO4WKeKUJ837QtSBGwMR62o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bSj2/zH6aCiIEzqmm+7dCdfv76dDbPo6BsmUVoQBhxzDeOkzJHx7pFHC5zKg0BJxZUMF3ow+smEUCSms5SnhfCMUmiGjJ3XZrjjiEYvPaVXiel+3cqSihfT0YbD0ZCZYxvMmIZrBGWV9oixnS9V+XqDvm6l2RcQ4yibe60t2xYg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U4BHFmcX; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U4BHFmcX" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2bd9a485bd6so635536eec.1 for ; Thu, 05 Mar 2026 11:33:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772739223; x=1773344023; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=fq7KIO0V4zx1zhH5qW6s86NIhGqp/50i/2Zf3Crez5U=; b=U4BHFmcXF9nwSL3/FVFI2Fj4+If/2THqyQ+fgrp20oSZYqO9a9CI1zojJ/mLBkr46u KrERh0KLCnj3/dAxPZ90BVMmnxayaT6QGFTbJ4XDyumohRFZz66/iY0Jc8NhpRatJV43 fZqfAhKvfArDdDsXHOFxBsvMndTUq85lrTkztxVk2QFzx3DRMzJ0ikuB/PfbfrtsZbdq SlYioXhm4SvtfLvbGjwO9bycSbd/vYkcR7DyTxCwWdkFZQnUczfdhyIsm/ZvXZu3xaAJ mCtuty29bZQoFMBezL+W/4sxdFkzfYHR5cAPowdZQzBpPcdnH3IesV2W8HaiBGPhyIQC XHNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772739223; x=1773344023; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fq7KIO0V4zx1zhH5qW6s86NIhGqp/50i/2Zf3Crez5U=; b=hlhSk9QzZlVVWZJ6c3oMjTdZLEg2YbKztlT/ipcPjSRRlRYgGHwd8Gws3pd2Ny5Z9N TeCr4QPxOsK8+sP7lYjkeoLsHc09g7d+gJYa1a267gnkeSJhPdecJe/HKjilwV+MXbr1 2XCP9zeuC44FMqEY67nI+fO/EuOqMnMJYe4IchYNF3IcmHAUton3levuxYZrwa49VtIE XBruBXIeGf/unEzkK5z/bcjRZgGYnhItywrVy6xpxd4l2XYsgAZb6shkhnCCFQYCZyJk WSaUscdRbpyaqKmvmC5EAoklcRX5Px+LqAUfUDpLeqi2vVG6IqziAKWUEqgB6/BydiO2 uthw== X-Forwarded-Encrypted: i=1; AJvYcCUhg0olzCxydab39v5/rq68US5rhCju++Agt//l7tSFVuR+N4ddEXPBdkwH9G2AkmHZnXjnYsMdBxvdgB0=@vger.kernel.org X-Gm-Message-State: AOJu0YyQe/CNo8U5NLwOWK53P4tsRd1rFwX5P6KnrcBcNNOON8cTxSse BnMKefp5VtUo3jVEnZ2VapWgw+rkqOmGRqiEz3bG1VSJPKsjnBJZK7izW2ueYiC5 X-Gm-Gg: ATEYQzyCNeFgNfigxuCMIOHuHvIU+3tBUdKUQn06Q/KkvnPT7BEPozTrlN5tfzx+qFY tv9CBXOvrf5frQTTG1K/8PlsurTn7GgeSW8AV4UdkKyLzjzke8hvPy010Xijq6EC/xsXuQxOQ+3 aX2P+yPFDb9OsOrWlS4FdhBnp4DEawijhgsyGgHDV6nUMlwzx7mGbdlin61TOXXaCC5mJc9F7LY l/TvzkrJizELxzBRtpveh7RLJKfbKLP7thEI4029zSTXUT5CirVcmMlzvZm5kjzOhdOwMwm3jxn bHi/eDHYmQqQSd5nlQS+NxoGtTMgAPJowWfYCS6i2N5GmTB3GBiKlwWGZGjIKs2PaxF03sp7rsr Qd9b0X9wMZdAGjuEqMuRwwSP4ml5jsgIWSfKoZXJuA5FKD6JK2V+goUy3RsCINP6l9+3rbN33Z5 64mAF7fIrd+pBkGVVIZVdHiAtB8Fg53CHFc+Rg X-Received: by 2002:a05:7300:6d07:b0:2ba:a098:ae64 with SMTP id 5a478bee46e88-2be4abadc62mr427346eec.34.1772739222765; Thu, 05 Mar 2026 11:33:42 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be09bc9ec4sm11081299eec.24.2026.03.05.11.33.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 11:33:42 -0800 (PST) Sender: Guenter Roeck From: Guenter Roeck To: Steven Rostedt Cc: Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Guenter Roeck , Miaoqian Lin Subject: [PATCH v2] tracing: Add NULL pointer check to trigger_data_free() Date: Thu, 5 Mar 2026 11:33:39 -0800 Message-ID: <20260305193339.2810953-1-linux@roeck-us.net> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If trigger_data_alloc() fails and returns NULL, event_hist_trigger_parse() jumps to the out_free error path. While kfree() safely handles a NULL pointer, trigger_data_free() does not. This causes a NULL pointer dereference in trigger_data_free() when evaluating data->cmd_ops->set_filter. Fix the problem by adding a NULL pointer check to trigger_data_free(). The problem was found by an experimental code review agent based on gemini-3.1-pro while reviewing backports into v6.18.y. Assisted-by: Gemini:gemini-3.1-pro Cc: Miaoqian Lin Cc: Steven Rostedt (Google) Fixes: 0550069cc25f ("tracing: Properly process error handling in event_his= t_trigger_parse()") Signed-off-by: Guenter Roeck --- v2: Add NULL pointer check to trigger_data_free() to make it more robust instead of changing the calling code. Note: Changed patch description to reflect new functionality. kernel/trace/trace_events_trigger.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/trace/trace_events_trigger.c b/kernel/trace/trace_event= s_trigger.c index fecbd679d432..d5230b759a2d 100644 --- a/kernel/trace/trace_events_trigger.c +++ b/kernel/trace/trace_events_trigger.c @@ -50,6 +50,9 @@ static int trigger_kthread_fn(void *ignore) =20 void trigger_data_free(struct event_trigger_data *data) { + if (!data) + return; + if (data->cmd_ops->set_filter) data->cmd_ops->set_filter(NULL, data, NULL); =20 --=20 2.45.2