From nobody Thu Apr 9 21:50:50 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D982E1DF75A for ; Thu, 5 Mar 2026 12:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772713541; cv=none; b=Ed/yR2fD6reIk4JxHE7zvKoPF+Mk1ccdE1rU5jIZsFmaPGrIAEqBxlMszJqwMkGNtpnZhK8AS+zbRsObkbLYQ/E2yaLoSMNy6sbMxWuH8C0cT6LCtzEsymrwEc77WQPJFrKFfRa5h202iEWf5iRSeKFIkynMoQhJcBS9aaFGOhs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772713541; c=relaxed/simple; bh=iwX2UcBl7tP30h9WaByuWXJH1KsY4yDRWRnRss61q8c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=c00P6IDBAWY1toGP0OSE0vj8/1L4rbK/HPVS0Iebh8f7jOVDkTQhKKXXCPGQU2+sHcW6xNZ9lwH0RJcA0QUYVnQ7pZBhe739kbDyJwEIXDcccO2CzN7ePOY8dvuAwOXpZmFvne0EsCrBj+YVy9PECg8qs+Z1ytYyChqkc7PFukI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SmZLVues; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SmZLVues" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48336a6e932so49853235e9.3 for ; Thu, 05 Mar 2026 04:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772713537; x=1773318337; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yPy3h4xaTybaSqSbqk4gaOiETs94bm/62y+eylc0szI=; b=SmZLVuesbvl82vVQCoj29Y0E+JIo6ZFpZHfXGFW2p9cB1kUhXVsf6i1EhC2f3OMiD7 g8y6eD6tc/gSLlKTjUAQzCOzj2DodvjnpFTX0TMj+ZPj2O2ObT+E0RbQAOG/7FbKQfnW 2Z1Ss7xuqENFAkWdGM5jqmTOn0sSNGZsH7LpsjO2F/oQLZkBphUhb2whMrEHJG7ScbX1 9UfnMefJ9z+m6f2w5cqVLfWeqZ4A/ZTbfnHBlM0g8WZRqnxKvyNCh6Vpj3R3q4imLBXN BQ1m8liOLJWHC8EAPUOkNVs5EXLE3XiVmY5gNBOFw/XnSsFCHgwDStyp/59Y3EKWfdHD 5DvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772713537; x=1773318337; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yPy3h4xaTybaSqSbqk4gaOiETs94bm/62y+eylc0szI=; b=m5os5slgCorR130w3x9AUu86neGymKeFedTSpX0yn2gl3ftPGW6kf60ABhHXJlY66Z /qnY1wSFqAEHoPdONGzZ/rmxiTq1D3rdoQzrwKoeYPtnm4zFRmyugQWU9SPkGI2EHvgH 0HtjuCntFfB9lLlL2n5G/EvaT7M86kBe6oRrMDW1jIettXe6P+sMt0LlmUZla6JjUMLu fyR72xhpkVCM7QP5dooxehUfg/fBb/THv4+vtv68vEDTuiC439Y4o9mN79kWOpL7aMxc 6TH1nUYM3WR4AZtCqKoUUZCUKnJ7zzFZDzIE8Mq70COTNKC4ZG4RZ+qcWp+4vap+akUo b5Nw== X-Forwarded-Encrypted: i=1; AJvYcCXhFS9PmY/pMGHR2g0E9M3xB3Y1UwR5eMHmRMsMNTgZU0CEp8tUHgS/fklZw5urqcHRvqjAIIS46qqKEMc=@vger.kernel.org X-Gm-Message-State: AOJu0YxgRKuMSKfpw6iEATRGcuTrKl1liCJf/JkI04jcxydmst5+PjBu +Ss3U/SR01c682Q3O3v9BzgEj2SCoYSQN0FNl9qcDT4flE1Po8BJhbx3 X-Gm-Gg: ATEYQzw7sWPsrVindIMgCiHkfePIOujZMRB2RwLKNabwIjwxxNyI1Emjl4TN1aMmpEZ MEhz+FWRe9CRuzO43LND79kF5jd+YYk4r7hU2a9t0zC9m6Cv5p307FqR3hjex2+0lwh6xKj5zWD TLSqyqoettmHEVZu/sZhmNAs4/QzhPesF6eRZz+nwGSGFLhwyA9ZkgWvD2FXgqu5WgY6Zk/ZDNk hgRPR0Rv7Va1Q5W3uEsNAtQ+sFChGhD+wbixaMuL/pVdd9ZokXd94oWKHWMzBeAa2YuNI9NPJs1 zpb3VFTgb0c2Oiz1z3AKJUWdr+WNeyziGsGbqtMihzfU6DJXkzkamdAgz/qv7kyt/1tBy2ctQ9q g9ElHLTnedziSCqhAQKVffWJxXQ6vzUKWpP5VZq5YsRBU/0aIngQlu6EkQLnQ0IvCKsjAVtVOy3 /fqIKAu3GS/E+1YJml50ophAqstAXLyesfZz5nyiRyTWDVAoq/f5crOqSnd73cJ5eXJYDWTalqE ag6wNXxTFQuGknmcXAan3mRk+WR X-Received: by 2002:a05:600c:64c6:b0:477:a219:cdb7 with SMTP id 5b1f17b1804b1-485197eb4d5mr103855525e9.0.1772713537033; Thu, 05 Mar 2026 04:25:37 -0800 (PST) Received: from skynet.lan (2a02-9142-4581-3b00-0000-0000-0000-0008.red-2a02-914.customerbaf.ipv6.rima-tde.net. [2a02:9142:4581:3b00::8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b8807a4esm30025156f8f.4.2026.03.05.04.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 04:25:36 -0800 (PST) From: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= To: linux@armlinux.org.uk, andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mnhagan88@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Subject: [PATCH RESEND net] net: sfp: improve Huawei MA5671a fixup Date: Thu, 5 Mar 2026 13:25:15 +0100 Message-ID: <20260305122533.43820-1-noltari@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable With the current sfp_fixup_ignore_tx_fault() fixup we ignore the TX_FAULT signal, but we also need to apply sfp_fixup_ignore_los() in order to be able to communicate with the module even if the fiber isn't connected for configuration purposes. This is needed for all the MA5671a firmwares, excluding the FS modded firmware. Fixes: 2069624dac19 ("net: sfp: Add tx-fault workaround for Huawei MA5671A = SFP ONT") Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas --- drivers/net/phy/sfp.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 347c1e0e94d9..bcea137ad5f9 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -361,6 +361,12 @@ static void sfp_fixup_ignore_tx_fault(struct sfp *sfp) sfp->state_ignore_mask |=3D SFP_F_TX_FAULT; } =20 +static void sfp_fixup_huawei(struct sfp *sfp) +{ + sfp_fixup_ignore_tx_fault(sfp); + sfp_fixup_ignore_los(sfp); +} + static void sfp_fixup_nokia(struct sfp *sfp) { sfp_fixup_long_startup(sfp); @@ -499,7 +505,7 @@ static const struct sfp_quirk sfp_quirks[] =3D { // Huawei MA5671A can operate at 2500base-X, but report 1.2GBd NRZ in // their EEPROM SFP_QUIRK("HUAWEI", "MA5671A", sfp_quirk_2500basex, - sfp_fixup_ignore_tx_fault), + sfp_fixup_huawei), =20 // Lantech 8330-262D-E can operate at 2500base-X, but incorrectly report // 2500MBd NRZ in their EEPROM --=20 2.47.3