From nobody Thu Apr 9 21:50:48 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2EC1388395 for ; Thu, 5 Mar 2026 12:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772712843; cv=none; b=skyyxkVgGdTIjKfKQyFzgG3ch7EUlSy6XGQtzQ8P+jOFLHMnMWI6ktGbnwUMYpNyibnLOiIX5P8JNz41306EEgTaCX+vCUTFFVb+IFbL5BbhKfrAxnF9Vm9RnMAvcHPgagDJmF9NPxwLjBnPPgvvBD4aAZf/5NCbN5/CimlAgu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772712843; c=relaxed/simple; bh=iwX2UcBl7tP30h9WaByuWXJH1KsY4yDRWRnRss61q8c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=kPNK+0Ru0iCvhLPm8qzEFNpi1h4sHVl7Tvp/Saa13iLQ/xI1whRrPmvvupRVTuISPrkpkY71bmvA3CnJuqrk9hyUAklbpTjpJFeHQ3DuXNOLDYfoAv3VG+hxj26kSayBbA/VM3RbR3pkiIefMuGsMejIwov0V/dtxw7vgH6GHYI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UXallV0k; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UXallV0k" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48371bb515eso118852625e9.1 for ; Thu, 05 Mar 2026 04:14:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772712839; x=1773317639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yPy3h4xaTybaSqSbqk4gaOiETs94bm/62y+eylc0szI=; b=UXallV0kEoDcEatFGIcj67KN2TTHI0K6M7MJHzTzvGS0wUxselM5tumRPfcaKGrcmg 9Yy1yCCkzE8Z5i17vWT9kPfz6qAZTh2Ony6hHNf4fzEjZQhHdPok1YYDXZSfwm0cX8sK mF69uErdq++Lxn49LVym8He3jSCpMQNnJH+BQ8pWuDsiBuN9MYPnlfuOO2th/oncE3cE zPcJtSa7R/ZYkBAw9YSGxi0nukpUyaziZJOa5E2DotpCHR+AFivhKQeUygXk4RHyjGs0 HRTgGReahuxRAh/SC6iqvGFEC1tFcZMJrtnhTsnyLghu7I1pKvu61856bfkzmnwmubr/ N7Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772712839; x=1773317639; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yPy3h4xaTybaSqSbqk4gaOiETs94bm/62y+eylc0szI=; b=JQFjVmpgUmuZGfAYzWrcopWwC1xKDVvo2DBqX9qIY08IQxG1Y3jYUR8vu6e+nuAJ4W c1U4941dJVbrggtKPcZEGN/zuOIGAUBI83BuZGJjh/HjUiZV4JwEvg8H9XAL5q/zv9J/ meaLrM3evjAKSJbeTuX23Vpy92cgfJAy4h3ndHg1BD+3MAmRimjAi21MvGIcYTA8gZ5U ZrBGqbqPIs2m1gkcyruCbrSx2Fet7dibT3uPcU9IEy1boX3Wo2Swqn38dM5R95ZJsNiJ EhjgguL8PUlUwcAXljTQxJ05XVRby5X3lSdk0g21wOS8PWd4FT6+h0dB7GIMriVDzmkK JEPQ== X-Forwarded-Encrypted: i=1; AJvYcCWmCpoGYAFErsZY2j/MojQvUkWipGHMMqwCDGe3EKGj9V0g6CpgjEK2txiV8vbJaVRmXwRdgal74bdj/xQ=@vger.kernel.org X-Gm-Message-State: AOJu0YysVOj0nSbAA4OHxSxlMm1Rn+URkvVCOey+oHiqn4Od9bUFiQDD Zu+EyyAzuVLwglSnfUxZMa0+2zZyzPpsVGT01QUPVtz8oZ31gLXN9aaL X-Gm-Gg: ATEYQzzv8kSAHBmmZVAESrs6DoDaPmq34GTPb+SgiLavl9jBqvsZoIGJ85kDdm5FObe ycdShbKrKamuPmAfXGMXC/A2y4pZ4Y6B2hNmEM/DFRbqimwGuVz0Eo/S1efOvv7whJQHk9yxRsE tzrJJTO2B+aqHdls9bthDdn280V3UuhthUd6aAt9mSJmkJsWFcntEez/9DZnV6XD/9wXuzQqii+ MJXXINfje1HftTAOSKWwMzn0jUKbUw+AbRcNYxfI/nBKfVFDbhmagmHRHo3OqaroysOwzVTuZxr PacRvc0n/D7nUM3piumA0EZ6Qz3VeGWoTgS+5sC3+fS1VLKIgOks17ym+Pa9/PxxUEzSBFwuGBK /guirhfqCcmE+tM+hNhiiL5D5KccZn0ujaJSaP1NS4XrzTVG8JhlLSnOUabGMCWX00yV7+p7pve ToKOryIq02TzdBcA0Wk69QVsNcsFdWvcTtIeBwG7Ll+7jIjU23ub+ZA2qWZJr8Ycsabnm2MvU0x 3sVeyjgAlemS0s1u1GJQUUuCadA X-Received: by 2002:a05:600c:470d:b0:47d:18b0:bb9a with SMTP id 5b1f17b1804b1-485198b340emr99599985e9.33.1772712839130; Thu, 05 Mar 2026 04:13:59 -0800 (PST) Received: from skynet.lan (2a02-9142-4581-3b00-0000-0000-0000-0008.red-2a02-914.customerbaf.ipv6.rima-tde.net. [2a02:9142:4581:3b00::8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851acf9ac7sm32219815e9.15.2026.03.05.04.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 04:13:58 -0800 (PST) From: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= To: linux@armlinux.org.uk, andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mnhagan88@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Subject: [PATCH] net: sfp: improve Huawei MA5671a fixup Date: Thu, 5 Mar 2026 13:12:39 +0100 Message-ID: <20260305121354.40674-1-noltari@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable With the current sfp_fixup_ignore_tx_fault() fixup we ignore the TX_FAULT signal, but we also need to apply sfp_fixup_ignore_los() in order to be able to communicate with the module even if the fiber isn't connected for configuration purposes. This is needed for all the MA5671a firmwares, excluding the FS modded firmware. Fixes: 2069624dac19 ("net: sfp: Add tx-fault workaround for Huawei MA5671A = SFP ONT") Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas --- drivers/net/phy/sfp.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 347c1e0e94d9..bcea137ad5f9 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -361,6 +361,12 @@ static void sfp_fixup_ignore_tx_fault(struct sfp *sfp) sfp->state_ignore_mask |=3D SFP_F_TX_FAULT; } =20 +static void sfp_fixup_huawei(struct sfp *sfp) +{ + sfp_fixup_ignore_tx_fault(sfp); + sfp_fixup_ignore_los(sfp); +} + static void sfp_fixup_nokia(struct sfp *sfp) { sfp_fixup_long_startup(sfp); @@ -499,7 +505,7 @@ static const struct sfp_quirk sfp_quirks[] =3D { // Huawei MA5671A can operate at 2500base-X, but report 1.2GBd NRZ in // their EEPROM SFP_QUIRK("HUAWEI", "MA5671A", sfp_quirk_2500basex, - sfp_fixup_ignore_tx_fault), + sfp_fixup_huawei), =20 // Lantech 8330-262D-E can operate at 2500base-X, but incorrectly report // 2500MBd NRZ in their EEPROM --=20 2.47.3