From nobody Thu Apr 2 00:13:29 2026 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 268293822BC for ; Thu, 5 Mar 2026 11:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772709020; cv=none; b=joBM1SYkTIk4asxdObeUgMwEd8UrzQRbuJ4q/lJVnxaR7wA78fBV8s0waN3gU8e3cMgIhYnDQQVl1pcU8lTmuVsfEXC5rmBqU55vurM3udFQigY4CB+bKZSFLghbcUXnSGnlqEqMPCeLBaVgDgRL+NbBw/deiOVzUv2eS53W+yI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772709020; c=relaxed/simple; bh=iILJccyDyJaNfe5/O36ZoRk8XcC4XvtVI+KNgSJv2Nc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YMt6td1zkBg404Jt7Ynrc6+0TUvkA02YbcFPHEPvWdtxbZkb32JGnJpOVuO840wYcqiqlhsI3C4n0GahMDsP7bL3rpPr3dzehwsutdQ2YnHTpGZm2EoAy145fDWfyso5lyAjWEa0ps7ljQM1QWJZP5Qxki2reSoP5NS7tN3LbIo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmo-cybersecurity.com; spf=pass smtp.mailfrom=gmo-cybersecurity.com; dkim=pass (2048-bit key) header.d=gmo-cybersecurity.com header.i=@gmo-cybersecurity.com header.b=DVW6TfxG; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmo-cybersecurity.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmo-cybersecurity.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmo-cybersecurity.com header.i=@gmo-cybersecurity.com header.b="DVW6TfxG" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c73967cf77aso27757a12.3 for ; Thu, 05 Mar 2026 03:10:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmo-cybersecurity.com; s=google; t=1772709018; x=1773313818; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8Uah3KJlZJ0YDkhXOPrfMLRnjC77tql+fRjEzdTgsKU=; b=DVW6TfxGI3iG/7wYkWj8BG2PVC1BcETzqH1s2iQr/tDZ0XYDtmlfMnGCr1bUq5UxGJ 8dCfYy8Rc9qhoX55TBHO3FUL/prPI4EKzu5ukTCNUSAGzMlrc/346feltegVNMo41GM5 fVLJk4K6SjwqvgyRg8TYOWQbtPdgbnMn1xtguH9Vfpkg61dV6HovyVllwVppzg6HC8VP GMY+YYcUfH1bSDQT11RBwQh0/BOVnBbvMfbD2jC2c5i3irw0YJTetfLFoTPd2wJgXimb Xoq21EK7vHaOKPMpecQIjigkrdL5hR2fIYYszktzGTOsy7ZRc0a8fVBMYzPEOqxvGS9Q D0Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772709018; x=1773313818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8Uah3KJlZJ0YDkhXOPrfMLRnjC77tql+fRjEzdTgsKU=; b=uo2cqm6dOQf+CUvKSItNIx10+bgAcKK0yPZuUraFIViP9ZHlg1rYLf0n8GsaMs1v+6 5/9QiGr1DW4qfrgN7l+2HH2QNzQR0FeGmyp4w7H7U38yNJ6u8GS+1ZHZWwOjvWfHTDcW EJjdTqp6U28uvyCIjGK/BjJgnXNZl8fuY+WYzPxXpVGJwDHj0pzv4ssxrJXXBX/ZAX2S aDubFlO6p4v2LZJW8ZZ12fzZrLeJeCcD2CxEGtsK60YFb72vFCoOg1P07c0n4+WCyMeb YIXxgZVMCpvhg6Rbk41pC02Q6T/OECffGMwfezRiZ3RDKZ83Z81FZk0YD92ABLD6dk9z o3Ww== X-Forwarded-Encrypted: i=1; AJvYcCVcZrA8a1snKHn8+lS+dYet1N4RGfEID5w+WHOKm/3Nae9nyTxg/7wqNgkZvbbIwRlhLvmdaMqnCfDZ4Q8=@vger.kernel.org X-Gm-Message-State: AOJu0YzZWw4JLxJuLfc422SlMH4keTfGBubKwLVWHZSzzfvRO1nsFNYD ExII1/DK55Zx6RfoTj2Cw/kqlHUqpinArYdzJBviHlS5iUNCRH5eTFdX77z0cnkQDM8= X-Gm-Gg: ATEYQzy3o84GvMMGAXRJMKswzLYzZPGZU4a8pObQGTw5KXdzd7kBr6aZ8KnWr8hdtFl Et52g9en3v8Pqod8ThZ3dvimolng1nyAQxhUSMXTWIV6H1Kx5dk2JGxRRK6wvNmeEZrBw+c6Sf3 /h80mJhuDpR4Sbl8dzsRji40t/Ka6798DUGK6rMMINWpbdARx9fbx/yEP16ZtjXaI1OVY3XE7G9 P1YYjqbmRJeNJzUemArrzDc0lj+cNGBHBGDTQMFw7Wf5SBhRespWdBoq9n4lX7Gx0GYg/uKF5XO M9HpLk9phnS7DGuCLOBThQhwC/HM7KO3l/WJwKda+S60X0ouAWZDIsZ312WJF143NxJrGLW5ah+ 0nBtF8L0EQALU/2nUVVlYSYuAMG+Bn4fxZzkgx4QDZ7jZjHqxXxXM1smjTgv6cgTY80HGVmZgbU san9pPEcjI1/ZyYGFRaD7j4NXgW+aLY0u31tUmMEpvJTygc6bsZsi+Uc/VCNc6A3ig9f5Q1X//p 51AimInX9hJUVUNMlb+jTs= X-Received: by 2002:a17:902:db0f:b0:2ad:6e26:abbb with SMTP id d9443c01a7336-2ae6ab9ecd3mr48315825ad.54.1772709018409; Thu, 05 Mar 2026 03:10:18 -0800 (PST) Received: from cachyos.camel-monitor.ts.net (akacd-04p3-188.ppp11.odn.ad.jp. [210.237.248.188]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3e4e34fesm153501155ad.28.2026.03.05.03.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 03:10:18 -0800 (PST) From: Kota Toda To: Jeff Garzik , Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Alexander Aring , Stefan Schmidt , Miquel Raynal , David Ahern Cc: Kota Toda , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yuki Koike , linux-wpan@vger.kernel.org Subject: [PATCH v4 2/2] net: read header_ops callbacks with READ_ONCE() Date: Thu, 5 Mar 2026 20:07:49 +0900 Message-ID: <20260305110751.167489-3-kota.toda@gmo-cybersecurity.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260305110751.167489-1-kota.toda@gmo-cybersecurity.com> References: <20260305110751.167489-1-kota.toda@gmo-cybersecurity.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Bonding now updates its header_ops callbacks at runtime, so lockless readers can observe concurrent callback updates. This patch loads header_ops callbacks with READ_ONCE() and=20 call the loaded function pointer, instead of=20 re-reading through dev->header_ops. Signed-off-by: Kota Toda Co-developed-by: Yuki Koike Signed-off-by: Yuki Koike --- include/linux/netdevice.h | 41 +++++++++++++++++++++++++++------------ include/net/cfg802154.h | 2 +- net/core/neighbour.c | 6 +++--- net/ipv4/arp.c | 2 +- net/ipv6/ndisc.c | 2 +- 5 files changed, 35 insertions(+), 18 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 77a99c8ab..79fb0864a 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -3150,35 +3150,50 @@ static inline int dev_hard_header(struct sk_buff *s= kb, struct net_device *dev, const void *daddr, const void *saddr, unsigned int len) { - if (!dev->header_ops || !dev->header_ops->create) - return 0; + int (*create)(struct sk_buff *skb, struct net_device *dev, + unsigned short type, const void *daddr, + const void *saddr, unsigned int len); =20 - return dev->header_ops->create(skb, dev, type, daddr, saddr, len); + if (!dev->header_ops) + return 0; + create =3D READ_ONCE(dev->header_ops->create); + if (!create) + return 0; + return create(skb, dev, type, daddr, saddr, len); } =20 static inline int dev_parse_header(const struct sk_buff *skb, unsigned char *haddr) { + int (*parse)(const struct sk_buff *skb, unsigned char *haddr); const struct net_device *dev =3D skb->dev; =20 - if (!dev->header_ops || !dev->header_ops->parse) + if (!dev->header_ops) return 0; - return dev->header_ops->parse(skb, haddr); + parse =3D READ_ONCE(dev->header_ops->parse); + if (!parse) + return 0; + return parse(skb, haddr); } =20 static inline __be16 dev_parse_header_protocol(const struct sk_buff *skb) { + __be16 (*parse_protocol)(const struct sk_buff *skb); const struct net_device *dev =3D skb->dev; =20 - if (!dev->header_ops || !dev->header_ops->parse_protocol) + if (!dev->header_ops) + return 0; + parse_protocol =3D READ_ONCE(dev->header_ops->parse_protocol); + if (!parse_protocol) return 0; - return dev->header_ops->parse_protocol(skb); + return parse_protocol(skb); } =20 /* ll_header must have at least hard_header_len allocated */ static inline bool dev_validate_header(const struct net_device *dev, char *ll_header, int len) { + bool (*validate)(const char *ll_header, unsigned int len); if (likely(len >=3D dev->hard_header_len)) return true; if (len < dev->min_header_len) @@ -3189,15 +3204,17 @@ static inline bool dev_validate_header(const struct= net_device *dev, return true; } =20 - if (dev->header_ops && dev->header_ops->validate) - return dev->header_ops->validate(ll_header, len); - - return false; + if (!dev->header_ops) + return false; + validate =3D READ_ONCE(dev->header_ops->validate); + if (!validate) + return false; + return validate(ll_header, len); } =20 static inline bool dev_has_header(const struct net_device *dev) { - return dev->header_ops && dev->header_ops->create; + return dev->header_ops && READ_ONCE(dev->header_ops->create); } =20 /* diff --git a/include/net/cfg802154.h b/include/net/cfg802154.h index 76d2cd2e2..dec638763 100644 --- a/include/net/cfg802154.h +++ b/include/net/cfg802154.h @@ -522,7 +522,7 @@ wpan_dev_hard_header(struct sk_buff *skb, struct net_de= vice *dev, { struct wpan_dev *wpan_dev =3D dev->ieee802154_ptr; =20 - return wpan_dev->header_ops->create(skb, dev, daddr, saddr, len); + return READ_ONCE(wpan_dev->header_ops->create)(skb, dev, daddr, saddr, le= n); } #endif =20 diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 96786016d..ff948e35e 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -1270,7 +1270,7 @@ static void neigh_update_hhs(struct neighbour *neigh) =3D NULL; =20 if (neigh->dev->header_ops) - update =3D neigh->dev->header_ops->cache_update; + update =3D READ_ONCE(neigh->dev->header_ops->cache_update); =20 if (update) { hh =3D &neigh->hh; @@ -1540,7 +1540,7 @@ static void neigh_hh_init(struct neighbour *n) * hh_cache entry. */ if (!hh->hh_len) - dev->header_ops->cache(n, hh, prot); + READ_ONCE(dev->header_ops->cache)(n, hh, prot); =20 write_unlock_bh(&n->lock); } @@ -1556,7 +1556,7 @@ int neigh_resolve_output(struct neighbour *neigh, str= uct sk_buff *skb) struct net_device *dev =3D neigh->dev; unsigned int seq; =20 - if (dev->header_ops->cache && !READ_ONCE(neigh->hh.hh_len)) + if (READ_ONCE(dev->header_ops->cache) && !READ_ONCE(neigh->hh.hh_len)) neigh_hh_init(neigh); =20 do { diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index 7822b2144..421bea6eb 100644 --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c @@ -278,7 +278,7 @@ static int arp_constructor(struct neighbour *neigh) memcpy(neigh->ha, dev->broadcast, dev->addr_len); } =20 - if (dev->header_ops->cache) + if (READ_ONCE(dev->header_ops->cache)) neigh->ops =3D &arp_hh_ops; else neigh->ops =3D &arp_generic_ops; diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index d961e6c2d..d81f509ec 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -361,7 +361,7 @@ static int ndisc_constructor(struct neighbour *neigh) neigh->nud_state =3D NUD_NOARP; memcpy(neigh->ha, dev->broadcast, dev->addr_len); } - if (dev->header_ops->cache) + if (READ_ONCE(dev->header_ops->cache)) neigh->ops =3D &ndisc_hh_ops; else neigh->ops =3D &ndisc_generic_ops; --=20 2.53.0