From nobody Thu Apr 9 23:25:13 2026 Received: from canpmsgout06.his.huawei.com (canpmsgout06.his.huawei.com [113.46.200.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B15BD336896; Thu, 5 Mar 2026 06:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.221 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772693230; cv=none; b=L/eJ7tKLGNMdxZRbSqw0YvQsGnyUiaKQn3eB68OToWngY5/RHQiuzXrzrXejDN5HCSRMSgsxGojtCG75jCtUGcHsN2uVVE4eKESjhDSUL5oqly9dz1oJqN/L1P2wYALNaF2nTmqMaJ77ASpkBCH8dZKF++WlZgQGEVCcQRU35Os= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772693230; c=relaxed/simple; bh=T+S8kftzIEGtGBHHY4aqv28KBazVlbZNJZhSMsbai4U=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ncTVdZA0Wmo0A25XUNSQj3d5bDh2fGMB7nYwU589Ne7sxkcU3vkFX+BUrALWtx9/fNJ1MaXaYG/W9jJrB4iijimd/U/xs0wxbjpJAEgZuDw5BdmGgr5pcGurilkxQAvaE+BYfyCHFA2RgE5NIpwgYuusdJl5g2ZS+LhkZwmdSE0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=h-partners.com; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b=NTM/u94y; arc=none smtp.client-ip=113.46.200.221 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=h-partners.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b="NTM/u94y" dkim-signature: v=1; a=rsa-sha256; d=h-partners.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=NAv6EiRKzKHrk4156Api7kyciszsULpevwMZqz+i+SM=; b=NTM/u94ynFSa/VuVDI4FieDR3yxNG0SVxkwncgMg3/U+0uZ3yYUs0npiljF+/1WSyoerhmiW8 29IOQTJd72xUYXewHH2QmQaj+3BZQsRMU1+DihyB2J9pGPt2rwzPhi6c7eQKDfg6+4JCxv00Kmd 7+BqkmTdZL197Xzde/hkmzE= Received: from mail.maildlp.com (unknown [172.19.162.140]) by canpmsgout06.his.huawei.com (SkyGuard) with ESMTPS id 4fRKhf4Gq7zRhSc; Thu, 5 Mar 2026 14:42:10 +0800 (CST) Received: from kwepemh200005.china.huawei.com (unknown [7.202.181.112]) by mail.maildlp.com (Postfix) with ESMTPS id 83DCC2025F; Thu, 5 Mar 2026 14:47:01 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by kwepemh200005.china.huawei.com (7.202.181.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 5 Mar 2026 14:47:00 +0800 From: Yihang Li To: , CC: , , , , , , Subject: [RESEND PATCH 1/2] scsi: hisi_sas: Correct the printing format issues Date: Thu, 5 Mar 2026 14:46:59 +0800 Message-ID: <20260305064700.116033-2-liyihang9@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260305064700.116033-1-liyihang9@huawei.com> References: <20260305064700.116033-1-liyihang9@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemh200005.china.huawei.com (7.202.181.112) Content-Type: text/plain; charset="utf-8" There are some print format errors, fix them. Signed-off-by: Yihang Li --- drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/= hisi_sas_main.c index 30a9c6612651..00e4b59ff711 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -1326,7 +1326,7 @@ static int hisi_sas_control_phy(struct asd_sas_phy *s= as_phy, enum phy_func func, =20 if (sts && !wait_for_completion_timeout(&completion, HISI_SAS_WAIT_PHYUP_TIMEOUT)) { - dev_warn(dev, "phy%d wait phyup timed out for func %d\n", + dev_warn(dev, "phy%d wait phyup timed out for func %u\n", phy_no, func); if (phy->in_reset) ret =3D -ETIMEDOUT; diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas= /hisi_sas_v3_hw.c index 2f9e01717ef3..6a841d53bb10 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -896,7 +896,7 @@ static void setup_itct_v3_hw(struct hisi_hba *hisi_hba, qw0 =3D HISI_SAS_DEV_TYPE_SATA << ITCT_HDR_DEV_TYPE_OFF; break; default: - dev_warn(dev, "setup itct: unsupported dev type (%d)\n", + dev_warn(dev, "setup itct: unsupported dev type (%u)\n", sas_dev->dev_type); } =20 @@ -2847,7 +2847,7 @@ static void wait_cmds_complete_timeout_v3_hw(struct h= isi_hba *hisi_hba, static ssize_t intr_conv_v3_hw_show(struct device *dev, struct device_attribute *attr, char *buf) { - return scnprintf(buf, PAGE_SIZE, "%u\n", hisi_sas_intr_conv); + return scnprintf(buf, PAGE_SIZE, "%d\n", hisi_sas_intr_conv); } static DEVICE_ATTR_RO(intr_conv_v3_hw); =20 @@ -3293,7 +3293,7 @@ static int debugfs_set_bist_v3_hw(struct hisi_hba *hi= si_hba, bool enable) u32 *fix_code =3D &hisi_hba->debugfs_bist_fixed_code[0]; struct device *dev =3D hisi_hba->dev; =20 - dev_info(dev, "BIST info:phy%d link_rate=3D%d code_mode=3D%d path_mode=3D= %d ffe=3D{0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x} fixed_code=3D{0x%x, 0x%= x}\n", + dev_info(dev, "BIST info:phy%u link_rate=3D%u code_mode=3D%u path_mode=3D= %u ffe=3D{0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x, 0x%x} fixed_code=3D{0x%x, 0x%= x}\n", phy_no, linkrate, code_mode, path_mode, ffe[FFE_SAS_1_5_GBPS], ffe[FFE_SAS_3_0_GBPS], ffe[FFE_SAS_6_0_GBPS], ffe[FFE_SAS_12_0_GBPS], @@ -3650,7 +3650,7 @@ static void debugfs_print_reg_v3_hw(u32 *regs_val, st= ruct seq_file *s, int i; =20 for (i =3D 0; i < reg->count; i++) { - int off =3D i * HISI_SAS_REG_MEM_SIZE; + u32 off =3D i * HISI_SAS_REG_MEM_SIZE; const char *name; =20 name =3D debugfs_to_reg_name_v3_hw(off, reg->base_off, --=20 2.33.0 From nobody Thu Apr 9 23:25:13 2026 Received: from canpmsgout09.his.huawei.com (canpmsgout09.his.huawei.com [113.46.200.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22B9B2EBB86; Thu, 5 Mar 2026 06:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.224 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772693231; cv=none; b=r8HMPT8sDjcIjIlUCZJkx1S7tsySN2/oT3Bu0eDHScEzicxvn6gc5hCZncJIKoDfm3kvCIhG0St9D3DB02C21voyaIX+CZWGWX3SkXGbzexortQ6ijqk82jRaLYjq0NzxbVqbu30arSU7CV2d1aWSkBdStd5XbGXU6b9vZdw1NY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772693231; c=relaxed/simple; bh=tjz8DYTFLILaLPZ2POqqGVLbbtO83RpCWW9MF1wDxnA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=P0yPsHndgDdqHFYoVzPgW7TkLOoJeIBqI50iYOJNMLqqPtoUp9QkV5Dmq93YN8QvTJcT1qtizymCjDiIS4IpkvMCUj7NOlFVfqmYXRWSKf7z7qkUAJWm0Tu/nyxmsn0u8UI1eyI+GModjB6j9BIjervt/Ej35PvKq+1fuAbJLXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=h-partners.com; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b=VAMv6CGV; arc=none smtp.client-ip=113.46.200.224 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=h-partners.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b="VAMv6CGV" dkim-signature: v=1; a=rsa-sha256; d=h-partners.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=iBOVi96Sh49dtoTfm+FbmO+TG0+HTIsqRUXIifZb570=; b=VAMv6CGV1oPRE1T62SqdTnfWCyUc6XQp4pSZeb4ruQDt2OxWrDEIYrCt5bwyy/mMh/ik6eYo/ GvZRfsz/yRiSD9s6TvY311k3W5QgErXjRUdfhTvQSv330PqqiUkamh7LKk0ZbKLTYfG3MdWKz0j An3vP7tLqh+GPeBpQEymYY8= Received: from mail.maildlp.com (unknown [172.19.162.92]) by canpmsgout09.his.huawei.com (SkyGuard) with ESMTPS id 4fRKhf3y9rz1cyp9; Thu, 5 Mar 2026 14:42:10 +0800 (CST) Received: from kwepemh200005.china.huawei.com (unknown [7.202.181.112]) by mail.maildlp.com (Postfix) with ESMTPS id EB9AD40568; Thu, 5 Mar 2026 14:47:01 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by kwepemh200005.china.huawei.com (7.202.181.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 5 Mar 2026 14:47:01 +0800 From: Yihang Li To: , CC: , , , , , , Subject: [RESEND PATCH 2/2] scsi: hisi_sas: Fixed the risk of overflow in bitwise logical operations Date: Thu, 5 Mar 2026 14:47:00 +0800 Message-ID: <20260305064700.116033-3-liyihang9@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20260305064700.116033-1-liyihang9@huawei.com> References: <20260305064700.116033-1-liyihang9@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemh200005.china.huawei.com (7.202.181.112) Content-Type: text/plain; charset="utf-8" Fixed a few constants defined via macros that had overflow risks. Signed-off-by: Yihang Li --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas= /hisi_sas_v3_hw.c index 6a841d53bb10..ba9d6877483a 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -432,7 +432,7 @@ #define CMPLT_HDR_IPTT_OFF 0 #define CMPLT_HDR_IPTT_MSK (0xffff << CMPLT_HDR_IPTT_OFF) #define CMPLT_HDR_DEV_ID_OFF 16 -#define CMPLT_HDR_DEV_ID_MSK (0xffff << CMPLT_HDR_DEV_ID_OFF) +#define CMPLT_HDR_DEV_ID_MSK (0xffffU << CMPLT_HDR_DEV_ID_OFF) /* dw3 */ #define SATA_DISK_IN_ERROR_STATUS_OFF 8 #define SATA_DISK_IN_ERROR_STATUS_MSK (0x1 << SATA_DISK_IN_ERROR_STATUS_OF= F) @@ -444,7 +444,7 @@ #define FIS_ATA_STATUS_ERR_OFF 18 #define FIS_ATA_STATUS_ERR_MSK (0x1 << FIS_ATA_STATUS_ERR_OFF) #define FIS_TYPE_SDB_OFF 31 -#define FIS_TYPE_SDB_MSK (0x1 << FIS_TYPE_SDB_OFF) +#define FIS_TYPE_SDB_MSK (0x1U << FIS_TYPE_SDB_OFF) =20 /* ITCT header */ /* qw0 */ --=20 2.33.0