From nobody Thu Apr 9 14:57:51 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22F2F200110 for ; Thu, 5 Mar 2026 04:49:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772686192; cv=none; b=taSfrDz/q3tYHioG0g0SFNmP78yBjtfj+F6XAn7jkjBZMQvAszl8m2qJB0TzmHgZ6HZGpge6q1FJdJDkm3ivFZ7GLZVN35FKkno830MPa11ngGCkCAEIbbCPsx17tgbCi+wwQPtoYJFnWm85e6syaH8ABaplfiyTDeL7q+dIwB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772686192; c=relaxed/simple; bh=jI+XjltSWI7z9cqMIkGUsHesFiDS+5K02m+Txt33crw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ekta7f+/cJfDQ5JpCnsXWefdhEO/gdTcCJmU0PnAHs9bzNUX8FMTwkSLDRoMfB5QLLjn0okL6HzFEGGaJ0GgNpcusLJKh075TEPOpRGTZ2SLN9oRjrD6AQuJpzZ4OQ7WCdQf7imz/CPlIk2lNO0vxGkK5yN+Sv4gVaxuQTo1LA4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D25AuaC6; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D25AuaC6" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ae43042ea7so49705335ad.0 for ; Wed, 04 Mar 2026 20:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772686190; x=1773290990; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wtRLYVacjU+FLKQcuDOYdF2aeBusQOEEXCWfIih9meM=; b=D25AuaC6+MIK1wgHW44T/KnnnR8stbVCLxpDKvJPh/yVJxAuU1b4/raA7YVJUDc7rI EF7xqwo3J0ncVZovuegXKKn7M5fK7cD3d1DimIzfFypf8DT9BTkGUeygPOLsIBfbDXkR rqMFkJPkr3ZTiz7tVPZjCpRzvcx2YU+P1hKAkcO6VbUvIe7poFyE/ycFe49H3sjp2K+W AXkTZl9DCdgu5RlRrjlyAjdx4yjnvADlH1zeY5SbtnAhdSUzq4WOXgAh+RJEVNCYBGoO 9cygGD/PnNAmVsmNeIgfBsudO3hTFvIcJK8wFp0XoBmyDYVEZK/c5qegzbV2BR+KBDKw GJjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772686190; x=1773290990; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wtRLYVacjU+FLKQcuDOYdF2aeBusQOEEXCWfIih9meM=; b=Extxk/NT9ZW8wRPIumWsw0Cg0t//9CGDttBlYZ9f74fv1r7TAlUfpRwt46hYIU+XJy dxAZ3oOqxbKCMHtyoF0htUooUEefZxn63ofI0bnTK+Kl3ELmXR3E2OQf+NSJ4GQRCH1L YnOBpaLfRXLvKLdNsVP8cMyKNoyrmYrN110Ltsf7NgkUAfvLWDjVfbIpQO840WFeEIz+ omHCSdd9s9MP4ACtCGppHsu/MWHyT/t0GHMcLAY/ua231vGh/T8zUycEhMbKJSi5i2tZ DlkqsQLQjg+x5C0DpLbheEUxFkuzLLGAZONVIz8iLyTxUs0lgVMiWH2KIaU1VLB0w9D2 3U+g== X-Forwarded-Encrypted: i=1; AJvYcCUQY2S/d6HZjOdG9pIuBbrO8cNsTUfk4j7PwULZQj1PlUnSlHLRytNkO2eNIs+uAoc5Sr6IzfKDev9HD2A=@vger.kernel.org X-Gm-Message-State: AOJu0YygolIr5wADt5B3hW5z53ZeEw4t/N8OJblVW9fkusQtYePJSUBC ki1tahQ+kqaTyMfvod2Esv5Sd0OpbQMMK72rQwZggNZanP4fBa2DrwtF X-Gm-Gg: ATEYQzy6EKUrSSfVH+pMyFDkeb+sjznqLUf25PXvOYnCBgs3viBye8A+vtLhLqFptIk 2Ixo41DPBEqM6nRWxcmpTkGbWpwu+v8KUM/tX+pj3B37eYol1VelvnPslCPYkQjRbBN19RHJesb cwH7dtOB8T8wZxxkz/hNrF53IxEUMPSZSc40WJixTfBrd5KIwda/ICsrGOqQCD8wPK53pnvL+RO TgJ8PcZ83L5WAgY+Yss2OnXPYcuqbPsUmAxt9lmG6WZyPel+DDjIDF7QYjKK00H321RqU49pTNo /K1r5hr4pOKqJHZhAupgxG7yK9dh2cLiDTyIQLLLkV4NClrkm1gi9ALdL4w6pqpX7EraEuFZ4LM FBTnxPVjirAKkRb9VfSiThfpfVU3fm5sV3wI7ruSzblMjhFaMmvJRgbugJrtAH6jDHrdCUdDn9s uM4Eak8cfa/yAPy021gU4KAyY4IeD6bH1AfT3FHqEIISVgnkVhexPEANE9WOFPDzSMQU0KhbcJQ 3L6468GMEwbWyUrnNPoO6UswyGHInPyG2reNPMVL5qj7pDNJS2VuTUAnP6c X-Received: by 2002:a17:902:f652:b0:2ae:524b:93de with SMTP id d9443c01a7336-2ae6aa0f419mr40837535ad.17.1772686190452; Wed, 04 Mar 2026 20:49:50 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:50f9:a2c6:c0a6:8352]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae5229cda1sm127350025ad.23.2026.03.04.20.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 20:49:50 -0800 (PST) From: Chintan Patel To: sumit.semwal@linaro.org, neil.armstrong@linaro.org Cc: dianders@chromium.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chintan Patel Subject: [PATCH v3] drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers Date: Wed, 4 Mar 2026 20:49:21 -0800 Message-ID: <20260305044921.10942-1-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the driver to use the non-deprecated mipi_dsi_*_multi() helpers and mipi_dsi_msleep(). Switch DCS command sequences to the multi context API and accumulate errors via struct mipi_dsi_multi_context. Replace open-coded error handling with the multi helpers and convert nt36672a_send_cmds() and power sequencing accordingly. This patch is intended to functionally be a no-op, though there is one slight change. Previously a failure in regulator_bulk_disable() would have caused nt36672a_panel_unprepare() to return an error. Now it won't. No other errors in nt36672a_panel_unprepare() were propagated, so this makes things consistent. Signed-off-by: Chintan Patel Reviewed-by: Douglas Anderson --- Changes in v3: - Keep local ret variable in nt36672a_panel_power_off() to preserve error c= ode in logging. - Change mipi_dsi_msleep() back to regular msleep(60) in power-down sequenc= e to preserve behavior. - Reset dsi_ctx.accum_err before set_display_off_multi() and before power-d= own to preserve original error-tolerant shutdown behavior. Changes in v2: - Address alignment feedback from Doug. - Restore original power-down ordering. - Drop return value from nt36672a_panel_power_off(). - Consolidate error handling around dsi_ctx.accum_err. .../gpu/drm/panel/panel-novatek-nt36672a.c | 94 ++++++------------- 1 file changed, 30 insertions(+), 64 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/d= rm/panel/panel-novatek-nt36672a.c index 29e1f6aea480..7e8b5e059575 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c @@ -79,70 +79,57 @@ static inline struct nt36672a_panel *to_nt36672a_panel(= struct drm_panel *panel) return container_of(panel, struct nt36672a_panel, base); } =20 -static int nt36672a_send_cmds(struct drm_panel *panel, const struct nt3667= 2a_panel_cmd *cmds, - int num) +static void nt36672a_send_cmds(struct mipi_dsi_multi_context *dsi_ctx, + const struct nt36672a_panel_cmd *cmds, int num) { - struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel); unsigned int i; - int err; =20 for (i =3D 0; i < num; i++) { const struct nt36672a_panel_cmd *cmd =3D &cmds[i]; =20 - err =3D mipi_dsi_dcs_write(pinfo->link, cmd->data[0], cmd->data + 1, 1); - - if (err < 0) - return err; + /* cmd->data[0] is the DCS command, cmd->data[1] is the parameter */ + mipi_dsi_dcs_write_buffer_multi(dsi_ctx, cmd->data, sizeof(cmd->data)); } - - return 0; } =20 -static int nt36672a_panel_power_off(struct drm_panel *panel) +static void nt36672a_panel_power_off(struct drm_panel *panel) { struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel); - int ret =3D 0; + int ret; =20 gpiod_set_value(pinfo->reset_gpio, 1); =20 ret =3D regulator_bulk_disable(ARRAY_SIZE(pinfo->supplies), pinfo->suppli= es); if (ret) dev_err(panel->dev, "regulator_bulk_disable failed %d\n", ret); - - return ret; } =20 static int nt36672a_panel_unprepare(struct drm_panel *panel) { struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel); - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D pinfo->link }; =20 /* send off cmds */ - ret =3D nt36672a_send_cmds(panel, pinfo->desc->off_cmds, - pinfo->desc->num_off_cmds); + nt36672a_send_cmds(&dsi_ctx, pinfo->desc->off_cmds, + pinfo->desc->num_off_cmds); =20 - if (ret < 0) - dev_err(panel->dev, "failed to send DCS off cmds: %d\n", ret); - - ret =3D mipi_dsi_dcs_set_display_off(pinfo->link); - if (ret < 0) - dev_err(panel->dev, "set_display_off cmd failed ret =3D %d\n", ret); + /* Reset error to continue with display off even if send_cmds failed */ + dsi_ctx.accum_err =3D 0; + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + /* Reset error to continue power-down even if display off failed */ + dsi_ctx.accum_err =3D 0; =20 /* 120ms delay required here as per DCS spec */ msleep(120); =20 - ret =3D mipi_dsi_dcs_enter_sleep_mode(pinfo->link); - if (ret < 0) - dev_err(panel->dev, "enter_sleep cmd failed ret =3D %d\n", ret); + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); =20 /* 0x3C =3D 60ms delay */ msleep(60); =20 - ret =3D nt36672a_panel_power_off(panel); - if (ret < 0) - dev_err(panel->dev, "power_off failed ret =3D %d\n", ret); + nt36672a_panel_power_off(panel); =20 - return ret; + return 0; } =20 static int nt36672a_panel_power_on(struct nt36672a_panel *pinfo) @@ -170,52 +157,31 @@ static int nt36672a_panel_power_on(struct nt36672a_pa= nel *pinfo) static int nt36672a_panel_prepare(struct drm_panel *panel) { struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel); - int err; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D pinfo->link }; =20 - err =3D nt36672a_panel_power_on(pinfo); - if (err < 0) - goto poweroff; + dsi_ctx.accum_err =3D nt36672a_panel_power_on(pinfo); =20 /* send first part of init cmds */ - err =3D nt36672a_send_cmds(panel, pinfo->desc->on_cmds_1, - pinfo->desc->num_on_cmds_1); + nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_1, + pinfo->desc->num_on_cmds_1); =20 - if (err < 0) { - dev_err(panel->dev, "failed to send DCS Init 1st Code: %d\n", err); - goto poweroff; - } - - err =3D mipi_dsi_dcs_exit_sleep_mode(pinfo->link); - if (err < 0) { - dev_err(panel->dev, "failed to exit sleep mode: %d\n", err); - goto poweroff; - } + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); =20 /* 0x46 =3D 70 ms delay */ - msleep(70); + mipi_dsi_msleep(&dsi_ctx, 70); =20 - err =3D mipi_dsi_dcs_set_display_on(pinfo->link); - if (err < 0) { - dev_err(panel->dev, "failed to Set Display ON: %d\n", err); - goto poweroff; - } + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 /* Send rest of the init cmds */ - err =3D nt36672a_send_cmds(panel, pinfo->desc->on_cmds_2, - pinfo->desc->num_on_cmds_2); + nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_2, + pinfo->desc->num_on_cmds_2); =20 - if (err < 0) { - dev_err(panel->dev, "failed to send DCS Init 2nd Code: %d\n", err); - goto poweroff; - } + mipi_dsi_msleep(&dsi_ctx, 120); =20 - msleep(120); + if (dsi_ctx.accum_err < 0) + gpiod_set_value(pinfo->reset_gpio, 0); =20 - return 0; - -poweroff: - gpiod_set_value(pinfo->reset_gpio, 0); - return err; + return dsi_ctx.accum_err; } =20 static int nt36672a_panel_get_modes(struct drm_panel *panel, --=20 2.43.0