From nobody Thu Apr 9 23:23:25 2026 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010011.outbound.protection.outlook.com [52.101.46.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 576A3286A4; Thu, 5 Mar 2026 04:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772685030; cv=fail; b=on/w62h/npeupTTCbZrPJZTRYxT0haFbzUa3Zuu3tQnza3naSEvnhgBZJcWdVlJCSb5rqSomgGILtvAxh/Xjc4KCEocq8H24W37ee+J9TIg3yvza29SkRR6z5bWx1a97yK4s/rt3YESjrhjPftZSuw6kLqDn99TJLZSNSZh/Pa8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772685030; c=relaxed/simple; bh=lT+X3UVW2RqpTH77hECsplmkCQYa13nyTRO0QmTzKJc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qxeiGhzgFH6b18/RUFgIqp4D3d+rwhENeKreUELI6YSovqmqhP7wnoQoOrifnGrDEi+p/vyciS5Ei7e1wR5ZAgiZO0E1839P8uFjapjgyNlP2BebpzISUsW8rl1oHxzQ9SN8A6trhdwXL0ZDM1J0Ld3u4m0nWfqbj3lIML0GkUc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Ck3U6Wnu; arc=fail smtp.client-ip=52.101.46.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Ck3U6Wnu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=s2DH44upLDM8Qg2aTpO7ji7PbnDa9NH5xiHuyAMDW6YaSRBHYV8cGN/f8LLP6lucNMCOaT75nzyB4c/kxOMHJe3ZfspfH5oyxsBrhz3UqY8W+4sgFlUNT0no/z8k1YsTu3OqAn8M5RNjJsFn7S5TLuGPWLO9zrotoD6uew6wdT4JQ/oyGVREMwnvB3Fz6xSV1NyROmM2ZjYH6mQalHimew5rMumpFWp3+qVhVq/7ykQeD+9Rg78yJ6sU7Pj9anKj4f4N3zxoHnXLqvbqm7dS1ZNUVJAindZ/tUFsjQCWL8J75zE/us9S9wRCVTH5KiWLbuY+/cyZJYvj0ngvVsuy+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0WhJ/DlysRMRlAqQ8KTfrnZOh4bC/H/L9iys24i4DgQ=; b=IxvAQ1BVlr9r1A/uTOiXirW7O90OqIm5vOG8wzwIDN0wREfqO+OFkECMYsHCWJRWWW0m98UzcPx45u1iXzguqSvZdIeGjUHF4KqutI/pTgNtGBVxp3GPCW3ThAhs37I4/ROn1RjYsfUzqT5w7nqgHg6oIaEFsaUyjo5kPs3wDHlTkHDscWZdjfQRqJmZoiSJ5DNg5BfdWkYem2JoF4te03LrBPzVW6vSdGWLO1qktueJAk1CWAp3XwfQvL2n0rnpL7C03g9RdjsZ2h5eQB8eTdtvx0s7K1sOFHPAtvtOn05lkA++2IRSXrlZjKjU3+IBJhI4AO7tHdUNYEUwiY6RxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0WhJ/DlysRMRlAqQ8KTfrnZOh4bC/H/L9iys24i4DgQ=; b=Ck3U6Wnu+/Gihp6Ysyzo1uKbBJJ4uMzFkZ9wcvbFw31oIdq2HG8w+Ay0FCNrIT6qpY24jSaCqGVQhEi5LJlS2dE08K6vSNSozFYcyg0HAmUWyAnKqbo5A1CmqQDI3ttXipLPOvKYqAJCYbr1CAawBe7bNWs2SyUhY7q4g/osdSc= Received: from MN0P220CA0022.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:52e::12) by LV5PR12MB9826.namprd12.prod.outlook.com (2603:10b6:408:2fe::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.17; Thu, 5 Mar 2026 04:30:26 +0000 Received: from BL02EPF00021F6F.namprd02.prod.outlook.com (2603:10b6:208:52e:cafe::a7) by MN0P220CA0022.outlook.office365.com (2603:10b6:208:52e::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.23 via Frontend Transport; Thu, 5 Mar 2026 04:30:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF00021F6F.mail.protection.outlook.com (10.167.249.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.18 via Frontend Transport; Thu, 5 Mar 2026 04:30:26 +0000 Received: from airavat.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 4 Mar 2026 22:30:23 -0600 From: Raju Rangoju To: CC: , , , , , , , , Raju Rangoju Subject: [PATCH v2 net 1/3] amd-xgbe: fix link status handling in xgbe_rx_adaptation Date: Thu, 5 Mar 2026 09:59:50 +0530 Message-ID: <20260305042952.835926-2-Raju.Rangoju@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260305042952.835926-1-Raju.Rangoju@amd.com> References: <20260305042952.835926-1-Raju.Rangoju@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6F:EE_|LV5PR12MB9826:EE_ X-MS-Office365-Filtering-Correlation-Id: 9941626b-52e9-44b9-c4ef-08de7a6fecff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700016; X-Microsoft-Antispam-Message-Info: 4RisALPQI+39VVro/3j2Dy07Zxd+Af5psSjAehsm5e4faS67rzeRn3Vvn6dBfp+3tR0wJuORuHsXUHcHRV+bupMK32Kf/jVt1+8Ew5wryaoRI4gFHMDb2DXqXV+hJhXEfoBaM3+7qRyE2U0OUqIWUnGnhTGGFbpCwUgGXNNcxZgc8RUvqT3b9jZ5Atm9CoTXdt4ZSgbARZeZl8hUdOeSF0pIbtZPc1aQZHhDSv4r2xWkyczMyno+oKMgqw7zi111rrcIG+3wYMRBe0zrK9NeKu7lxvu7mM1nR9AGu9AerwC/FyDI30byoFijSSG3yLhRc0RVfSN0nnga8zY1jf8pRo9f071DvYHTyZlnDC1OMIhnt8wPn8B+GnU3CzGIs/hGGMqpyVEyblpWXhkn3hPtYu9kov6KNpWov2NdVRXY8CWI7TwGkV+6xoj1aF/eDEAewWgfPQSKLBvpGWC2hG01ldGpwOATe7p+ETxRLmjVhBzoyPkPHQxFHtv2REh49eP03lkrEz3yqWgyKpORzR2P1X5islwqpilLmpmLBK3Fx4z0Ha+qgKnkk+tHCmG4XD4SGndeq3l6YcxywMmDkwK7R8Xt/inSMbE8XIkJnZvY8C2iiQrDYHtkftkmBjkA6Lisx6TFCNCHHzUl95kDurlGOAlUskrNfNJ2i+1iirmW0RRhlbKQ2gVJlq8Ay5ghKblyYn+j2Z3NjoV9wDPLhGN/B9TT/jEbFuHC1J2g0L/lG+YZcUYKgoXMK2PfBe6Tkz+7LLmnrxdYlpfE0ElzVyUQlA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 99hJ/hIxKo3QR06K4Motk19mhSQVttWV3N+cWtt3F2OAgTz1FYsCeBFn+mjiCMZ8KNiZXhm6ILHiwdMfwn2cz8oyzeTxMsmNz/Ig41blOG/DC6gKGXtMkB0oDmc3FFQblM20Kp2WP0tso18m7oDpb1oyl7Csau71QliWnCDaCHrf8zAvJ65kCYxrWGg/Jhn8CqKADJskf94IZP9imLi/nG/cW5Xbij6DQk033/bKrLU8iLqjN1o7ykWkqcG8WOlbzeqbbgGzhBNbyuIz5ipzieBDx7RTww0NXghrEoK3694+aOkPAX/qDtcL3oEGPPyg4D3CnyDg+3gKSZJ1ZPfvtoePaBvZmhBsoNqkVGEzq+Kz+LHFbR4Lwtp7d7dfts8ePvpxGyb1H6373HApDqdCjgkDiv1yK9QifoChJpjPMZX2EFZjdocese5nKdpyZ4JL X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2026 04:30:26.8463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9941626b-52e9-44b9-c4ef-08de7a6fecff X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV5PR12MB9826 Content-Type: text/plain; charset="utf-8" The link status bit is latched low to allow detection of momentary link drops. If the status indicates that the link is already down, read it again to obtain the current state. Fixes: 16ceda2ef683 ("amd-xgbe: do not double read link status") Signed-off-by: Raju Rangoju --- drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethe= rnet/amd/xgbe/xgbe-phy-v2.c index 1dbfa9d4360d..457d6049291f 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c @@ -1964,11 +1964,20 @@ static void xgbe_rx_adaptation(struct xgbe_prv_data= *pdata) =20 /* Step 4: Check for Block lock */ =20 - /* Link status is latched low, so read once to clear - * and then read again to get current state - */ - reg =3D XMDIO_READ(pdata, MDIO_MMD_PCS, MDIO_STAT1); reg =3D XMDIO_READ(pdata, MDIO_MMD_PCS, MDIO_STAT1); + if (reg < 0) + goto set_mode; + + /* Link status is latched low so that momentary link drops + * can be detected. If link was already down read again + * to get the latest state. + */ + if (!pdata->phy.link && !(reg & MDIO_STAT1_LSTATUS)) { + reg =3D XMDIO_READ(pdata, MDIO_MMD_PCS, MDIO_STAT1); + if (reg < 0) + goto set_mode; + } + if (reg & MDIO_STAT1_LSTATUS) { /* If the block lock is found, update the helpers * and declare the link up --=20 2.34.1 From nobody Thu Apr 9 23:23:25 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010007.outbound.protection.outlook.com [40.93.198.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C339F4204E; Thu, 5 Mar 2026 04:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.7 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772685042; cv=fail; b=EmRQmBQhLgN+eqMGjfAEp4CXZCwzxhAbIfk1bYA22ZszoQtpEJMb8G+bkc0Jcz9g4tj3iMXfO2R/g9ZvlvKNcCujeqLDMwh/4pwnZVxBNmdd7OM8jLN3ZBiJ+E9pILWDPZt6jMVIs9doVQ4WzI5IFJti3jAD6KW5BKdbgVlJQRg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772685042; c=relaxed/simple; bh=xfGF7REHJv4xruYlX16/MirQ27yaI0+3sfhG4TrHkUc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WUkNvAo2nRBIXG7oYHqAeVXflouiMoDHE/LQkjO4TOvvvEDgJCyfBzcUdcx+C7IzKyB8b2GSlNryoMhmY1DOeh3f0wckwojbA6T6IxoCJjLkvRX9AMnaDGirzVr0a9kb3II2FA74irHI8zesc0nBz3y0GL4VlVKMQK1bsprIkhw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=iLkCRess; arc=fail smtp.client-ip=40.93.198.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="iLkCRess" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rBID3BGVk4VupnPxMHeQtOdTvgu1otos3BBYz/kMvRiCQwj7d/CBKB/nd1jQMq8jtWW3Psq6KTE1iDs9naqg6bZ0lfIzPfgeeG99nv7PXjad8AIpuHgbpjN+BMylQJVU6qprxPDPKCiMAbeuulIdGPXVCL1f5389cfWF7WEaipA1tmfo5Q7VeDFpz+1K/iL/xSfJYmPFGlx5CEEAe466iHgkGJsT1mzztI8UqtKHaugmP0Get10luFhvPgZCKz9e/4Yu+l3uBYtphxCezI+dH2ODJeML76/gVYGdYtuxJFo2q1sfM6n2B9xuIVi1wlYGT2HEORxI04PYEOhk2IXSGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9rzKqtx61jFvZl04VWR7Ek/6LmXAcZhbyvzd2dIpHGY=; b=jH+UauYaVzKSgGikRXdZJ/5PWmJc92+AzE+Qf7dZd2ANappoZnbfMk25hp9kHZmZXod754fG/6DMJBlLrv7RpRhMtrV+I0+Z+g+u5s6y/XV0wA9NbJA7RgDO2+JY5ZugkECYqk2Hz+PT+ieHKIKuYv8tXoUhpC2AKYES1F469qCDeOfAd3ms+rhMXbZ7Ku3RDLU69jeNuI/L+KTt+Ft4XLf8Uqhc8c4BxePvoGggoFNbON7zKRdQT3cLlxZp0WOK86Ptvc9WxS0R7e58/bahLOyPPpHpwZLOoIdqGSBvgaNX8C1ER0LFQfqRc4zeC+61OZwQDyfN+BtP2TXiBEoV3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9rzKqtx61jFvZl04VWR7Ek/6LmXAcZhbyvzd2dIpHGY=; b=iLkCRessWGlgmXO9qkbIcVmxsrvJWbbVgbSKuLp1kHGEXmBsPQRo1zllDmjx1V8I+EgbCsUgcKMcA+6bHYXZJlo0Qu6ZAjs9HVl9pIAfzgU3dJahg5sh6qJ0pGdtzv5z5oi5v0TsmjrY4/sNkV+3m9YCu+y0cR7MoBIlrxJZUb8= Received: from MN2PR15CA0063.namprd15.prod.outlook.com (2603:10b6:208:237::32) by DS7PR12MB5789.namprd12.prod.outlook.com (2603:10b6:8:74::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Thu, 5 Mar 2026 04:30:37 +0000 Received: from BL02EPF00021F6E.namprd02.prod.outlook.com (2603:10b6:208:237:cafe::84) by MN2PR15CA0063.outlook.office365.com (2603:10b6:208:237::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.23 via Frontend Transport; Thu, 5 Mar 2026 04:30:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF00021F6E.mail.protection.outlook.com (10.167.249.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.18 via Frontend Transport; Thu, 5 Mar 2026 04:30:36 +0000 Received: from airavat.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 4 Mar 2026 22:30:33 -0600 From: Raju Rangoju To: CC: , , , , , , , , Raju Rangoju Subject: [PATCH v2 net 2/3] amd-xgbe: prevent CRC errors during RX adaptation with AN disabled Date: Thu, 5 Mar 2026 09:59:51 +0530 Message-ID: <20260305042952.835926-3-Raju.Rangoju@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260305042952.835926-1-Raju.Rangoju@amd.com> References: <20260305042952.835926-1-Raju.Rangoju@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6E:EE_|DS7PR12MB5789:EE_ X-MS-Office365-Filtering-Correlation-Id: cf1f5bec-9585-47ce-4f0e-08de7a6ff2ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700016|82310400026|376014; X-Microsoft-Antispam-Message-Info: tIiC4JMIKoQUc+prJnrUiAg4NPsHp+QRlM+PzFKJaoZIIcOj2rzuJHdDzwmaiYx6AGebVvsalo9f0cyVsdJdXR1my7rmmov+Gu2MTXLFDRMWwAUCa8mx5dMZ4QuAWbESxscuSv9x9SmfmU8tZnpRuFsooXPtsaekRkjAsIxGX//yz1xrGn8jwpNJJxBsfmY2loR6Ak6+Fr2YNolEGJQASNXW3ZRn3u1og3vM07+ljzQKUWY5AWCYs011q0PeRtnlgEoVxDC0KvXCq683eqpZmDNQ/dIHWiEhJ+DqtmGXU5VAhz2tjaR68Z8RYaKarh9izzodfoMAHUEyhKeEDqf6h4abWzLBKygGaMymz+gpByXe2kuETBrcMVjlEzH7eGyTd6lphK+tqXGeEuGq+sFFnYf5Ysgqrl2aR4pTeYQz70ONkpOocCEhBUJ9+r1BR6jJWt8DSS7G6/HbOKn2yJGVvkm5wPPGrR7hwHTwT624ykI8jKVMh++GIiLc9Mi5k7AzylFOPFM/PdimFZIA6kDUpsxm66dJwKdUA26yv8vwWdGF1xV0CYV6PZX1mkfh+tchnbgwBbLNOlqCNau1mZ+sIkE4lbcUJvfhFPwn/h6aCKZz+Z59AWq57oELUgZsWr8xeo7tCycmDsu7r4HYN5rwqfN8M2QM4ebEEzlNmPHc/r7eD3AE5d5HF3oYfC04NbKST6dGYfjAcJcjSJvN4P2FhZieCuUg4y/rbxFCHnXRa0nFYzEIBHrtywJZahNBJ2vh1f6Oze/YsGwUl7mFAMDgJw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(36860700016)(82310400026)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RheYWDvuTO68ww4/o/cc41KlUg9auZZ/2e4csQ4cwatkMArveTYuWYnjGZG8vRb7EDBwSSKztVhuvXXGtLnfNAdnGnSqJ3lhns/PjP2VUnWhRvhYvYnfsG9nYQ/INk0oDawdPi8JVic3Oll/zQIFH99teiVuLugIph4EcKy/832NyIWxKR8cEI+KKiT776oI01TlYehOJ2P+RpMqz5GojQ9c6nvZlD8DvpFo4dbd66ok0x3XAL6HE3gcVeSf2ERolOovqz3Th47FLNgJGLa5eZfEL0nUMfPoJSBrtP+mOLBxYdVg6wwgjU6fGfBNRwuSsv1g+K8HkHdHm5HuvU0tc6uNRijzuN/5Arnjr1WfusUBE0ep2+h+PrCrmyVnv0FkYCjofiMPSDuUycpBW94zP7qwebDHaFiGwl73w80gtdp7eGfeyW1uSkCgP+gmz8LO X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2026 04:30:36.8482 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf1f5bec-9585-47ce-4f0e-08de7a6ff2ef X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5789 Content-Type: text/plain; charset="utf-8" When operating in 10GBASE-KR mode with auto-negotiation disabled and RX adaptation enabled, CRC errors can occur during the RX adaptation process. This happens because the driver continues transmitting and receiving packets while adaptation is in progress. Fix this by stopping TX/RX immediately when the link goes down and RX adaptation needs to be re-triggered, and only re-enabling TX/RX after adaptation completes and the link is confirmed up. Introduce a flag to track whether TX/RX was disabled for adaptation so it can be restored correctly. This prevents packets from being transmitted or received during the RX adaptation window and avoids CRC errors from corrupted frames. Fixes: 4f3b20bfbb75 ("amd-xgbe: add support for rx-adaptation") Signed-off-by: Raju Rangoju --- Changes since v1: - Change the rx_adapt_data_path_stopped flag to boolean type as it is only used as a true/false indicator. drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 61 ++++++++++++++++++++- drivers/net/ethernet/amd/xgbe/xgbe.h | 4 ++ 2 files changed, 64 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c b/drivers/net/ethe= rnet/amd/xgbe/xgbe-phy-v2.c index 457d6049291f..880949051c3c 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c @@ -2017,6 +2017,50 @@ static void xgbe_phy_rx_adaptation(struct xgbe_prv_d= ata *pdata) xgbe_rx_adaptation(pdata); } =20 +/* + * xgbe_phy_stop_data_path - Stop TX/RX to prevent packet corruption + * @pdata: driver private data + * + * This function stops the data path (TX and RX) to prevent packet + * corruption during critical PHY operations like RX adaptation. + * Must be called before initiating RX adaptation when link goes down. + */ +static void xgbe_phy_stop_data_path(struct xgbe_prv_data *pdata) +{ + if (pdata->rx_adapt_data_path_stopped) + return; + + netif_dbg(pdata, link, pdata->netdev, + "stopping data path for RX adaptation\n"); + + /* Stop TX/RX to prevent packet corruption during RX adaptation */ + pdata->hw_if.disable_tx(pdata); + pdata->hw_if.disable_rx(pdata); + + pdata->rx_adapt_data_path_stopped =3D true; +} + +/* + * xgbe_phy_start_data_path - Re-enable TX/RX after RX adaptation + * @pdata: driver private data + * + * This function re-enables the data path (TX and RX) after RX adaptation + * has completed successfully. Only called when link is confirmed up. + */ +static void xgbe_phy_start_data_path(struct xgbe_prv_data *pdata) +{ + if (!pdata->rx_adapt_data_path_stopped) + return; + + netif_dbg(pdata, link, pdata->netdev, + "restarting data path after RX adaptation\n"); + + pdata->hw_if.enable_rx(pdata); + pdata->hw_if.enable_tx(pdata); + + pdata->rx_adapt_data_path_stopped =3D false; +} + static void xgbe_phy_rx_reset(struct xgbe_prv_data *pdata) { int reg; @@ -2826,6 +2870,10 @@ static int xgbe_phy_link_status(struct xgbe_prv_data= *pdata, int *an_restart) if (pdata->en_rx_adap) { /* if the link is available and adaptation is done, * declare link up + * + * Note: When link is up and adaptation is done, we can + * safely re-enable the data path if it was stopped + * for adaptation. */ if ((reg & MDIO_STAT1_LSTATUS) && pdata->rx_adapt_done) return 1; @@ -2833,6 +2881,14 @@ static int xgbe_phy_link_status(struct xgbe_prv_data= *pdata, int *an_restart) * retrigger the adaptation logic. (if the mode is not set, * then issue mailbox command first) */ + + /* CRITICAL: Stop data path BEFORE triggering RX adaptation + * to prevent CRC errors from packets corrupted during + * the adaptation process. This is especially important + * when AN is OFF in 10G KR mode. + */ + xgbe_phy_stop_data_path(pdata); + if (pdata->mode_set) { xgbe_phy_rx_adaptation(pdata); } else { @@ -2840,8 +2896,11 @@ static int xgbe_phy_link_status(struct xgbe_prv_data= *pdata, int *an_restart) xgbe_phy_set_mode(pdata, phy_data->cur_mode); } =20 - if (pdata->rx_adapt_done) + if (pdata->rx_adapt_done) { + /* Adaptation complete, safe to re-enable data path */ + xgbe_phy_start_data_path(pdata); return 1; + } } else if (reg & MDIO_STAT1_LSTATUS) return 1; =20 diff --git a/drivers/net/ethernet/amd/xgbe/xgbe.h b/drivers/net/ethernet/am= d/xgbe/xgbe.h index 4333d269ee84..450ebce94347 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe.h +++ b/drivers/net/ethernet/amd/xgbe/xgbe.h @@ -1266,6 +1266,10 @@ struct xgbe_prv_data { bool en_rx_adap; int rx_adapt_retries; bool rx_adapt_done; + /* Flag to track if data path (TX/RX) was stopped for RX adaptation. + * This prevents packet corruption during the adaptation window. + */ + bool rx_adapt_data_path_stopped; bool mode_set; bool sph; }; --=20 2.34.1 From nobody Thu Apr 9 23:23:25 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010001.outbound.protection.outlook.com [40.93.198.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73F3B21CA03; Thu, 5 Mar 2026 04:30:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772685052; cv=fail; b=bmPWLFQ31fiNZfw19INd/s6W6loBDnH4hE9sbyebGPAH1dzKJB4Tcl+VGchbX/URwQBH72Y0MMczmEVUXcbkNfWmHfFbUgrpq3jqRmpNBg2bEeQUiE9vp4a/3LznJ2BJDDvsoL0VX9MT9yzhiC8MA0D4zDxHM6Ihq2ocE26jKy0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772685052; c=relaxed/simple; bh=MDoh9XorZwXNQ9Z8MdYsn+6HL8ATvFbUSWeJRhub+Bk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZykJlXYmPOzJ0YwazqZEwDDxAIAqPT6gJD2HioQ8zUScIAAbeKPtOZAirzqQX3q8aozN7MR0pT9YffAkttXTnUd653+jFz7viCZDgQchUJ0rAEQfkyBfK6q9kQBSi/6Csf6cYZU7tC7AyPbaJvHPo78UNm77OkBLxVBgGCPcGXU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=i1C+Auk2; arc=fail smtp.client-ip=40.93.198.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="i1C+Auk2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=d7Ws42tC1Y3S/Bn+wnryXI+sSE9DI6LFoJda+UvoZUhjz1nitOj/ONWiotUSWGGNrxC6S4tqFyvG0BqwpiiFFGZeNfzaAV3DDejdQadxmLf7HSxPYx1eL/W9aeKF7DuF+SwsLtp83HOwCuaxayfdeo6Bdu58LPAGM2pvXuu62Ivcr+OCOTKiEeifI7Q97TCF8xrrLBwFYiTtXJi5RfckWeaYxoBzfM2nM0Oa6jnPCUp2fXr16w457Zy01vjMfJWsreWSF/n5K70OyBHh83aYgUNJMZ1kjiwpRFkzfqpCFiRaViDDVzabSEFCKTNQYE1x/Q0y7vvqNEeu+kUVR1nWWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RgiOldHZF8acyCanz7c4xusYDK52DN3aidndYtKD70I=; b=eaQyGIJR+PmdfpkyOmlsltiZuLwYqCm6L41ZJWIRXdG4ba4g9u1BvEmObz4CDHmFFjxvQ7xNtS6/HGxpKAqGToY2mTjD3d2JIZbgAQLOG6V9h69GYfkzX2uxxD8GynruTYBvNw5SZxO+oNvyzzqIs6hD8clZh6zGzAaaMYz3Arfw0PPYJ6V7TN74uHraMQDwaDgp/GEaN5gmd0XVd+bnG5WrmcSjj3pgwryv8OB4/xXT9A20nEIaQQnLseV2Ksi8YiSi+6KA9zORvX1pU5q/fRLuanZymB3Nf4d60teOzZ6HwKBjj28Rw2m2KfBJm9G9PBI6bV62hUPDJ+P7UWF00Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RgiOldHZF8acyCanz7c4xusYDK52DN3aidndYtKD70I=; b=i1C+Auk2nJ8zqCzkEZkR4gKKhweQFtbRqIK+MfFXWS7oDzj27DDJO4Z8ubHbehnnRhDd7+vlvV9M2ahVn/xcwMYmrFRz6C4zSNjloGFS6YFurh2438i013CCCvSbqq2TISDTDECYAofer1Fdsnvoce/ZdXIXNKEX2fpm0ZB803E= Received: from MN2PR15CA0058.namprd15.prod.outlook.com (2603:10b6:208:237::27) by PH0PR12MB5632.namprd12.prod.outlook.com (2603:10b6:510:14c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.17; Thu, 5 Mar 2026 04:30:48 +0000 Received: from BL02EPF00021F6E.namprd02.prod.outlook.com (2603:10b6:208:237:cafe::3) by MN2PR15CA0058.outlook.office365.com (2603:10b6:208:237::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9654.23 via Frontend Transport; Thu, 5 Mar 2026 04:30:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BL02EPF00021F6E.mail.protection.outlook.com (10.167.249.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.18 via Frontend Transport; Thu, 5 Mar 2026 04:30:47 +0000 Received: from airavat.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 4 Mar 2026 22:30:44 -0600 From: Raju Rangoju To: CC: , , , , , , , , Raju Rangoju , Maxime Chevallier Subject: [PATCH v2 net 3/3] amd-xgbe: reset PHY settings before starting PHY Date: Thu, 5 Mar 2026 09:59:52 +0530 Message-ID: <20260305042952.835926-4-Raju.Rangoju@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260305042952.835926-1-Raju.Rangoju@amd.com> References: <20260305042952.835926-1-Raju.Rangoju@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6E:EE_|PH0PR12MB5632:EE_ X-MS-Office365-Filtering-Correlation-Id: d28fcdff-d5c1-4a0f-e845-08de7a6ff97b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700016|82310400026; X-Microsoft-Antispam-Message-Info: nzjfIfFtbKf6DYnDyjCOA3Y8eYNaMeoYOsDNh9pVnn6M6mQ5HGp7zkc8N+eLEVf6D0HKeQUbQRziCOtDs+7xG2FfVJVZrbXuYRdNYmBObbrNzwi99B8zwrj9wnh09ycGo88wqU90WkYEfe87WOvpl4OPuQCOn3Zc/qBDRucv5sT4LkycYWREtkfPHVIZmdglapuckVdfjBBrqpS3Xj7YXF5+ayoEm39OoEBc41Z52Y0izgdk4csYTow2QlLElIXYMuKmb5xXfM7lEcH2YSrrEQpPqAjTuTV9UYunCiuCqNkYZIORjHq5gnPsvQFekmn9yMsSRISrWNcTWV/iJIIXOnzjcvOAT3CjWLU3DFRleECr1TBkrm52/f0nq3B6EgHlDpFgQvgHz98epHx26HDatpOShmhJwF6lS3fj/5Q+7NjRulDswVs/u2dfXYliCVilQ4I12RrDeCZ67wTkSqkwtldS5euMWZBidYI8DiG7ZjhzEVvW4hpnNjC6Cf4ntMk6xv1WgF63R44pIZKd/1j3bgAS06pOInmvmFyRmsr0Hu1IB1wXOQ8LbqIkstyiS17A6hNEqZvSJuUGgJNAyNC9QCEKXKNMIXRx2SrDMySgyhLNGRXtb/lck6jGKFYWVj2RzJR5gGbo+axR+7DAoD8ghkgr4gdEQqPlKZWtcCmLGlYc7xZ02c0346ZDAylhu+hv/ObcvMq/9CPoyqpI/9Uql2LhQsDO7MLbu8A+rbK7aPcfofVU4HnPkzgslI43Wzjq32xS+TUFSvPaWEVFTKzsnw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700016)(82310400026);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 9e8C7DsatOporEYQQSSH46UySeu3mMS9XwnGI874Y/oMTTwbNK3ELpAjkYn1kzZf8NSd0wUTg5d4Mgv6E9UedbZpSMestKAmer6P6Mv650xLjJgylm49PJN+B0YQLaOW7yz++2v+airBQUIxnoT+utZCf6rraU441HrKRvAEg4qxfOdKjW/B2rvgeufdR0kswA7iWvLk4DXxlk+wwoxDiCyBy27JPLrGLu0qvtbRlrqAlqJcHJfskxRMQfc7NOCcPNaWlcvqAD0M1Ng1myQyYxfXeX4FvCxeIyydi6aIr1XChe75xSg1xRf2RZ0pzj05h5P4QnZDwN6H67FdSkbp+l89aU29mwqPEgOnEy/UZ+1fycrAwsiYfRyUHqbZgBEuyXE2tf/ppTPfZx714fsmx1YEAMNiV7VVcBSyhJBnyYx5W7h28vR/OQAje5VijhDB X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2026 04:30:47.8359 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d28fcdff-d5c1-4a0f-e845-08de7a6ff97b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5632 Content-Type: text/plain; charset="utf-8" commit f93505f35745 ("amd-xgbe: let the MAC manage PHY PM") moved xgbe_phy_reset() from xgbe_open() to xgbe_start(), placing it after phy_start(). As a result, the PHY settings were being reset after the PHY had already started. Reorder the calls so that the PHY settings are reset before phy_start() is invoked. Fixes: f93505f35745 ("amd-xgbe: let the MAC manage PHY PM") Reviewed-by: Maxime Chevallier Signed-off-by: Raju Rangoju --- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/etherne= t/amd/xgbe/xgbe-drv.c index 8b79d88480db..fd4f451efcb2 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c @@ -1271,6 +1271,12 @@ static int xgbe_start(struct xgbe_prv_data *pdata) if (ret) goto err_napi; =20 + /* Reset the phy settings */ + ret =3D xgbe_phy_reset(pdata); + if (ret) + goto err_irqs; + + /* Start the phy */ ret =3D phy_if->phy_start(pdata); if (ret) goto err_irqs; @@ -1280,11 +1286,6 @@ static int xgbe_start(struct xgbe_prv_data *pdata) =20 udp_tunnel_nic_reset_ntf(netdev); =20 - /* Reset the phy settings */ - ret =3D xgbe_phy_reset(pdata); - if (ret) - goto err_txrx; - netif_tx_start_all_queues(netdev); =20 xgbe_start_timers(pdata); @@ -1294,10 +1295,6 @@ static int xgbe_start(struct xgbe_prv_data *pdata) =20 return 0; =20 -err_txrx: - hw_if->disable_rx(pdata); - hw_if->disable_tx(pdata); - err_irqs: xgbe_free_irqs(pdata); =20 --=20 2.34.1