From nobody Thu Apr 9 23:23:14 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32468256C9E for ; Thu, 5 Mar 2026 02:02:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772676143; cv=none; b=HM719Mr6NXD0IyAtIYq4VXjhiNW3Lkkh4Ae4Nu7CJ/WNElOBsHET8zPVceaG3KKI6Yy3IAgG6oon0bgGaIDzA08wPLl/pv1kprHJyMxzMB2OJxUhIhN4ZWwnw9tJ8uAI8DChAHr4w7AuC5aB9csRaKYfxv/96qtBWe30W/ahat4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772676143; c=relaxed/simple; bh=Ut0LBaIFCr8anvsWjCXs10JI7D3ERgIc+nt7nfIPcrc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Fi5l3RyfqB8SNHnxx5XSUPqMFJDbkxEQvmCCXjH7Os6iCqEUs35NLDdxiPgShkJhzlzJszCEOQ60tT/+kyE4GdKsJIGwtWN7hrBBp3UkqhySf1J9q+GUV+pTKJpWIXXrQsSAEKCk4Xre+OsE0VUXgXC+u+aa0fmrXdXaU7XsYJI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hi1XVzdF; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hi1XVzdF" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so86139025ad.2 for ; Wed, 04 Mar 2026 18:02:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772676141; x=1773280941; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+Bg0btbUeSqqnqqf25rmDsoXzFMKsOrLyRA2/2SfChA=; b=Hi1XVzdFCGqFT4TFj+fPyLMDSc8KnwsOP5IlmHR8FCGrvC6vYOcEfoXY46NJbVU5el TXV7635JQ272f4ChcfqqJMCban8p/o7CPH/05JQIVqldZ1YJfHZUl2X6FplmdIpsKBHA tzoRrzlBYN8ECsNhOfHq+xhgylxGvDdUzILL/5vRsYT9Cp6ay7qXWleYaUXjG6bIb0Pd B7OO9BE28xqlLZysJ2U4ewig5hr9bEmEp6T+NLb1dYUeE+DPaRg2rtFwNn6B23GFzwwJ lPLLIkccUcm+WsGjY8EXFiqBBgV+4r/iA8szW2th1K+4jr/1DxWXCQooS6XkEYC0CZ6+ /ZKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772676141; x=1773280941; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+Bg0btbUeSqqnqqf25rmDsoXzFMKsOrLyRA2/2SfChA=; b=nTpgtdODsjy17i0a1HZA7NjShuW1W2KpY5zUG4MTsHaupW3ej3KqzKnd+p69u356Gv KfLT5/PZ60DrpGzeCue8EZBiXvjssy4G4v96JyyFKXcVELSHi2rKxzyL+cj65a4svHXi JAFG4MWg1FogTpNKRYgdv84i4U3Lc8SaSpUAan+UKHb6frVG/aZAqnv8KrgRPx/YNrsv 6YLLn2WFDy7DtRt/wxd40yyWcIxG8jUQoKj1P/fV5WY9qSEpW1pxr2QFqUbsYmxpWJtj TrK6B8WqJpaTT3irKIN4GKgXRmO1SziMruLwToU3BGlluq8qSiQzcS6VLEmxbC+d117e comA== X-Forwarded-Encrypted: i=1; AJvYcCWCZcG0kU0mMUW/0TPrZ9n9ZRZx7NoSAGaLo14Nk6jNBQR1EWaO9rkgeivoNpexM3rukcRzI4yZlPVNy9E=@vger.kernel.org X-Gm-Message-State: AOJu0Yytvy96rUJQXTtLG/azhsFhp6WTdtPEIejVN/zQlKSVXCH6YJhb d3S08LwfWrSJxBqlWa5so+dXHITiFSEdGNmLiK4ysjDRidHadHHR5l6j X-Gm-Gg: ATEYQzyiHsvjvxLCeVSlZEeZ9jcvencTuemCD6StfrvJIJSWmq+Gwp3ZT52IrcwaaRR 12uG3MManXdi1fvj+3cDmTGJjFDK22AhQkcbisPgaakpNk9l3DqfZBm4LKhaH1vU5rklnELlEJa Ld3LSWC3YMx49qgyWDpEqQsSo7oyqWuka09rroY+h+I6Z7fAfgUCqr1j2IKAl4vwQBPy6HgF++3 INyBSTBJ8mLHkDMaoXJFnpSM5Us5DZhCUMF8RVhltXs+YuodRe5JU4+iZUe8J0+fpZu2vS0VY/i vl3qiniQxmkjz6wXMvyP4YZ3QGNbWA18NFdSekK8FKZR+5MwtqcQXe67FcnZW+LkhENlrEW4Ewp CvI2HR5/cQ3gmW4GDjLuEm0tsqVOPtBJREwXzM8dKEg1UUJV8An60SLqK61Yt1ORpDQdnbkoM2c 4L7CfhR/JjZXQY+dklb0wChHx1HBrS/62TwYQDAkvK6tdt3LlyZFdBSWBWuIc52Zkc5II5W5ws0 lMz90cgwUKjxakv X-Received: by 2002:a17:902:d50b:b0:2ae:517a:6c28 with SMTP id d9443c01a7336-2ae6aaf14e7mr46171315ad.29.1772676141422; Wed, 04 Mar 2026 18:02:21 -0800 (PST) Received: from tower (c-73-37-64-97.hsd1.or.comcast.net. [73.37.64.97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb6f3436sm294587165ad.88.2026.03.04.18.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 18:02:20 -0800 (PST) From: Mark Adamenko To: linux-staging@lists.linux.dev Cc: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Mark Adamenko Subject: [PATCH] staging: most: dim2: replace BUG_ON() with error handling Date: Wed, 4 Mar 2026 18:01:48 -0800 Message-ID: <20260305020148.59842-1-marusik.adamenko@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace BUG_ON() calls with error handling to avoid unnecessary kernel crashes. Signed-off-by: Mark Adamenko --- drivers/staging/most/dim2/dim2.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 8d649d920433..cec9d19e1cde 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -168,8 +168,10 @@ static int try_start_dim_transfer(struct hdm_channel *= hdm_ch) unsigned long flags; struct dim_ch_state st; =20 - BUG_ON(!hdm_ch); - BUG_ON(!hdm_ch->is_initialized); + if (!hdm_ch) + return -EINVAL; + if (!hdm_ch->is_initialized) + return -EINVAL; =20 spin_lock_irqsave(&dim_lock, flags); if (list_empty(head)) { @@ -190,7 +192,11 @@ static int try_start_dim_transfer(struct hdm_channel *= hdm_ch) return -EAGAIN; } =20 - BUG_ON(mbo->bus_address =3D=3D 0); + if (mbo->bus_address =3D=3D 0) { + spin_unlock_irqrestore(&dim_lock, flags); + return -EINVAL; + } + if (!dim_enqueue_buffer(&hdm_ch->ch, mbo->bus_address, buf_size)) { list_del(head->next); spin_unlock_irqrestore(&dim_lock, flags); @@ -271,8 +277,8 @@ static void service_done_flag(struct dim2_hdm *dev, int= ch_idx) unsigned long flags; u8 *data; =20 - BUG_ON(!hdm_ch); - BUG_ON(!hdm_ch->is_initialized); + if (!hdm_ch || !hdm_ch->is_initialized) + return; =20 spin_lock_irqsave(&dim_lock, flags); =20 @@ -457,7 +463,8 @@ static int configure_channel(struct most_interface *mos= t_iface, int ch_idx, int const ch_addr =3D ch_idx * 2 + 2; struct hdm_channel *const hdm_ch =3D dev->hch + ch_idx; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); + if (ch_idx < 0 || ch_idx >=3D DMA_CHANNELS) + return -EINVAL; =20 if (hdm_ch->is_initialized) return -EPERM; @@ -569,7 +576,8 @@ static int enqueue(struct most_interface *most_iface, i= nt ch_idx, struct hdm_channel *hdm_ch =3D dev->hch + ch_idx; unsigned long flags; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); + if (ch_idx < 0 || ch_idx >=3D DMA_CHANNELS) + return -EINVAL; =20 if (!hdm_ch->is_initialized) return -EPERM; @@ -645,7 +653,8 @@ static int poison_channel(struct most_interface *most_i= face, int ch_idx) u8 hal_ret; int ret =3D 0; =20 - BUG_ON(ch_idx < 0 || ch_idx >=3D DMA_CHANNELS); + if (ch_idx < 0 || ch_idx >=3D DMA_CHANNELS) + return -EINVAL; =20 if (!hdm_ch->is_initialized) return -EPERM; --=20 2.53.0