From nobody Thu Apr 9 23:26:09 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30E5619CC0C for ; Thu, 5 Mar 2026 16:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772727362; cv=none; b=aiEf9isNnspRrDytIIVSu7PURX3PHl5nczuwQ9qgLrFc8noIFqZ5LIkH5B2nLX6/LNUvL8C8bBJ8yr+NIenKSLZKiXf+5dII4Fct4rhFbI1kOSrnLeKnqMyzMpOP7v62dyou7j8UX6rFXDuZH/Wkn6pG3NV2TMNDd0Z/sWFWS54= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772727362; c=relaxed/simple; bh=ayZa6eUX42z6X1IZOjyqGaQSXE2kotFlsEPGUri5Ogw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IIQGEcdvUU1YkBhI2KAw8+PppAN3Rxu3Nqh+QpMuQS5UU2sB2xQMjs4grkwxclHFsILRJHTFc0g5kfkBjppZYQM4bxynf6YMag4eJCYg3TRAabG9d0nVy3grGkE7EiTT1B4lDPj5JRRO7t4AFpfeVHTewNi0iMlR5qm9xUH09IM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=sVKDQJkZ; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="sVKDQJkZ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=/a+GWLIdcwkHBuwol8H36LzeFXVyS6jDGhiuvAeHeQU=; b=sVKDQJkZ6MaWDuUWoXeAC0C6W1 ZRWAtxO/eM8x2cWUi9o/MfbvBYxYSI3EOkimXiM6jeekYUR8TSU3DE50CgKccrbQLOBVSrpCUONez w8km0GIPVeZrNtwvgk9vUaHHQQFq8poxPU3+A0v6sdu/JzA8BnNamTjYRn+S2XgrSbcYBI/TSAo0O Og8yU/dHs9wCZAMFX9OVgi8y3H4gPAL43H4wXRrmUfX0kr3ECNPfs1uutKswj5AkY0+jYyL7N4MSI M8l7EYGnDx7saj1yyQ1WZ/Kebl+jPm26SweH0DvYlioKJaKY5dD7K7AbHqSkGTbqqLs/AhlOuOina 1KRYLy4g==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1vyBMj-00Gqq8-Cs; Thu, 05 Mar 2026 16:15:57 +0000 From: Breno Leitao Date: Thu, 05 Mar 2026 08:15:37 -0800 Subject: [PATCH v2 1/5] workqueue: Use POOL_BH instead of WQ_BH when checking pool flags Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260305-wqstall_start-at-v2-1-b60863ee0899@debian.org> References: <20260305-wqstall_start-at-v2-0-b60863ee0899@debian.org> In-Reply-To: <20260305-wqstall_start-at-v2-0-b60863ee0899@debian.org> To: Tejun Heo , Lai Jiangshan , Andrew Morton Cc: linux-kernel@vger.kernel.org, Omar Sandoval , Song Liu , Danielle Costantino , kasan-dev@googlegroups.com, Petr Mladek , kernel-team@meta.com, Breno Leitao X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=1075; i=leitao@debian.org; h=from:subject:message-id; bh=ayZa6eUX42z6X1IZOjyqGaQSXE2kotFlsEPGUri5Ogw=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpqawzFjrISbfyzAjsU4t6y0T8xqK9Hf+IB0mlb 0pNMWyyX1+JAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaamsMwAKCRA1o5Of/Hh3 bTAiD/4nJSvjlW9FdyS7S6CjWzJrDIyYotlGnLrT3S3LmxR6XhIdnb/3pTSR+x8DxabOBXpTArH FCvfGlvqv//IQ/tn1GV1mPZyrmS8h09o6R6zmAS9NsDzL3zbP6K9y3TBRVjp/nilf/wDl9lI0TQ V8c7LOR9KNyLGWUCVcBmW+1rwFC3Xl9NK7vOoGOZ6gy7ANMa+pfoEPkplv9uM4GUtBvuG+6V4fI 4C6ZN76r3W6+RhIkdjbkonACIPn/YwkuYBH0jcLRrH9k/q7953uXuhgA8xZs5anoOX+h4hsJw56 PohrSrUlhxgi5JS5R7Bmx6D0Lvm+tZE5hhUjyIe3ZgR3ugYdo1jKkxumvb58VussbosFSIEPT3v PTTMp9Ty5p59OzhCMM6BUycK8+lbHCEQrip7yMaQUWMforoM1lsvNPY6jvwN5N38xqzo6+Z13ue QOxlRIcJUDjsEqPQdDV8HMvtabJ4YSHeU7DtRLfMurGx7IlJEQB9Cypn2c8zTSgeKmGYhjJ4lZm lqnRe6AcvsHdpUc3/9W0CXWY7JUhbzt4N6WsjVp6fBSv6JcFi9RHyFRNDy3dRMOnuSeCLN6/olm 35FDuSAAo4Z+PGcNVnfdqdS/GL8ag/jW22mTYsYDTLR9wIPTIIkT4kFYKwNOdEatKCBW3ZqC0N0 SEjfcE1f9BcyL0Q== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao pr_cont_worker_id() checks pool->flags against WQ_BH, which is a workqueue-level flag (defined in workqueue.h). Pool flags use a separate namespace with POOL_* constants (defined in workqueue.c). The correct constant is POOL_BH. Both WQ_BH and POOL_BH are defined as (1 << 0) so this has no behavioral impact, but it is semantically wrong and inconsistent with every other pool-level BH check in the file. Fixes: 4cb1ef64609f ("workqueue: Implement BH workqueues to eventually repl= ace tasklets") Signed-off-by: Breno Leitao Acked-by: Song Liu --- kernel/workqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index aeaec79bc09c4..1e5b6cb0fbda6 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -6274,7 +6274,7 @@ static void pr_cont_worker_id(struct worker *worker) { struct worker_pool *pool =3D worker->pool; =20 - if (pool->flags & WQ_BH) + if (pool->flags & POOL_BH) pr_cont("bh%s", pool->attrs->nice =3D=3D HIGHPRI_NICE_LEVEL ? "-hi" : ""); else --=20 2.47.3