From nobody Thu Apr 9 23:26:49 2026 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87E54396D27; Thu, 5 Mar 2026 12:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772713233; cv=none; b=qpH+kdqOSA1WrSPL3LY7x5dl6XbxxxZlK6/S6hdZ8XPr8gI6qjOo2EFwcMoZFEOfWFGgBsIdQSi+ayvro8pkcPc/qq/yWgg0bGkvaDI9kqGaHHeYFBbAA6MEQutfl7GR3s2rSdS01YjP5vIMBDjDDZVUHhNoRbmZeGER7DBpU4c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772713233; c=relaxed/simple; bh=fa+UCbtwReJTJptJMdx/NTEP96lWAeW85C7bH3Iv6iA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=khgfd4CrksbqUAPtOfJV3CISMDNWjRYoZ72JdQcJOXR6hoDT92vgx+IIoFp0ZegZpYDPhBBrzGWTs5TFj+3ycQlE/LjbJ11E/ceFlREx9CyK0dVyWqhaiDaFkJISUUnW8psjoLyYrBCCP2Uf8VnNkeoYnulJ8O/fcNzIrK9Wnp8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=NtOJIhf1; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="NtOJIhf1" Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6257qwYG2123727; Thu, 5 Mar 2026 12:20:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=DLefWu Qx1WI+Y5vD2GhByCm3kkB0v+kz8E76A14iFbs=; b=NtOJIhf10x4RnzKsV+fA6r fPC/EDLIITMOJGOj+2adGQuHRPIEC2h38MoYfutEGNqscNScEithtSDPaIBQI6Es E/PGJTd/VGqaRfoKE2lg7tqg4W1k382VuFr36qyiTa0VHgO3dc/g03fjJR2ehIVC C0Nk5ZRzwfBTzO5aBN3zTJdiyF2UIzsfw2bOoAXVxcy/v1KXnNQqWNhJP2EbowjH stWM/J7NC/chyCtqMr76k+g/aCvpArnZ9q3IrwS5FgG95Cw6IZigSSteOi9IeHy7 Y5JOmh28G85j6OyCYDE5JxXLPraWDBhrxIEg3lEsyL5IpDtDPwzyZA69S6j+eC0Q == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4ckskd3k4g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Mar 2026 12:20:28 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 6259FMto016756; Thu, 5 Mar 2026 12:20:26 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4cmbpnb7nq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Mar 2026 12:20:26 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 625CKMje48824676 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 Mar 2026 12:20:22 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BC72D20040; Thu, 5 Mar 2026 12:20:22 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6C78B2004B; Thu, 5 Mar 2026 12:20:22 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 5 Mar 2026 12:20:22 +0000 (GMT) From: Julian Ruess Date: Thu, 05 Mar 2026 13:20:13 +0100 Subject: [PATCH v3 1/3] vfio/pci: Rename vfio_config_do_rw() to vfio_pci_config_rw_single() and export it Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260305-vfio_pci_ism-v3-1-1217076c81d9@linux.ibm.com> References: <20260305-vfio_pci_ism-v3-0-1217076c81d9@linux.ibm.com> In-Reply-To: <20260305-vfio_pci_ism-v3-0-1217076c81d9@linux.ibm.com> To: schnelle@linux.ibm.com, wintera@linux.ibm.com, ts@linux.ibm.com, oberpar@linux.ibm.com, gbayer@linux.ibm.com, Alex Williamson , Jason Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian Cc: mjrosato@linux.ibm.com, alifm@linux.ibm.com, raspl@linux.ibm.com, hca@linux.ibm.com, agordeev@linux.ibm.com, gor@linux.ibm.com, julianr@linux.ibm.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-pci@vger.kernel.org X-Mailer: b4 0.14.2 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: DKvhiIPjnyuzuhuJe9qEFn7vr22GV-Ac X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDA5OSBTYWx0ZWRfXyFndmPTI87nY IVEHFJJR06V43phJHh8tdem/RnjVAIqyzEFZXT146mjjdoU7SNW4VL96OvndgFFdE+iAyvACizb 3uP+MC13KpJNa1SUHu/c34Dvgq74ffRc2O/qpQMYqxAn0epf/mVP4upJasdxcx2Mz3UzB/Tm4Bz vLuJQ4Pw38yBhUBf+P9ZwIuVwQmGW+nJTMSSio1OkjSulKYnwd8Ps5ltP7MeBAnddoYtfNbrR/I oIWi39Hr9U5oOum1zRpr+tlmCTKtHzwk/lSJDtEOvh9jk9Mbm7gU2XRKhSRJBl05drQA+ANkIGO gro49jtz8As7LilklIUHshc9htB4O4tzBT3psyGi9ieu84Ivn2DjaoRs7ERcBXeiUVG5my+JfNo VWb6WRDV9YEtpTFND51xQpE9EdfNklVk/GcX+gN0HvUWE+b0FZ85KOBYEqkDku3fa0kTeuw69N6 5fd5mVKCfoMHlkkNOyw== X-Authority-Analysis: v=2.4 cv=H7DWAuYi c=1 sm=1 tr=0 ts=69a9750c cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VnNF1IyMAAAA:8 a=mooU_oynDD9EFzHbF-IA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-ORIG-GUID: DKvhiIPjnyuzuhuJe9qEFn7vr22GV-Ac X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_04,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050099 A follow-up patch adds a new variant driver for s390 ISM devices. Since this device uses a 256=E2=80=AFTiB BAR 0 that is never mapped, the variant driver needs its own ISM_VFIO_PCI_OFFSET_MASK. To minimally mirror the functionality of vfio_pci_config_rw() with such a custom mask, export vfio_config_do_rw(). To better distinguish the now exported function from vfio_pci_config_rw(), rename it to vfio_pci_config_rw_single() emphasizing that it does a single config space read or write. Reviewed-by: Niklas Schnelle Signed-off-by: Julian Ruess --- drivers/vfio/pci/vfio_pci_config.c | 8 +++++--- drivers/vfio/pci/vfio_pci_priv.h | 4 ++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci= _config.c index b4e39253f98da61a5e2b6dd0089b2f6aef4b85a0..fbb47b4ddb43d42b758b16778e6= e701379d7e7db 100644 --- a/drivers/vfio/pci/vfio_pci_config.c +++ b/drivers/vfio/pci/vfio_pci_config.c @@ -1880,8 +1880,9 @@ static size_t vfio_pci_cap_remaining_dword(struct vfi= o_pci_core_device *vdev, return i; } =20 -static ssize_t vfio_config_do_rw(struct vfio_pci_core_device *vdev, char _= _user *buf, - size_t count, loff_t *ppos, bool iswrite) +ssize_t vfio_pci_config_rw_single(struct vfio_pci_core_device *vdev, + char __user *buf, size_t count, loff_t *ppos, + bool iswrite) { struct pci_dev *pdev =3D vdev->pdev; struct perm_bits *perm; @@ -1970,6 +1971,7 @@ static ssize_t vfio_config_do_rw(struct vfio_pci_core= _device *vdev, char __user =20 return ret; } +EXPORT_SYMBOL_GPL(vfio_pci_config_rw_single); =20 ssize_t vfio_pci_config_rw(struct vfio_pci_core_device *vdev, char __user = *buf, size_t count, loff_t *ppos, bool iswrite) @@ -1981,7 +1983,7 @@ ssize_t vfio_pci_config_rw(struct vfio_pci_core_devic= e *vdev, char __user *buf, pos &=3D VFIO_PCI_OFFSET_MASK; =20 while (count) { - ret =3D vfio_config_do_rw(vdev, buf, count, &pos, iswrite); + ret =3D vfio_pci_config_rw_single(vdev, buf, count, &pos, iswrite); if (ret < 0) return ret; =20 diff --git a/drivers/vfio/pci/vfio_pci_priv.h b/drivers/vfio/pci/vfio_pci_p= riv.h index 27ac280f00b975989f6cbc02c11aaca01f9badf3..28a3edf65aeecfa06cd1856637c= d33eec1fa3006 100644 --- a/drivers/vfio/pci/vfio_pci_priv.h +++ b/drivers/vfio/pci/vfio_pci_priv.h @@ -37,6 +37,10 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_core_device = *vdev, uint32_t flags, ssize_t vfio_pci_config_rw(struct vfio_pci_core_device *vdev, char __user = *buf, size_t count, loff_t *ppos, bool iswrite); =20 +ssize_t vfio_pci_config_rw_single(struct vfio_pci_core_device *vdev, + char __user *buf, size_t count, loff_t *ppos, + bool iswrite); + ssize_t vfio_pci_bar_rw(struct vfio_pci_core_device *vdev, char __user *bu= f, size_t count, loff_t *ppos, bool iswrite); =20 --=20 2.51.0