From nobody Thu Apr 9 21:52:27 2026 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A0FA30FC1E for ; Thu, 5 Mar 2026 19:21:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772738520; cv=none; b=a5nCbueej7u6e+mycf5Ef/638l6wRkhUUKUS8dHf9/y6Jvq480y0QSQw2nsPqA3Fle4Jd8kggg0+gsy+cmVs75+e5SujIQfS45KqwdAdjtOWBa5VN3WA4JwSPc9/zmtzF3sUMo9xztBp0kP178H57GpSkp2bYUQWaEk7azIovW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772738520; c=relaxed/simple; bh=puVzQVVivVatnMzmHhQf7aghQyv1Ohkpm6fvRgahEf0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FL5st107+OseCoymP4zkTbaLKezgbtjENy5gxDeTrduC4RShUXqx5r4HYdeAGEmf3Zyi7S+P6gYnFIVny4BTBFiKDIlwlwz+i+xXdb0XVqnu+AZnohBxn58xKPTHGM5boz1jNXfGVhPF69CZn/Ro6YkT3jcBEKsAQW2rFQWDNJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UKgbLoZa; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UKgbLoZa" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-1277e072e2dso4667594c88.0 for ; Thu, 05 Mar 2026 11:21:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772738518; x=1773343318; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fTfBwtx85kwVzzZ3HjdtefR3fnbTNSxXGk3ctCXP+Og=; b=UKgbLoZa1qLiM5v4KbLZrQeQWRp6IgTQNxIGdDhp5WTOl9r03jVJKw6jT4nshM8GQ+ ycxvs5sdpkKIAnjyi+Y8f4/YgYwFhtVkPLcRxTaGz0erJ+T0qFRcDwdg9/q80TUuF7ym 6YjaBe3Xahe0E6zvidOVukAwMdn60gyVprScVop2ahMZX0Ihj3FxPN5T+3OtG7BE9ySP 9ppWbB4FPTnIBIKvKPGs8wFZ3w1kRByat9b/LO3orm8/QDnqkqpelo6qIXNYGmOU+pmr 3JFt4g/ksvSFmYruHl5sAjXYVzIHVFHzvQRzr+uGjnT7k5AK6/mRJh6990ynGo4tB9JX l7Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772738518; x=1773343318; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fTfBwtx85kwVzzZ3HjdtefR3fnbTNSxXGk3ctCXP+Og=; b=AgY1ZhClYVlBNnhiWztGgISSbtfVmEWHfVVUiUztI5bGyXvbuTrdLgKKyoMdsxmQ1U jBgTvMWGrTrJPcf5vmp2j6T3QQpP4Jad3W6irm58schkx5UXKJM94DYWKGrGiDmHPEsA CK4NyUhRaoQlpJOeo9bF8L+EHU7/asuRbHSML1V0uNMtKFTlWndC3CH6gA7awVkSB4T/ Dd1RRArVSKEtJMRf6bLFb9mQ7CKDwlCknAIckoq1MhfKfmxZgdIzkcNysByXplnv0gjk SavLMs/PEsKXqrIVjgKnGn+hjclmfGg+bjS5AC6W31BicjdeMTXn59y30zso69qfAzxQ RP9A== X-Forwarded-Encrypted: i=1; AJvYcCU9zlD7JHcLI2hrtdOspTu5Jm3M0/8IIrsnTwEggd+xPjMTe0ENpsrKy6ocANNWRAA/XNPDK389HnwsjcM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywe9YxFJDxqw5fhGY4eItVGq2PcWaGdkRzsOmIUoK9e+uSLXNOP 5j95e3rg8OqH7316XYB3d6c/mIxR5v/+r9gKhmuKoXMxDmL776NnMTYaPbFlPg== X-Gm-Gg: ATEYQzzhxrnvXaDCP10GXiIQgZCvIgnkd6QGWTQ+vn1lupc8KMqKehieNMGuiwaMP4f OtEuM+PrtQUYn9EuyJIsGnHMKO2WdhY0lsF/Z1BpRd9+zTogF9uWt5OmqwTZKT1i/5NfcIYbP28 Kacy0KFgw1pakclWn+EYHf3VErsEhjlZK3yQ6Ndg5yWtsLXEwM9Qm2PN5FadhwNU7nLJfnStxqa 028IS+rfhEfpiaDlAUJ17xnjibrTb8PQ2xD7Wi3Bn1iyTScTs96KH3lm8XgYJEgog3oGR0QEUAH iuBuviORHjlgWSV0m+Z0E6qc8/2mjEISjMHEBt3OzF9wkcvj2QroPruaD2z/80W70h2ACVNiff8 aZulU96dbaD0GbCXoLzJDW1Kcx9IbmQgSJGgzgPso2jCrwtyrORjl2pVW5/slv0MKbng4LeG8SD ppT9nQAFc3BuSXEzeJV2l5iyXaG7ENboaV5p7d88PLg4jsUOsBPV2IPSR4mdk0ECdl+n7JoDuRL 1lkuymvodmLxdk= X-Received: by 2002:a05:7022:2208:b0:123:3c65:d724 with SMTP id a92af1059eb24-128bc030d6fmr1068015c88.25.1772738518437; Thu, 05 Mar 2026 11:21:58 -0800 (PST) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:7788:d145:a740:ca06]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be1281ff70sm10800980eec.14.2026.03.05.11.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 11:21:57 -0800 (PST) From: Dmitry Torokhov Date: Thu, 05 Mar 2026 11:21:53 -0800 Subject: [PATCH v3 2/6] iio: adc: ti-ads7950: do not clobber gpio state in ti_ads7950_get() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260305-ti-ads7950-facelift-v3-2-a23fdd1a079e@gmail.com> References: <20260305-ti-ads7950-facelift-v3-0-a23fdd1a079e@gmail.com> In-Reply-To: <20260305-ti-ads7950-facelift-v3-0-a23fdd1a079e@gmail.com> To: Jonathan Cameron , David Lechner Cc: =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Jonathan Cameron X-Mailer: b4 0.15-dev-94184 GPIO state was inadvertently overwritten by the result of spi_sync(), resulting in ti_ads7950_get() only returning 0 as GPIO state (or error). Fix this by introducing a separate variable to hold the state. Fixes: c97dce792dc8 ("iio: adc: ti-ads7950: add GPIO support") Reported-by: David Lechner Signed-off-by: Dmitry Torokhov --- drivers/iio/adc/ti-ads7950.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c index b8cc39fc39fb..cdc624889559 100644 --- a/drivers/iio/adc/ti-ads7950.c +++ b/drivers/iio/adc/ti-ads7950.c @@ -427,13 +427,15 @@ static int ti_ads7950_set(struct gpio_chip *chip, uns= igned int offset, static int ti_ads7950_get(struct gpio_chip *chip, unsigned int offset) { struct ti_ads7950_state *st =3D gpiochip_get_data(chip); + bool state; int ret; =20 mutex_lock(&st->slock); =20 /* If set as output, return the output */ if (st->gpio_cmd_settings_bitmask & BIT(offset)) { - ret =3D (st->cmd_settings_bitmask & BIT(offset)) ? 1 : 0; + state =3D st->cmd_settings_bitmask & BIT(offset); + ret =3D 0; goto out; } =20 @@ -444,7 +446,7 @@ static int ti_ads7950_get(struct gpio_chip *chip, unsig= ned int offset) if (ret) goto out; =20 - ret =3D ((st->single_rx >> 12) & BIT(offset)) ? 1 : 0; + state =3D (st->single_rx >> 12) & BIT(offset); =20 /* Revert back to original settings */ st->cmd_settings_bitmask &=3D ~TI_ADS7950_CR_GPIO_DATA; @@ -456,7 +458,7 @@ static int ti_ads7950_get(struct gpio_chip *chip, unsig= ned int offset) out: mutex_unlock(&st->slock); =20 - return ret; + return ret ?: state; } =20 static int ti_ads7950_get_direction(struct gpio_chip *chip, --=20 2.53.0.473.g4a7958ca14-goog