From nobody Thu Apr 9 21:50:50 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94DA639FCC6 for ; Thu, 5 Mar 2026 15:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772725107; cv=none; b=biC+76A/8oLEuT5/ipdTK0T+7pkFK26EkKD0JKm4ZLkt7W2z9rQi0PSA3BxeWLln6NGef87MTYX++MJsoh/xsVC5tp7ksv6mCYHfFxz/1874+SCUpnwqROsIzS82v94B7flcSDPEuiacRGj8dJs1/Leu4UVbNMTgJXELgB4vMjA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772725107; c=relaxed/simple; bh=abxR5oIsLcrkxbLIHiQZCFRJOUOd6Ae6V6Vg+uXUVjY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=D1vTLRdIM+SD1avNI3gSRpkAAykKVwbtPzZo6LLa69PaS/BoJAy9Asx40Me0BEnKR0je07zLY1Fn4P3sRL+yqPWPY80L3zD/nD839GzaYReK2nLectgIKXiL+dxZZ1Qmijg5gdfdBSBOzOZQMUNjnx/i8KyQ+VSmTFo9ocJUrwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VVZsJPdv; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VVZsJPdv" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-82746ed8cdcso5380165b3a.3 for ; Thu, 05 Mar 2026 07:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772725106; x=1773329906; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=p+rLnJ3aJ6D+F+fZbg2d06YcvZPxOEiVrOGPvy9ur+c=; b=VVZsJPdvLD+Jx9w8Ige3ZD5hPTpvk2BQCGeyre0uAzOB2M6gKi7b8UR+/LwZLQNoUu EyWxJs8P2nOZ3Otr/G4iX/SX9LJ49qg6EYPJTYCwJO+b8PCO/U5AX/mqVdVyPrK38xTK Zshaekd4NJy5yLTZGCCllSX8UjIwu+JbEHSLgWoTcnC5j5ovrY7SDvnw9tvWldfYYfAv OomItYMibF3dgpesiIHExOYJWpnuwMra4PMG3Hk+gxMG0as3U/xYf4c4RteY6mbKEjOX JMF0nvpmf2RMAh6CJV6fsp9wm5t3tn8dmH12yLlyql+5u9ylTQWNBTk7TYwTgX6Mon6h i7Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772725106; x=1773329906; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p+rLnJ3aJ6D+F+fZbg2d06YcvZPxOEiVrOGPvy9ur+c=; b=k6QLizEeDmtOKR+eZUiVT3x49io5LwHE/hylGmpsvgkqRp6IkqGi/ICUSTgH2o4c20 we0k/07ZG+wdjO8VTzfmhZ5j7OHzcR79shAqqZtXYwYIhHEY3YoFNaZv0X3ApkMr10DO QRGa74YOBkRrq0bZbdfRrUg+Wg7V5+8XS/ThnbuHioebPsv0G89xMhjxzUwPfv2kN6YI 0V9LH+bOXvZkXAtPDAF8baq9EXAJd4Muyx4FHsxY4yEluVBzRXQq1fOELsQ5AIdS8/n/ 4PP3hF8849t5C9p56wOoghMV/6YHI9EXduv81a+cB07NqtqVN8xQPD0xQMGo41b2jrag GZaQ== X-Forwarded-Encrypted: i=1; AJvYcCVwI3Qg6TrG3A3smJEH+uMXAT1Guv8F9/5k88fyxpTeHMisYD1VbRj0uq6Sy1hWLPBRj+HI5RX2/jPPrUs=@vger.kernel.org X-Gm-Message-State: AOJu0YyVl/+Oq6l/5tVw1YY8XqL5MW3ZzFlkszmrwDyh5LwDRToO2JDx JMtMu8V9J8/H0f4wdGyZjqLcyvj3eX/MsN4FC5fYcen5WxTMz7dvHXz2 X-Gm-Gg: ATEYQzwS1s7Mf3fTqRJaA53s2BgRq5U4d4ZY2s1SdK/wnaNy1+BsBoNH7NfTwWZzyYR aAnfX9lV+bI4BCCF0FXsz05Hqy+sPtsz21bTGeiZ0dGBwyXvmkGz5oHi3FCImb459DfoOjXAZdn qIUthPacQgyWFklazJ8lV43eSBeryFOTb3pRxFLsydKjbsgQgtmpKMMa1n21YgEoe52klA3Z/wW ZGZbfGPPwCK+k71hXGrf+bT/MNMQXq2B0f67FLTTtLOLij9yX/WZz8joaFYTgPQG3SapY2Hg7Ql 3KBS97mAemdsveuUqBzM/uUmPOlzbPRarGzcpsaaMj/jxZWpw9ddqOh3oZ+tuNW1LCktdmEAdMT 0UmQCk9D9eOhEPR5D6n8fcI3PcbalQuGRxa5mRhd7EvsT8KMSnw0CHeeuv6fxIBB0/rmEAZAhTr zP8vMTOYDvCZuuJw792Q== X-Received: by 2002:a05:6a00:3d4a:b0:821:7d7e:41d5 with SMTP id d2e1a72fcca58-82972cce807mr5929465b3a.52.1772725105728; Thu, 05 Mar 2026 07:38:25 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2::3a87]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8297d3d6aedsm3376850b3a.31.2026.03.05.07.38.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 07:38:25 -0800 (PST) From: Felix Gu Date: Thu, 05 Mar 2026 23:38:21 +0800 Subject: [PATCH] spi: rockchip-sfc: Remove redundant spi_unregister_controller() call Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260305-sfc-v1-1-6fbf6df0e899@gmail.com> X-B4-Tracking: v=1; b=H4sIAGyjqWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDYwNT3eK0ZF1jA3NzA4tUy5RkM3MloMqCotS0zAqwKdGxtbUAik9DnlU AAAA= X-Change-ID: 20260305-sfc-307708e9dc67 To: Mark Brown , Heiko Stuebner , Jon Lin Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772725103; l=1268; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=abxR5oIsLcrkxbLIHiQZCFRJOUOd6Ae6V6Vg+uXUVjY=; b=J6tc/xqw+Xy5g7gTlKOpBVM1cXwg5atz100uVzTGIdf5HIjfSEWQs+6wpbxq6GRY/zxwHcmAr vgb60XU41OnC3/BsuE0mAYuLmktzO9OE35d06KPi0QWgA3YedwXJ0WS X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The driver uses devm_spi_register_controller() for registration, which automatically unregisters the controller via devm cleanup when the device is removed. The manual call to spi_unregister_controller() in the remove() callback is therefore redundant and should be removed. Fixes: 8011709906d0 ("spi: rockchip-sfc: Support pm ops") Signed-off-by: Felix Gu --- drivers/spi/spi-rockchip-sfc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c index 2990bf85ee47..19e832f045d2 100644 --- a/drivers/spi/spi-rockchip-sfc.c +++ b/drivers/spi/spi-rockchip-sfc.c @@ -740,9 +740,7 @@ static int rockchip_sfc_probe(struct platform_device *p= dev) static void rockchip_sfc_remove(struct platform_device *pdev) { struct rockchip_sfc *sfc =3D platform_get_drvdata(pdev); - struct spi_controller *host =3D sfc->host; =20 - spi_unregister_controller(host); dma_unmap_single(&pdev->dev, sfc->dma_buffer, sfc->max_iosize, DMA_BIDIRECTIONAL); free_pages((unsigned long)sfc->buffer, get_order(sfc->max_iosize)); --- base-commit: 3f9cd19e764b782706dbaacc69e502099cb014ba change-id: 20260305-sfc-307708e9dc67 Best regards, --=20 Felix Gu