From nobody Thu Apr 9 23:26:46 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A89AC3CB2EC for ; Thu, 5 Mar 2026 16:28:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772728131; cv=none; b=twe7EcXnemQAP6uX9yeGUmP7I688Qbow89nmjSGLpzm8hIjnF/qJKwZk+RTZx/Bj2f7NWB4SsIQayEJDu4ZzawWnQv/hhaB1oqwZ0Dj7qTWNpsu6qBFDxqIHd+iAOoOZHoh6JIa4yqqhVl5w07d8al4pSgicl5UWvxIHY4OF8DA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772728131; c=relaxed/simple; bh=suVlOkK2FxaMrVmsSWeDXx31yW5F+MdOw/3w+mpbd44=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L4TkgOFfTTeqc+HpnoBYCqP410HGDjXXsrvuOK26SFrlA3perfisJMGPNRr8Qth2uIukg2OUl+KLsOTtzHj3gzcNpeeiNxp3DlrnkPTrHiHkB+r7Q3PfitOICDnnLRd3Hx/yhJPHi7yalMfwW8UysZoIC77RECI3i6Mn25Z9Tvs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=epz1j30v; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="epz1j30v" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-439b790af67so2854247f8f.0 for ; Thu, 05 Mar 2026 08:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772728128; x=1773332928; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=b/8Q0uO9fn7N2aNObdrJAfX+BnNEdYRQNZ6cnN9zLhE=; b=epz1j30vedCEsttEsm4d2OBncjoiS0LYTY6RdwSakYZ+KIwO597Bgzu2oHRE4njRtj oTuy7aE0K9wYaSI9zcqpndAakUPWm0NXFPFDd8ciJRq+MmWGAQd1SoJsN651JC/SX/ip vW5qfbBmluj2CyfK4UsQb8PGp7mXyfFrDcfLkzzmp9HuWy0j3WH6KkVhxN5lUxGV0VIE 0DmJjhl8IkafpyzMC5BCY4VC/0lqpmIhdwwOHGSHYkT2iWGZZO9d54+AoOao0MgAyxE+ Rbs+mXVUh+Zgan5IEWqqlsVZrxKdqGTtqVpR5bRDLlE46/sLNFaW/8g5m/ygTsADYn9Z vaTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772728128; x=1773332928; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=b/8Q0uO9fn7N2aNObdrJAfX+BnNEdYRQNZ6cnN9zLhE=; b=AZ3YS+bGyezi27NU5btk203A2UNuXnjG5PlqFROJVUXc1xPoRH5IZD7jaTBipw7gNM tfhzIatNt9AWg+fecyLICSWBeVn9vDKGUllu++zYudCePDY3Cad9J2oymTxJ8xAreTpD /xR3x6dmQR4wDR5J5VMGiN8MKU6mezCgcjoZgxBxaP35XBBHTLoHWGdmRWniaRp4G3zE rn8NsMoLsRZtJhuG8l8SbdfpdVzy6bl61y50yLa1qKSeYNMzlLnFyVWwffFghGwCr+J+ aKc58zUuxdkqjhRlqIFWw027ZBeeCK1Mr0rcgRC+gBLa7eOGaWQX17FAvp+c+fpbP30r EMlw== X-Forwarded-Encrypted: i=1; AJvYcCVKHkCdzr/mgaXk+Lch69EIK4gr2c23E3zCxz48st/REJFNeqlS/Eqedu2j6vk6sWqR/u7EBAwu7X8pNdI=@vger.kernel.org X-Gm-Message-State: AOJu0YwBWwEHqJN19qo02Gm9QYe373UMrZzCubMdkw3Y8pjGY/rkkbFY UJByfC+3hGp6/YOz/d99k9poSoZ2OXT29pbmPtBz2tXgf+VYJ3DOvWkHlwWFF/3LiJ8= X-Gm-Gg: ATEYQzzuVMqNvpoD5OLnTz123PcHntoTxdOTAS+dFkzXR7q0KdLkT/89lLW6WkF0zAh txtCOwlbe+8tHG5L6WKRWUlbZLXCFu4Y7APxqD503LouDDwDj/k9Y31L4rWgDCIL1BottwnBBh2 fCisLkgEf85ajds5RLuSUuMhHcC6L9QzRwy3mk5MWnCkijHddjdAneEJ1bSE23YCN8/VVMzk+K2 IY0y0htEH5xMMD71L8BntVv0BL8rDd9/6j2b4u9jCalxYE9DRu2xxitOM20JDCMa6rFXR+ndqna gCekfA+sloJHbrqeY9SQpvkW3Jak+3KUX73sSzXRiqINhOP5On5GBYKnjswlkgme6atrKTv7+zJ ioZ/b68Pn7WZCpoNeNdgD9wMC7KSGVxbeQWQGT7WJuSHlfutzV3ANcbWuhhUUhY2q8Ltpo7OGe+ 0JyO32gAoA9nueRY8yOb+cCGd1Dc0UoLFd X-Received: by 2002:a05:6000:1849:b0:439:ccd7:cdcc with SMTP id ffacd0b85a97d-439cfd65a3amr5335384f8f.18.1772728127425; Thu, 05 Mar 2026 08:28:47 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439c2f8c0e7sm19596034f8f.29.2026.03.05.08.28.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 08:28:47 -0800 (PST) From: James Clark Date: Thu, 05 Mar 2026 16:28:17 +0000 Subject: [PATCH v2 1/3] KVM: arm64: Read PMUVer as unsigned Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260305-james-kvm-pmuver-sign-v2-1-ee80a125af9b@linaro.org> References: <20260305-james-kvm-pmuver-sign-v2-0-ee80a125af9b@linaro.org> In-Reply-To: <20260305-james-kvm-pmuver-sign-v2-0-ee80a125af9b@linaro.org> To: Marc Zyngier , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Colton Lewis , Alexandru Elisei Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, James Clark X-Mailer: b4 0.14.0 ID_AA64DFR0_EL1.PMUVer is an unsigned field, so this skips initialization of host_data_ptr(nr_event_counters) for PMUv3 for Armv8.8 onwards as they appear as negative values. Fix it by reading it as unsigned. Now ID_AA64DFR0_EL1_PMUVer_IMP_DEF needs to be special cased, so use pmuv3_implemented() which already does it. Fixes: 2417218f2f23 ("KVM: arm64: Get rid of __kvm_get_mdcr_el2() and relat= ed warts") Signed-off-by: James Clark --- arch/arm64/kvm/debug.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kvm/debug.c b/arch/arm64/kvm/debug.c index 3ad6b7c6e4ba..f4d7b12045e8 100644 --- a/arch/arm64/kvm/debug.c +++ b/arch/arm64/kvm/debug.c @@ -10,6 +10,7 @@ #include #include =20 +#include #include #include #include @@ -75,8 +76,10 @@ static void kvm_arm_setup_mdcr_el2(struct kvm_vcpu *vcpu) void kvm_init_host_debug_data(void) { u64 dfr0 =3D read_sysreg(id_aa64dfr0_el1); + unsigned int pmuver =3D cpuid_feature_extract_unsigned_field(dfr0, + ID_AA64DFR0_EL1_PMUVer_SHIFT); =20 - if (cpuid_feature_extract_signed_field(dfr0, ID_AA64DFR0_EL1_PMUVer_SHIFT= ) > 0) + if (pmuv3_implemented(pmuver)) *host_data_ptr(nr_event_counters) =3D FIELD_GET(ARMV8_PMU_PMCR_N, read_sysreg(pmcr_el0)); =20 --=20 2.34.1