From nobody Thu Apr 9 23:24:44 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B692F3A6EE9 for ; Thu, 5 Mar 2026 14:30:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772721061; cv=none; b=NOiMKUBgqWtEUq8aB6goD49iwomGDLZ0vV8r61tAE1ZivQeYKK7OI0aBnH5fIiwu9qLLWqDkmazeTyW5XZciNFUkrpUBrZEX9bdEVVCpqoZcREg5PruRZIabY7Rg/TVsxBHQF3jWZ1f6FrtmiHK7peP+EoZEMQHdfU8MXETdhgU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772721061; c=relaxed/simple; bh=93mNWzDSyV1/6hDP+y0Mc4joR9UKuCrK6sioo+SXDbw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=N/0H2FO78pU+pPy/q23dEncoubI0A/asTVzw84icgViL8a83j42GymU/4Vn3xCvVGAEW+RYsspzBXuhwlGI1V1KuGHv1VZ2Z67Oa1guMjM3rHMtXPcs99a69vMAk7rF5tcE4L2+ciwThRNRkZrfxNCnYPCRX+OWcxvKrRg5t4j0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bvJd+QZV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KGtoK/qk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bvJd+QZV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KGtoK/qk" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 625AGHSD2119008 for ; Thu, 5 Mar 2026 14:30:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gM1FM0OVfdRIp4jLyHcwDI8KJBwQikDnEiW6JeMAtS4=; b=bvJd+QZVd1cuXnBe d1Iu4H0BCI2RvIQ9+FkYoE1LMp3W7g5Uc6RN07q/YdOmW1zHapFWPIWyeWiFKAav YKH24h5m0nbgSt8D74Xju/mrNkgbx2PV26C/BNweWP0lsDNrG33K7h7XW1jU9VtR ew+d7k8hen45yRRSpoaDEZEXf0S9Q67KHumSzIg3f4YYC50wNAO5bLBlSc8Dn30+ Kz/97wUNFKI7vThte+/E6Q2jg4qNXVGeogaG+SZqwXWDg/1m3iilIKYb64Lif0G/ pA/RQEexF2cAUbDw1dY8n4GUS4DBcdTo1srCJ+CSPFRv3E/dvZwg0tRzDTichBoB EgXcFQ== Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cps0m3nxf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 14:30:59 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5675cb317e3so10994155e0c.0 for ; Thu, 05 Mar 2026 06:30:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772721058; x=1773325858; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gM1FM0OVfdRIp4jLyHcwDI8KJBwQikDnEiW6JeMAtS4=; b=KGtoK/qkbUqf3OcAia4GLegsi1/5Lr4T61BiMSPwWwV+id1zPSXKMZqV1Yqrinkfvj LcKzJtpX8kIW+mrFaY7mZmE9cmqPuZDQX053ZqTSFgqDJw9ll6aCyVS+4wAuCQa3Yofw ngrMTK3IfBnpj6TAqG/IPp1tMvSha4+cQO9ruiblzWnQT9zd2iBqLDMi9/UR/Hs8e/si 4dFHUc7Z+algRKSU0tNvqSLnTYT/92keQ7gV4+BDfGvqW6PBjGnr0lGqsj8Spv4Ohr2e Miii2JapsIyWoyWpLH6McvIfl058VERkLCPLJj4PXIJVEC5fy093UpCzXOjPGLCTGGcD poAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772721058; x=1773325858; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gM1FM0OVfdRIp4jLyHcwDI8KJBwQikDnEiW6JeMAtS4=; b=T2XWg7ya3r6G5n5xOQhSEqAhIlBIaONBjjP4Tpn3PHhnVsRDBZmm0yFeXQzm7iyX68 Ng1EwqC68oIzvCYkqDe/VgDP8kLUN0i3EYnzxKM36divQNMTtxjC4Xznw8xUFI8C6w4B Td4O2mVsxvrTeGKcunFQQlbfMeRKV3Q9p2pmqvzUQyDriJMNJvMsmBP3JHvS+4fDKD4Z UHKtmHFMd9WIVSoCQ0duQvQuNsc5fIiQS/UR1Z5aA46LYbw0ueVUqE3SBbq0sugW1e4h ZGfKcHEg4T49+RPzsAeDs2rr3CRvgWqpU6SYhJhmp0HjvnX1hk7WRZmNLWCjrrhe2UY/ I7zw== X-Forwarded-Encrypted: i=1; AJvYcCUlecJfNRhDP36UsS4UhvICRhi1xsITMzayGg0TvMtFzwpLmXCqGCfvfxm+2yjXk+5qXf9ll74Tc86BV3o=@vger.kernel.org X-Gm-Message-State: AOJu0Yysq5VQZmk+pIQEd66vU84C6T7YKV6WZtsyHlcevlB3aOVU1LDJ apWE2fPwesa+MPQH4EiWexI+PrMCSMkbOkEd4VhX4+QMHpZmj3GpZDIrd58JGa96T/8n2gY1Xpk QOA0xemtHCzb9aN+H1tSrsjM6QrZrx05x+Rli/aiPphQAwOJ5rHAmmUdl5pLLVtf/lJM= X-Gm-Gg: ATEYQzzS+wJnmboYlcaZQPAQ0e2liqaconLks90dnH2kqRtVkuMkhg+wHuOrklSghsQ h6l6fJx9Ilw6RER23Rb5wDJqZ0tvnrVTtDDENXPLSxqBUvg2nCMnbMQTuyjMEGckIjqEqVlEZef o9TYdyv5lG5IODDp+W2KOjdRFo+yYZIVaiAk64quWHHcX9W1bSbtPUDSij20hnSkege/oYKQUiU Doy7EFzefP+kIqEQeWq/5n1GxbOJpYqt6u7j9SznmBcVkYDBHfCSVwnpSZ9lwOInp1OBWg2rsFq Omt9p1VL3Y+WqdDdd2RAkrOJBFrOloZTx0+YFgB8gMzSHXNdISKr4uCQ2I1LhCub5LnjmyUPlZp Q0SO0Kf7WNx9fvanTBUeRv9v/vAM2AmS3Gtx3icBgB/dIDh+NMzwmAn9NN8m0Dao3vXd9r4zsRU ljeiPpIN9Z3gz4ZuSBgk54+gNIhRSJ33pw+d4= X-Received: by 2002:a05:6122:3b11:b0:559:67df:5889 with SMTP id 71dfb90a1353d-56ae7603caamr2234053e0c.6.1772721057654; Thu, 05 Mar 2026 06:30:57 -0800 (PST) X-Received: by 2002:a05:6122:3b11:b0:559:67df:5889 with SMTP id 71dfb90a1353d-56ae7603caamr2234012e0c.6.1772721057127; Thu, 05 Mar 2026 06:30:57 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a126fcf563sm1522618e87.27.2026.03.05.06.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 06:30:56 -0800 (PST) From: Dmitry Baryshkov Date: Thu, 05 Mar 2026 16:30:46 +0200 Subject: [PATCH v4 4/9] drm/msm/dp: Move link training to atomic_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260305-hpd-refactor-v4-4-39c9d1fef321@oss.qualcomm.com> References: <20260305-hpd-refactor-v4-0-39c9d1fef321@oss.qualcomm.com> In-Reply-To: <20260305-hpd-refactor-v4-0-39c9d1fef321@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1716; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=JI7bZYAZgZZoG3QbCYkVN62ORKAZ93CC/pbTrYikaXc=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqZOYJcHCddaM4Ycs5ue+0qxkZQCBHCEMF1NlK SScGLBEaXeJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaamTmAAKCRCLPIo+Aiko 1QzyB/9fUSrBJ7tXabZzoPSyhUByYGbsn2dwnTzGpCkrAjntqwc/Mvda3/QcMsW+TyTExxAMs2M uJn3K30cHJ3NJjol+mvY7nv8c/FVBw+JaAhKVwwyVripMBXYbheLqRTwnliIo00Oxn0Lw0kXZxe 2Gcb2i4YIg0IUhgubc3D4xY1EAS8M1wYZuCFDNuIdykwpshp8qAkQ6GGUD6Vrtdm4tmLA4CM7M/ eY7KoHPqppMk6+nsWgXJ2P61V2eInZvVGs1gPd1Yuh/BbFLf7zmCw3qluHzYcWR0EXJQvpS8VeK hi4FHW4s/frRPcAQmJYOucfohIoY5zf9dG1PzU1M8RcZTCKm X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=e6wLiKp/ c=1 sm=1 tr=0 ts=69a993a3 cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=IoBVowuyLm_M3JZO-XQA:9 a=QEXdDO2ut3YA:10 a=vmgOmaN-Xu0dpDh8OwbV:22 X-Proofpoint-ORIG-GUID: dx1k3fZHjwNTT1Iam2YxnufiESzK3k_I X-Proofpoint-GUID: dx1k3fZHjwNTT1Iam2YxnufiESzK3k_I X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDExNiBTYWx0ZWRfXyu9tL5E59LU8 km2/b4mpDdmXRMVSwLS+FkI731UJ+pTd86FIpemh5hB/yPr3T5tLz14wXHdojI8JJBP/E1Mna0j nPGWi7qIW3vLRBhKqyTb+0VzSS4w1bCFN5l9DiOmQxXL0uJ14tkiWtNiLy8/2vRA/DiJSjyNEwy OVyNz8zIkoPIDpAkbF5/L1nOcRRE0IUcmgVoochRwxRt9XaqS3ed9RhNs2qWTzPaLBW91VOe+kn k5ZYQmlPAdvKog6YbiKD7YQapeM/S1kH55CNnxHxPIyUfV8EvryLY3a4dmjR7d6tXL0B+ggeF2U BLIYHjTJhp3T5RhTOuYNfvtDF66q+E0zRF/QjwdgzUXm0fRxoPR/zzhKJBXZRusJ1vmAvl1PUmQ 4zO2zqYdIW9jxdwoLVIkCstfdG7fB4sG7LNmZqprTH/cqr2kmT7LVBgs0+K1E90/P1D2eW1bstr FnVCgnYv3ys8oarQLPw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_04,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 adultscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050116 From: Jessica Zhang Currently, the DP link training is being done during HPD. Move link training to atomic_enable() in accordance with the atomic_enable() documentation. Link disabling is already done in atomic_post_disable() (as part of the dp_ctrl_off_link_stream() helper). Finally, call the plug/unplug handlers directly in hpd_notify() instead of queueing them in the event thread so that they aren't preempted by other events. Signed-off-by: Jessica Zhang Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index a05144de3b93..e7b1ed5491c4 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -436,11 +436,6 @@ static int msm_dp_display_process_hpd_high(struct msm_= dp_display_private *dp) msm_dp_link_psm_config(dp->link, &dp->panel->link_info, false); =20 msm_dp_link_reset_phy_params_vx_px(dp->link); - rc =3D msm_dp_ctrl_on_link(dp->ctrl); - if (rc) { - DRM_ERROR("failed to complete DP link training\n"); - goto end; - } =20 msm_dp_add_event(dp, EV_USER_NOTIFICATION, true, 0); =20 @@ -1695,6 +1690,11 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *= drm_bridge, force_link_train =3D true; } =20 + rc =3D msm_dp_ctrl_on_link(msm_dp_display->ctrl); + if (rc) + DRM_ERROR("Failed link training (rc=3D%d)\n", rc); + // TODO: schedule drm_connector_set_link_status_property() + msm_dp_display_enable(msm_dp_display, force_link_train); =20 rc =3D msm_dp_display_post_enable(dp); --=20 2.47.3