From nobody Thu Apr 9 23:24:44 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBCBE3A7F51 for ; Thu, 5 Mar 2026 14:30:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772721060; cv=none; b=YE4rj3zp97lSuZ7vywm7e1QVDbbknrt4TR6CxjL74AtLXSREFxq6j4bSzFYs/B2mwZW9h1eXg7CPTpOYhgnvSGj/PhieanTsguXaNUi4Bmqs9HE887Q0fXkRPc663dNtq9KtN8FOYV4KmMvkUACM1jbyyCID6eZAx+n0hf+1xS4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772721060; c=relaxed/simple; bh=OWRdOQlqAgZDHEFjFECShBR1RF+bUr9ZLUwiZwlLTKQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XbKpn3K8n+625xgebMd27I6e7MPTxc7Zot8BHcj8GYKqBE/vRIFzn6CIPXW3U2eBdP6xHIy5HHNgWQLANa1p77wvA2yt/jnYTOUdVJZu/RdbUg6bKlIF9fEbWWtmfwFPLJvKhy0Qn4/KE+TUDV2LgBXtneIWilPeyXRUE9ls3nw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d+e8FkeJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AWiV5eZl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d+e8FkeJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AWiV5eZl" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 625AFfHD2922564 for ; Thu, 5 Mar 2026 14:30:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SKcwhb+xWTwW8lIkUoC+RbFacXz+V1PCsboLX21gXQg=; b=d+e8FkeJ4Y7l/fHE a8Mz499o/9gD4jHBziO8z5hLSXSHsthC8/PC/ELdFX5cuZfnJ/WNaY4v3MzdDGJI E7AWF41HW6qRlXudanQoaeEstRdy0zjzoVKMXBfTtIkGh9LqnrmgxFnkq+KA+wPb P9QNZCd48K7TshI1Rnhbzfk4Fx0V0Fqk7r3HZPKqXopQjYnTwJy4mGYQLoEmvn1a aqgDV/Jke3VRfEQIp+0QOM3M+IlMaATctBjN+RYrJBIKLVS9FmWsQvM1ikGQUSTT M39A2MFUe+nEnOuZ1G6/GZsb15SebGQO6eB/Qt2pYCz8ln1d81euPD3ZkxPE0I+j Llsm5Q== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cq2q81wx6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 05 Mar 2026 14:30:57 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-94dec0ac214so72567658241.3 for ; Thu, 05 Mar 2026 06:30:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772721057; x=1773325857; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SKcwhb+xWTwW8lIkUoC+RbFacXz+V1PCsboLX21gXQg=; b=AWiV5eZlm24d+TUUmc/2sqc3B/yp1jAHHCnwgj7/2t06GVcWCDWV3OTHZmR5Xo48cL HRCgckUTG0U+IKUHHhJTUKpSUO+lpW3l8wV6gXObPbts7L0GbAkLShkkPukMHDhXh8sM wfaPCEwVriSq1yt3OSN9mMjIDtQzsk+CWsqK+Bm+Wl9n1i5V7Xc0NYaPbRIoJtZ7AOPW p8VHz5zW5Bequ+wwVPbV63BRYWUv0p0iCTmWevWcXvhljJirWnvCHzt+w1k2aAxH+M10 5QkhKn/+OjxIil9pCQWYzeugUB7Rd689HnW1xptYroQZ69VSVq/QhEKbNVyb+VrjNRVF 0JwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772721057; x=1773325857; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SKcwhb+xWTwW8lIkUoC+RbFacXz+V1PCsboLX21gXQg=; b=V5IkS/ExaK70+TfmeTwFnqzwleNqIiEXoZO+kYXKgvHXAbZBwAPVdC3whPHtjLgXjP eo5M96+qqrnB7fy3DjEq96uJUeL041EYNfO3nB5MNZ5vadUB3jXlpKNjzflvx+kLoewD Jpl4FFEYJbEjEk8n3/Y7sPEqFcKqvTWc2x7wLx7Z1S7GQvtvTMiOawcnh0sHyMm1N9WV AaEYUwLL8Z/84nRVrkJhqcUb4hcneBiTZeo8DNmWt28rFkCaexr0M7YHrJ5mbbMW+Q+o 1STwuLGzdcK6gzeqD9szLsemJ4Sn4Q7qmRPtIj4islJt0NSAPibNrDMW105WGp56kzeX i3Fw== X-Forwarded-Encrypted: i=1; AJvYcCXQQ6lRyzRSgxo2RYB2xmACZgmPD82IhuWV8jQJsONZUHgqrl8idWBaXbeYYNr7Vg49WdSkMA/ZuJZQ4zY=@vger.kernel.org X-Gm-Message-State: AOJu0YzodZmOq2EcUxkfMqxmc07rBRvpJIZaXiLMwx+28smK72rjq5PZ S8Txy9kxCLB7R4pyhw7Ha5oAs9hGmdkciqTMdsvezV3iNpaObresGeddezHsKJtc7Hb6ZZ8g+9V m6yzgqihWo0ZUBgu06ImYJr81mPyUpw0rH0W+j9NSvXU0HQzuMxhmqvxT56nLs2Gme8g= X-Gm-Gg: ATEYQzy8Qkxel97O6IdfyOhwgcaa2GTmSUpuhbXM7wtdvWMi4kT96lPUFJTKbof4vDi u/+340Zx9sIW8ugAsY3RJOmXW4Al+wg9j/jhs6WE91dtCETjgfm36VOyjYe1QPGNFvflHMCmHWE gs3fWyXeM1USHU0xekCBiDP8J48YOWsEz3OEjbuKWP9qvGQHAolF9zf8AwIezGHC75vxKU/HE1B BKiQTY5hyPnfRDDqIyYPU6R+SQG12i2abEXep+zdP5XuaRKLg61OaxDo4gt0zeaxEpBsp85O72N cMZczTvoFWsYatkYpqCxdZ9kKgfdiKl8of4JZGnNNrUUT/vMUtzBTRJfow44GBExUp+USDBfveR Xv5Cwl2c1K+C9a7RucoaQzts5HZP+8oPPY/dbSDrGQqd5Xdm0NAnESK8Fyn1MpLTZy4FlmwSvMc Fw6E4pD+RczAxlwxRhJPtexpkDMk5CRWIGlEg= X-Received: by 2002:a05:6102:a4a:b0:5ff:24b4:8992 with SMTP id ada2fe7eead31-5ffaac15453mr2837174137.4.1772721056378; Thu, 05 Mar 2026 06:30:56 -0800 (PST) X-Received: by 2002:a05:6102:a4a:b0:5ff:24b4:8992 with SMTP id ada2fe7eead31-5ffaac15453mr2837098137.4.1772721055666; Thu, 05 Mar 2026 06:30:55 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a126fcf563sm1522618e87.27.2026.03.05.06.30.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 06:30:54 -0800 (PST) From: Dmitry Baryshkov Date: Thu, 05 Mar 2026 16:30:45 +0200 Subject: [PATCH v4 3/9] drm/msm/dp: Read DPCD and sink count in bridge detect() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260305-hpd-refactor-v4-3-39c9d1fef321@oss.qualcomm.com> References: <20260305-hpd-refactor-v4-0-39c9d1fef321@oss.qualcomm.com> In-Reply-To: <20260305-hpd-refactor-v4-0-39c9d1fef321@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4422; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=Fflo70A3oSMP6LkHXNPuDEYg6XV8ot0GBkcmgzq2Sd4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpqZOY4EH5tOhJuNNlBqaGXMfWD0qmfHcWOb8Md OAljlFsck2JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaamTmAAKCRCLPIo+Aiko 1e3yB/9nmGw5lKskzi+7opE88tsBJ84JNH2uon89P31MsY0o31gm0avvv1hfvFUXX81kgUc/oSb 6LcX61PL5oNi0P6+CAoFWXb0iil+kzezIZm+jg0L/P5sOtoM0rNbyJqBkfBpxsUCdL7Td4WKCOp bhbpOmRinO25ahqKRWhbTLSnEAZScQ9jtTXHjAQvllfkR3j7xuHei6aGxVDGfEd6hVyjiRRn8TZ yxlOy76d2Tp/4bjjSzwso/BSkXfQF2JhAM034ZytvqRf/GPyn8SwBhMdVPxfBplYYSfs47nd5yq 56f9yujtCWga1EMW+Bs7dqBRoMb+Uomq0PcoqC0cSrmAvidy X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: r7bhd3z2uRZwfmX8z6B5_DQYWpw1in4E X-Proofpoint-ORIG-GUID: r7bhd3z2uRZwfmX8z6B5_DQYWpw1in4E X-Authority-Analysis: v=2.4 cv=GecaXAXL c=1 sm=1 tr=0 ts=69a993a1 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=jcEwYMPARZwhhGfK5pwA:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA1MDExNiBTYWx0ZWRfXz3wNV/W2tndJ z5ZoDWlTxGSJasiTtturuUzmyEqH6ldDIyPlM2Xazb4KkOgPui7mFvwmOx9SdwD+apEKZopUndA Ewz09fC9PRCHZggJKrpOSwme/Ig9e63aJS3qBkabZd0VGzdqSEtJVRdqa2cBWtK42Qcz/4Pyxj1 Z8s9PmN2524JTrok36K3zyamoio+JNmwlZFVg93705czMTAn1Da5bQ1HF/bPdZAHOiZ5YUoBsS/ 6lzRfcmCHQfkL9Gv4G6RHFQTRB1jvkKajTT3+MC+BVQ6BARc26ZCkeW7sivnVVsp5PvEyxWFU27 5yJfuKM7NcS53tLT3NIixX8Mn0FA0xRslGYP2yhlBxlr+3PnTvl5SqcISn4KYgSfpLiZQsdl5QU rv2bbcV1DS9XQZLQRQDocX9joYkasxlebbGYMShG0zqGtcCTPK9GpiMt3uJXmA+p41oiM8f+IvP xBhA6XItPHlpoweqXJQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-05_04,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 impostorscore=0 spamscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603050116 From: Jessica Zhang Instead of relying on the link_ready flag to specify if DP is connected, read the DPCD bits and get the sink count to accurately detect if DP is connected. Signed-off-by: Jessica Zhang Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 60 +++++++++++++++++++++++++++++++++= ++++ drivers/gpu/drm/msm/dp/dp_drm.c | 20 ------------- drivers/gpu/drm/msm/dp/dp_drm.h | 2 ++ 3 files changed, 62 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 5997cd28ba11..a05144de3b93 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -1151,6 +1151,66 @@ static int msm_dp_hpd_event_thread_start(struct msm_= dp_display_private *msm_dp_p return 0; } =20 +/** + * msm_dp_bridge_detect - callback to determine if connector is connected + * @bridge: Pointer to drm bridge structure + * @connector: Pointer to drm connector structure + * Returns: Bridge's 'is connected' status + */ +enum drm_connector_status msm_dp_bridge_detect(struct drm_bridge *bridge, + struct drm_connector *connector) +{ + struct msm_dp_bridge *msm_dp_bridge =3D to_dp_bridge(bridge); + struct msm_dp *dp =3D msm_dp_bridge->msm_dp_display; + struct msm_dp_display_private *priv; + int ret =3D 0; + int status =3D connector_status_disconnected; + u8 dpcd[DP_RECEIVER_CAP_SIZE]; + struct drm_dp_desc desc; + + dp =3D to_dp_bridge(bridge)->msm_dp_display; + + priv =3D container_of(dp, struct msm_dp_display_private, msm_dp_display); + + if (!dp->link_ready) + return status; + + msm_dp_aux_enable_xfers(priv->aux, true); + + ret =3D pm_runtime_resume_and_get(&dp->pdev->dev); + if (ret) { + DRM_ERROR("failed to pm_runtime_resume\n"); + msm_dp_aux_enable_xfers(priv->aux, false); + return status; + } + + ret =3D msm_dp_aux_is_link_connected(priv->aux); + if (dp->internal_hpd && !ret) + goto end; + + ret =3D drm_dp_read_dpcd_caps(priv->aux, dpcd); + if (ret) + goto end; + + ret =3D drm_dp_read_desc(priv->aux, &desc, drm_dp_is_branch(dpcd)); + if (ret) + goto end; + + status =3D connector_status_connected; + if (drm_dp_read_sink_count_cap(connector, dpcd, &desc)) { + int sink_count =3D drm_dp_read_sink_count(priv->aux); + + drm_dbg_dp(dp->drm_dev, "sink_count =3D %d\n", sink_count); + + if (sink_count <=3D 0) + status =3D connector_status_disconnected; + } + +end: + pm_runtime_put_sync(&dp->pdev->dev); + return status; +} + static irqreturn_t msm_dp_display_irq_handler(int irq, void *dev_id) { struct msm_dp_display_private *dp =3D dev_id; diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_dr= m.c index fd6443d2b6ce..e4622c85fb66 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/msm/dp/dp_drm.c @@ -15,26 +15,6 @@ #include "dp_audio.h" #include "dp_drm.h" =20 -/** - * msm_dp_bridge_detect - callback to determine if connector is connected - * @bridge: Pointer to drm bridge structure - * @connector: Pointer to drm connector structure - * Returns: Bridge's 'is connected' status - */ -static enum drm_connector_status -msm_dp_bridge_detect(struct drm_bridge *bridge, struct drm_connector *conn= ector) -{ - struct msm_dp *dp; - - dp =3D to_dp_bridge(bridge)->msm_dp_display; - - drm_dbg_dp(dp->drm_dev, "link_ready =3D %s\n", - str_true_false(dp->link_ready)); - - return (dp->link_ready) ? connector_status_connected : - connector_status_disconnected; -} - static int msm_dp_bridge_atomic_check(struct drm_bridge *bridge, struct drm_bridge_state *bridge_state, struct drm_crtc_state *crtc_state, diff --git a/drivers/gpu/drm/msm/dp/dp_drm.h b/drivers/gpu/drm/msm/dp/dp_dr= m.h index 9eb3431dd93a..6c0426803d78 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.h +++ b/drivers/gpu/drm/msm/dp/dp_drm.h @@ -25,6 +25,8 @@ int msm_dp_bridge_init(struct msm_dp *msm_dp_display, str= uct drm_device *dev, struct drm_encoder *encoder, bool yuv_supported); =20 +enum drm_connector_status msm_dp_bridge_detect(struct drm_bridge *bridge, + struct drm_connector *connector); void msm_dp_bridge_atomic_enable(struct drm_bridge *drm_bridge, struct drm_atomic_state *state); void msm_dp_bridge_atomic_disable(struct drm_bridge *drm_bridge, --=20 2.47.3