From nobody Mon Apr 13 15:11:14 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11BBA2C0F91 for ; Fri, 6 Mar 2026 03:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772766878; cv=none; b=shhS4GcRHy2b3hoE/JBUTWfHngDFnBytsUP7lGSABO46mzG91ca4Gl2vb735f/JIPKuLN2s1M5g/2dqGh0zLZAD92dYtKLtSzec95ctzQddepdtlwToRSbnzbfQjvFHlksk4mlkZJ3rHZSlGCjrsCTcaMyeJRKQxjUt43oF+SfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772766878; c=relaxed/simple; bh=fRY6995pDVPrsgfEGntNtqtKE5aYXYzxVYUkdV2LGjE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Gd7iI2ZegNnpFmZU5Se9ZjgC0GjGbkUVpObQi8i55kQwAi1tIqH85KFfd2C0VhEat5RjZzqTDOo6O3ZLJoyqbqYWqxOfAP9viB5X4Qnxy8voMBtWVNfq6/CIEovfpC95hha/nqQ2TG+59bxPSysvniXay8Hkz8zGC/3sXElvNVs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=g6jIU8Tl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J4pmI3LA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="g6jIU8Tl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J4pmI3LA" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 625Kn7XT3139825 for ; Fri, 6 Mar 2026 03:14:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CUND/+KqgfCDxCvWEudnxvEruQxwolLqNyciLlg2IxM=; b=g6jIU8TlIm1p2Qvi GgfnDeEVztMj15DAlvJmKQvqvX+MNv4CXRsJkPtflr9mxZ0TiybM9PrScwuyJw7K LPQNl8R/4tMkzjOWmtxNQGEe72/9DTRmXILpVJIPim3G0nd/zyXtibM1wVXLOq1N dC+TXTnKK7HmCPa+2OCsSdygh0ZJgTJj07Ri+eBWDBhymEJ51MnsbQrJ8bgkIQPg JN0OW5tEU9pTaQHub+mk43lu92ptX6bfKYryilHX0OVHdwWIiBjntmX92bJJwCrV UqN0dRLjoOWF4hmZILHk8Q2oJxqyB1yNmKFpYnwFUYSA99CCfrSERQwRb+JOKKpv GcYHMg== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cq1pk4bpt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 03:14:35 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-2be27d4e3e5so13389605eec.1 for ; Thu, 05 Mar 2026 19:14:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772766857; x=1773371657; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CUND/+KqgfCDxCvWEudnxvEruQxwolLqNyciLlg2IxM=; b=J4pmI3LAvEEDhoL8lgKeAZ1McH95w/czXWY/Fwc8zK2cIYvm4sR7Agy/hadTP9OF8k ocN/f+Meo7MDwd8ZCPpEMBs2+lJnYs2VPXSyy+1M86devHe8KI39jW+Ais1xCqeen4zC 2wr0wTRN4C0T/U5ETUbwO7wq5vqCu9TwYGpPUquOqASws0kzDwNFxhUajApGPAjJaamK jAklAYFCp6Mc/VB5p8aB4JkOUBBzRf6aGwdYKD7kwdQKtQBIexJX4jnbuloaRFPn9X5A Na0J5EZY8nrdnho2fbTNnOrhqLEzqdVJHnwl8SsZA5yU5ukuMIxvueBNJX1jtes8wlTI XVMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772766857; x=1773371657; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CUND/+KqgfCDxCvWEudnxvEruQxwolLqNyciLlg2IxM=; b=ipKxaROJQ6AhV69qM8UqE6gdoRQ/xtj18m7C+I8J449lfHna/UnGFl8T2H3pJXkZJ7 bPO/uTWd5quAU6a7ew6OgKRS4XmOO3vcUGmKP/fT5mUXrhXB9jQC+ov2gD0CaQJ4SjA6 Xty8ZmRA2x1R70g4ZNyAaip5t3F82CdwVflT6xs+JzLj5KbTnJ4iq9FeZAVWZ6vGfWrk 9nfpsjlPrNLyOt4otEPY1z/jWwmCaKPApR07IFMeyv59hmSosyWj8vS013E9cOOEPz/H J+w/KwZXvibhENKk+epqRzcwll7m0UJllwjnMTsVbHL/cF8BcJn7hbtCUh+mraCMBxs4 I1jA== X-Forwarded-Encrypted: i=1; AJvYcCXET6n/Ro8tcru1q44OdMhKNsUBRkRYvRccFO5pZ+w9jZ952NNNqiFaqRquIxaqaLylL8VpRPtOoHdEPNw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxqz7SzrtTXj/KLfA+gjgs5ku1OmtxOLtTMz/VW9ZMOhiTiY4AP lEpWgw3E7/IxUb2wdqeFjP5f8Db1S9ska4FRdLscINJJxHnUc6dI09xw4nY5Zg0+TfOk8WUU+lU pTiMCOinFAfrpXjzti/R2+apFtzY1ypiupCPc07klTQbeCKxS2gAeZSHDm09ePitsEYZx4DUknA == X-Gm-Gg: ATEYQzwE/sstJKXHZYg3TJ3pxKcwcPokFbI/+0s0TB2LcVB9DKxTMzrWzbqakiBxwm9 NXRPVhpDhM10RFrA/0KQcJcBs7Q9lgFjAw2oGZfmCLzZPQGb7IDReIBfizdPUvjy1J3QRlj/wtG 6ND7+5Y4AZ4U9qwc3v+lSUSGOa40o7RtPnJjc/RxCx+pwPSY1KML927nBQ6J4bAjfDlyRQIwZi+ Y8Ef31ChG6mBk9QpWR19PDp668y+XU4WbXWrma0Yw1Brd/SWcq9yApWIoYVVBMQjSyFHcx1Aoyg Bpe4wd06YM2ujjes1F2LK8sW65+1tbox0+L9wlwGtGN8JDite4kYUKD1aFIoc+3RdQFZdjFzmMS trEgAKM6TZ9Yh+QAfFe91oH5P3JfdXEVTwZuB5DpTGs432JWf/3fiDD0JPGBiBezYigMN/mUa0w == X-Received: by 2002:a05:7300:3724:b0:2be:126c:e335 with SMTP id 5a478bee46e88-2be4de98aa4mr303403eec.10.1772766856718; Thu, 05 Mar 2026 19:14:16 -0800 (PST) X-Received: by 2002:a05:7300:3724:b0:2be:126c:e335 with SMTP id 5a478bee46e88-2be4de98aa4mr303389eec.10.1772766856074; Thu, 05 Mar 2026 19:14:16 -0800 (PST) Received: from hu-fruiz-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be4f82b1d3sm197839eec.11.2026.03.05.19.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2026 19:14:15 -0800 (PST) From: Francisco Munoz Ruiz Date: Thu, 05 Mar 2026 19:12:06 -0800 Subject: [PATCH 2/2] soc: qcom: llcc: Use guards for mutex handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260305-external_llcc_changes1set-v1-2-6347e52e648e@oss.qualcomm.com> References: <20260305-external_llcc_changes1set-v1-0-6347e52e648e@oss.qualcomm.com> In-Reply-To: <20260305-external_llcc_changes1set-v1-0-6347e52e648e@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Francisco Munoz Ruiz , Unnathi Chalicheemala , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772766853; l=2371; i=francisco.ruiz@oss.qualcomm.com; s=20260305; h=from:subject:message-id; bh=yd2tvj1vkEgWnWkgYzbTmmIfhhcbMrW8XBX8Xkv+080=; b=bpib13fbS79o02D0uzDtPYSent/2VfnH2Z0lLgkk1jUglgdpju+rZNdXMXdBgrUNjxgvnQJQw 3xmfJiyo0DDAf6rgHE9mqmk07pBiVS7lH87/eduPKuOtKrsuXt+GHBd X-Developer-Key: i=francisco.ruiz@oss.qualcomm.com; a=ed25519; pk=Gcv2CX7iHozjnQ4oK+9fINmBiQTmVC4SpaZzoM63CHE= X-Proofpoint-ORIG-GUID: Rlackv8AlzUO2DbaXSay3jqmDlc_7smT X-Authority-Analysis: v=2.4 cv=Gu9PO01C c=1 sm=1 tr=0 ts=69aa469b cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=VvdJ20gCDTMsAWRwTQIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-GUID: Rlackv8AlzUO2DbaXSay3jqmDlc_7smT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDAyOSBTYWx0ZWRfX9RtY1T1eBPnF HCxNaPXzH+MoRY0TmQLgkF+vI2rz9bO02SOvtckebQd/qWZFAtB5BpEaUHqxt5HhhwlS8FrY1Ue xotmgbFSfaht2JhiPt/QUTSnvHoretHpAjEmFq9aasjCsg1hcepKCotqLDuLqjlXIq9eJfqtpB9 fSgkiXVZe72zXJuA3hYgB2pGthV65u8ra9xqVljhrNRabrRSb45cIEv5wodkzzl87sw2MqubMry WzYPLqnWcgYy5ESAPlSp0hsuh+VYunWgHAoCgiDuAHad7OjjLjUZ7lHU6Ch1IELLSjASnBuU8Q7 mBm8QV/tnhy0yeiqhpIPVU3lTpBIosE7NFiO6UqtkbIB6B+EPlE+ioeZNcF9PnqeU7V/OEoKAbT qlWNMcwnD8Yd9PWbQffobjmlMxUlGfD4xGJ6nsvFdeWPnoK/lKFhNGpzGeoosP0rQrzFYp6U/zZ wXseY/iXIgGY05BspWg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_01,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 adultscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060029 From: Unnathi Chalicheemala Replacing manual lock/unlock pairs with guard() removes the need to think about unlocking entirely and keeps the function trivially structured. Signed-off-by: Unnathi Chalicheemala Signed-off-by: Francisco Munoz Ruiz Reviewed-by: Konrad Dybcio --- drivers/soc/qcom/llcc-qcom.c | 28 ++++++++-------------------- 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index 2e7f05df93a6..f859d91460c6 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -4531,27 +4531,21 @@ int llcc_slice_activate(struct llcc_slice_desc *des= c) if (IS_ERR_OR_NULL(desc)) return -EINVAL; =20 - mutex_lock(&drv_data->lock); + guard(mutex)(&drv_data->lock); /* Already active; try to take another reference. */ - if (refcount_inc_not_zero(&desc->refcount)) { - mutex_unlock(&drv_data->lock); + if (refcount_inc_not_zero(&desc->refcount)) return 0; - } =20 act_ctrl_val =3D ACT_CTRL_OPCODE_ACTIVATE << ACT_CTRL_OPCODE_SHIFT; - ret =3D llcc_update_act_ctrl(desc->slice_id, act_ctrl_val, DEACTIVATE); - if (ret) { - mutex_unlock(&drv_data->lock); + if (ret) return ret; - } =20 /* Set first reference */ refcount_set(&desc->refcount, 1); - mutex_unlock(&drv_data->lock); =20 - return ret; + return 0; } EXPORT_SYMBOL_GPL(llcc_slice_activate); =20 @@ -4573,27 +4567,21 @@ int llcc_slice_deactivate(struct llcc_slice_desc *d= esc) if (IS_ERR_OR_NULL(desc)) return -EINVAL; =20 - mutex_lock(&drv_data->lock); + guard(mutex)(&drv_data->lock); /* refcount > 1, drop one ref and we=E2=80=99re done. */ - if (refcount_dec_not_one(&desc->refcount)) { - mutex_unlock(&drv_data->lock); + if (refcount_dec_not_one(&desc->refcount)) return 0; - } =20 act_ctrl_val =3D ACT_CTRL_OPCODE_DEACTIVATE << ACT_CTRL_OPCODE_SHIFT; - ret =3D llcc_update_act_ctrl(desc->slice_id, act_ctrl_val, ACTIVATE); - if (ret) { - mutex_unlock(&drv_data->lock); + if (ret) return ret; - } =20 /* Finalize: atomically transition 1 -> 0 */ WARN_ON_ONCE(!refcount_dec_if_one(&desc->refcount)); - mutex_unlock(&drv_data->lock); =20 - return ret; + return 0; } EXPORT_SYMBOL_GPL(llcc_slice_deactivate); =20 --=20 2.34.1