From nobody Thu Mar 19 05:42:59 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D8103A5E6D; Thu, 5 Mar 2026 14:21:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772720492; cv=pass; b=MXBEsPDiFzEhrAEesJQxVmyne5ZSS1nLHA8TmqW8nyfP8f5EPWJl45Q7KEI+HiEPlFt/lULwpy2/BUFTAY5jWYkjAw9368AtUhblyyJUwYweww7r4UxosCZzTKd0IAJFDNM22Q1JkbqZOkcp9L0UOx1Qxi3fGCkInodlL/KxnJ8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772720492; c=relaxed/simple; bh=aW/8wxf6GSCwSoAdLLm4VVrkJB+GX5eYAqXLDnJ+qug=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rMTP1+8PDAatC6+dZcxj4Mc8UdL3q5qqF7GXxfuCBU1qHU7G+BcyyZovU1ytM3k0TbQcbOy3orWF5/C1N6H7kG1LQZOEVnRD493rG83qbNJA0MgF0R6bEDwntlYpGfHS9/l/mb8nFzT4IdiB/VZjzNG3ePAyVm/Nr048RZxQpFo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=XbFmM42A; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="XbFmM42A" ARC-Seal: i=1; a=rsa-sha256; t=1772720449; cv=none; d=zohomail.com; s=zohoarc; b=ijDml14lo492Mf0+Chxx3jnIJQoJMvAdGqd+C1bW/hPBMP27P6wZ7yqxJBTqZ76oekMW4Y+R3JAplSAVDRG4dkuMxevZpGqqJrl2hknfa6g6MFtQ/g8nGBxX8NU7xv9i8N4yi9kJRP0hTpwrPpI6RXpMm1z+wA47WS3R0A8im/M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772720449; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=W2PmvOIerNEdbC3Szyeshb/aQVEy280CVGxOVUPEVFQ=; b=lPfBjttf6vdzcbOrQm9lTZLpb+oOR7SvyxXTDvlfu54uHahJyNXbriZNqEtR9Yc23eBID/rzLM18ok0K0Zi+AhW2Hy91cSUl/zzDVFhvJrHR7R+9ETgca95gSlp8PUcvzrAo4i/gs2IXyAirUfBkuMm6W1ISTOSbg8/bA9PohhM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1772720449; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=W2PmvOIerNEdbC3Szyeshb/aQVEy280CVGxOVUPEVFQ=; b=XbFmM42A8LOByNoD6RYIKspQWuBtfEwkwLzGwNsWSG6qzHpEKxMhoIcFu61Ed1Ui cSNSOIge67da3xi9sBOTm8O/iotoSKpRt6zvBI5vgkT8SXN207/+vJqNqdIGDwJUmdv 4zfWWvvy4WuO1IhaiGKZDxzrDlqxQP0YHOf5EBxk= Received: by mx.zohomail.com with SMTPS id 1772720447959152.31514523383407; Thu, 5 Mar 2026 06:20:47 -0800 (PST) From: Nicolas Frattaroli Date: Thu, 05 Mar 2026 15:19:32 +0100 Subject: [PATCH v10 06/22] drm/display: hdmi-state-helper: Act on color format DRM property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260305-color-format-v10-6-a58c68a11868@collabora.com> References: <20260305-color-format-v10-0-a58c68a11868@collabora.com> In-Reply-To: <20260305-color-format-v10-0-a58c68a11868@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 With the introduction of the "color format" DRM property, which allows userspace to request a specific color format, the HDMI state helper should implement this. Implement it by translating the requested drm_connector_color_format to a drm_output_color_format enum value as per the logic HDMI should use for this: Auto is translated to RGB, and a fallback to YUV420 is only performed if the original color format was auto. Signed-off-by: Nicolas Frattaroli Reviewed-by: Maxime Ripard --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 31 +++++++++++++++++++++= ++++ 1 file changed, 31 insertions(+) diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/= drm/display/drm_hdmi_state_helper.c index a0d88701d236..954f8b2973fc 100644 --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c @@ -670,8 +670,39 @@ hdmi_compute_config(const struct drm_connector *connec= tor, unsigned int max_bpc =3D clamp_t(unsigned int, conn_state->max_bpc, 8, connector->max_bpc); + enum drm_output_color_format fmt; int ret; =20 + if (conn_state->color_format !=3D DRM_CONNECTOR_COLOR_FORMAT_AUTO) { + switch (conn_state->color_format) { + case DRM_CONNECTOR_COLOR_FORMAT_AUTO: + drm_warn(connector->dev, "AUTO format in non-AUTO path.\n"); + fallthrough; + case DRM_CONNECTOR_COLOR_FORMAT_RGB444: + fmt =3D DRM_OUTPUT_COLOR_FORMAT_RGB444; + break; + case DRM_CONNECTOR_COLOR_FORMAT_YCBCR444: + fmt =3D DRM_OUTPUT_COLOR_FORMAT_YCBCR444; + break; + case DRM_CONNECTOR_COLOR_FORMAT_YCBCR422: + fmt =3D DRM_OUTPUT_COLOR_FORMAT_YCBCR422; + break; + case DRM_CONNECTOR_COLOR_FORMAT_YCBCR420: + fmt =3D DRM_OUTPUT_COLOR_FORMAT_YCBCR420; + break; + default: + drm_dbg_kms(connector->dev, "HDMI does not support color format '%d'.\n= ", + conn_state->color_format); + return -EINVAL; + } + + return hdmi_compute_format_bpc(connector, conn_state, mode, max_bpc, fmt= ); + } + + /* + * For %DRM_CONNECTOR_COLOR_FORMAT_AUTO, try RGB first, and fall back + * to the less bandwidth-intensive YCBCR420 if RGB fails. + */ ret =3D hdmi_compute_format_bpc(connector, conn_state, mode, max_bpc, DRM_OUTPUT_COLOR_FORMAT_RGB444); if (ret) { --=20 2.53.0