From nobody Fri Apr 10 01:01:17 2026 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66C3C26E702 for ; Thu, 5 Mar 2026 03:34:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772681655; cv=none; b=bHDjn8QueuNePLYHtk2CSzIyT0WxL+5M75lc/MyO2JMLZ2ELjTJ5TNpd6U3BO1ed4ljLq7LHhRBgN5qd9eBD4718cC6RuqMxEROGDG+Nrwmh7l+9EjQT41ayerLAM/c0wKv7TekQUNZQAHtX8KhlIw0923oLIUr/iXHXraBmNNA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772681655; c=relaxed/simple; bh=3cQd24z258zjc20dy6ohb0HVeZL+LfFrMaR3/kR1p5Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Vx3Ku19dW+Tfn1WNrzpkMqKkwq1wbd+usIV2OS7MN6TUKm/RtEobdEBjCDxKfZCBXO70gPGEVxii9+V9m2mi5WoiPbrNCSzkRiBpzFTeGZIjmBYzLoSKzls+++AlWfGTr2CZQTbT+60zliedIhv3eGkqV7YBYseu88ODkDgwowg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SidjP6Bj; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SidjP6Bj" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-5069df1dea8so62144951cf.1 for ; Wed, 04 Mar 2026 19:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772681653; x=1773286453; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2d5yl02iJv/wkdm4hWnCdO+qs5aDrcJeSjvUW0fTJuE=; b=SidjP6Bj1PVb3X7Yjw+MI6l8teBl3jhBlDLyZuGxFtfUg7WFxijpnenVz19Qu1nQLX eBrVlTNn4oEpkPnaMyt5Lv8xmcZ3xmjgqNOiyyJovd/YcxxJZv3iNZnqKTi0+UJSXjzy ATKUsOyfK02qOUX7ZrBT3GsjrBVJ3wcy7JvZNGrCc6A/xIrmYdUA6ml/8eTKBRSGMfJ3 onkEWzLMUAxnH8mll9PP69MFHxsQFfVbXgDfGpqWjG1RTqHaxy7OhqTEjLNSHcMashaf NkbQClKluWQ3zMw3+J2V1lA+57uk46CyZD/ZyORfWr6d/C3VyoC2lCBlyNRlqyh74lHC 9rTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772681653; x=1773286453; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2d5yl02iJv/wkdm4hWnCdO+qs5aDrcJeSjvUW0fTJuE=; b=F/2FOqmVWCyDEFm22XV+QYcUl3iYP+0xqhShU5Mk+Y0zXem2YpqiTrCvnlOnHcGjeU WGI2Cz3LUKGkzE3jdP2nAbJBW0mGtwJPPZsE3FQJnO+rZP2jwnXqJakoUGfT3Y+fyOSq ibnrIvCI60hssDLOQoe+UlL/rKJH1ELwij37paZuPaofxSdIMx3dyv+ImJl3VZquevZv Gp9bD7Fxq465bqUYVpMQKdEFruqF2LQ4q2brm+46LlkLMOrJXU+7IAwYOVN8pM7CTKSL SuML6+UcFdeWqBh6S6OoEroXKdVzRk/CO7JodA+Bq8rDpwDdtoIiqYIPbfN9JawSGpgC mkYw== X-Forwarded-Encrypted: i=1; AJvYcCXq1dBrZkmr1638zcxN5ckK7hlcXpne9kTvHiSYMUffDppiUStlgbWJnxhPfT5UfZl5g5pcPHyk+ELA+qA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2PL+ZygkrvVb35Fh4QygCzas7vowPBZv31omNVeIPh0sSV29h f80QQLVZ1XLBtxTHyg2l9VsfgtQvaGvGYC0zV6TKFrjOk9jbCTcQ2WZ3 X-Gm-Gg: ATEYQzy3Z6B2gHdZl529qOMHKjrLijBSnTheEibLiM+37z44wlaNpSjd3Bd0AqgAu6V Kn2s4zhu3rLxDioaYyNkYo8eI1cpjcS2TiD8qY7ES889UUckXUnVlaR9KgDJlL/uEa+YJlIT3CB NMeUPWCAdhnlOIOhJQwk+9RhuPG6xcXcecLBXFXtcEemHiF0M0RMB6Zbi3j1SMifK8XO1ILO/MS 4Qm9Pvpcva0oZhTSETxrpZPWBC5T8TI2ZwW3gwKorbIug/9RSxpjo2MMmcc2kVp8k9ZheXre7+M zSHgmyAPVls034jh7RCSJ8q9zpfBYvEcr1gyD5cl2oel/+y4to8INt13ctKEoKlA7pibfRFLzGs Ull9R7I6lNKCzLproTwDQvHhGsJPMa/xPI0Z3gN1a98LxM7VuyPWDRsZojNGFgwNQC+qZu3WXMB 669SpAXWAQ1YRRBZ7H0W2tOU3WirE= X-Received: by 2002:ac8:5a0c:0:b0:501:4b10:aa9e with SMTP id d75a77b69052e-508db2a632bmr59254511cf.13.1772681653433; Wed, 04 Mar 2026 19:34:13 -0800 (PST) Received: from [172.17.0.2] ([134.128.219.200]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-507449630b6sm190667601cf.7.2026.03.04.19.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 19:34:13 -0800 (PST) From: Yuanshen Cao Date: Thu, 05 Mar 2026 03:34:08 +0000 Subject: [PATCH v2 2/2] pmdomain: sunxi: Add support for A733 to Allwinner PCK600 driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260305-b4-pck600-a733-v2-2-ba6bbed7d253@gmail.com> References: <20260305-b4-pck600-a733-v2-0-ba6bbed7d253@gmail.com> In-Reply-To: <20260305-b4-pck600-a733-v2-0-ba6bbed7d253@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Ulf Hansson Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Yuanshen Cao X-Mailer: b4 0.14.3 The Allwinner A733 PCK600, similar to A523 PCK600, is likely a customized version of ARM PCK-600 power controller. It shares the same BSP driver with A523. According to the BSP provided by Radxa, unlike A523, it doesn't require reset, as well as a different pair of delay values. Make reset optional in the sunxi pck600 driver and add support for A733. Signed-off-by: Yuanshen Cao Acked-by: Jernej Skrabec Reviewed-by: Chen-Yu Tsai # matched against BSP driver --- drivers/pmdomain/sunxi/sun55i-pck600.c | 35 ++++++++++++++++++++++++++++++= ---- 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/drivers/pmdomain/sunxi/sun55i-pck600.c b/drivers/pmdomain/sunx= i/sun55i-pck600.c index c7ab51514531..1d47bbd35ced 100644 --- a/drivers/pmdomain/sunxi/sun55i-pck600.c +++ b/drivers/pmdomain/sunxi/sun55i-pck600.c @@ -52,6 +52,7 @@ struct sunxi_pck600_desc { u32 logic_power_switch0_delay; u32 logic_power_switch1_delay; u32 off2on_delay; + bool has_rst_clk; }; =20 struct sunxi_pck600_pd { @@ -151,9 +152,11 @@ static int sunxi_pck600_probe(struct platform_device *= pdev) if (IS_ERR(base)) return PTR_ERR(base); =20 - rst =3D devm_reset_control_get_exclusive_released(dev, NULL); - if (IS_ERR(rst)) - return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n"); + if (desc->has_rst_clk) { + rst =3D devm_reset_control_get_exclusive_released(dev, NULL); + if (IS_ERR(rst)) + return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n"= ); + } =20 clk =3D devm_clk_get_enabled(dev, NULL); if (IS_ERR(clk)) @@ -206,7 +209,27 @@ static const struct sunxi_pck600_desc sun55i_a523_pck6= 00_desc =3D { .device_ctrl1_delay =3D 0xffff, .logic_power_switch0_delay =3D 0x8080808, .logic_power_switch1_delay =3D 0x808, - .off2on_delay =3D 0x8 + .off2on_delay =3D 0x8, + .has_rst_clk =3D true, +}; + +static const char * const sun60i_a733_pck600_pd_names[] =3D { + "VI", "DE_SYS", "VE_DEC", "VE_ENC", "NPU", + "GPU_TOP", "GPU_CORE", "PCIE", "USB2", "VO", "VO1" +}; + +static const struct sunxi_pck600_desc sun60i_a733_pck600_desc =3D { + .pd_names =3D sun60i_a733_pck600_pd_names, + .num_domains =3D ARRAY_SIZE(sun60i_a733_pck600_pd_names), + .logic_power_switch0_delay_offset =3D 0xc00, + .logic_power_switch1_delay_offset =3D 0xc04, + .off2on_delay_offset =3D 0xc10, + .device_ctrl0_delay =3D 0x1f1f1f, + .device_ctrl1_delay =3D 0x1f1f, + .logic_power_switch0_delay =3D 0x8080808, + .logic_power_switch1_delay =3D 0x808, + .off2on_delay =3D 0x8, + .has_rst_clk =3D false, }; =20 static const struct of_device_id sunxi_pck600_of_match[] =3D { @@ -214,6 +237,10 @@ static const struct of_device_id sunxi_pck600_of_match= [] =3D { .compatible =3D "allwinner,sun55i-a523-pck-600", .data =3D &sun55i_a523_pck600_desc, }, + { + .compatible =3D "allwinner,sun60i-a733-pck-600", + .data =3D &sun60i_a733_pck600_desc, + }, {} }; MODULE_DEVICE_TABLE(of, sunxi_pck600_of_match); --=20 2.53.0