From nobody Sun Apr 12 08:42:07 2026 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3B7E37267B for ; Wed, 4 Mar 2026 21:20:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772659244; cv=none; b=XP2iKP0Ko2OLEltvGNZHCC6kaNDLcrgGxY/S0PavJreyqaec32OAoWsrB9BOmfD6FLdVDQISNFeFGZ2S7mWKhbupmt2i10fJOoPbAgZx7qVb/afqDcGcBbDtH0i031KpDIsL7TD3e2AD+UtcO2VscJ4wOv0aG12+MFWCv4On+XM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772659244; c=relaxed/simple; bh=6R8PrkFcQOCkIy4N2WzayI9dh6LczXsY2dRZzlQ20Ac=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FDthm/ghoNgPQijvd9mcWlshglgOqbCT2rCNrMJmAsh9Z4f11IYJFc/zXieZqGvDGuDTZ7KN87tvnK3cJExquCmmD3MEp4FYSVl9EHo6bKtYPgaagJeYg3ltWru78N9cVDqsQAMQ+Nki/AGWkbrSakHtqG0uqChkRiepp9+IbXw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sobrie.be; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YhTgeb/D; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sobrie.be Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YhTgeb/D" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-b9359c0ec47so796168666b.0 for ; Wed, 04 Mar 2026 13:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772659241; x=1773264041; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=A6fnLdIBwuzKkIFXrEW2ZKLeYt2tdG7l6PDBWXCSAU8=; b=YhTgeb/DZlu6PqJLI7pFECxTMaczmWreCEUxtUqjBRh7JBxrDYSsfAnO24FptkUQKG eOI134xYI+YVXiy/0SkkTb8/UJF5iiW5XAVHno90phWN+f8AJf5kMVzqzYS49EIsiJHB vbZ2a7qoVATfME9j4jVhXbw0BtLgJovYM7eMxFEzrWzohHrxsqZwfGRUEcV43Y2MWUAK jEIxPP7qLgJbLsFSVZrNHifyr2UhEE1ttPdNKNYdydc6G+aZJfSGECBsIlC/VCdZv1i0 2mmSw/ELoMw8OjrL5BXdjRQnE8r8I0rzzzOuMUE4bGpK3h2kwXAvdkWi8hZ1n858DQXP ViWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772659241; x=1773264041; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A6fnLdIBwuzKkIFXrEW2ZKLeYt2tdG7l6PDBWXCSAU8=; b=j5LwkejfOqalShP77eeeTSht59KtonOVCObWkjmjHsVIDo4NTQKg0FHFYa9Cw6BgEU doJnhgPaUfIXRAWA05I5W8PBpC3cudPYLQ4HgTYL+A07j/PSHnIaqXzWR8EKaQ3T8dN2 fJipd1wnS+m6+KFnl0rRrKD/xbVKsfhJdUl0iSvmYTo1raOdqa57/JcgdqS4ndEKO4ek ZaqhLhKVWvB5b+RedORFrVLUrSYAIIhKnP/IVQDTjN6WPSX8YYGF1iYTU8HdQeIV8uXY C2C7viQs5Son8LKnarkWPs5imiZnZMLSaTQ/OOMMMk+HAvOltl6XtMBPO8Hrva1czZf/ E89w== X-Forwarded-Encrypted: i=1; AJvYcCW310Xi1/1L4nwjE7FWClhLwjvXISm7JeUMVzOQ8CEERBTdWhCm77c/VuZGHr/rw0iQhNuXZ3cfcj6d05g=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx2hOtpCxXWasTr9sbSYb7TL0zrcx7Ay1MlgnTo1qnt8MRGAzQ 251zt9C4KyIhzXky6NPQjcOg0mOkvb+bkN0KRm072hBA+Bql3PpUKx1S X-Gm-Gg: ATEYQzyd0WKFWNx1craoahjyBCYQlnzAs3vMqZD2GlQIzMpg8lay8pcGbvqKGaY0xWA fpFd9xDFUp0IIUmumL6Qz+V1HczNji7Mdx1V0cCiC4LjutjPCs5rB51eq2FF3rQ+I7ezqHfh5k7 zDlPb5+aSTmNafLeAgGYwKJHYoARY6LJmM9NFQ0B2ofOjp6Iv9ChH6fAxmNpX3rpUbf8hwpBEUh R+iR+SFXIzd1BiovdrGcxhv5oSQnRO2b+wtNMLqrVmDriM7/102CKjax2JsPkdI04asp1Lqt1tC TSSKnlIaMZCFVWnfZhWody1AxBK76rD3BdsWAPQoLHi9YkfJQjiGJGhUgmDkmGP9HocyXYRSmDz fkZy2V/Vw3haL9FnFOjKoI8q8YIRzNgBUCSbz3S4mRrCG4c9YLbI2hebLRB54TMl+tIBtQRMASK OPYfKKDj7OKmL2DowdkbNj0FYsGdkylKMW77EsL1t7J4FwAJ5V77w= X-Received: by 2002:a17:907:70e:b0:b73:2b08:ac70 with SMTP id a640c23a62f3a-b93f1430131mr202869766b.49.1772659240655; Wed, 04 Mar 2026 13:20:40 -0800 (PST) Received: from localhost ([2a02:a03f:b7dc:2b00:a97a:8551:7733:cb60]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b93c8e3d060sm331313266b.56.2026.03.04.13.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 13:20:40 -0800 (PST) Sender: Olivier Sobrie From: Olivier Sobrie To: Guenter Roeck , Naresh Solanki Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: (max6639) fix inverted polarity Date: Wed, 4 Mar 2026 22:20:39 +0100 Message-ID: <20260304212039.570274-1-olivier@sobrie.be> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" According to MAX6639 documentation: D1: PWM Output Polarity. PWM output is low at 100% duty cycle when this bit is set to zero. PWM output is high at 100% duty cycle when this bit is set to 1. Up to commit 0f33272b60ed ("hwmon: (max6639) : Update hwmon init using info structure"), the polarity was set to high (0x2) when no platform data was set. After the patch, the polarity register wasn't set anymore if no platform data was specified. Nowadays, since commit 7506ebcd662b ("hwmon: (max6639) : Configure based on DT property"), it is always set to low which doesn't match with the comment above and change the behavior compared to versions prior 0f33272b60ed. Fixes: 0f33272b60ed ("hwmon: (max6639) : Update hwmon init using info struc= ture") Signed-off-by: Olivier Sobrie --- drivers/hwmon/max6639.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/max6639.c b/drivers/hwmon/max6639.c index a0a1dbbda887..9a3c515efe2e 100644 --- a/drivers/hwmon/max6639.c +++ b/drivers/hwmon/max6639.c @@ -607,7 +607,7 @@ static int max6639_init_client(struct i2c_client *clien= t, return err; =20 /* Fans PWM polarity high by default */ - err =3D regmap_write(data->regmap, MAX6639_REG_FAN_CONFIG2a(i), 0x00); + err =3D regmap_write(data->regmap, MAX6639_REG_FAN_CONFIG2a(i), 0x02); if (err) return err; =20 --=20 2.53.0