From nobody Thu Apr 2 15:41:44 2026 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 807013DEAEA for ; Wed, 4 Mar 2026 18:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650695; cv=none; b=MxqYy+EFoa0vGsGv/PHCoXpeCDnF9JGGhFNi4CwoWwYhTt2QcO7L7jUJ/Ope8QUHTeRT3zuwSlt1RYyurIs+3mUWT1LD8uuniNrao+3QIndOGWUknBOsjkeQB5h414ediqM8dohP7c66zKQy85xs0FiA/i4Hh/CihnndbE1WoA8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650695; c=relaxed/simple; bh=82wJ6CSHc8UFLw87bHXmNuqNeti15tSupjn/C1BIx6g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=btrqnyi+HgzRTLGSCSUXb6/+hLUh1C8W2z2FB+j46x/SrsPoovWHZ0HMqPBp4wPlHneqnL9zJFgGJLjdAro3JPe6R/TqNwmrHtAWJMYfAXTFHXXNakxuvb9I5w2gStInoONaVlIEnD+Ljzhv6g7dE7cwSKfPBT8geYDDkdagpns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AQqMm9yM; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AQqMm9yM" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-38a23dd61c1so35588501fa.1 for ; Wed, 04 Mar 2026 10:58:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772650691; x=1773255491; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MxQXkdXlba88gXFDuag6mxU8wtp75fT8rqY0N+LZnb8=; b=AQqMm9yMkYPEu4GmYKLj2K5s0hWNC7kqsGL0/itZRuvC8Aks9NCk7SprZszLn+4aGS Eyqp1CNacVxgPlhqmlx50fg0LAwnTdGK29J54vhVaJgBxErbndaoYpT3se1eauMqr2da dgsYLI9eQsrnwdUehiWyhHa1FuW3JgUjDPWFhTCYYf1pKjMZ7oxbr8hwiFz0XyKSHMF4 lmWPRowql3Ho7IgyVrqZTWRi0a5rm4u4aNDD5bNer4igTmqQaN7Jp1sFu3GIc5nRWOnw 6gjPI2CjkIjjb/iL5wUL/752AbElZ5O5Yy+anKnVhc31phCAReOwavaT4KFZO0SAAE3i sj0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772650691; x=1773255491; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MxQXkdXlba88gXFDuag6mxU8wtp75fT8rqY0N+LZnb8=; b=SE4zwH+O55TWbtjxHYwI+RQjAsosoIjjIW0pg5ITdlcyo/mWvI9Wi1G1pCIszwv53/ jp9TsM2J4pMjSofqo/AKdAnowugdhAbNx76rypnx6HbBqGaK7rvlGstcgcLgTU5jQJtS 0+yu58nlYM8Yw8N72Q75+v67kQDPMWpCwktIwsSMuiLUT6lNdcm6WnTYzFamugx5178f TZKODm2znIGlInogTsFUwCyeESid+n2ObimGDH1a7803ty49UNqeanOMkyIZP/gZvLMi V9gx/A00hJwQuanR3Yq86HIPXA9QRBq+MWH3lcDj3kxxsyUFn9Z7EuHkaz0/87gc/Z1a /W7w== X-Forwarded-Encrypted: i=1; AJvYcCWJaSDWQub4VxRsxE5ydNJ25HYROSmQoj4EBDuOF0efC6RHQUUqzbhhOvdMz1tUDoGovvYqrhnr3+Elles=@vger.kernel.org X-Gm-Message-State: AOJu0Yy55BqbA0He7svH6ybhM3sA/0gF6MK5/fSDw3TJCfG6tlzRgWct eCTYrNrmp+QzPEqgmqUHlAFAY+eASRYNX2wv6+GsjNlyOv+NqdRtRvct X-Gm-Gg: ATEYQzyOBhnFf6FblDSeBhZBehfzUCXOfGO9582j5lQbN7koRcz55qhTKXuFAM1JNMk pegYxeIo+Rxvr0OhEftXaYebdMxXhyF81CUFsJQ0WsmTV4V0Y1K7mGqZm63EMlbdj6c0GlncDVk VD410B2jLp8/ELsBvHYpviUptpfi6tHSRfMIE+M0WNvqU1Dgiqw40f7dldyG3OMkmoSgW4lrorJ fmNED3VVb8PSWX+hDj9Y1xgDVnjVLkCnqd7Oizxoq/OegOogPv8Blaghyv1LRzwLPaMvIW6VRXh 6w5aKKgJnrhSnc8kZmnPs66pbPJseijFlgiQJSp6RgIWox4e3Mqm8o6kMmZepYDPZqpsJYhnujn FZe+2t9dqyxH1ZuMKOGBcGRo0ksHzQuvZzPvwl+4wsil/N0MEfBXiXgeH0+BrfaI6fGe+Phgl34 44NDpoudIG4c5+ X-Received: by 2002:a05:651c:110c:b0:387:98:f2b4 with SMTP id 38308e7fff4ca-38a2c5747c7mr22154041fa.11.1772650690240; Wed, 04 Mar 2026 10:58:10 -0800 (PST) Received: from xeon ([188.163.112.72]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a12a6ddd3bsm704985e87.0.2026.03.04.10.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 10:58:09 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v5 6/7] power: supply: Add driver for ASUS Transformer battery Date: Wed, 4 Mar 2026 20:57:50 +0200 Message-ID: <20260304185751.83494-7-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304185751.83494-1-clamor95@gmail.com> References: <20260304185751.83494-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Driver implements one battery cell per EC controller and supports reading of battery status for ASUS Transformer's pad and mobile dock. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw Reviewed-by: Sebastian Reichel --- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile | 1 + .../supply/asus-transformer-ec-battery.c | 272 ++++++++++++++++++ 3 files changed, 284 insertions(+) create mode 100644 drivers/power/supply/asus-transformer-ec-battery.c diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 81fadb0695a9..3c46b412632d 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -122,6 +122,17 @@ config BATTERY_CHAGALL This driver can also be built as a module. If so, the module will be called chagall-battery. =20 +config BATTERY_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's battery driver" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here to enable support APM status emulation using + battery class devices. + + This sub-driver supports battery cells found in Asus Transformer + tablets and mobile docks and controlled by special embedded + controller. + config BATTERY_CPCAP tristate "Motorola CPCAP PMIC battery driver" depends on MFD_CPCAP && IIO diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index 41c400bbf022..aa5e6b05b018 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -22,6 +22,7 @@ obj-$(CONFIG_TEST_POWER) +=3D test_power.o obj-$(CONFIG_BATTERY_88PM860X) +=3D 88pm860x_battery.o obj-$(CONFIG_CHARGER_ADP5061) +=3D adp5061.o obj-$(CONFIG_BATTERY_ACT8945A) +=3D act8945a_charger.o +obj-$(CONFIG_BATTERY_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec-battery= .o obj-$(CONFIG_BATTERY_AXP20X) +=3D axp20x_battery.o obj-$(CONFIG_CHARGER_AXP20X) +=3D axp20x_ac_power.o obj-$(CONFIG_BATTERY_CHAGALL) +=3D chagall-battery.o diff --git a/drivers/power/supply/asus-transformer-ec-battery.c b/drivers/p= ower/supply/asus-transformer-ec-battery.c new file mode 100644 index 000000000000..aefcd3fed6fe --- /dev/null +++ b/drivers/power/supply/asus-transformer-ec-battery.c @@ -0,0 +1,272 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_BATTERY_DATA_FRESH_MSEC 5000 + +#define ASUSEC_BATTERY_DISCHARGING 0x40 +#define ASUSEC_BATTERY_FULL_CHARGED 0x20 +#define ASUSEC_BATTERY_NOT_CHARGING 0x10 + +#define TEMP_CELSIUS_OFFSET 2731 + +struct asus_ec_battery_data { + const struct asusec_info *ec; + struct power_supply *battery; + struct power_supply_desc psy_desc; + struct delayed_work poll_work; + struct mutex battery_lock; /* for data refresh */ + unsigned long batt_data_ts; + int last_state; + u8 batt_data[DOCKRAM_ENTRY_BUFSIZE]; +}; + +static int asus_ec_battery_refresh(struct asus_ec_battery_data *priv) +{ + int ret =3D 0; + + guard(mutex)(&priv->battery_lock); + + if (time_before(jiffies, priv->batt_data_ts)) + return ret; + + ret =3D asus_dockram_read(priv->ec->dockram, ASUSEC_DOCKRAM_BATT_CTL, + priv->batt_data); + if (ret < 0) + return ret; + + priv->batt_data_ts =3D jiffies + + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC); + + return ret; +} + +static enum power_supply_property asus_ec_battery_properties[] =3D { + POWER_SUPPLY_PROP_STATUS, + POWER_SUPPLY_PROP_VOLTAGE_MAX, + POWER_SUPPLY_PROP_CURRENT_MAX, + POWER_SUPPLY_PROP_TEMP, + POWER_SUPPLY_PROP_VOLTAGE_NOW, + POWER_SUPPLY_PROP_CURRENT_NOW, + POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_CHARGE_NOW, + POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW, + POWER_SUPPLY_PROP_TIME_TO_FULL_NOW, + POWER_SUPPLY_PROP_PRESENT, +}; + +static const unsigned int asus_ec_battery_prop_offs[] =3D { + [POWER_SUPPLY_PROP_STATUS] =3D 1, + [POWER_SUPPLY_PROP_VOLTAGE_MAX] =3D 3, + [POWER_SUPPLY_PROP_CURRENT_MAX] =3D 5, + [POWER_SUPPLY_PROP_TEMP] =3D 7, + [POWER_SUPPLY_PROP_VOLTAGE_NOW] =3D 9, + [POWER_SUPPLY_PROP_CURRENT_NOW] =3D 11, + [POWER_SUPPLY_PROP_CAPACITY] =3D 13, + [POWER_SUPPLY_PROP_CHARGE_NOW] =3D 15, + [POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW] =3D 17, + [POWER_SUPPLY_PROP_TIME_TO_FULL_NOW] =3D 19, +}; + +static int asus_ec_battery_get_value(struct asus_ec_battery_data *priv, + enum power_supply_property psp) +{ + int ret, offs; + + if (psp >=3D ARRAY_SIZE(asus_ec_battery_prop_offs)) + return -EINVAL; + + offs =3D asus_ec_battery_prop_offs[psp]; + if (!offs) + return -EINVAL; + + ret =3D asus_ec_battery_refresh(priv); + if (ret < 0) + return ret; + + if (offs >=3D priv->batt_data[0]) + return -ENODATA; + + return get_unaligned_le16(priv->batt_data + offs); +} + +static int asus_ec_battery_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct asus_ec_battery_data *priv =3D power_supply_get_drvdata(psy); + int ret; + + switch (psp) { + case POWER_SUPPLY_PROP_PRESENT: + val->intval =3D 1; + break; + + default: + ret =3D asus_ec_battery_get_value(priv, psp); + if (ret < 0) + return ret; + + val->intval =3D (s16)ret; + + switch (psp) { + case POWER_SUPPLY_PROP_STATUS: + if (ret & ASUSEC_BATTERY_FULL_CHARGED) + val->intval =3D POWER_SUPPLY_STATUS_FULL; + else if (ret & ASUSEC_BATTERY_NOT_CHARGING) + val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; + else if (ret & ASUSEC_BATTERY_DISCHARGING) + val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; + else + val->intval =3D POWER_SUPPLY_STATUS_CHARGING; + break; + + case POWER_SUPPLY_PROP_TEMP: + val->intval -=3D TEMP_CELSIUS_OFFSET; + break; + + case POWER_SUPPLY_PROP_CHARGE_NOW: + case POWER_SUPPLY_PROP_CURRENT_NOW: + case POWER_SUPPLY_PROP_CURRENT_MAX: + case POWER_SUPPLY_PROP_VOLTAGE_NOW: + case POWER_SUPPLY_PROP_VOLTAGE_MAX: + val->intval *=3D 1000; + break; + + case POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW: + case POWER_SUPPLY_PROP_TIME_TO_FULL_NOW: + val->intval *=3D 60; + break; + + default: + break; + } + + break; + } + + return 0; +} + +static void asus_ec_battery_poll_work(struct work_struct *work) +{ + struct asus_ec_battery_data *priv =3D + container_of(work, struct asus_ec_battery_data, poll_work.work); + int state; + + state =3D asus_ec_battery_get_value(priv, POWER_SUPPLY_PROP_STATUS); + if (state < 0) + return; + + if (state & ASUSEC_BATTERY_FULL_CHARGED) + state =3D POWER_SUPPLY_STATUS_FULL; + else if (state & ASUSEC_BATTERY_DISCHARGING) + state =3D POWER_SUPPLY_STATUS_DISCHARGING; + else + state =3D POWER_SUPPLY_STATUS_CHARGING; + + if (priv->last_state !=3D state) { + priv->last_state =3D state; + power_supply_changed(priv->battery); + } + + /* continuously send uevent notification */ + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); +} + +static const struct power_supply_desc asus_ec_battery_desc =3D { + .name =3D "asus-ec-battery", + .type =3D POWER_SUPPLY_TYPE_BATTERY, + .properties =3D asus_ec_battery_properties, + .num_properties =3D ARRAY_SIZE(asus_ec_battery_properties), + .get_property =3D asus_ec_battery_get_property, + .external_power_changed =3D power_supply_changed, +}; + +static int asus_ec_battery_probe(struct platform_device *pdev) +{ + struct asus_ec_battery_data *priv; + struct device *dev =3D &pdev->dev; + struct power_supply_config cfg =3D { }; + int ret; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + + mutex_init(&priv->battery_lock); + + priv->ec =3D cell_to_ec(pdev); + priv->batt_data_ts =3D jiffies - 1; + priv->last_state =3D POWER_SUPPLY_STATUS_UNKNOWN; + + cfg.fwnode =3D dev_fwnode(dev->parent); + cfg.drv_data =3D priv; + + memcpy(&priv->psy_desc, &asus_ec_battery_desc, sizeof(priv->psy_desc)); + priv->psy_desc.name =3D devm_kasprintf(dev, GFP_KERNEL, "%s-battery", + priv->ec->name); + + priv->battery =3D devm_power_supply_register(dev, &priv->psy_desc, &cfg); + if (IS_ERR(priv->battery)) + return dev_err_probe(dev, PTR_ERR(priv->battery), + "Failed to register power supply\n"); + + ret =3D devm_delayed_work_autocancel(dev, &priv->poll_work, + asus_ec_battery_poll_work); + if (ret) + return ret; + + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); + + return 0; +} + +static int __maybe_unused asus_ec_battery_suspend(struct device *dev) +{ + struct asus_ec_battery_data *priv =3D dev_get_drvdata(dev); + + cancel_delayed_work_sync(&priv->poll_work); + + return 0; +} + +static int __maybe_unused asus_ec_battery_resume(struct device *dev) +{ + struct asus_ec_battery_data *priv =3D dev_get_drvdata(dev); + + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); + + return 0; +} + +static SIMPLE_DEV_PM_OPS(asus_ec_battery_pm_ops, + asus_ec_battery_suspend, asus_ec_battery_resume); + +static struct platform_driver asus_ec_battery_driver =3D { + .driver =3D { + .name =3D "asus-transformer-ec-battery", + .pm =3D &asus_ec_battery_pm_ops, + }, + .probe =3D asus_ec_battery_probe, +}; +module_platform_driver(asus_ec_battery_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_AUTHOR("Svyatoslav Ryhel "); +MODULE_DESCRIPTION("ASUS Transformer's battery driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0