From nobody Thu Apr 2 15:41:45 2026 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6E5E3DBD46 for ; Wed, 4 Mar 2026 18:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650692; cv=none; b=LrHorx9P/HrzpXthUXbkBwziPdrAqcFwJ/W55l791YbGEiU7pdH2xDUT7xFy1UQRXXld7HFGKbuw55QsA6K8MckRzt/JYK1xrqAoj1nuqmL13Cu+6FZ2aDrJDPyfj7cjTyyV0eJtksX2/EJjidIBbdBLNx8nY5wLQTj4CfVgkH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650692; c=relaxed/simple; bh=LOjxMtUEiS4cNMWq1QoDk6BPRM0HvYSyeLI5k5nkNkA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hs9FcAjNcOJmr4zpKLlyLYL32f7owmftOQ2fdlnoe7LHdb7QSdi4kCwv0pFLLWtVg1OCT7aN0mVRQPjck2g9J/wRXDBCvQIKfq9mhiP3/W5fwOodQHfsJsW9lEfflXxIVSNTn7Z6c/ZDDGjIC6W0rXd/3edNL3K791xFCnyoajw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U3tIqnfK; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U3tIqnfK" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-386fb2c31e2so132625331fa.1 for ; Wed, 04 Mar 2026 10:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772650686; x=1773255486; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DNOE7jd4qzR4EDDWV5mqgo/ldDWXaWc2vNzYIUVYGLw=; b=U3tIqnfK6gkeE5YaFC2VhekSRhAaajtqSezo/ae+4TRPMEgwTYordw3tie60+eu32K dcpLN0QxkfIAm+juNSM6MdRQwuaP93uJNS8PVAMTM655HsQ1O419cKrvJH4DoAD5cPkY ybYtRnNo3HcBNl87DawCdbx0rzlQXkgGqVumMF5Ccln3EU5XYP+GfidHsIIb8468zapj CR05XHODUJYIewPoHAu6ZvsMzvQXLbgPw+qkFqX7hBb49JbuHtohhTdJqbrFDCPTxVDS Rj29CC/a+GFlNm492Fs3hwRMM8FtCFQmKRoQkrzyjZi6vNt++NyyXv9Rh2/3vVbnWtUL DT8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772650686; x=1773255486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DNOE7jd4qzR4EDDWV5mqgo/ldDWXaWc2vNzYIUVYGLw=; b=sTG6meCPH4OeQX3vEm7mPIjEM4c5gO5ztfR7u8TU6uZuU4/T9OIE6wBrldI762zPM1 n6h+8r7jgeXcs1IMJDYTIK8KAZIyqRhmJHj/w7jZMI6Tqu1kB6fzDZ4xmx+wtSELKoba WNAunUgyw7Jp3uXkyg8Ce6EuCI8sZ7aE/CLGCbl+eh8MLKBtL2W7+p9qLqeb3ByhxurW x8ScqcGGb3LH4ly/dNA6Wl+jqVpYESDT22BoP/QFCPTFezmjsyFRmTdtP3blt/loqqzZ aw5RyYF5pnXJ7fXmJpuLGdpMa+mw+nZncHB2IecaMhHMixs/0eG2Mt014dERxDlop4Wi xaJA== X-Forwarded-Encrypted: i=1; AJvYcCU4UvzRoA99rT8y8lg3pJoBqD9CSsspPEhXDRyY4iOD7NDK1UOOr7SjwilLR/1Pr7c/Xx744GzNWH7CeU8=@vger.kernel.org X-Gm-Message-State: AOJu0YyIjLarKnVzAUkPrcn+mouWdRRz05aaCMbCvGj9C6HKF6YXPFCQ VHBtwvKnn6J0Wf9ltVowe1te2++icfYhgpd8/T8EWdeBeaKHKkWD+E9E X-Gm-Gg: ATEYQzxhEySnKlJMkIaKxe1BOxMTdENg/FP7O7L4f8jZoAA1cLYNM74zytjI7LfQqXL 9Jfj6uJGAolI3O6uuOVJeIGDlgaR5mCZnkum6/wN28hUjDT7wt+7sRztC8gNRUl0fth6bTT3gTe OFl6R1WWVv5C2OZ14lJm4hvYDhYsP+enbgYi86HFYVkEWRlBrMtgVwZOHwsPV9j7f+TjXqQfoRr ogUz9YU4kyut8Moq11DdGS/JUFDzplhBp3ABDHOBM5xtoKB0Aw57p9gYBmKlECPHtqVfeqK4wVs ZPPiVJeNZ3TSsRuETMz75QmA4mmxFxufnQhtWZrmfrnK91YkEqkpV4Y0at2Mjqonc7rrUaBRUdr JTVGiDrWTrjZIqa6o2bvMPlYYf+Zuc1exouQ0ntbMPzCiFQlaJ5VbJhlD/YMkJ81hp9jNzCPcBf GKp18OJ596wSyw X-Received: by 2002:a2e:b88f:0:b0:380:c72:d495 with SMTP id 38308e7fff4ca-38a2c7d4f0dmr26972481fa.32.1772650685991; Wed, 04 Mar 2026 10:58:05 -0800 (PST) Received: from xeon ([188.163.112.72]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a12a6ddd3bsm704985e87.0.2026.03.04.10.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 10:58:05 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v5 3/7] input: serio: Add driver for ASUS Transformer dock keyboard and touchpad Date: Wed, 4 Mar 2026 20:57:47 +0200 Message-ID: <20260304185751.83494-4-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304185751.83494-1-clamor95@gmail.com> References: <20260304185751.83494-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add input driver for ASUS Transformer dock keyboard and touchpad. Some keys in ASUS Dock report keycodes that don't make sense according to their position, this patch modifies the incoming data that is sent to serio to send proper scancodes. Co-developed-by: Ion Agorria Signed-off-by: Ion Agorria Signed-off-by: Micha=C5=82 Miros=C5=82aw Signed-off-by: Svyatoslav Ryhel --- drivers/input/serio/Kconfig | 15 ++ drivers/input/serio/Makefile | 1 + drivers/input/serio/asus-transformer-ec-kbc.c | 147 ++++++++++++++++++ 3 files changed, 163 insertions(+) create mode 100644 drivers/input/serio/asus-transformer-ec-kbc.c diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig index c7ef347a4dff..1ca17ba632cc 100644 --- a/drivers/input/serio/Kconfig +++ b/drivers/input/serio/Kconfig @@ -97,6 +97,21 @@ config SERIO_RPCKBD To compile this driver as a module, choose M here: the module will be called rpckbd. =20 +config SERIO_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's Dock keyboard and touchpad controller" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here if you want to use the keyboard and/or touchpad on + Asus Transformed's Mobile Dock. + + For keyboard support you also need atkbd driver. + + For touchpad support you also need psmouse driver with Elantech + touchpad option enabled. + + To compile this driver as a module, choose M here: the module will + be called asus-transformer-ec-kbc. + config SERIO_AMBAKMI tristate "AMBA KMI keyboard controller" depends on ARM_AMBA diff --git a/drivers/input/serio/Makefile b/drivers/input/serio/Makefile index 6d97bad7b844..9ecf0d011863 100644 --- a/drivers/input/serio/Makefile +++ b/drivers/input/serio/Makefile @@ -13,6 +13,7 @@ obj-$(CONFIG_SERIO_CT82C710) +=3D ct82c710.o obj-$(CONFIG_SERIO_RPCKBD) +=3D rpckbd.o obj-$(CONFIG_SERIO_SA1111) +=3D sa1111ps2.o obj-$(CONFIG_SERIO_AMBAKMI) +=3D ambakmi.o +obj-$(CONFIG_SERIO_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec-kbc.o obj-$(CONFIG_SERIO_Q40KBD) +=3D q40kbd.o obj-$(CONFIG_SERIO_GSCPS2) +=3D gscps2.o obj-$(CONFIG_HP_SDC) +=3D hp_sdc.o diff --git a/drivers/input/serio/asus-transformer-ec-kbc.c b/drivers/input/= serio/asus-transformer-ec-kbc.c new file mode 100644 index 000000000000..47fd6e48c989 --- /dev/null +++ b/drivers/input/serio/asus-transformer-ec-kbc.c @@ -0,0 +1,147 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include + +struct asus_ec_kbc_data { + struct notifier_block nb; + struct asusec_info *ec; + struct serio *sdev[2]; +}; + +static int asus_ec_kbc_notify(struct notifier_block *nb, + unsigned long action, void *data_) +{ + struct asus_ec_kbc_data *priv =3D container_of(nb, struct asus_ec_kbc_dat= a, nb); + unsigned int port_idx, n; + u8 *data =3D data_; + + if (action & (ASUSEC_SMI_MASK | ASUSEC_SCI_MASK)) + return NOTIFY_DONE; + else if (action & ASUSEC_AUX_MASK) + port_idx =3D 1; + else if (action & (ASUSEC_KBC_MASK | ASUSEC_KEY_MASK)) + port_idx =3D 0; + else + return NOTIFY_DONE; + + n =3D data[0] - 1; + data +=3D 2; + + /* + * We need to replace these incoming data for keys: + * RIGHT_META Press 0xE0 0x27 -> LEFT_ALT Press 0x11 + * RIGHT_META Release 0xE0 0xF0 0x27 -> LEFT_ALT Release 0xF0 0x11 + * COMPOSE Press 0xE0 0x2F -> RIGHT_META Press 0xE0 0x27 + * COMPOSE Release 0xE0 0xF0 0x2F -> RIGHT_META Release 0xE0 0xF0 0x27 + */ + + if (port_idx =3D=3D 0 && n >=3D 2 && data[0] =3D=3D 0xE0) { + if (n =3D=3D 3 && data[1] =3D=3D 0xF0) { + switch (data[2]) { + case 0x27: + data[0] =3D 0xF0; + data[1] =3D 0x11; + n =3D 2; + break; + case 0x2F: + data[2] =3D 0x27; + break; + } + } else if (n =3D=3D 2) { + switch (data[1]) { + case 0x27: + data[0] =3D 0x11; + n =3D 1; + break; + case 0x2F: + data[1] =3D 0x27; + break; + } + } + } + + while (n--) + serio_interrupt(priv->sdev[port_idx], *data++, 0); + + return NOTIFY_OK; +} + +static int asus_ec_serio_write(struct serio *port, unsigned char data) +{ + const struct asusec_info *ec =3D port->port_data; + + return asus_ec_i2c_command(ec, (data << 8) | port->id.extra); +} + +static void asus_ec_serio_remove(void *data) +{ + serio_unregister_port(data); +} + +static int asus_ec_register_serio(struct platform_device *pdev, int idx, + const char *name, int cmd) +{ + struct asus_ec_kbc_data *priv =3D platform_get_drvdata(pdev); + struct i2c_client *parent =3D to_i2c_client(pdev->dev.parent); + struct serio *port =3D kzalloc_obj(*port); + + if (!port) + return -ENOMEM; + + priv->sdev[idx] =3D port; + port->dev.parent =3D &pdev->dev; + port->id.type =3D SERIO_8042; + port->id.extra =3D cmd & 0xFF; + port->write =3D asus_ec_serio_write; + port->port_data =3D (void *)priv->ec; + snprintf(port->name, sizeof(port->name), "%s %s", + priv->ec->model, name); + snprintf(port->phys, sizeof(port->phys), "i2c-%u-%04x/serio%d", + i2c_adapter_id(parent->adapter), parent->addr, idx); + + serio_register_port(port); + + return devm_add_action_or_reset(&pdev->dev, asus_ec_serio_remove, port); +} + +static int asus_ec_kbc_probe(struct platform_device *pdev) +{ + struct asusec_info *ec =3D cell_to_ec(pdev); + struct asus_ec_kbc_data *priv; + int ret; + + priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + priv->ec =3D ec; + + ret =3D asus_ec_register_serio(pdev, 0, "Keyboard", 0); + if (ret < 0) + return ret; + + ret =3D asus_ec_register_serio(pdev, 1, "Touchpad", I8042_CMD_AUX_SEND); + if (ret < 0) + return ret; + + priv->nb.notifier_call =3D asus_ec_kbc_notify; + + return devm_asus_ec_register_notifier(pdev, &priv->nb); +} + +static struct platform_driver asus_ec_kbc_driver =3D { + .driver.name =3D "asus-transformer-ec-kbc", + .probe =3D asus_ec_kbc_probe, +}; +module_platform_driver(asus_ec_kbc_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer's Dock keyboard and touchpad controll= er driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0