From nobody Thu Apr 2 14:07:59 2026 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 949433CD8C2 for ; Wed, 4 Mar 2026 18:58:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650687; cv=none; b=RM5GpY5PAhBqBEhgwfEUuvmpOdixicC3Rq83qEh90Znses+E3MlZWe0uDZu3E9cGgnMXozpNwrFCijyKMZ/JsrqTYDS1KNLbcQCIjb7TKZaPlOy2d8fOQNA37qxIW6ryTxhG39+LElVXm0Wv05kiGF/VcrZXTCgAXEBS/LU3kY0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650687; c=relaxed/simple; bh=Um/z68zG3N61niZpCEIqJtffZwPNsXI2dku/W5e1n1w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KBpCD75fXcf+Hb9kYcYo+BnZt369YAMSlqZMiGB2ZP80yJlGyQT2Lv6eYYm5Z0rtENLLo/YfPpsC5BEgnmwHRtgHaSYxhMkXHRG10MXaz5aCpOzp+H0NbQhou/aj0D2/d1FPKdDpUo0ikinLXTmrIs2ScN4kFcR+S/C3I+DEdKM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BSoWYr20; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BSoWYr20" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-38a2cc31e20so19909711fa.1 for ; Wed, 04 Mar 2026 10:58:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772650684; x=1773255484; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+X0ubJBSyO/B3iU+P8TQmYBYVQdgv6gVa1x95cmnAWM=; b=BSoWYr20bcI3o3JCa9seNp57s083V2y+QhavjlJ3GtJNXMtupOBHmoSXXKFOxT35IB fpyDzpUq+Dw9a8juhD86IzkpVG+dVVD6AgCzBs0ClWxJqdzSpnLTcPetrZ+G/NonGKDH Y6DGANEVtgOL0NIKIWc14Qq1+3RtWW6IRHzRVHmpq8kv52G8YigIbgdTsqKDAKUxnuSR XCTROFJ4hxjEKxEKXavX0RnEZUPUhST7ROb5J9VHsOOY6vayoLe06U5teHkvp46m6yjV RywDnGo7q/9BnWOC7k5WiS+0rAMYjCRWXVZ6sHWHTezB1KMwqOifymCuJsVcTNkHxgF6 s9vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772650684; x=1773255484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+X0ubJBSyO/B3iU+P8TQmYBYVQdgv6gVa1x95cmnAWM=; b=K/X0hN6Zzb97gV8CjlvwbV/PvVKTH13VMFDCUwreuJ2E2k7NOqwlnSV5AC+OuSRnhv zh2nFMugItbOGMmVrlugOAAfpZOxYuptuN7WSonwZNw7PtXXEOCYvioBv7VzHsfY2qI4 k51xxdsPxZ6290ZY5hG6hRYCJcjA9lkmK92MaPb3KIyVoq0hoqGba1V7HChTN5x205Tl IZ1jE05E3l5TwBMnPCrhAySDlsrndiXCFdDAy31gc+fQYuychDqIR99Nw0vVu6ZJ1EJ3 NBr8tJAG5dK+Lsv500sYH8BL5lISq21NXpUIupzmB9ppMzhy3PZnRO1IjfaCaEC/IflS u5LA== X-Forwarded-Encrypted: i=1; AJvYcCUbGyPtdT/BRkNzyp5EQU8iG3o6SSUFGUsMjIGIgcPvvWX3aBIxetTgIZrfaxvrzoYpsuBwCcxg7dpr86w=@vger.kernel.org X-Gm-Message-State: AOJu0YwTYkGPM3PTOMgjGOaI0FoLHU5li5f7+BKmqugA8nT/ovILqLBB SKidlgnm34svcmMIMRbyx5EAuc2sqUWj7PL35fyKQ8eqGVKoHB4UAkGY X-Gm-Gg: ATEYQzxpBbmxqj8xj3a37JqSrocm7sjtlflpSOK0Q8AkKMRvixBPZkjzj+hkxei3A+/ Mp45dEsQvc7ObajpO5lofU6X1YH+BpVy4T/DMM/mNJODTkii+34TETqqzX2OzogSY5y9fVty1z8 MBIxG37h5CPFnB9SBorjkEZNcKE26ieE26MDRz0gg30mz2KWDueTH8P5ZSGyVQeOg03XXG2LDnw 6en5v6mWc3R3UvtEEZDEN+vK1i/Lhh0VnhsX24gswIZ2PiG/2vl3jUpCk6xwo1SXtkEZyzfSD5+ BvE+3yqcXgwK5757F9MNhDuNu/05EZTuvjJiU5g8eE8zOmXnUGpWyVRF8wOpwhqT1uSkcsdzDEL 6Mr+7SM8hooER83LL/bKhyMVKuIM6FqssV9+8Jn27u7Vd2BVeBBB5qr/c79Uv4O3Vd3i9Vu217E LUsVy4lGSoOHHI X-Received: by 2002:a2e:9e11:0:b0:386:1ce2:1192 with SMTP id 38308e7fff4ca-38a2c5b25cemr17005641fa.20.1772650683643; Wed, 04 Mar 2026 10:58:03 -0800 (PST) Received: from xeon ([188.163.112.72]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a12a6ddd3bsm704985e87.0.2026.03.04.10.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 10:58:03 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v5 1/7] dt-bindings: embedded-controller: document ASUS Transformer EC Date: Wed, 4 Mar 2026 20:57:45 +0200 Message-ID: <20260304185751.83494-2-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304185751.83494-1-clamor95@gmail.com> References: <20260304185751.83494-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Document embedded controller used in ASUS Transformer device series. Signed-off-by: Svyatoslav Ryhel Reviewed-by: Rob Herring (Arm) --- .../asus,tf201-ec-pad.yaml | 119 ++++++++++++++++++ 1 file changed, 119 insertions(+) create mode 100644 Documentation/devicetree/bindings/embedded-controller/a= sus,tf201-ec-pad.yaml diff --git a/Documentation/devicetree/bindings/embedded-controller/asus,tf2= 01-ec-pad.yaml b/Documentation/devicetree/bindings/embedded-controller/asus= ,tf201-ec-pad.yaml new file mode 100644 index 000000000000..60b6375864aa --- /dev/null +++ b/Documentation/devicetree/bindings/embedded-controller/asus,tf201-ec-p= ad.yaml @@ -0,0 +1,119 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/embedded-controller/asus,tf201-ec-pad.y= aml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ASUS Transformer's Embedded Controller + +description: + Several Nuvoton based Embedded Controllers attached to an I2C bus, + running a custom ASUS firmware, specific to the ASUS Transformer + device series. + +maintainers: + - Svyatoslav Ryhel + +properties: + compatible: + description: + The 'pad' suffix is used for the controller within the tablet, while + the 'dock' suffix refers to the controller in the mobile dock keyboa= rd. + oneOf: + - enum: + - asus,sl101-ec-dock + - asus,tf101-ec-dock + - asus,tf201-ec-pad + - asus,tf600t-ec-dock + - asus,tf600t-ec-pad + + - items: + - enum: + - asus,tf101g-ec-dock + - asus,tf201-ec-dock + - asus,tf300t-ec-dock + - asus,tf300tg-ec-dock + - asus,tf300tl-ec-dock + - asus,tf700t-ec-dock + - const: asus,tf101-ec-dock + + - items: + - enum: + - asus,tf300t-ec-pad + - asus,tf300tg-ec-pad + - asus,tf300tl-ec-pad + - asus,tf700t-ec-pad + - const: asus,tf201-ec-pad + + - items: + - enum: + - asus,tf701t-ec-dock + - const: asus,tf600t-ec-dock + + - items: + - enum: + - asus,p1801-t-ec-pad + - asus,tf701t-ec-pad + - const: asus,tf600t-ec-pad + + reg: + description: + The ASUS Transformer EC has a main I2C address and an associated + DockRAM device, which provides power-related functions for the + embedded controller. Both addresses are required for operation. + minItems: 2 + + reg-names: + items: + - const: ec + - const: dockram + + interrupts: + maxItems: 1 + + request-gpios: + maxItems: 1 + +required: + - compatible + - reg + - reg-names + +allOf: + - $ref: /schemas/power/supply/power-supply.yaml + - if: + properties: + compatible: + not: + contains: + const: asus,tf600t-ec-dock + then: + required: + - interrupts + - request-gpios + +unevaluatedProperties: false + +examples: + - | + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + embedded-controller@19 { + compatible =3D "asus,tf201-ec-dock", "asus,tf101-ec-dock"; + reg =3D <0x19>, <0x1b>; + reg-names =3D "ec", "dockram"; + + interrupt-parent =3D <&gpio>; + interrupts =3D <151 IRQ_TYPE_LEVEL_LOW>; + + request-gpios =3D <&gpio 134 GPIO_ACTIVE_LOW>; + + monitored-battery =3D <&dock_battery>; + }; + }; +... --=20 2.51.0 From nobody Thu Apr 2 14:07:59 2026 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA9993DA5AB for ; Wed, 4 Mar 2026 18:58:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650690; cv=none; b=Z57oNQJp4uXjrgB7y8Kght/ZSS46SuirFx97lc6CCdC3Dvk3E05XF1VoctI5v7rOtz/JxtgBcYsSBnB/JzQE3dTQwLQQ8IaKEIIByf6AoaK31tu5djApUqhJtMEa9LEXWn8RAMJ+EqDCxG6xyQfM9SHySms0H/DqfDPUCZGkhYE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650690; c=relaxed/simple; bh=navC5G1S8W8VX/n9M16sJYL90Z7g1iUS62GUDJpPyuY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fgfTio2W5YU+J5ei2Rn18NDMPgvl8Ay5bEwRoeEx3e51dg4k1joVyCNddcVglGMJsLhyuviCn55+Io2K2O+2T06k16mSEuT/MF/1zLB68k7CWqNZ5A6e2Le8PtB3GKQWRYgUidyY7NNNZt25v/6g8+yQEPwZ6sf73UUpnNQZ2KM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XXszN3V2; arc=none smtp.client-ip=209.85.208.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XXszN3V2" Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-38a27d39067so27901061fa.1 for ; Wed, 04 Mar 2026 10:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772650685; x=1773255485; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2931DPcC4IxpMNLiMCX6IPqOOVc3fEg8iXAlIxRLRik=; b=XXszN3V27l0L6Jyom3kG3h5RrKqYkAFCf1eHUDOeEXxB9eXB3sqoRHaQ178ro6BkUv QMGaBJhCgXTLdyJCxl/2Uu5OAO76kqIEDliE+bOUMgp5S4Yyk3rqggdkMov/KamNqf02 xfj2IjKe4XpLbuKwkCeHno86MXCKuZlJoR7ZlJRal4sy7HTrjQ1xRZ3y0cE3jSwqoxcE wmdQnm6ZNFJ3OskY+5Ez2ZTsi+4jDU0sWnQTmUJaXNji+QtafboCCmv7B42aSKsazUie fWf+oLNyzH86NJ0B4A9lWYU3/tb2yAn7sQ5icEXvKpS0o0oK3yaYDTaJkyLFa63NIzSs qWTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772650685; x=1773255485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2931DPcC4IxpMNLiMCX6IPqOOVc3fEg8iXAlIxRLRik=; b=em4LYnKqO0dJRYc4UaoZwYQFCDnrOlTFgJEbg3mB23oOTt58QA+fR8iXGUUGtwITcS bXvVp/+y6mF5E1CF1KUuYFQzAnKh3H6NgSAB6G0OrtBBc1IW7MIWGWrsNOW3nvqKOcxn QStGAxNaIE4F3gitnDyf8Fr9j/OlEcpX63ww2U3hVTxkDz724ZGA7a9StCnRspMlQo6c vRoMSH2ySoz1blDiUpgUcIhxou0vCzeZYQKRJj29XbhOIbB/920yEFpd1FctXrbkKFww YrvS7Drft8AJGw3jgsbF+oaykxxhykDX4m+NsxfYuLqAqwXlXMFvZzQmufRQTl+7sCls lRww== X-Forwarded-Encrypted: i=1; AJvYcCWCB0Gdqkt9ydqtJsUyth2C0BZNwmYCwgyffzuXl7H4koBd6LYnY4p5wnZnXQmxIZInaFRRzS5YRKz3VuE=@vger.kernel.org X-Gm-Message-State: AOJu0YzLNDFi1RStfzJClgrn1jf0vkAWUIODifhzjrx/61q6aQsnMLs8 IO1EcY+BaF/dcPI7X2Wj2PgqmfYiA/Yf4zutWkpomjj6Ly1FJ0PTAQ6w X-Gm-Gg: ATEYQzwomfEQ6TZCvlOAbpvn3dfKPsYXyCq5dRti2HLbcVRwobXQUujjwOggZ3P7ahG XVtSf+9E0Dx/FWRjHnIihVVXcV7+IF+NTy/XwCYMPc6ogfm9qdTSwM6T0/mwGByzterr2ouUl+B okVF9yfElUqCqJa1MkeiawOrY83qGSlWCmnzlMcDx6vbc+6Tv28SbkdEyXiK82ibBHhcOc1ofXJ hpU35QyLVCA4XUStAdGmnK/cU40jvlZ/a05aswmu/JEF2kaq4JIwJZeKD82UmOoE8xkb0PUKcKo rmzhJPQ0bxVh7SI5yYPcZ1WvH0PyPEOzuo7ELYp+UHdgX+dq4+aFPlfWcs5nd+mL16GJjXoQeeo oPB/oneyDlgKQB6UvYA6VAq/1UbYELooTGbqzg0NB0z6Ifc98GyVEAE5mYoxNd/hxBCVP8zJDqv 6b2n4u1RLcuxXu X-Received: by 2002:a05:651c:f02:b0:38a:464:a53d with SMTP id 38308e7fff4ca-38a2c574d63mr25901741fa.12.1772650684896; Wed, 04 Mar 2026 10:58:04 -0800 (PST) Received: from xeon ([188.163.112.72]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a12a6ddd3bsm704985e87.0.2026.03.04.10.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 10:58:04 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v5 2/7] mfd: Add driver for ASUS Transformer embedded controller Date: Wed, 4 Mar 2026 20:57:46 +0200 Message-ID: <20260304185751.83494-3-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304185751.83494-1-clamor95@gmail.com> References: <20260304185751.83494-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Support Nuvoton NPCE795-based ECs as used in Asus Transformer TF201, TF300T, TF300TG, TF300TL and TF700T pad and dock, as well as TF101 dock and TF600T, P1801-T and TF701T pad. This is a glue driver handling detection and common operations for EC's functions. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw --- drivers/mfd/Kconfig | 14 + drivers/mfd/Makefile | 1 + drivers/mfd/asus-transformer-ec.c | 762 ++++++++++++++++++++++++ include/linux/mfd/asus-transformer-ec.h | 162 +++++ 4 files changed, 939 insertions(+) create mode 100644 drivers/mfd/asus-transformer-ec.c create mode 100644 include/linux/mfd/asus-transformer-ec.h diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 7192c9d1d268..5aa4facfd2df 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -137,6 +137,20 @@ config MFD_AAT2870_CORE additional drivers must be enabled in order to use the functionality of the device. =20 +config MFD_ASUS_TRANSFORMER_EC + tristate "ASUS Transformer's embedded controller" + depends on I2C && OF + help + Support ECs found in ASUS Transformer's Pad and Mobile Dock. + + This provides shared glue for functional part drivers: + asus-transformer-ec-kbc, asus-transformer-ec-keys, + leds-asus-transformer-ec, asus-transformer-ec-battery + and asus-transformer-ec-charger. + + This driver can also be built as a module. If so, the module + will be called asus-transformer-ec. + config MFD_AT91_USART tristate "AT91 USART Driver" select MFD_CORE diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index e75e8045c28a..fd80088d8a9a 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -10,6 +10,7 @@ obj-$(CONFIG_MFD_88PM805) +=3D 88pm805.o 88pm80x.o obj-$(CONFIG_MFD_88PM886_PMIC) +=3D 88pm886.o obj-$(CONFIG_MFD_ACT8945A) +=3D act8945a.o obj-$(CONFIG_MFD_SM501) +=3D sm501.o +obj-$(CONFIG_MFD_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec.o obj-$(CONFIG_ARCH_BCM2835) +=3D bcm2835-pm.o obj-$(CONFIG_MFD_BCM590XX) +=3D bcm590xx.o obj-$(CONFIG_MFD_BD9571MWV) +=3D bd9571mwv.o diff --git a/drivers/mfd/asus-transformer-ec.c b/drivers/mfd/asus-transform= er-ec.c new file mode 100644 index 000000000000..aa3b9e31f3fc --- /dev/null +++ b/drivers/mfd/asus-transformer-ec.c @@ -0,0 +1,762 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_RSP_BUFFER_SIZE 8 + +struct asus_ec_chip_data { + const char *name; + const struct mfd_cell *mfd_devices; + unsigned int num_devices; + bool clr_fmode; /* clear Factory Mode bit in EC control register */ +}; + +struct asus_ec_data { + struct asusec_info info; + struct mutex ecreq_lock; /* prevent simultaneous access */ + struct gpio_desc *ecreq; + struct i2c_client *self; + const struct asus_ec_chip_data *data; + char ec_data[DOCKRAM_ENTRY_BUFSIZE]; + bool logging_disabled; +}; + +struct dockram_ec_data { + struct mutex ctl_lock; /* prevent simultaneous access */ + char ctl_data[DOCKRAM_ENTRY_BUFSIZE]; +}; + +#define to_ec_data(ec) \ + container_of(ec, struct asus_ec_data, info) + +/** + * asus_dockram_read - Read a register from the DockRAM device. + * @client: Handle to the DockRAM device. + * @reg: Register to read. + * @buf: Byte array into which data will be read; must be large enough to + * hold the data returned by the DockRAM. + * + * This executes the DockRAM read based on the SMBus "block read" protocol + * or its emulation. It extracts DOCKRAM_ENTRY_SIZE bytes from the set + * register address. + * + * Returns a negative errno code else zero on success. + */ +int asus_dockram_read(struct i2c_client *client, int reg, char *buf) +{ + struct device *dev =3D &client->dev; + int ret; + + memset(buf, 0, DOCKRAM_ENTRY_BUFSIZE); + ret =3D i2c_smbus_read_i2c_block_data(client, reg, + DOCKRAM_ENTRY_BUFSIZE, buf); + if (ret < 0) + return ret; + + if (buf[0] > DOCKRAM_ENTRY_SIZE) { + dev_err(dev, "bad data len; buffer: %*ph; ret: %d\n", + DOCKRAM_ENTRY_BUFSIZE, buf, ret); + return -EPROTO; + } + + dev_dbg(dev, "got data; buffer: %*ph; ret: %d\n", + DOCKRAM_ENTRY_BUFSIZE, buf, ret); + + return 0; +} +EXPORT_SYMBOL_GPL(asus_dockram_read); + +/** + * asus_dockram_write - Write a byte array to a register of the DockRAM de= vice. + * @client: Handle to the DockRAM device. + * @reg: Register to write to. + * @buf: Byte array to be written (up to DOCKRAM_ENTRY_SIZE bytes). + * + * This executes the DockRAM write based on the SMBus "block write" + * protocol or its emulation. It writes DOCKRAM_ENTRY_SIZE bytes to the + * specified register address. + * + * Returns a negative errno code else zero on success. + */ +int asus_dockram_write(struct i2c_client *client, int reg, const char *buf) +{ + if (buf[0] > DOCKRAM_ENTRY_SIZE) + return -EINVAL; + + dev_dbg(&client->dev, "sending data; buffer: %*ph\n", buf[0] + 1, buf); + + return i2c_smbus_write_i2c_block_data(client, reg, buf[0] + 1, buf); +} +EXPORT_SYMBOL_GPL(asus_dockram_write); + +/** + * asus_dockram_access_ctl - Read from or write to the DockRAM control reg= ister. + * @client: Handle to the DockRAM device. + * @out: Pointer to a variable where the register value will be stored. + * @mask: Bitmask of bits to be cleared. + * @xor: Bitmask of bits to be set (via XOR). + * + * This performs a control register read if @out is provided and both @mask + * and @xor are zero. Otherwise, it performs a control register update if + * @mask and @xor are provided. + * + * Returns a negative errno code else zero on success. + */ +int asus_dockram_access_ctl(struct i2c_client *client, u64 *out, u64 mask, + u64 xor) +{ + struct dockram_ec_data *priv =3D i2c_get_clientdata(client); + char *buf =3D priv->ctl_data; + u64 val; + int ret =3D 0; + + guard(mutex)(&priv->ctl_lock); + + ret =3D asus_dockram_read(client, ASUSEC_DOCKRAM_CONTROL, buf); + if (ret < 0) + goto exit; + + if (buf[0] !=3D ASUSEC_CTL_SIZE) { + ret =3D -EPROTO; + goto exit; + } + + val =3D get_unaligned_le64(buf + 1); + + if (out) + *out =3D val; + + if (mask || xor) { + put_unaligned_le64((val & ~mask) ^ xor, buf + 1); + ret =3D asus_dockram_write(client, ASUSEC_DOCKRAM_CONTROL, buf); + } + +exit: + if (ret < 0) + dev_err(&client->dev, "Failed to access control flags: %d\n", + ret); + + return ret; +} +EXPORT_SYMBOL_GPL(asus_dockram_access_ctl); + +static void asus_ec_remove_notifier(struct device *dev, void *res) +{ + struct asusec_info *ec =3D dev_get_drvdata(dev->parent); + struct notifier_block **nb =3D res; + + blocking_notifier_chain_unregister(&ec->notify_list, *nb); +} + +/** + * devm_asus_ec_register_notifier - Managed registration of notifier to an + * ASUS EC blocking notifier chain. + * @pdev: Device requesting the notifier (used for resource management). + * @nb: Notifier block to be registered. + * + * Register a notifier to the ASUS EC blocking notifier chain. The notifier + * will be automatically unregistered when the requesting device is detach= ed. + * + * Return: 0 on success or a negative error code on failure. + */ +int devm_asus_ec_register_notifier(struct platform_device *pdev, + struct notifier_block *nb) +{ + struct asusec_info *ec =3D dev_get_drvdata(pdev->dev.parent); + struct notifier_block **res; + int ret; + + res =3D devres_alloc(asus_ec_remove_notifier, sizeof(*res), GFP_KERNEL); + if (!res) + return -ENOMEM; + + *res =3D nb; + ret =3D blocking_notifier_chain_register(&ec->notify_list, nb); + if (ret) { + devres_free(res); + return ret; + } + + devres_add(&pdev->dev, res); + + return 0; +} +EXPORT_SYMBOL_GPL(devm_asus_ec_register_notifier); + +static int asus_ec_signal_request(const struct asusec_info *ec) +{ + struct asus_ec_data *priv =3D to_ec_data(ec); + + guard(mutex)(&priv->ecreq_lock); + + dev_dbg(&priv->self->dev, "EC request\n"); + + gpiod_set_value_cansleep(priv->ecreq, 1); + msleep(50); + + gpiod_set_value_cansleep(priv->ecreq, 0); + msleep(200); + + return 0; +} + +static int asus_ec_write(struct asus_ec_data *priv, u16 data) +{ + int ret =3D i2c_smbus_write_word_data(priv->self, ASUSEC_WRITE_BUF, data); + + dev_dbg(&priv->self->dev, "EC write: %04x, ret =3D %d\n", data, ret); + return ret; +} + +static int asus_ec_read(struct asus_ec_data *priv, bool in_irq) +{ + int ret =3D i2c_smbus_read_i2c_block_data(priv->self, ASUSEC_READ_BUF, + sizeof(priv->ec_data), + priv->ec_data); + + dev_dbg(&priv->self->dev, "EC read: %*ph, ret =3D %d%s\n", + sizeof(priv->ec_data), priv->ec_data, + ret, in_irq ? "; in irq" : ""); + + return ret; +} + +/** + * asus_ec_i2c_command - Send a 16-bit command to the ASUS EC. + * @ec: Pointer to the shared ASUS EC structure. + * @data: The 16-bit command (word) to be sent. + * + * Return: 0 on success or a negative error code on failure. + */ +int asus_ec_i2c_command(const struct asusec_info *ec, u16 data) +{ + return asus_ec_write(to_ec_data(ec), data); +} +EXPORT_SYMBOL_GPL(asus_ec_i2c_command); + +static void asus_ec_clear_buffer(struct asus_ec_data *priv) +{ + int retry =3D ASUSEC_RSP_BUFFER_SIZE; + + while (retry--) { + if (asus_ec_read(priv, false) < 0) + continue; + + if (priv->ec_data[1] & ASUSEC_OBF_MASK) + continue; + + break; + } +} + +static int asus_ec_log_info(struct asus_ec_data *priv, unsigned int reg, + const char *name, char **out) +{ + char buf[DOCKRAM_ENTRY_BUFSIZE]; + int ret; + + ret =3D asus_dockram_read(priv->info.dockram, reg, buf); + if (ret < 0) + return ret; + + if (!priv->logging_disabled) + dev_info(&priv->self->dev, "%-14s: %.*s\n", name, + buf[0], buf + 1); + + if (out) + *out =3D kstrndup(buf + 1, buf[0], GFP_KERNEL); + + return 0; +} + +static int asus_ec_reset(struct asus_ec_data *priv) +{ + int retry, ret; + + for (retry =3D 0; retry < 3; retry++) { + ret =3D asus_ec_write(priv, 0); + if (!ret) + return 0; + + msleep(300); + } + + return ret; +} + +static int asus_ec_magic_debug(struct asus_ec_data *priv) +{ + u64 flag; + int ret; + + ret =3D asus_ec_get_ctl(&priv->info, &flag); + if (ret < 0) + return ret; + + flag &=3D ASUSEC_CTL_SUSB_MODE; + dev_info(&priv->self->dev, "EC FW behaviour: %s\n", + flag ? "susb on when receive ec_req" : + "susb on when system wakeup"); + + return 0; +} + +static int asus_ec_set_factory_mode(struct asus_ec_data *priv, bool on) +{ + dev_info(&priv->self->dev, "Entering %s mode.\n", on ? "factory" : + "normal"); + return asus_ec_update_ctl(&priv->info, ASUSEC_CTL_FACTORY_MODE, + on ? ASUSEC_CTL_FACTORY_MODE : 0); +} + +static void asus_ec_handle_smi(struct asus_ec_data *priv, unsigned int cod= e); + +static irqreturn_t asus_ec_interrupt(int irq, void *dev_id) +{ + struct asus_ec_data *priv =3D dev_id; + unsigned long notify_action; + int ret; + + ret =3D asus_ec_read(priv, true); + if (ret <=3D 0 || !(priv->ec_data[1] & ASUSEC_OBF_MASK)) + return IRQ_NONE; + + notify_action =3D priv->ec_data[1]; + if (notify_action & ASUSEC_SMI_MASK) { + unsigned int code =3D priv->ec_data[2]; + + asus_ec_handle_smi(priv, code); + + notify_action |=3D code << 8; + dev_dbg(&priv->self->dev, "SMI code: 0x%02x\n", code); + } + + blocking_notifier_call_chain(&priv->info.notify_list, + notify_action, priv->ec_data); + + return IRQ_HANDLED; +} + +static int asus_ec_detect(struct asus_ec_data *priv) +{ + char *model =3D NULL; + int ret; + + ret =3D asus_ec_reset(priv); + if (ret) + goto err_exit; + + asus_ec_clear_buffer(priv); + + ret =3D asus_ec_log_info(priv, ASUSEC_DOCKRAM_INFO_MODEL, "model", &model= ); + if (ret) + goto err_exit; + + ret =3D asus_ec_log_info(priv, ASUSEC_DOCKRAM_INFO_FW, "FW version", NULL= ); + if (ret) + goto err_exit; + + ret =3D asus_ec_log_info(priv, ASUSEC_DOCKRAM_INFO_CFGFMT, "Config format= ", NULL); + if (ret) + goto err_exit; + + ret =3D asus_ec_log_info(priv, ASUSEC_DOCKRAM_INFO_HW, "HW version", NULL= ); + if (ret) + goto err_exit; + + priv->logging_disabled =3D true; + + ret =3D asus_ec_magic_debug(priv); + if (ret) + goto err_exit; + + priv->info.model =3D model; + priv->info.name =3D priv->data->name; + + if (priv->data->clr_fmode) + asus_ec_set_factory_mode(priv, false); + +err_exit: + if (ret) + dev_err(&priv->self->dev, "failed to access EC: %d\n", ret); + + return ret; +} + +static void asus_ec_handle_smi(struct asus_ec_data *priv, unsigned int cod= e) +{ + dev_dbg(&priv->self->dev, "SMI interrupt: 0x%02x\n", code); + + switch (code) { + case ASUSEC_SMI_HANDSHAKE: + case ASUSEC_SMI_RESET: + asus_ec_detect(priv); + break; + } +} + +static ssize_t dockram_read(struct file *filp, char __user *buf, + size_t count, loff_t *ppos) +{ + struct i2c_client *client =3D filp->private_data; + unsigned int reg, rsize; + ssize_t n_read =3D 0, val; + loff_t off =3D *ppos; + char *data; + int ret; + + reg =3D off / DOCKRAM_ENTRY_SIZE; + off %=3D DOCKRAM_ENTRY_SIZE; + rsize =3D DOCKRAM_ENTRIES * DOCKRAM_ENTRY_SIZE; + + if (!count) + return 0; + + data =3D kmalloc(DOCKRAM_ENTRY_BUFSIZE, GFP_KERNEL); + + while (reg < DOCKRAM_ENTRIES) { + unsigned int len =3D DOCKRAM_ENTRY_SIZE - off; + + if (len > rsize) + len =3D rsize; + + ret =3D asus_dockram_read(client, reg, data); + if (ret < 0) { + if (!n_read) + n_read =3D ret; + break; + } + + val =3D copy_to_user(buf, data + 1 + off, len); + if (val =3D=3D len) + return -EFAULT; + + *ppos +=3D len; + n_read +=3D len; + + if (len =3D=3D rsize) + break; + + rsize -=3D len; + buf +=3D len; + off =3D 0; + ++reg; + } + + kfree(data); + + return n_read; +} + +static int dockram_write_one(struct i2c_client *client, int reg, + const char __user *buf, size_t count) +{ + struct dockram_ec_data *priv =3D i2c_get_clientdata(client); + int ret; + + if (!count || count > DOCKRAM_ENTRY_SIZE) + return -EINVAL; + if (buf[0] !=3D count - 1) + return -EINVAL; + + guard(mutex)(&priv->ctl_lock); + + priv->ctl_data[0] =3D (u8)count; + memcpy(priv->ctl_data + 1, buf, count); + ret =3D asus_dockram_write(client, reg, priv->ctl_data); + + return ret; +} + +static ssize_t dockram_write(struct file *filp, const char __user *buf, + size_t count, loff_t *ppos) +{ + struct i2c_client *client =3D filp->private_data; + unsigned int reg; + loff_t off =3D *ppos; + int ret; + + if (off % DOCKRAM_ENTRY_SIZE !=3D 0) + return -EINVAL; + + reg =3D off / DOCKRAM_ENTRY_SIZE; + if (reg >=3D DOCKRAM_ENTRIES) + return -EINVAL; + + ret =3D dockram_write_one(client, reg, buf, count); + + return ret < 0 ? ret : count; +} + +static const struct debugfs_short_fops dockram_fops =3D { + .read =3D dockram_read, + .write =3D dockram_write, + .llseek =3D default_llseek, +}; + +static int control_reg_get(void *client, u64 *val) +{ + return asus_dockram_access_ctl(client, val, 0, 0); +} + +static int control_reg_set(void *client, u64 val) +{ + return asus_dockram_access_ctl(client, NULL, ~0ull, val); +} + +DEFINE_DEBUGFS_ATTRIBUTE(control_reg_fops, control_reg_get, + control_reg_set, "%016llx\n"); + +static int ec_request_set(void *ec, u64 val) +{ + if (val) + asus_ec_signal_request(ec); + + return 0; +} + +DEFINE_DEBUGFS_ATTRIBUTE(ec_request_fops, NULL, ec_request_set, "%llu\n"); + +static int ec_irq_set(void *ec, u64 val) +{ + struct asus_ec_data *priv =3D to_ec_data(ec); + + if (val) + irq_wake_thread(priv->self->irq, priv); + + return 0; +} + +DEFINE_DEBUGFS_ATTRIBUTE(ec_irq_fops, NULL, ec_irq_set, "%llu\n"); + +static void asus_ec_debugfs_remove(void *debugfs_root) +{ + debugfs_remove_recursive(debugfs_root); +} + +static void devm_asus_ec_debugfs_init(struct device *dev) +{ + struct asusec_info *ec =3D dev_get_drvdata(dev); + struct asus_ec_data *priv =3D to_ec_data(ec); + struct dentry *debugfs_root, *dockram_dir; + char *name =3D devm_kasprintf(dev, GFP_KERNEL, "asus-ec-%s", + priv->data->name); + + debugfs_root =3D debugfs_create_dir(name, NULL); + dockram_dir =3D debugfs_create_dir("dockram", debugfs_root); + + debugfs_create_file("ec_irq", 0200, debugfs_root, ec, + &ec_irq_fops); + debugfs_create_file("ec_request", 0200, debugfs_root, ec, + &ec_request_fops); + debugfs_create_file("control_reg", 0644, dockram_dir, + priv->info.dockram, &control_reg_fops); + debugfs_create_file("dockram", 0644, dockram_dir, + priv->info.dockram, &dockram_fops); + + devm_add_action_or_reset(dev, asus_ec_debugfs_remove, debugfs_root); +} + +static void asus_ec_release_dockram_dev(void *client) +{ + i2c_unregister_device(client); +} + +static struct i2c_client *devm_asus_dockram_get(struct device *dev) +{ + struct i2c_client *parent =3D to_i2c_client(dev); + struct i2c_client *dockram; + struct dockram_ec_data *priv; + int ret; + + dockram =3D i2c_new_ancillary_device(parent, "dockram", + parent->addr + 2); + if (IS_ERR(dockram)) + return dockram; + + ret =3D devm_add_action_or_reset(dev, asus_ec_release_dockram_dev, + dockram); + if (ret) + return ERR_PTR(ret); + + priv =3D devm_kzalloc(&dockram->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return ERR_PTR(-ENOMEM); + + i2c_set_clientdata(dockram, priv); + mutex_init(&priv->ctl_lock); + + return dockram; +} + +static int asus_ec_probe(struct i2c_client *client) +{ + struct device *dev =3D &client->dev; + struct asus_ec_data *priv; + int ret; + + if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_I2C_BLOCK)) + return dev_err_probe(dev, -ENXIO, + "I2C bus is missing required SMBus block mode support\n"); + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->data =3D device_get_match_data(dev); + if (!priv->data) + return -ENODEV; + + i2c_set_clientdata(client, priv); + priv->self =3D client; + + priv->info.dockram =3D devm_asus_dockram_get(dev); + if (IS_ERR(priv->info.dockram)) + return dev_err_probe(dev, PTR_ERR(priv->info.dockram), + "failed to get dockram\n"); + + priv->ecreq =3D devm_gpiod_get(dev, "request", GPIOD_OUT_LOW); + if (IS_ERR(priv->ecreq)) + return dev_err_probe(dev, PTR_ERR(priv->ecreq), + "failed to get request GPIO\n"); + + BLOCKING_INIT_NOTIFIER_HEAD(&priv->info.notify_list); + mutex_init(&priv->ecreq_lock); + + asus_ec_signal_request(&priv->info); + + ret =3D asus_ec_detect(priv); + if (ret) + return dev_err_probe(dev, ret, "failed to detect EC version\n"); + + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, + &asus_ec_interrupt, + IRQF_ONESHOT | IRQF_SHARED, + client->name, priv); + if (ret) + return dev_err_probe(dev, ret, "failed to register IRQ\n"); + + /* Parent I2C controller uses DMA, ASUS EC and child devices do not */ + client->dev.coherent_dma_mask =3D 0; + client->dev.dma_mask =3D &client->dev.coherent_dma_mask; + + if (IS_ENABLED(CONFIG_DEBUG_FS)) + devm_asus_ec_debugfs_init(dev); + + return devm_mfd_add_devices(dev, 0, priv->data->mfd_devices, + priv->data->num_devices, NULL, 0, NULL); +} + +static const struct mfd_cell asus_ec_sl101_dock_mfd_devices[] =3D { + { + .name =3D "asus-transformer-ec-kbc", + }, +}; + +static const struct asus_ec_chip_data asus_ec_sl101_dock_data =3D { + .name =3D "dock", + .mfd_devices =3D asus_ec_sl101_dock_mfd_devices, + .num_devices =3D ARRAY_SIZE(asus_ec_sl101_dock_mfd_devices), + .clr_fmode =3D false, +}; + +static const struct mfd_cell asus_ec_tf101_dock_mfd_devices[] =3D { + { + .name =3D "asus-transformer-ec-battery", + .id =3D 1, + }, { + .name =3D "asus-transformer-ec-charger", + .id =3D 1, + }, { + .name =3D "asus-transformer-ec-led", + .id =3D 1, + }, { + .name =3D "asus-transformer-ec-keys", + }, { + .name =3D "asus-transformer-ec-kbc", + }, +}; + +static const struct asus_ec_chip_data asus_ec_tf101_dock_data =3D { + .name =3D "dock", + .mfd_devices =3D asus_ec_tf101_dock_mfd_devices, + .num_devices =3D ARRAY_SIZE(asus_ec_tf101_dock_mfd_devices), + .clr_fmode =3D false, +}; + +static const struct mfd_cell asus_ec_tf201_pad_mfd_devices[] =3D { + { + .name =3D "asus-transformer-ec-battery", + .id =3D 0, + }, { + .name =3D "asus-transformer-ec-led", + .id =3D 0, + }, +}; + +static const struct asus_ec_chip_data asus_ec_tf201_pad_data =3D { + .name =3D "pad", + .mfd_devices =3D asus_ec_tf201_pad_mfd_devices, + .num_devices =3D ARRAY_SIZE(asus_ec_tf201_pad_mfd_devices), + .clr_fmode =3D true, +}; + +static const struct mfd_cell asus_ec_tf600t_pad_mfd_devices[] =3D { + { + .name =3D "asus-transformer-ec-battery", + .id =3D 0, + }, { + .name =3D "asus-transformer-ec-charger", + .id =3D 0, + }, { + .name =3D "asus-transformer-ec-led", + .id =3D 0, + }, +}; + +static const struct asus_ec_chip_data asus_ec_tf600t_pad_data =3D { + .name =3D "pad", + .mfd_devices =3D asus_ec_tf600t_pad_mfd_devices, + .num_devices =3D ARRAY_SIZE(asus_ec_tf600t_pad_mfd_devices), + .clr_fmode =3D true, +}; + +static const struct of_device_id asus_ec_match[] =3D { + { .compatible =3D "asus,sl101-ec-dock", .data =3D &asus_ec_sl101_dock_dat= a }, + { .compatible =3D "asus,tf101-ec-dock", .data =3D &asus_ec_tf101_dock_dat= a }, + { .compatible =3D "asus,tf201-ec-pad", .data =3D &asus_ec_tf201_pad_data = }, + { .compatible =3D "asus,tf600t-ec-pad", .data =3D &asus_ec_tf600t_pad_dat= a }, + { } +}; +MODULE_DEVICE_TABLE(of, asus_ec_match); + +static struct i2c_driver asus_ec_driver =3D { + .driver =3D { + .name =3D "asus-transformer-ec", + .of_match_table =3D asus_ec_match, + }, + .probe =3D asus_ec_probe, +}; +module_i2c_driver(asus_ec_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_AUTHOR("Svyatoslav Ryhel "); +MODULE_DESCRIPTION("ASUS Transformer's EC driver"); +MODULE_LICENSE("GPL"); diff --git a/include/linux/mfd/asus-transformer-ec.h b/include/linux/mfd/as= us-transformer-ec.h new file mode 100644 index 000000000000..0a72de40352e --- /dev/null +++ b/include/linux/mfd/asus-transformer-ec.h @@ -0,0 +1,162 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __MFD_ASUS_TRANSFORMER_EC_H +#define __MFD_ASUS_TRANSFORMER_EC_H + +#include +#include +#include + +struct i2c_client; + +struct asusec_info { + const char *model; + const char *name; + struct i2c_client *dockram; + struct workqueue_struct *wq; + struct blocking_notifier_head notify_list; +}; + +#define DOCKRAM_ENTRIES 0x100 +#define DOCKRAM_ENTRY_SIZE 32 +#define DOCKRAM_ENTRY_BUFSIZE (DOCKRAM_ENTRY_SIZE + 1) + +/* interrupt sources */ +#define ASUSEC_OBF_MASK BIT(0) +#define ASUSEC_KEY_MASK BIT(2) +#define ASUSEC_KBC_MASK BIT(3) +#define ASUSEC_AUX_MASK BIT(5) +#define ASUSEC_SCI_MASK BIT(6) +#define ASUSEC_SMI_MASK BIT(7) + +/* SMI notification codes */ +#define ASUSEC_SMI_POWER_NOTIFY 0x31 /* [un]plugging USB cable */ +#define ASUSEC_SMI_HANDSHAKE 0x50 /* response to ec_req edge */ +#define ASUSEC_SMI_WAKE 0x53 +#define ASUSEC_SMI_RESET 0x5f +#define ASUSEC_SMI_ADAPTER_EVENT 0x60 /* [un]plugging charger to dock */ +#define ASUSEC_SMI_BACKLIGHT_ON 0x63 +#define ASUSEC_SMI_AUDIO_DOCK_IN 0x70 + +#define ASUSEC_SMI_ACTION(code) (ASUSEC_SMI_MASK | ASUSEC_OBF_MASK | \ + (ASUSEC_SMI_##code << 8)) + +/* control register [0x0a] layout */ +#define ASUSEC_CTL_SIZE 8 + +/* + * EC reports power from 40-pin connector in the LSB of the control + * register. The following values have been observed (xor 0x02): + * + * PAD-ec no-plug 0x40 / PAD-ec DOCK 0x20 / DOCK-ec no-plug 0x40 + * PAD-ec AC 0x25 / PAD-ec DOCK+AC 0x24 / DOCK-ec AC 0x25 + * PAD-ec USB 0x45 / PAD-ec DOCK+USB 0x24 / DOCK-ec USB 0x41 + */ + +#define ASUSEC_CTL_DIRECT_POWER_SOURCE BIT_ULL(0) +#define ASUSEC_STAT_CHARGING BIT_ULL(2) +#define ASUSEC_CTL_FULL_POWER_SOURCE BIT_ULL(5) +#define ASUSEC_CTL_SUSB_MODE BIT_ULL(9) +#define ASUSEC_CMD_SUSPEND_S3 BIT_ULL(33) +#define ASUSEC_CTL_TEST_DISCHARGE BIT_ULL(35) +#define ASUSEC_CMD_SUSPEND_INHIBIT BIT_ULL(37) +#define ASUSEC_CTL_FACTORY_MODE BIT_ULL(38) +#define ASUSEC_CTL_KEEP_AWAKE BIT_ULL(39) +#define ASUSEC_CTL_USB_CHARGE BIT_ULL(40) +#define ASUSEC_CTL_LED_BLINK BIT_ULL(40) +#define ASUSEC_CTL_LED_AMBER BIT_ULL(41) +#define ASUSEC_CTL_LED_GREEN BIT_ULL(42) +#define ASUSEC_CMD_SWITCH_HDMI BIT_ULL(56) +#define ASUSEC_CMD_WIN_SHUTDOWN BIT_ULL(62) + +#define ASUSEC_DOCKRAM_INFO_MODEL 0x01 +#define ASUSEC_DOCKRAM_INFO_FW 0x02 +#define ASUSEC_DOCKRAM_INFO_CFGFMT 0x03 +#define ASUSEC_DOCKRAM_INFO_HW 0x04 +#define ASUSEC_DOCKRAM_CONTROL 0x0a +#define ASUSEC_DOCKRAM_BATT_CTL 0x14 + +#define ASUSEC_WRITE_BUF 0x64 +#define ASUSEC_READ_BUF 0x6a + +/* dockram comm */ +int asus_dockram_read(struct i2c_client *client, int reg, char *buf); +int asus_dockram_write(struct i2c_client *client, int reg, const char *buf= ); +int asus_dockram_access_ctl(struct i2c_client *client, + u64 *out, u64 mask, u64 xor); + +/* EC public API */ + +/** + * cell_to_ec - Request the shared ASUS EC structure via a subdevice's pde= v. + * @pdev: EC subdevice pdev requesting access to the shared ASUS EC struct= ure. + * + * Returns a pointer to the asusec_info structure. + */ +static inline struct asusec_info *cell_to_ec(struct platform_device *pdev) +{ + return dev_get_drvdata(pdev->dev.parent); +} + +/** + * asus_ec_get_ctl - Read from the DockRAM control register. + * @ec: Pointer to the shared ASUS EC structure. + * @out: Pointer to the variable where the register value will be stored. + * + * Performs a control register read and stores the value in @out. + * + * Return: 0 on success, or a negative errno code on failure. + */ +static inline int asus_ec_get_ctl(const struct asusec_info *ec, u64 *out) +{ + return asus_dockram_access_ctl(ec->dockram, out, 0, 0); +} + +/** + * asus_ec_update_ctl - Update the DockRAM control register. + * @ec: Pointer to the shared ASUS EC structure. + * @mask: Bitmask of bits to be cleared. + * @xor: Bitmask of bits to be toggled or set (via XOR). + * + * Performs a read-modify-write update on the control register using + * the provided @mask and @xor values. + * + * Return: 0 on success, or a negative errno code on failure. + */ +static inline int asus_ec_update_ctl(const struct asusec_info *ec, + u64 mask, u64 xor) +{ + return asus_dockram_access_ctl(ec->dockram, NULL, mask, xor); +} + +/** + * asus_ec_set_ctl_bits - Sets bits of the DockRAM control register. + * @ec: Pointer to the shared ASUS EC structure. + * @mask: Bitmask of bits to be set. + * + * Sets bits of the control register using the provided @mask value. + * + * Return: 0 on success, or a negative errno code on failure. + */ +static inline int asus_ec_set_ctl_bits(const struct asusec_info *ec, u64 m= ask) +{ + return asus_dockram_access_ctl(ec->dockram, NULL, mask, mask); +} + +/** + * asus_ec_clear_ctl_bits - Clears bits of the DockRAM control register. + * @ec: Pointer to the shared ASUS EC structure. + * @mask: Bitmask of bits to be cleared. + * + * Clears bits of the control register using the provided @mask value. + * + * Return: 0 on success, or a negative errno code on failure. + */ +static inline int asus_ec_clear_ctl_bits(const struct asusec_info *ec, u64= mask) +{ + return asus_dockram_access_ctl(ec->dockram, NULL, mask, 0); +} + +int asus_ec_i2c_command(const struct asusec_info *ec, u16 data); +int devm_asus_ec_register_notifier(struct platform_device *dev, + struct notifier_block *nb); +#endif /* __MFD_ASUS_TRANSFORMER_EC_H */ --=20 2.51.0 From nobody Thu Apr 2 14:07:59 2026 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6E5E3DBD46 for ; Wed, 4 Mar 2026 18:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650692; cv=none; b=LrHorx9P/HrzpXthUXbkBwziPdrAqcFwJ/W55l791YbGEiU7pdH2xDUT7xFy1UQRXXld7HFGKbuw55QsA6K8MckRzt/JYK1xrqAoj1nuqmL13Cu+6FZ2aDrJDPyfj7cjTyyV0eJtksX2/EJjidIBbdBLNx8nY5wLQTj4CfVgkH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650692; c=relaxed/simple; bh=LOjxMtUEiS4cNMWq1QoDk6BPRM0HvYSyeLI5k5nkNkA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hs9FcAjNcOJmr4zpKLlyLYL32f7owmftOQ2fdlnoe7LHdb7QSdi4kCwv0pFLLWtVg1OCT7aN0mVRQPjck2g9J/wRXDBCvQIKfq9mhiP3/W5fwOodQHfsJsW9lEfflXxIVSNTn7Z6c/ZDDGjIC6W0rXd/3edNL3K791xFCnyoajw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U3tIqnfK; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U3tIqnfK" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-386fb2c31e2so132625331fa.1 for ; Wed, 04 Mar 2026 10:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772650686; x=1773255486; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DNOE7jd4qzR4EDDWV5mqgo/ldDWXaWc2vNzYIUVYGLw=; b=U3tIqnfK6gkeE5YaFC2VhekSRhAaajtqSezo/ae+4TRPMEgwTYordw3tie60+eu32K dcpLN0QxkfIAm+juNSM6MdRQwuaP93uJNS8PVAMTM655HsQ1O419cKrvJH4DoAD5cPkY ybYtRnNo3HcBNl87DawCdbx0rzlQXkgGqVumMF5Ccln3EU5XYP+GfidHsIIb8468zapj CR05XHODUJYIewPoHAu6ZvsMzvQXLbgPw+qkFqX7hBb49JbuHtohhTdJqbrFDCPTxVDS Rj29CC/a+GFlNm492Fs3hwRMM8FtCFQmKRoQkrzyjZi6vNt++NyyXv9Rh2/3vVbnWtUL DT8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772650686; x=1773255486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DNOE7jd4qzR4EDDWV5mqgo/ldDWXaWc2vNzYIUVYGLw=; b=sTG6meCPH4OeQX3vEm7mPIjEM4c5gO5ztfR7u8TU6uZuU4/T9OIE6wBrldI762zPM1 n6h+8r7jgeXcs1IMJDYTIK8KAZIyqRhmJHj/w7jZMI6Tqu1kB6fzDZ4xmx+wtSELKoba WNAunUgyw7Jp3uXkyg8Ce6EuCI8sZ7aE/CLGCbl+eh8MLKBtL2W7+p9qLqeb3ByhxurW x8ScqcGGb3LH4ly/dNA6Wl+jqVpYESDT22BoP/QFCPTFezmjsyFRmTdtP3blt/loqqzZ aw5RyYF5pnXJ7fXmJpuLGdpMa+mw+nZncHB2IecaMhHMixs/0eG2Mt014dERxDlop4Wi xaJA== X-Forwarded-Encrypted: i=1; AJvYcCU4UvzRoA99rT8y8lg3pJoBqD9CSsspPEhXDRyY4iOD7NDK1UOOr7SjwilLR/1Pr7c/Xx744GzNWH7CeU8=@vger.kernel.org X-Gm-Message-State: AOJu0YyIjLarKnVzAUkPrcn+mouWdRRz05aaCMbCvGj9C6HKF6YXPFCQ VHBtwvKnn6J0Wf9ltVowe1te2++icfYhgpd8/T8EWdeBeaKHKkWD+E9E X-Gm-Gg: ATEYQzxhEySnKlJMkIaKxe1BOxMTdENg/FP7O7L4f8jZoAA1cLYNM74zytjI7LfQqXL 9Jfj6uJGAolI3O6uuOVJeIGDlgaR5mCZnkum6/wN28hUjDT7wt+7sRztC8gNRUl0fth6bTT3gTe OFl6R1WWVv5C2OZ14lJm4hvYDhYsP+enbgYi86HFYVkEWRlBrMtgVwZOHwsPV9j7f+TjXqQfoRr ogUz9YU4kyut8Moq11DdGS/JUFDzplhBp3ABDHOBM5xtoKB0Aw57p9gYBmKlECPHtqVfeqK4wVs ZPPiVJeNZ3TSsRuETMz75QmA4mmxFxufnQhtWZrmfrnK91YkEqkpV4Y0at2Mjqonc7rrUaBRUdr JTVGiDrWTrjZIqa6o2bvMPlYYf+Zuc1exouQ0ntbMPzCiFQlaJ5VbJhlD/YMkJ81hp9jNzCPcBf GKp18OJ596wSyw X-Received: by 2002:a2e:b88f:0:b0:380:c72:d495 with SMTP id 38308e7fff4ca-38a2c7d4f0dmr26972481fa.32.1772650685991; Wed, 04 Mar 2026 10:58:05 -0800 (PST) Received: from xeon ([188.163.112.72]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a12a6ddd3bsm704985e87.0.2026.03.04.10.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 10:58:05 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v5 3/7] input: serio: Add driver for ASUS Transformer dock keyboard and touchpad Date: Wed, 4 Mar 2026 20:57:47 +0200 Message-ID: <20260304185751.83494-4-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304185751.83494-1-clamor95@gmail.com> References: <20260304185751.83494-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add input driver for ASUS Transformer dock keyboard and touchpad. Some keys in ASUS Dock report keycodes that don't make sense according to their position, this patch modifies the incoming data that is sent to serio to send proper scancodes. Co-developed-by: Ion Agorria Signed-off-by: Ion Agorria Signed-off-by: Micha=C5=82 Miros=C5=82aw Signed-off-by: Svyatoslav Ryhel --- drivers/input/serio/Kconfig | 15 ++ drivers/input/serio/Makefile | 1 + drivers/input/serio/asus-transformer-ec-kbc.c | 147 ++++++++++++++++++ 3 files changed, 163 insertions(+) create mode 100644 drivers/input/serio/asus-transformer-ec-kbc.c diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig index c7ef347a4dff..1ca17ba632cc 100644 --- a/drivers/input/serio/Kconfig +++ b/drivers/input/serio/Kconfig @@ -97,6 +97,21 @@ config SERIO_RPCKBD To compile this driver as a module, choose M here: the module will be called rpckbd. =20 +config SERIO_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's Dock keyboard and touchpad controller" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here if you want to use the keyboard and/or touchpad on + Asus Transformed's Mobile Dock. + + For keyboard support you also need atkbd driver. + + For touchpad support you also need psmouse driver with Elantech + touchpad option enabled. + + To compile this driver as a module, choose M here: the module will + be called asus-transformer-ec-kbc. + config SERIO_AMBAKMI tristate "AMBA KMI keyboard controller" depends on ARM_AMBA diff --git a/drivers/input/serio/Makefile b/drivers/input/serio/Makefile index 6d97bad7b844..9ecf0d011863 100644 --- a/drivers/input/serio/Makefile +++ b/drivers/input/serio/Makefile @@ -13,6 +13,7 @@ obj-$(CONFIG_SERIO_CT82C710) +=3D ct82c710.o obj-$(CONFIG_SERIO_RPCKBD) +=3D rpckbd.o obj-$(CONFIG_SERIO_SA1111) +=3D sa1111ps2.o obj-$(CONFIG_SERIO_AMBAKMI) +=3D ambakmi.o +obj-$(CONFIG_SERIO_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec-kbc.o obj-$(CONFIG_SERIO_Q40KBD) +=3D q40kbd.o obj-$(CONFIG_SERIO_GSCPS2) +=3D gscps2.o obj-$(CONFIG_HP_SDC) +=3D hp_sdc.o diff --git a/drivers/input/serio/asus-transformer-ec-kbc.c b/drivers/input/= serio/asus-transformer-ec-kbc.c new file mode 100644 index 000000000000..47fd6e48c989 --- /dev/null +++ b/drivers/input/serio/asus-transformer-ec-kbc.c @@ -0,0 +1,147 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include + +struct asus_ec_kbc_data { + struct notifier_block nb; + struct asusec_info *ec; + struct serio *sdev[2]; +}; + +static int asus_ec_kbc_notify(struct notifier_block *nb, + unsigned long action, void *data_) +{ + struct asus_ec_kbc_data *priv =3D container_of(nb, struct asus_ec_kbc_dat= a, nb); + unsigned int port_idx, n; + u8 *data =3D data_; + + if (action & (ASUSEC_SMI_MASK | ASUSEC_SCI_MASK)) + return NOTIFY_DONE; + else if (action & ASUSEC_AUX_MASK) + port_idx =3D 1; + else if (action & (ASUSEC_KBC_MASK | ASUSEC_KEY_MASK)) + port_idx =3D 0; + else + return NOTIFY_DONE; + + n =3D data[0] - 1; + data +=3D 2; + + /* + * We need to replace these incoming data for keys: + * RIGHT_META Press 0xE0 0x27 -> LEFT_ALT Press 0x11 + * RIGHT_META Release 0xE0 0xF0 0x27 -> LEFT_ALT Release 0xF0 0x11 + * COMPOSE Press 0xE0 0x2F -> RIGHT_META Press 0xE0 0x27 + * COMPOSE Release 0xE0 0xF0 0x2F -> RIGHT_META Release 0xE0 0xF0 0x27 + */ + + if (port_idx =3D=3D 0 && n >=3D 2 && data[0] =3D=3D 0xE0) { + if (n =3D=3D 3 && data[1] =3D=3D 0xF0) { + switch (data[2]) { + case 0x27: + data[0] =3D 0xF0; + data[1] =3D 0x11; + n =3D 2; + break; + case 0x2F: + data[2] =3D 0x27; + break; + } + } else if (n =3D=3D 2) { + switch (data[1]) { + case 0x27: + data[0] =3D 0x11; + n =3D 1; + break; + case 0x2F: + data[1] =3D 0x27; + break; + } + } + } + + while (n--) + serio_interrupt(priv->sdev[port_idx], *data++, 0); + + return NOTIFY_OK; +} + +static int asus_ec_serio_write(struct serio *port, unsigned char data) +{ + const struct asusec_info *ec =3D port->port_data; + + return asus_ec_i2c_command(ec, (data << 8) | port->id.extra); +} + +static void asus_ec_serio_remove(void *data) +{ + serio_unregister_port(data); +} + +static int asus_ec_register_serio(struct platform_device *pdev, int idx, + const char *name, int cmd) +{ + struct asus_ec_kbc_data *priv =3D platform_get_drvdata(pdev); + struct i2c_client *parent =3D to_i2c_client(pdev->dev.parent); + struct serio *port =3D kzalloc_obj(*port); + + if (!port) + return -ENOMEM; + + priv->sdev[idx] =3D port; + port->dev.parent =3D &pdev->dev; + port->id.type =3D SERIO_8042; + port->id.extra =3D cmd & 0xFF; + port->write =3D asus_ec_serio_write; + port->port_data =3D (void *)priv->ec; + snprintf(port->name, sizeof(port->name), "%s %s", + priv->ec->model, name); + snprintf(port->phys, sizeof(port->phys), "i2c-%u-%04x/serio%d", + i2c_adapter_id(parent->adapter), parent->addr, idx); + + serio_register_port(port); + + return devm_add_action_or_reset(&pdev->dev, asus_ec_serio_remove, port); +} + +static int asus_ec_kbc_probe(struct platform_device *pdev) +{ + struct asusec_info *ec =3D cell_to_ec(pdev); + struct asus_ec_kbc_data *priv; + int ret; + + priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + priv->ec =3D ec; + + ret =3D asus_ec_register_serio(pdev, 0, "Keyboard", 0); + if (ret < 0) + return ret; + + ret =3D asus_ec_register_serio(pdev, 1, "Touchpad", I8042_CMD_AUX_SEND); + if (ret < 0) + return ret; + + priv->nb.notifier_call =3D asus_ec_kbc_notify; + + return devm_asus_ec_register_notifier(pdev, &priv->nb); +} + +static struct platform_driver asus_ec_kbc_driver =3D { + .driver.name =3D "asus-transformer-ec-kbc", + .probe =3D asus_ec_kbc_probe, +}; +module_platform_driver(asus_ec_kbc_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer's Dock keyboard and touchpad controll= er driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Thu Apr 2 14:07:59 2026 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D2883D6CC2 for ; Wed, 4 Mar 2026 18:58:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650693; cv=none; b=ukfiEq4qnmj+KjzytYgNnnQXhcbrtJzMqfTQL0p7YgQWBh4oUiNNPmcR+7x7t3jRO5COh+/LxE7Cr25bQUdiSRH+QWMwtu6iDej5JQvce5aYCfehCRbbFXcRvfmOlYNCMziUsMhupnE0hH9vAiCv+fmv+jTSUirOJHOX7wyhk20= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650693; c=relaxed/simple; bh=ZTqgWtpj6tKUgf32dtc8i7L8MjH0YqS/79IDbEUtnwg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R96gQismtb0FH3ry6/ToH7zO4jgnQfCpCwps2yyR89Qw2OkVOsFVjqVCS21YX0J3ur/y8E+7lxK+R7QogYp8j79pFXhAi3hsj0fBhmu4a/B+tFsvGc6C6yLS2NhC5terXmvW5XInjWjTByTgzYKhUsLEIEvZDB0YHH0ZmfC6EMk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NVeEnba4; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NVeEnba4" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-389e71756d8so139022101fa.2 for ; Wed, 04 Mar 2026 10:58:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772650687; x=1773255487; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RdovW4y7qNJYO1ZIVTtHt3DP+4V/Cdk3nKOn+FFq9HA=; b=NVeEnba4oSKuHcSSCz+BTGG/T2JcNWkhhFeTblqdxKeO2qSkK/Znbi0Xlvwp2h72CF 1Mhn6KfUvahEoIfx3x8OTFr1sqSbDWDqvbzijsIus2wf1t4gWN5VLE7H9f3fV8Fy72OP /kVwMoa7jm4zhOmcvWpe5X8eGYL4LNVHF912CbJvjI7DSEAGxNkCVAGG7BrAe6QDvwC3 pfSqPfP+YAbocvz/Xay3MrAQazol549WcYPUvxwtEeGLcj2BWR6pd3T9bxZBP3OxNZiR KFBvTHtE7cp3KzQCnsv7EKPYq+z3sWLoYdTHB3NSeLlwgR7QwRU9NtWXROxdDUXnYT6Y JLIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772650687; x=1773255487; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RdovW4y7qNJYO1ZIVTtHt3DP+4V/Cdk3nKOn+FFq9HA=; b=IlOSTkQnRKTQ7epBOxL/37zrGL25Aqw2lGwBi6vRFi91jzWVJ7OSAaNnDwvYQYBYq0 R0MgX/DL4psS8RXvaxLoHE/jVnJMY3sJBUC+/0YqwtTXHxtbu9SfFy0W0E9Le0Ofq/0B DpWI/7lmvqieWI4KVcRc1XQ/2dvTpFotnlkGdSdmIro5gqsQV77Rmq+qeiVlc98Dmk3y KlhGaX7UL6C/zYCgWkFXzlS+HzP6ByIrO7mfI293TTvCVVuAzFuhsmJRyq3n3cOAbTV2 r3bqfQctKpW7Inds7okkRf+Xe+i3+T885PD2gFobgErbSqE5efNAgqqZJCdlctDuFRVu 4kDg== X-Forwarded-Encrypted: i=1; AJvYcCW9JANBBnXImNSpPsfwU4gZaxRUrqdwdtigsUwlV56p0PiwgjQrUM4PADHGnhl6BP/fFDCu1o70ZBjpaR4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz16DirQTtyIZvTmzZBHh+aXN/gvGrwcZxA3nAD14mB3ULQLbal rptqQWDjdP9KWcJbS4zWlkrGnvWk6+plpnyxg+8Ksoi8uVL7r/Fv+/Yi X-Gm-Gg: ATEYQzxvyLywe4CXy3Rfa3eI3YeDb1vwYhFrvLn3wq6HTn3a6YCbt5mgyBOlqFDO+U7 zd7RtuivBjlJzMVEq2D9lZL2XLk3NzbGHrSRaIqz/XhhNEivjLRva52iUG1fFda0ZvPuXLVdObO fyNdqjV1VSWo84PgpHa1UGcDqwIueJDw44EdzuF6JClKQQFDTvPMiwR6RHQtNmBw6ENtMtQ0h7h ex6d6Sf6Z+5FanSJwqviNs77e18DuMEVNlg6Nx/+QB+7Ky4F4w3WwXMul7lwS6PJYh/NO0LJUKQ eMlhBTiWLHR9jr6J8eLABFVGuVg/6hwZ1kwS10+NILvuDVPtWcH9UMDzPWNBb+N5gcMgoEZlXwQ syj5EV/C4kWolM/gXARcYDHN9jVg7cr51eunWPYC2KXH2ffKVCiPvFouFc9GeIZCIIH///AnL+9 PTwv7MTguUBo+D X-Received: by 2002:a2e:bd13:0:b0:38a:3381:991f with SMTP id 38308e7fff4ca-38a33819db9mr3763751fa.2.1772650687124; Wed, 04 Mar 2026 10:58:07 -0800 (PST) Received: from xeon ([188.163.112.72]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a12a6ddd3bsm704985e87.0.2026.03.04.10.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 10:58:06 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v5 4/7] input: keyboard: Add driver for ASUS Transformer dock multimedia keys Date: Wed, 4 Mar 2026 20:57:48 +0200 Message-ID: <20260304185751.83494-5-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304185751.83494-1-clamor95@gmail.com> References: <20260304185751.83494-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add support for multimedia top button row of ASUS Transformer's Mobile Dock keyboard. Driver is made that function keys (F1-F12) are used by default which suits average Linux use better and with pressing ScreenLock + AltGr function keys layout is switched to multimedia keys. Since this only modifies codes sent by asus-ec-keys it doesn't affect normal keyboards at all. Co-developed-by: Ion Agorria Signed-off-by: Ion Agorria Signed-off-by: Micha=C5=82 Miros=C5=82aw Signed-off-by: Svyatoslav Ryhel --- drivers/input/keyboard/Kconfig | 10 + drivers/input/keyboard/Makefile | 1 + .../input/keyboard/asus-transformer-ec-keys.c | 272 ++++++++++++++++++ 3 files changed, 283 insertions(+) create mode 100644 drivers/input/keyboard/asus-transformer-ec-keys.c diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 2ff4fef322c2..4e577e5cf216 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -89,6 +89,16 @@ config KEYBOARD_APPLESPI To compile this driver as a module, choose M here: the module will be called applespi. =20 +config KEYBOARD_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's Mobile Dock multimedia keys" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here if you want to use multimedia keys present on Asus + Transformer's Mobile Dock. + + To compile this driver as a module, choose M here: the + module will be called asus-transformer-ec-keys. + config KEYBOARD_ATARI tristate "Atari keyboard" depends on ATARI diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makef= ile index 2d906e14f3e2..575edb0e8eb4 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -11,6 +11,7 @@ obj-$(CONFIG_KEYBOARD_ADP5585) +=3D adp5585-keys.o obj-$(CONFIG_KEYBOARD_ADP5588) +=3D adp5588-keys.o obj-$(CONFIG_KEYBOARD_AMIGA) +=3D amikbd.o obj-$(CONFIG_KEYBOARD_APPLESPI) +=3D applespi.o +obj-$(CONFIG_KEYBOARD_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec-keys.o obj-$(CONFIG_KEYBOARD_ATARI) +=3D atakbd.o obj-$(CONFIG_KEYBOARD_ATKBD) +=3D atkbd.o obj-$(CONFIG_KEYBOARD_BCM) +=3D bcm-keypad.o diff --git a/drivers/input/keyboard/asus-transformer-ec-keys.c b/drivers/in= put/keyboard/asus-transformer-ec-keys.c new file mode 100644 index 000000000000..02516ccb0b12 --- /dev/null +++ b/drivers/input/keyboard/asus-transformer-ec-keys.c @@ -0,0 +1,272 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_EXT_KEY_CODES 0x20 + +struct asus_ec_keys_data { + struct notifier_block nb; + struct asusec_info *ec; + struct input_dev *xidev; + bool special_key_pressed; + bool special_key_mode; + unsigned short keymap[ASUSEC_EXT_KEY_CODES * 2]; +}; + +static void asus_ec_input_event(struct input_handle *handle, + unsigned int event_type, + unsigned int event_code, int value) +{ + struct asus_ec_keys_data *priv =3D handle->handler->private; + + /* Store special key state */ + if (event_type =3D=3D EV_KEY && event_code =3D=3D KEY_RIGHTALT) + priv->special_key_pressed =3D !!value; +} + +static int asus_ec_input_connect(struct input_handler *handler, struct inp= ut_dev *dev, + const struct input_device_id *id) +{ + struct input_handle *handle; + int error; + + handle =3D kzalloc_obj(*handle); + if (!handle) + return -ENOMEM; + + handle->dev =3D dev; + handle->handler =3D handler; + handle->name =3D "asusec-media-handler"; + + error =3D input_register_handle(handle); + if (error) + goto err_free_handle; + + error =3D input_open_device(handle); + if (error) + goto err_unregister_handle; + + return 0; + + err_unregister_handle: + input_unregister_handle(handle); + err_free_handle: + kfree(handle); + + return error; +} + +static void asus_ec_input_disconnect(struct input_handle *handle) +{ + input_close_device(handle); + input_unregister_handle(handle); + kfree(handle); +} + +static const struct input_device_id asus_ec_input_ids[] =3D { + { + .flags =3D INPUT_DEVICE_ID_MATCH_EVBIT, + .evbit =3D { BIT_MASK(EV_KEY) }, + }, + { } +}; + +static struct input_handler asus_ec_input_handler =3D { + .name =3D "asusec-media-handler", + .event =3D asus_ec_input_event, + .connect =3D asus_ec_input_connect, + .disconnect =3D asus_ec_input_disconnect, + .id_table =3D asus_ec_input_ids, +}; + +static const unsigned short asus_ec_dock_ext_keys[] =3D { + /* Function keys [0x00 - 0x19] */ + [0x01] =3D KEY_DELETE, + [0x02] =3D KEY_F1, + [0x03] =3D KEY_F2, + [0x04] =3D KEY_F3, + [0x05] =3D KEY_F4, + [0x06] =3D KEY_F5, + [0x07] =3D KEY_F6, + [0x08] =3D KEY_F7, + [0x10] =3D KEY_F8, + [0x11] =3D KEY_F9, + [0x12] =3D KEY_F10, + [0x13] =3D KEY_F11, + [0x14] =3D KEY_F12, + [0x15] =3D KEY_MUTE, + [0x16] =3D KEY_VOLUMEDOWN, + [0x17] =3D KEY_VOLUMEUP, + /* Multimedia keys [0x20 - 0x39] */ + [0x21] =3D KEY_SCREENLOCK, + [0x22] =3D KEY_WLAN, + [0x23] =3D KEY_BLUETOOTH, + [0x24] =3D KEY_TOUCHPAD_TOGGLE, + [0x25] =3D KEY_BRIGHTNESSDOWN, + [0x26] =3D KEY_BRIGHTNESSUP, + [0x27] =3D KEY_BRIGHTNESS_AUTO, + [0x28] =3D KEY_PRINT, + [0x30] =3D KEY_WWW, + [0x31] =3D KEY_CONFIG, + [0x32] =3D KEY_PREVIOUSSONG, + [0x33] =3D KEY_PLAYPAUSE, + [0x34] =3D KEY_NEXTSONG, + [0x35] =3D KEY_MUTE, + [0x36] =3D KEY_VOLUMEDOWN, + [0x37] =3D KEY_VOLUMEUP, +}; + +static void asus_ec_keys_report_key(struct input_dev *dev, unsigned int co= de, + unsigned int key, bool value) +{ + input_event(dev, EV_MSC, MSC_SCAN, code); + input_report_key(dev, key, value); + input_sync(dev); +} + +static int asus_ec_keys_process_key(struct input_dev *dev, u8 code) +{ + struct asus_ec_keys_data *priv =3D dev_get_drvdata(dev->dev.parent); + unsigned int key =3D 0; + + if (code =3D=3D 0) + return NOTIFY_DONE; + + /* Flip special key mode state when pressing key 1 with special key press= ed */ + if (priv->special_key_pressed && code =3D=3D 1) { + priv->special_key_mode =3D !priv->special_key_mode; + return NOTIFY_DONE; + } + + /* + * Relocate code to second "page" if pressed state XOR's mode state + * This way special key will invert the current mode + */ + if (priv->special_key_mode ^ priv->special_key_pressed) + code +=3D ASUSEC_EXT_KEY_CODES; + + if (code < dev->keycodemax) { + unsigned short *map =3D dev->keycode; + + key =3D map[code]; + } + + if (!key) + key =3D KEY_UNKNOWN; + + asus_ec_keys_report_key(dev, code, key, 1); + asus_ec_keys_report_key(dev, code, key, 0); + + return NOTIFY_OK; +} + +static int asus_ec_keys_notify(struct notifier_block *nb, + unsigned long action, void *data_) +{ + struct asus_ec_keys_data *priv =3D container_of(nb, struct asus_ec_keys_d= ata, nb); + u8 *data =3D data_; + + if (action & ASUSEC_SMI_MASK) + return NOTIFY_DONE; + + if (action & ASUSEC_SCI_MASK) + return asus_ec_keys_process_key(priv->xidev, data[2]); + + return NOTIFY_DONE; +} + +static void asus_ec_keys_setup_keymap(struct asus_ec_keys_data *priv) +{ + struct input_dev *dev =3D priv->xidev; + unsigned int i; + + BUILD_BUG_ON(ARRAY_SIZE(priv->keymap) < ARRAY_SIZE(asus_ec_dock_ext_keys)= ); + + dev->keycode =3D priv->keymap; + dev->keycodesize =3D sizeof(*priv->keymap); + dev->keycodemax =3D ARRAY_SIZE(priv->keymap); + + input_set_capability(dev, EV_MSC, MSC_SCAN); + input_set_capability(dev, EV_KEY, KEY_UNKNOWN); + + for (i =3D 0; i < ARRAY_SIZE(asus_ec_dock_ext_keys); i++) { + unsigned int code =3D asus_ec_dock_ext_keys[i]; + + if (!code) + continue; + + __set_bit(code, dev->keybit); + priv->keymap[i] =3D code; + } +} + +static void asus_ec_input_handler_deregister(void *priv) +{ + input_unregister_handler(&asus_ec_input_handler); +} + +static int asus_ec_keys_probe(struct platform_device *pdev) +{ + struct asusec_info *ec =3D cell_to_ec(pdev); + struct i2c_client *parent =3D to_i2c_client(pdev->dev.parent); + struct asus_ec_keys_data *priv; + int ret; + + priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + priv->ec =3D ec; + + priv->xidev =3D devm_input_allocate_device(&pdev->dev); + if (!priv->xidev) + return -ENOMEM; + + priv->xidev->name =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, + "%s Keyboard Ext", ec->model); + priv->xidev->phys =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, + "i2c-%u-%04x", + i2c_adapter_id(parent->adapter), + parent->addr); + asus_ec_keys_setup_keymap(priv); + + ret =3D input_register_device(priv->xidev); + if (ret < 0) { + dev_err(&pdev->dev, "failed to register extension keys: %d\n", + ret); + return ret; + } + + asus_ec_input_handler.private =3D priv; + + ret =3D input_register_handler(&asus_ec_input_handler); + if (ret) + return ret; + + ret =3D devm_add_action_or_reset(&pdev->dev, asus_ec_input_handler_deregi= ster, + priv); + if (ret) + return ret; + + priv->nb.notifier_call =3D asus_ec_keys_notify; + + return devm_asus_ec_register_notifier(pdev, &priv->nb); +} + +static struct platform_driver asus_ec_keys_driver =3D { + .driver.name =3D "asus-transformer-ec-keys", + .probe =3D asus_ec_keys_probe, +}; +module_platform_driver(asus_ec_keys_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer's multimedia keys driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Thu Apr 2 14:07:59 2026 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D3FA3DBD7F for ; Wed, 4 Mar 2026 18:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650693; cv=none; b=Eu/KWans9ngHi9l4ltqvggd3duHDdqMjol/s9VOSlJnuRxEjr4vuqZHeG4m634byDzmLxwvj3YcMHh7oZN/J1dsUvq6IK1YQnl+vcR3gBY1wGR2UBlnZb+JNUe2IzgiNDfsw1PEr/kt/K7nMRD6fMooDNeDnIfyoofc4lss9Og8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650693; c=relaxed/simple; bh=iAwN1L5RO+DcRjbiVg9nB/v71sR6G3TJGVFbQvAkWCY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qIw+AEkurcse0WmLBf2FKLqjPtp5DAfBOCciCQO2shrdoDlNXx/wdCEhZDht4Q3k+paZ8GW1sg5a2NHeKng+lXlbnjowTb/wgu6fZV0GaVbkV010t84JGSgddWd422XJzrNh6fhGgB+W2m9sL1Z0c9SiVm6x+pIPK1NbQ7AG40s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wo6JTunx; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wo6JTunx" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-389e71756d8so139022571fa.2 for ; Wed, 04 Mar 2026 10:58:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772650688; x=1773255488; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7KTN5RIw3jy7znvqFB96hO7oLoRvfbkutQBACbQ/WQc=; b=Wo6JTunxe4SklQRnE8CMfK4Txy8k7pXW7nr8TyTFoRB+VERRiwA9k2ts7l1C3GI1BF LKAhGQtzrrKfF86HyWFsVN0jKO+xEwrexA1J9oqOomUVpoTNl0Bu+5j1mt6SwdSXDLGN 4EkO186J2TUcC8KgbZLkxjrSI6/l4KSrVSUl+f3Db45T4lIRCWrTojjmRBC6wkv0CI7q gdcrqtpKUbmEg2hiGz7bqboyiw+nVTu2PitlwHMhnSZaJxIzztnGr+UvNui4qVlyEOPc PnX9CKP8LrOSqCksrEGmqgpEz3yXydSHz8P8TBAuDnHbhw9wur8iwpyeGHOjTJfcnWkk uPsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772650688; x=1773255488; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7KTN5RIw3jy7znvqFB96hO7oLoRvfbkutQBACbQ/WQc=; b=THBg9gQnt26oR5UrNPgghTRP6r19hXRr2WRgXYCOnQU7Con4KqmiSeiAvKgJLKjrrj OkIeK9WHd735yKFspxzwhvusJM4jAlj3+nvmlKHJVy3kdCtMtYSnOEyeX3tRUuxyhiyf qZlMHF3zrymRFfGINf5sqkiccYxKN3oKStFGF1vPGXKRqLP9L+xlT7eHsZZqadrtIrhw foA/TAypaZq86m3RRbE3bD9ervy19J94VvYrrLZL+Y2RPc52Y5RCSJOwTMTF27wPqIUk mA+KUn3tDlQY8uR12tL8JwP4je8g919BBtjkK0YHnnMAZ5aqEuXhdw4NqL9WZmd7Hc41 WSPA== X-Forwarded-Encrypted: i=1; AJvYcCUo7N7/QSQCjjTRDCGJZckRVQ6MdIpNSUy3zBKAd4kV74Rt79jclk1sxl5J826Sh0e5I1c4/wY4IpdQuEg=@vger.kernel.org X-Gm-Message-State: AOJu0YyOvBnalrGLWgGCbHOImFGSd0ZO5q1zC3h17CmQjypc+/yuPwfS BOt5vX4B+CAWrYeHbPJxHTBNjwwytHtca3Wjt5yPhxIMtQ7QdL7t3aTO X-Gm-Gg: ATEYQzxt3DpTZAb3iBtjXf1oLcvg0F4vW8Sw6SayD9J1d7SAizaeaCuiOOWHjrXNB/1 ij9apndvnKjYEMU9yoXkrJTzxUYoj62Sug/GFQS8rFdb79Bo3+UHeVNquW0O8RNbuEERcmVjg4y 1snh0jONW1sR6DM5mYqUsiL/CRisPchMBnVvRFm8w3dAKpXdBSFpv2HG7mor9tGppMLbyWwOb7Z uZItFlzxo5QhhVc37+sKe+gvn1/0bfVmIREGRBbfsK+u3jXZfK9eTY554+aiWi1OZ7IC0mIKYj2 x13GJXqut85IEI2uk5V0nYh/fvH4Iyvuo0SI3G+48PkpJzjlnIpdk3TCuzgvMNgGPKpQP7yMjQe qCVon211rD11AZ/0vXFLgm8sw2QSmroWfCFm+y4ZO7zSKFMSPjqXhambd0xhyHGjoHvkE9EsUGg l5yu/4R0VQO22l X-Received: by 2002:a05:651c:987:b0:385:bab3:5ba7 with SMTP id 38308e7fff4ca-38a2c6af560mr21897461fa.19.1772650688249; Wed, 04 Mar 2026 10:58:08 -0800 (PST) Received: from xeon ([188.163.112.72]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a12a6ddd3bsm704985e87.0.2026.03.04.10.58.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 10:58:07 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v5 5/7] leds: Add driver for ASUS Transformer LEDs Date: Wed, 4 Mar 2026 20:57:49 +0200 Message-ID: <20260304185751.83494-6-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304185751.83494-1-clamor95@gmail.com> References: <20260304185751.83494-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw ASUS Transformer tablets have a green and an amber LED on both the Pad and the Dock. If both LEDs are enabled simultaneously, the emitted light will be yellow. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw --- drivers/leds/Kconfig | 11 ++++ drivers/leds/Makefile | 1 + drivers/leds/leds-asus-transformer-ec.c | 79 +++++++++++++++++++++++++ 3 files changed, 91 insertions(+) create mode 100644 drivers/leds/leds-asus-transformer-ec.c diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 597d7a79c988..bda06dc145d7 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -120,6 +120,17 @@ config LEDS_OSRAM_AMS_AS3668 To compile this driver as a module, choose M here: the module will be called leds-as3668. =20 +config LEDS_ASUS_TRANSFORMER_EC + tristate "LED Support for Asus Transformer charging LED" + depends on LEDS_CLASS + depends on MFD_ASUS_TRANSFORMER_EC + help + This option enables support for charging indicator on + Asus Transformer's Pad and it's Dock. + + To compile this driver as a module, choose M here: the module + will be called leds-asus-transformer-ec. + config LEDS_AW200XX tristate "LED support for Awinic AW20036/AW20054/AW20072/AW20108" depends on LEDS_CLASS diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 8fdb45d5b439..d5395c3f1124 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -16,6 +16,7 @@ obj-$(CONFIG_LEDS_AN30259A) +=3D leds-an30259a.o obj-$(CONFIG_LEDS_APU) +=3D leds-apu.o obj-$(CONFIG_LEDS_ARIEL) +=3D leds-ariel.o obj-$(CONFIG_LEDS_AS3668) +=3D leds-as3668.o +obj-$(CONFIG_LEDS_ASUS_TRANSFORMER_EC) +=3D leds-asus-transformer-ec.o obj-$(CONFIG_LEDS_AW200XX) +=3D leds-aw200xx.o obj-$(CONFIG_LEDS_AW2013) +=3D leds-aw2013.o obj-$(CONFIG_LEDS_BCM6328) +=3D leds-bcm6328.o diff --git a/drivers/leds/leds-asus-transformer-ec.c b/drivers/leds/leds-as= us-transformer-ec.c new file mode 100644 index 000000000000..3186038e3be7 --- /dev/null +++ b/drivers/leds/leds-asus-transformer-ec.c @@ -0,0 +1,79 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include +#include +#include +#include +#include +#include + +static void asus_ec_led_set_brightness_amber(struct led_classdev *led, + enum led_brightness brightness) +{ + const struct asusec_info *ec =3D dev_get_drvdata(led->dev->parent); + + if (brightness) + asus_ec_set_ctl_bits(ec, ASUSEC_CTL_LED_AMBER); + else + asus_ec_clear_ctl_bits(ec, ASUSEC_CTL_LED_AMBER); +} + +static void asus_ec_led_set_brightness_green(struct led_classdev *led, + enum led_brightness brightness) +{ + const struct asusec_info *ec =3D dev_get_drvdata(led->dev->parent); + + if (brightness) + asus_ec_set_ctl_bits(ec, ASUSEC_CTL_LED_GREEN); + else + asus_ec_clear_ctl_bits(ec, ASUSEC_CTL_LED_GREEN); +} + +static int asus_ec_led_probe(struct platform_device *pdev) +{ + struct asusec_info *ec =3D cell_to_ec(pdev); + struct device *dev =3D &pdev->dev; + struct led_classdev *amber_led, *green_led; + int ret; + + platform_set_drvdata(pdev, ec); + + amber_led =3D devm_kzalloc(dev, sizeof(*amber_led), GFP_KERNEL); + if (!amber_led) + return -ENOMEM; + + amber_led->name =3D devm_kasprintf(dev, GFP_KERNEL, "%s::amber", ec->name= ); + amber_led->max_brightness =3D 1; + amber_led->flags =3D LED_CORE_SUSPENDRESUME | LED_RETAIN_AT_SHUTDOWN; + amber_led->brightness_set =3D asus_ec_led_set_brightness_amber; + + ret =3D devm_led_classdev_register(dev, amber_led); + if (ret) + return dev_err_probe(dev, ret, "failed to register amber LED\n"); + + green_led =3D devm_kzalloc(dev, sizeof(*green_led), GFP_KERNEL); + if (!green_led) + return -ENOMEM; + + green_led->name =3D devm_kasprintf(dev, GFP_KERNEL, "%s::green", ec->name= ); + green_led->max_brightness =3D 1; + green_led->flags =3D LED_CORE_SUSPENDRESUME | LED_RETAIN_AT_SHUTDOWN; + green_led->brightness_set =3D asus_ec_led_set_brightness_green; + + ret =3D devm_led_classdev_register(dev, green_led); + if (ret) + return dev_err_probe(dev, ret, "failed to register green LED\n"); + + return 0; +} + +static struct platform_driver asus_ec_led_driver =3D { + .driver.name =3D "asus-transformer-ec-led", + .probe =3D asus_ec_led_probe, +}; +module_platform_driver(asus_ec_led_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_AUTHOR("Svyatoslav Ryhel "); +MODULE_DESCRIPTION("ASUS Transformer's charging LED driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Thu Apr 2 14:07:59 2026 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 807013DEAEA for ; Wed, 4 Mar 2026 18:58:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650695; cv=none; b=MxqYy+EFoa0vGsGv/PHCoXpeCDnF9JGGhFNi4CwoWwYhTt2QcO7L7jUJ/Ope8QUHTeRT3zuwSlt1RYyurIs+3mUWT1LD8uuniNrao+3QIndOGWUknBOsjkeQB5h414ediqM8dohP7c66zKQy85xs0FiA/i4Hh/CihnndbE1WoA8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650695; c=relaxed/simple; bh=82wJ6CSHc8UFLw87bHXmNuqNeti15tSupjn/C1BIx6g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=btrqnyi+HgzRTLGSCSUXb6/+hLUh1C8W2z2FB+j46x/SrsPoovWHZ0HMqPBp4wPlHneqnL9zJFgGJLjdAro3JPe6R/TqNwmrHtAWJMYfAXTFHXXNakxuvb9I5w2gStInoONaVlIEnD+Ljzhv6g7dE7cwSKfPBT8geYDDkdagpns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AQqMm9yM; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AQqMm9yM" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-38a23dd61c1so35588501fa.1 for ; Wed, 04 Mar 2026 10:58:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772650691; x=1773255491; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MxQXkdXlba88gXFDuag6mxU8wtp75fT8rqY0N+LZnb8=; b=AQqMm9yMkYPEu4GmYKLj2K5s0hWNC7kqsGL0/itZRuvC8Aks9NCk7SprZszLn+4aGS Eyqp1CNacVxgPlhqmlx50fg0LAwnTdGK29J54vhVaJgBxErbndaoYpT3se1eauMqr2da dgsYLI9eQsrnwdUehiWyhHa1FuW3JgUjDPWFhTCYYf1pKjMZ7oxbr8hwiFz0XyKSHMF4 lmWPRowql3Ho7IgyVrqZTWRi0a5rm4u4aNDD5bNer4igTmqQaN7Jp1sFu3GIc5nRWOnw 6gjPI2CjkIjjb/iL5wUL/752AbElZ5O5Yy+anKnVhc31phCAReOwavaT4KFZO0SAAE3i sj0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772650691; x=1773255491; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MxQXkdXlba88gXFDuag6mxU8wtp75fT8rqY0N+LZnb8=; b=SE4zwH+O55TWbtjxHYwI+RQjAsosoIjjIW0pg5ITdlcyo/mWvI9Wi1G1pCIszwv53/ jp9TsM2J4pMjSofqo/AKdAnowugdhAbNx76rypnx6HbBqGaK7rvlGstcgcLgTU5jQJtS 0+yu58nlYM8Yw8N72Q75+v67kQDPMWpCwktIwsSMuiLUT6lNdcm6WnTYzFamugx5178f TZKODm2znIGlInogTsFUwCyeESid+n2ObimGDH1a7803ty49UNqeanOMkyIZP/gZvLMi V9gx/A00hJwQuanR3Yq86HIPXA9QRBq+MWH3lcDj3kxxsyUFn9Z7EuHkaz0/87gc/Z1a /W7w== X-Forwarded-Encrypted: i=1; AJvYcCWJaSDWQub4VxRsxE5ydNJ25HYROSmQoj4EBDuOF0efC6RHQUUqzbhhOvdMz1tUDoGovvYqrhnr3+Elles=@vger.kernel.org X-Gm-Message-State: AOJu0Yy55BqbA0He7svH6ybhM3sA/0gF6MK5/fSDw3TJCfG6tlzRgWct eCTYrNrmp+QzPEqgmqUHlAFAY+eASRYNX2wv6+GsjNlyOv+NqdRtRvct X-Gm-Gg: ATEYQzyOBhnFf6FblDSeBhZBehfzUCXOfGO9582j5lQbN7koRcz55qhTKXuFAM1JNMk pegYxeIo+Rxvr0OhEftXaYebdMxXhyF81CUFsJQ0WsmTV4V0Y1K7mGqZm63EMlbdj6c0GlncDVk VD410B2jLp8/ELsBvHYpviUptpfi6tHSRfMIE+M0WNvqU1Dgiqw40f7dldyG3OMkmoSgW4lrorJ fmNED3VVb8PSWX+hDj9Y1xgDVnjVLkCnqd7Oizxoq/OegOogPv8Blaghyv1LRzwLPaMvIW6VRXh 6w5aKKgJnrhSnc8kZmnPs66pbPJseijFlgiQJSp6RgIWox4e3Mqm8o6kMmZepYDPZqpsJYhnujn FZe+2t9dqyxH1ZuMKOGBcGRo0ksHzQuvZzPvwl+4wsil/N0MEfBXiXgeH0+BrfaI6fGe+Phgl34 44NDpoudIG4c5+ X-Received: by 2002:a05:651c:110c:b0:387:98:f2b4 with SMTP id 38308e7fff4ca-38a2c5747c7mr22154041fa.11.1772650690240; Wed, 04 Mar 2026 10:58:10 -0800 (PST) Received: from xeon ([188.163.112.72]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a12a6ddd3bsm704985e87.0.2026.03.04.10.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 10:58:09 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v5 6/7] power: supply: Add driver for ASUS Transformer battery Date: Wed, 4 Mar 2026 20:57:50 +0200 Message-ID: <20260304185751.83494-7-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304185751.83494-1-clamor95@gmail.com> References: <20260304185751.83494-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Driver implements one battery cell per EC controller and supports reading of battery status for ASUS Transformer's pad and mobile dock. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw Reviewed-by: Sebastian Reichel --- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile | 1 + .../supply/asus-transformer-ec-battery.c | 272 ++++++++++++++++++ 3 files changed, 284 insertions(+) create mode 100644 drivers/power/supply/asus-transformer-ec-battery.c diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 81fadb0695a9..3c46b412632d 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -122,6 +122,17 @@ config BATTERY_CHAGALL This driver can also be built as a module. If so, the module will be called chagall-battery. =20 +config BATTERY_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's battery driver" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here to enable support APM status emulation using + battery class devices. + + This sub-driver supports battery cells found in Asus Transformer + tablets and mobile docks and controlled by special embedded + controller. + config BATTERY_CPCAP tristate "Motorola CPCAP PMIC battery driver" depends on MFD_CPCAP && IIO diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index 41c400bbf022..aa5e6b05b018 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -22,6 +22,7 @@ obj-$(CONFIG_TEST_POWER) +=3D test_power.o obj-$(CONFIG_BATTERY_88PM860X) +=3D 88pm860x_battery.o obj-$(CONFIG_CHARGER_ADP5061) +=3D adp5061.o obj-$(CONFIG_BATTERY_ACT8945A) +=3D act8945a_charger.o +obj-$(CONFIG_BATTERY_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec-battery= .o obj-$(CONFIG_BATTERY_AXP20X) +=3D axp20x_battery.o obj-$(CONFIG_CHARGER_AXP20X) +=3D axp20x_ac_power.o obj-$(CONFIG_BATTERY_CHAGALL) +=3D chagall-battery.o diff --git a/drivers/power/supply/asus-transformer-ec-battery.c b/drivers/p= ower/supply/asus-transformer-ec-battery.c new file mode 100644 index 000000000000..aefcd3fed6fe --- /dev/null +++ b/drivers/power/supply/asus-transformer-ec-battery.c @@ -0,0 +1,272 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_BATTERY_DATA_FRESH_MSEC 5000 + +#define ASUSEC_BATTERY_DISCHARGING 0x40 +#define ASUSEC_BATTERY_FULL_CHARGED 0x20 +#define ASUSEC_BATTERY_NOT_CHARGING 0x10 + +#define TEMP_CELSIUS_OFFSET 2731 + +struct asus_ec_battery_data { + const struct asusec_info *ec; + struct power_supply *battery; + struct power_supply_desc psy_desc; + struct delayed_work poll_work; + struct mutex battery_lock; /* for data refresh */ + unsigned long batt_data_ts; + int last_state; + u8 batt_data[DOCKRAM_ENTRY_BUFSIZE]; +}; + +static int asus_ec_battery_refresh(struct asus_ec_battery_data *priv) +{ + int ret =3D 0; + + guard(mutex)(&priv->battery_lock); + + if (time_before(jiffies, priv->batt_data_ts)) + return ret; + + ret =3D asus_dockram_read(priv->ec->dockram, ASUSEC_DOCKRAM_BATT_CTL, + priv->batt_data); + if (ret < 0) + return ret; + + priv->batt_data_ts =3D jiffies + + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC); + + return ret; +} + +static enum power_supply_property asus_ec_battery_properties[] =3D { + POWER_SUPPLY_PROP_STATUS, + POWER_SUPPLY_PROP_VOLTAGE_MAX, + POWER_SUPPLY_PROP_CURRENT_MAX, + POWER_SUPPLY_PROP_TEMP, + POWER_SUPPLY_PROP_VOLTAGE_NOW, + POWER_SUPPLY_PROP_CURRENT_NOW, + POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_CHARGE_NOW, + POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW, + POWER_SUPPLY_PROP_TIME_TO_FULL_NOW, + POWER_SUPPLY_PROP_PRESENT, +}; + +static const unsigned int asus_ec_battery_prop_offs[] =3D { + [POWER_SUPPLY_PROP_STATUS] =3D 1, + [POWER_SUPPLY_PROP_VOLTAGE_MAX] =3D 3, + [POWER_SUPPLY_PROP_CURRENT_MAX] =3D 5, + [POWER_SUPPLY_PROP_TEMP] =3D 7, + [POWER_SUPPLY_PROP_VOLTAGE_NOW] =3D 9, + [POWER_SUPPLY_PROP_CURRENT_NOW] =3D 11, + [POWER_SUPPLY_PROP_CAPACITY] =3D 13, + [POWER_SUPPLY_PROP_CHARGE_NOW] =3D 15, + [POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW] =3D 17, + [POWER_SUPPLY_PROP_TIME_TO_FULL_NOW] =3D 19, +}; + +static int asus_ec_battery_get_value(struct asus_ec_battery_data *priv, + enum power_supply_property psp) +{ + int ret, offs; + + if (psp >=3D ARRAY_SIZE(asus_ec_battery_prop_offs)) + return -EINVAL; + + offs =3D asus_ec_battery_prop_offs[psp]; + if (!offs) + return -EINVAL; + + ret =3D asus_ec_battery_refresh(priv); + if (ret < 0) + return ret; + + if (offs >=3D priv->batt_data[0]) + return -ENODATA; + + return get_unaligned_le16(priv->batt_data + offs); +} + +static int asus_ec_battery_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct asus_ec_battery_data *priv =3D power_supply_get_drvdata(psy); + int ret; + + switch (psp) { + case POWER_SUPPLY_PROP_PRESENT: + val->intval =3D 1; + break; + + default: + ret =3D asus_ec_battery_get_value(priv, psp); + if (ret < 0) + return ret; + + val->intval =3D (s16)ret; + + switch (psp) { + case POWER_SUPPLY_PROP_STATUS: + if (ret & ASUSEC_BATTERY_FULL_CHARGED) + val->intval =3D POWER_SUPPLY_STATUS_FULL; + else if (ret & ASUSEC_BATTERY_NOT_CHARGING) + val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; + else if (ret & ASUSEC_BATTERY_DISCHARGING) + val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; + else + val->intval =3D POWER_SUPPLY_STATUS_CHARGING; + break; + + case POWER_SUPPLY_PROP_TEMP: + val->intval -=3D TEMP_CELSIUS_OFFSET; + break; + + case POWER_SUPPLY_PROP_CHARGE_NOW: + case POWER_SUPPLY_PROP_CURRENT_NOW: + case POWER_SUPPLY_PROP_CURRENT_MAX: + case POWER_SUPPLY_PROP_VOLTAGE_NOW: + case POWER_SUPPLY_PROP_VOLTAGE_MAX: + val->intval *=3D 1000; + break; + + case POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW: + case POWER_SUPPLY_PROP_TIME_TO_FULL_NOW: + val->intval *=3D 60; + break; + + default: + break; + } + + break; + } + + return 0; +} + +static void asus_ec_battery_poll_work(struct work_struct *work) +{ + struct asus_ec_battery_data *priv =3D + container_of(work, struct asus_ec_battery_data, poll_work.work); + int state; + + state =3D asus_ec_battery_get_value(priv, POWER_SUPPLY_PROP_STATUS); + if (state < 0) + return; + + if (state & ASUSEC_BATTERY_FULL_CHARGED) + state =3D POWER_SUPPLY_STATUS_FULL; + else if (state & ASUSEC_BATTERY_DISCHARGING) + state =3D POWER_SUPPLY_STATUS_DISCHARGING; + else + state =3D POWER_SUPPLY_STATUS_CHARGING; + + if (priv->last_state !=3D state) { + priv->last_state =3D state; + power_supply_changed(priv->battery); + } + + /* continuously send uevent notification */ + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); +} + +static const struct power_supply_desc asus_ec_battery_desc =3D { + .name =3D "asus-ec-battery", + .type =3D POWER_SUPPLY_TYPE_BATTERY, + .properties =3D asus_ec_battery_properties, + .num_properties =3D ARRAY_SIZE(asus_ec_battery_properties), + .get_property =3D asus_ec_battery_get_property, + .external_power_changed =3D power_supply_changed, +}; + +static int asus_ec_battery_probe(struct platform_device *pdev) +{ + struct asus_ec_battery_data *priv; + struct device *dev =3D &pdev->dev; + struct power_supply_config cfg =3D { }; + int ret; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + + mutex_init(&priv->battery_lock); + + priv->ec =3D cell_to_ec(pdev); + priv->batt_data_ts =3D jiffies - 1; + priv->last_state =3D POWER_SUPPLY_STATUS_UNKNOWN; + + cfg.fwnode =3D dev_fwnode(dev->parent); + cfg.drv_data =3D priv; + + memcpy(&priv->psy_desc, &asus_ec_battery_desc, sizeof(priv->psy_desc)); + priv->psy_desc.name =3D devm_kasprintf(dev, GFP_KERNEL, "%s-battery", + priv->ec->name); + + priv->battery =3D devm_power_supply_register(dev, &priv->psy_desc, &cfg); + if (IS_ERR(priv->battery)) + return dev_err_probe(dev, PTR_ERR(priv->battery), + "Failed to register power supply\n"); + + ret =3D devm_delayed_work_autocancel(dev, &priv->poll_work, + asus_ec_battery_poll_work); + if (ret) + return ret; + + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); + + return 0; +} + +static int __maybe_unused asus_ec_battery_suspend(struct device *dev) +{ + struct asus_ec_battery_data *priv =3D dev_get_drvdata(dev); + + cancel_delayed_work_sync(&priv->poll_work); + + return 0; +} + +static int __maybe_unused asus_ec_battery_resume(struct device *dev) +{ + struct asus_ec_battery_data *priv =3D dev_get_drvdata(dev); + + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); + + return 0; +} + +static SIMPLE_DEV_PM_OPS(asus_ec_battery_pm_ops, + asus_ec_battery_suspend, asus_ec_battery_resume); + +static struct platform_driver asus_ec_battery_driver =3D { + .driver =3D { + .name =3D "asus-transformer-ec-battery", + .pm =3D &asus_ec_battery_pm_ops, + }, + .probe =3D asus_ec_battery_probe, +}; +module_platform_driver(asus_ec_battery_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_AUTHOR("Svyatoslav Ryhel "); +MODULE_DESCRIPTION("ASUS Transformer's battery driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Thu Apr 2 14:07:59 2026 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 083E73DFC85 for ; Wed, 4 Mar 2026 18:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650697; cv=none; b=J2FlwYhyytlvL+DRAvUGoxPaVND7I0ZhC57syrwl3x7LgoNrkX6CdG7uHiadLHwO0rwet6ExN9hGBt7hD5d4KW79eqPclldN3AaNcwS4fglVPbM7krI0gZj8j/mbm5/ME5AnOY10SiBwt049ts80YgpUSQNr9fgkHOktPeIHmvc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772650697; c=relaxed/simple; bh=kH6IxGWU9/YPnlpdIv152C9oL2JnvfglKibkmH2D9yc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mS9fs47gPx51TWRqfDqopwbL8ztoKOmZ8B/oqe7grRlpO0afk6oGEH4AZV0+QThS/XO3IPSpF0d1s4RRW7CT9CMBt93fZazti3aB3G8ii3Es//kGldJpUlzaznWd+T5JwXgJlPxg2Hnh3FHV30pSxyuOdlkEiLpMdL66gedWDuA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XL5TlMiC; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XL5TlMiC" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-389e139ee5eso125989541fa.0 for ; Wed, 04 Mar 2026 10:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772650692; x=1773255492; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o3TwQJXKVq1pyC7HWfeudplW5CQQTbeaEyQZUhCqwB8=; b=XL5TlMiCpVWuKJzyj7siq+BkZ6jh2U1zvoKYFkMNcumO9QhRKD4i4S7nEdjsQuM1oP HKuCIC7i3fHV8FYMgVNUrqK7HpZJKuCroe4qvv97KLvccRsjkTxIUTTpsYJ+mfL0pf7A EfwIsvXAQAw/25bmANk2lZOeOM5c9I+S+IJxH67DGcmJi6+/fxcg4t72HKr+uCqquGvz 1haRHRlp6rnVHvkSnr9oPBPG449yUFlzBpMkxGxb9z90FjCdnSzuqqCb3C1XLUnJ9e2J Yr7yNYo6/aaZjqZhQVbbJ5rh6en2kaQTeL668pe7zLue3/D2NfUPGimPnXNkUd1xgNd/ vIpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772650692; x=1773255492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=o3TwQJXKVq1pyC7HWfeudplW5CQQTbeaEyQZUhCqwB8=; b=arjLjlLDuL2z/o6thyAuvJnL/OWuIvSs2HsB5kf00EgV+nlpTIZzGUgZniiRljzu3Y I8a4Aw23Lk9c5RHj5+kPVu2hhkyUPkR3pBbdhRlTS+TJxE0UM6HNl74q40ncmFgUGlPW pJJRLNHJ/iE/ZB63GASlk4aKczHoeaLwEKTvm88QSduviMxlIdrliumcztZuFEXEpl+r /lFyMK3soVHDWT5f4xTFBYDdkaPS+AM/R+wfq6H3n86yu633dSi/foq/4s20cufsAku6 ykx5ddiq3Q3mzij4XEVgleBvB7nVooRSsHc/vIjWl9t6EYKuLKy01ev1HJhl9UXQSvZR pH0A== X-Forwarded-Encrypted: i=1; AJvYcCXQOJTmRITmlilvwhCE3EClJ1A0W00wwsJ5rSVVQt+vTUDnxG0D9aA5gAxdjR0lETR5UrnzrR+9vpUw6Mc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7YeKY0XnrfcK2rBf9IQFicN6uGsh4GzDmCX4FvEEXdcLSiQAe dhsGrihNk7KsoUOGP69kkaFYTD2aiXrwEAUuxIqbhqgdS+KuSSQcCJ+s X-Gm-Gg: ATEYQzywkDPNe6vWZfRhWEXdbqAwJezwCfW/dHg3WijkYtC6PGVOiqrKCYsmO07P3r4 4y+TifHtclJAio1Vom1k/pJgKIpCfTh4i2eUgKwKOp3RKcpF7kkpxokubwCQWxSVvnpVmkH0SKx zUZLWR8RUIk8noSmBdrNOMiquEO68y9pV5iPwFhBUgUyROZyCi5QcJO7UJmeOxHM7uo05pa4dNI neyJQUMzovfODPZfdytJZRVneSwPhGwMi5KwdRttbLWeHGCmbfZldwI41yJRU2qQ2F+Cvld27zw 1I4TWbxYMQKymxtyrj5p39HhwUerpcOC2Dx42NlfLat8aUayHzvibGIWz/e2p0gfMeP7QmDCdag 6sjwOs3oCmOfCRY1BgUdJ4Gm/IkMUhczzvJ+gkBWG3jYtdExR1TrNEhnG7zrkDq4oQlniKey+4i tiI7V4JLQMdQ3P X-Received: by 2002:a05:651c:f04:b0:389:fc69:45e8 with SMTP id 38308e7fff4ca-38a2c597194mr30443421fa.13.1772650691885; Wed, 04 Mar 2026 10:58:11 -0800 (PST) Received: from xeon ([188.163.112.72]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a12a6ddd3bsm704985e87.0.2026.03.04.10.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 10:58:11 -0800 (PST) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Lee Jones , Pavel Machek , Sebastian Reichel , Svyatoslav Ryhel , Ion Agorria , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v5 7/7] power: supply: Add charger driver for Asus Transformers Date: Wed, 4 Mar 2026 20:57:51 +0200 Message-ID: <20260304185751.83494-8-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260304185751.83494-1-clamor95@gmail.com> References: <20260304185751.83494-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add support for charger detection capabilities found in the embedded controller of ASUS Transformer devices. Suggested-by: Maxim Schwalm Suggested-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw Signed-off-by: Svyatoslav Ryhel Reviewed-by: Sebastian Reichel --- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile | 1 + .../supply/asus-transformer-ec-charger.c | 193 ++++++++++++++++++ 3 files changed, 205 insertions(+) create mode 100644 drivers/power/supply/asus-transformer-ec-charger.c diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 3c46b412632d..56800aab82f9 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -497,6 +497,17 @@ config CHARGER_88PM860X help Say Y here to enable charger for Marvell 88PM860x chip. =20 +config CHARGER_ASUS_TRANSFORMER_EC + tristate "Asus Transformer's charger driver" + depends on MFD_ASUS_TRANSFORMER_EC + help + Say Y here to enable support AC plug detection on Asus Transformer + Dock. + + This sub-driver supports charger detection mechanism found in Asus + Transformer tablets and mobile docks and controlled by special + embedded controller. + config CHARGER_PF1550 tristate "NXP PF1550 battery charger driver" depends on MFD_PF1550 diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index aa5e6b05b018..24679f09bb61 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -68,6 +68,7 @@ obj-$(CONFIG_CHARGER_RT9471) +=3D rt9471.o obj-$(CONFIG_CHARGER_RT9756) +=3D rt9756.o obj-$(CONFIG_BATTERY_TWL4030_MADC) +=3D twl4030_madc_battery.o obj-$(CONFIG_CHARGER_88PM860X) +=3D 88pm860x_charger.o +obj-$(CONFIG_CHARGER_ASUS_TRANSFORMER_EC) +=3D asus-transformer-ec-charger= .o obj-$(CONFIG_CHARGER_PF1550) +=3D pf1550-charger.o obj-$(CONFIG_BATTERY_RX51) +=3D rx51_battery.o obj-$(CONFIG_AB8500_BM) +=3D ab8500_bmdata.o ab8500_charger.o ab8500_fg.o= ab8500_btemp.o ab8500_chargalg.o diff --git a/drivers/power/supply/asus-transformer-ec-charger.c b/drivers/p= ower/supply/asus-transformer-ec-charger.c new file mode 100644 index 000000000000..de01f0bf2fd7 --- /dev/null +++ b/drivers/power/supply/asus-transformer-ec-charger.c @@ -0,0 +1,193 @@ +// SPDX-License-Identifier: GPL-2.0-or-later + +#include +#include +#include +#include +#include +#include + +struct asus_ec_charger_data { + struct notifier_block nb; + const struct asusec_info *ec; + struct power_supply *psy; + struct power_supply_desc psy_desc; +}; + +static enum power_supply_property asus_ec_charger_properties[] =3D { + POWER_SUPPLY_PROP_USB_TYPE, + POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR, + POWER_SUPPLY_PROP_ONLINE, + POWER_SUPPLY_PROP_MODEL_NAME, +}; + +static int asus_ec_charger_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct asus_ec_charger_data *priv =3D power_supply_get_drvdata(psy); + enum power_supply_usb_type psu; + int ret; + u64 ctl; + + ret =3D asus_ec_get_ctl(priv->ec, &ctl); + if (ret) + return ret; + + switch (ctl & (ASUSEC_CTL_FULL_POWER_SOURCE | ASUSEC_CTL_DIRECT_POWER_SOU= RCE)) { + case ASUSEC_CTL_FULL_POWER_SOURCE: + psu =3D POWER_SUPPLY_USB_TYPE_CDP; /* DOCK */ + break; + case ASUSEC_CTL_DIRECT_POWER_SOURCE: + psu =3D POWER_SUPPLY_USB_TYPE_SDP; /* USB */ + break; + case 0: + psu =3D POWER_SUPPLY_USB_TYPE_UNKNOWN; /* no power source connected */ + break; + default: + psu =3D POWER_SUPPLY_USB_TYPE_ACA; /* power adapter */ + break; + } + + switch (psp) { + case POWER_SUPPLY_PROP_ONLINE: + val->intval =3D psu !=3D POWER_SUPPLY_USB_TYPE_UNKNOWN; + return 0; + + case POWER_SUPPLY_PROP_USB_TYPE: + val->intval =3D psu; + return 0; + + case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: + if (ctl & ASUSEC_CTL_TEST_DISCHARGE) + val->intval =3D POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE; + else if (ctl & ASUSEC_CTL_USB_CHARGE) + val->intval =3D POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO; + else + val->intval =3D POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE; + return 0; + + case POWER_SUPPLY_PROP_MODEL_NAME: + val->strval =3D priv->ec->model; + return 0; + + default: + return -EINVAL; + } +} + +static int asus_ec_charger_set_property(struct power_supply *psy, + enum power_supply_property psp, + const union power_supply_propval *val) +{ + struct asus_ec_charger_data *priv =3D power_supply_get_drvdata(psy); + + switch (psp) { + case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: + switch ((enum power_supply_charge_behaviour)val->intval) { + case POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO: + return asus_ec_update_ctl(priv->ec, + ASUSEC_CTL_TEST_DISCHARGE | ASUSEC_CTL_USB_CHARGE, + ASUSEC_CTL_USB_CHARGE); + + case POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE: + return asus_ec_clear_ctl_bits(priv->ec, + ASUSEC_CTL_TEST_DISCHARGE | ASUSEC_CTL_USB_CHARGE); + + case POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE: + return asus_ec_update_ctl(priv->ec, + ASUSEC_CTL_TEST_DISCHARGE | ASUSEC_CTL_USB_CHARGE, + ASUSEC_CTL_TEST_DISCHARGE); + default: + return -EINVAL; + } + + default: + return -EINVAL; + } +} + +static int asus_ec_charger_property_is_writeable(struct power_supply *psy, + enum power_supply_property psp) +{ + switch (psp) { + case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: + return true; + default: + return false; + } +} + +static const struct power_supply_desc asus_ec_charger_desc =3D { + .name =3D "asus-ec-charger", + .type =3D POWER_SUPPLY_TYPE_USB, + .charge_behaviours =3D BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO) | + BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE) | + BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE), + .usb_types =3D BIT(POWER_SUPPLY_USB_TYPE_UNKNOWN) | + BIT(POWER_SUPPLY_USB_TYPE_SDP) | + BIT(POWER_SUPPLY_USB_TYPE_CDP) | + BIT(POWER_SUPPLY_USB_TYPE_ACA), + .properties =3D asus_ec_charger_properties, + .num_properties =3D ARRAY_SIZE(asus_ec_charger_properties), + .get_property =3D asus_ec_charger_get_property, + .set_property =3D asus_ec_charger_set_property, + .property_is_writeable =3D asus_ec_charger_property_is_writeable, + .no_thermal =3D true, +}; + +static int asus_ec_charger_notify(struct notifier_block *nb, + unsigned long action, void *data) +{ + struct asus_ec_charger_data *priv =3D + container_of(nb, struct asus_ec_charger_data, nb); + + switch (action) { + case ASUSEC_SMI_ACTION(POWER_NOTIFY): + case ASUSEC_SMI_ACTION(ADAPTER_EVENT): + power_supply_changed(priv->psy); + break; + } + + return NOTIFY_DONE; +} + +static int asus_ec_charger_probe(struct platform_device *pdev) +{ + struct asus_ec_charger_data *priv; + struct device *dev =3D &pdev->dev; + struct power_supply_config cfg =3D { }; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + priv->ec =3D cell_to_ec(pdev); + + cfg.fwnode =3D dev_fwnode(dev->parent); + cfg.drv_data =3D priv; + + memcpy(&priv->psy_desc, &asus_ec_charger_desc, sizeof(priv->psy_desc)); + priv->psy_desc.name =3D devm_kasprintf(dev, GFP_KERNEL, "%s-charger", + priv->ec->name); + + priv->psy =3D devm_power_supply_register(dev, &priv->psy_desc, &cfg); + if (IS_ERR(priv->psy)) + return dev_err_probe(dev, PTR_ERR(priv->psy), + "Failed to register power supply\n"); + + priv->nb.notifier_call =3D asus_ec_charger_notify; + + return devm_asus_ec_register_notifier(pdev, &priv->nb); +} + +static struct platform_driver asus_ec_charger_driver =3D { + .driver.name =3D "asus-transformer-ec-charger", + .probe =3D asus_ec_charger_probe, +}; +module_platform_driver(asus_ec_charger_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer Pad battery charger driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0