From nobody Thu Apr 9 16:23:28 2026 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F080381AF8 for ; Wed, 4 Mar 2026 17:20:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772644829; cv=none; b=RXnz770SiP0N6iOUwZmqqjZ4yR0fGemt49/mGAPErJOULauEtX+PVYuQGzLPxOB5yOJeXy2MagMawldAdH1P/k14lFNaoJL7iUk4tD3CfVwNA0y1y5OEcIRU4BM24V18wHVseTIM2QFaoyZ+jcG7AhXI50Adm8IXdVkkPIjns+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772644829; c=relaxed/simple; bh=/IXmo69Qqppsb0Rguh1puUkOgy5dR4pABTlr/a1NR3o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D4mGEKWNPKSRbOvmHtYoU9v86jnScO6L1J7lri9Q4ab12mJ5nkLbrZ4tKvKgjKOqGka5NuTeKp8aI1aqzAZN/KSM9Z1DI0t+Q9Jwh4NlajCvwHYdKFGN5YDxP2I1u3MjwCEOwIW4ykZbb0pRGuteK1VWi1bcFkQZ8I6QOOXX3PU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VZWbTtfc; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VZWbTtfc" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2b4520f6b32so8133998eec.0 for ; Wed, 04 Mar 2026 09:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772644822; x=1773249622; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nYGdbxnOx3otBr6PvYVC6d9nFh0rDHzCPxy+MS19bo0=; b=VZWbTtfc94FYS7d61xr9ObzwEyUUb0gRCvsip8xd6+mHhedXcKTNabuzbMzb9/AcJG OuY0Ro3GSCdWZdP7fr+/iO1M91iv6RiNvkiAUubSJyazBLSXD+xCRDeSx/pRVm/4tVRK VY2eGdZD7hnoM6NTFiNK3xxjputdSDmCMt3Q4oHyqHoulN0YceMWdsDJjSYMKadgq0XX rXw3p4hQTJxiouikeKqRFOyfbu+k977c9zQ0mgaA1dpHOs2RSlTHxIBTzsgbcBG6ZuyN spMNLg+0QPN7XmqqpUEmj8rI54gNW5kF/Gg4zx59Y/VYLBgtzHswpwXh6R0fQ35YQzcj Xptw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772644822; x=1773249622; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nYGdbxnOx3otBr6PvYVC6d9nFh0rDHzCPxy+MS19bo0=; b=jBmT7xC7jNO8MK4W+dfz/3+yctkpA9MYl8f1zsuVsh8T8LkOlwojAZrobZiMbO7e6M PgZxyqVvi+n0esRxttiXTggA7g7DKCXZUWnA/yuyquuYQ1XS+poMpSY32StSVcSZuefY ZzTqVMbmbo5Jck44IyfSsoXWh33boBw98rSNOlP/qikfN9Z3nhNYFdZpn8xw5nQP3YDY /LSb5dfUu9nOCFErB2NbHqU3ed1WcGMLm0cvm8630btgFK3j7PudffcIRCyIeRyoSpBD aTXIP1lnEZlJ2yCnKBWqF3eUkx1CS+OUqCa18u6CiIx7DhGQXfRfDmZRcgFqIeTc6huj MqgA== X-Forwarded-Encrypted: i=1; AJvYcCXUXOlsRBZlnmC1foMf+WcLD70pq5Af6HwptvYfhoD+INp809JH9owPhUFPGu/IdysP7MdlODMB0+lfg+U=@vger.kernel.org X-Gm-Message-State: AOJu0YxRCC21ZM4hloK2e5XeELI2jxx0xBPtnX4iFDI3+bfZfAJoLxZd CD31Ny8skrciSO/p+NEAlLnHDQiRyHskeVH4uMXvO4WHazYiCTJJKgnB X-Gm-Gg: ATEYQzxAT06LywEVAToXwVHoVvGQh5WZpT7Nki61iBh3unOun2Uv/1SjmuhVS5uR0y2 tcw89ugW5/8USrQndrVYI2NHp+8gLxBmQH7Ou8zM97LMODrXdT3NK84BApJcgTp0xBZPWffB53M 3PhDCXuzc024EiI0SLirqfRvKU2Vf4fysWdS7tPE1CR77BOdRYScGQlj6cguUhNifWxRS+l3swZ NwBbVEBPqRF5F9xMkSfxQgRLPxi55vz92JrZM0xTBDFgTc8Fr3XKxWWS0Hme6exzNxdb3UWCB98 vc48Tdo9DV+2GfNhODQ31sdm4Zd9P+OqEMg9Sftatdh0XhPSGEhTW+Br/ooY9oiBWVrhriwmXpq YvgVOsQxEFo+/ZJ0ilBdvwLlNSkMVdh8wPyM5ZIhv0x8tw4GLarCvhqAHldszEsZGVrTFPBYePF IZbZ1Xv6bJ+eJcyhEGCHCL4SeX8T0XZLLtySxRY82NhWIAj+M5xTn7U5Yz43ErFdKMqA2INULWH ihf9RjWuJd3U4dyJzHp+OiF4zNoug8y1BHo8MnVKxnxE/7BFCbcNrAkjnfZiJRl+BZKyCS4gx2w X-Received: by 2002:a05:7301:6781:b0:2be:22b0:8bf3 with SMTP id 5a478bee46e88-2be310abb31mr976104eec.30.1772644821788; Wed, 04 Mar 2026 09:20:21 -0800 (PST) Received: from arch.guest.box.net ([8.39.49.133]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be2800c89asm2904789eec.31.2026.03.04.09.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 09:20:21 -0800 (PST) From: Milos Nikic To: jack@suse.cz Cc: tytso@mit.edu, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Milos Nikic , Zhang Yi , Andreas Dilger Subject: [PATCH v5 1/2] jbd2: gracefully abort instead of panicking on unlocked buffer Date: Wed, 4 Mar 2026 09:20:15 -0800 Message-ID: <20260304172016.23525-2-nikic.milos@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260304172016.23525-1-nikic.milos@gmail.com> References: <20260304172016.23525-1-nikic.milos@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In jbd2_journal_get_create_access(), if the caller passes an unlocked buffer, the code currently triggers a fatal J_ASSERT. While an unlocked buffer here is a clear API violation and a bug in the caller, crashing the entire system is an overly severe response. It brings down the whole machine for a localized filesystem inconsistency. Replace the J_ASSERT with a WARN_ON_ONCE to capture the offending caller's stack trace, and return an error (-EINVAL). This allows the journal to gracefully abort the transaction, protecting data integrity without causing a kernel panic. Signed-off-by: Milos Nikic Reviewed-by: Zhang Yi Reviewed-by: Jan Kara Reviewed-by: Andreas Dilger --- fs/jbd2/transaction.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c index dca4b5d8aaaa..04d17a5f2a82 100644 --- a/fs/jbd2/transaction.c +++ b/fs/jbd2/transaction.c @@ -1302,7 +1302,12 @@ int jbd2_journal_get_create_access(handle_t *handle,= struct buffer_head *bh) goto out; } =20 - J_ASSERT_JH(jh, buffer_locked(jh2bh(jh))); + if (WARN_ON_ONCE(!buffer_locked(jh2bh(jh)))) { + err =3D -EINVAL; + spin_unlock(&jh->b_state_lock); + jbd2_journal_abort(journal, err); + goto out; + } =20 if (jh->b_transaction =3D=3D NULL) { /* --=20 2.53.0