From nobody Fri Apr 10 00:55:54 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9546E34FF48 for ; Wed, 4 Mar 2026 15:42:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772638978; cv=none; b=jTnmfWseYYKUqNa8r55e86O9AUIzCDKNBgWU29apEGihIMq5be2Z59dohsujNCCPbY/Tn/sMzuW4lcZB5J/P4uJEEXB+C9YlLbN0SnlHicPZQXFim1yS194crIO5+PTaC+QDdgDXj7/XKShP84FiHQRC6FIyGyfPY53+f/88jmU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772638978; c=relaxed/simple; bh=HtPb39DNehF0QWemJ+b+lT+x3hgbR04jVkvsXQHYQQo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YxpN4zihOTE9BVQt4KAujioK+dwr+CL0UQBFG4Nv+w21W3HCx0U38flmFSTjzG9zJg1qbTwkbastSneWbgYdltUwCyB1DrkS+0zcMjwav/s9IW0KOg0T7S57n65KERFfNPCOKhekFEHXy4BnqPKQX2txWQt0IQdw0yQHmNkwlXw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iPHsC22g; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iPHsC22g" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2ae43042ea7so43792035ad.0 for ; Wed, 04 Mar 2026 07:42:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772638977; x=1773243777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4TjlFikyBnPQa3i9X3yH8EGu5EvTUdPSojCgwU8GdFA=; b=iPHsC22gnsBhancnIVu7Bnn+0ohuwF/HqIEBe7FjrEbxCsmIwqcMxCClwgu8Nb7Txo 6zs4HekLGQmOTAYD28OVhHXC/LWbKrC5NLstPpwF6ll9QrdC5e/7gams0JkC1ffmVYQ7 Wfi99b4MaBOOQUtFVPELzfEAAem4SYBSZLF+Yapzht5aJu0aTmNsYKhdH4iLpc3UC9IH CAToJKZDOu4qaZ5WItauzFxO5hjvNqeKeddFRwiJCQbrPe2BjfQoVpfaYwt4C7j1+CNJ Gs/MLTQGsZR3O8qhT3/Pc8+2FgZ/zeP5fXU3ZNBPEDDAfc+uYCiDqzCHRwv+D1dKy9O3 mlKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772638977; x=1773243777; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4TjlFikyBnPQa3i9X3yH8EGu5EvTUdPSojCgwU8GdFA=; b=L6TqBvtIQPZROAECESmWjIW79ZTOsYVttqhUWvn9mikrVBWSEMKFJQdROB7q255BBg y7INZapSxPLBADAVtXfeK0zJ+beiIrGzwIZzWrE0wn2hd+FLJLTktvX1q2oydXsRZdiO 3ACMGDkH3W+J+GwjFB8q5mLZyTeqqt3JCun0NDoa/Os+vNj65AOYpUu2+OTLkpZnd1n8 V0QMLU5S0eOMSseJ37r/KYdSGSfHbASFEea2sv10yDXT23jZFNeHx44A7VFDB3YRpnik Fwz4NtW9Kxv0Bz26vEt51UMi97o4WC7ECUi3Q9ieROAamtNZ6TdRqowcyy/Fpou5wxSM h+jg== X-Forwarded-Encrypted: i=1; AJvYcCUyLguKcwLNOQLJcnluY+jlknZnWH1zRqMFD2XJ4KaXULsLnfHmxQ8KgCQUitZTRRjNAON4cg3WIJvjgSw=@vger.kernel.org X-Gm-Message-State: AOJu0YwA3WU2ApbQErd9mEcEOYqcgvRsK1U4QSUI11QWVu6QZwfjxlF/ 0o5nbDqW3CXA0qKTSxP4afc9ssyuLhI9WKPY2E/LSEuGQpIkbnG7i067 X-Gm-Gg: ATEYQzxEZ0KHzpBDzKni8UmBUBHG98qEFGjAmSnG1/ZA+DEzTu6VH8Emi+hsL5NCxj3 1RvvrSo6quO4xtAHYyuwmtZeg+BSguoUAlbTHZwbsOfSRDsXNj/HvGMY3aUDoY/oOvqItnhcMlc Yj72Xx+qLgLlCjMVYLvVij9Ppz1DvLFlCKdNvssYu7aMY0IBo+kRdDmlfdL0IBJdoN5t3AnoIbb M/V29BJzFTqmTREYPfxR5FCJtFd0on3oq9rzcnSLTqFxwvMklxP1SFHbVoa+aHEY84Ijikok/Qs fbjoH2jsAVC1HQfCowcmN7i9A1DXw/E3ayQShl0WxDGo53kFLXW5V+5+I/U4sXsZooUFo7W2uGr b6q9lcX3FnWCKVqQstQn6ONK2OgTKH2PvvQ2LkExq/dm6LxiqtwVNke7eXfG0r0FbNP4kkw8cz9 iomvFfvmZ5HdCG6jjn+cuX/Fbp9ms4zeacmFj8ssPH8egaJkK9InG+W2u19LdutKKam2dzF4c6l chfGTMlyFI+g96A X-Received: by 2002:a17:903:2c04:b0:2ae:4fc2:d951 with SMTP id d9443c01a7336-2ae6aaae1e1mr27463395ad.27.1772638976926; Wed, 04 Mar 2026 07:42:56 -0800 (PST) Received: from tower (c-73-37-64-97.hsd1.or.comcast.net. [73.37.64.97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb5b36e1sm199354965ad.9.2026.03.04.07.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 07:42:56 -0800 (PST) From: Mark Adamenko To: linux-usb@vger.kernel.org Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Mark Adamenko Subject: [PATCH v2] usb: core: remove unnecessary goto in usb_create_newid_files() Date: Wed, 4 Mar 2026 07:42:16 -0800 Message-ID: <20260304154216.2750-1-marusik.adamenko@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The goto to 'exit' only returns the already initialized variable 'error', which would be 0. At that point it could not yet be anything else. Replacing with an early return 0 removes the need for the label entirely. Signed-off-by: Mark Adamenko --- v2: fix missing return statement at end of function --- drivers/usb/core/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index 2574e65bc640..752ff84a8dc1 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -186,7 +186,7 @@ static int usb_create_newid_files(struct usb_driver *us= b_drv) int error =3D 0; =20 if (usb_drv->no_dynamic_id) - goto exit; + return 0; =20 if (usb_drv->probe !=3D NULL) { error =3D driver_create_file(&usb_drv->driver, @@ -199,7 +199,7 @@ static int usb_create_newid_files(struct usb_driver *us= b_drv) &driver_attr_new_id); } } -exit: + return error; } =20 --=20 2.53.0