From nobody Wed Apr 15 16:26:06 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E18130EF80 for ; Wed, 4 Mar 2026 13:48:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772632131; cv=none; b=e5YjcpjAn3KQziRji1Aoe8TqNIDzPy4Nu8CpRFzCHpv+yE9NOm/rtyh5QgIOL7u0HH5VRMTpes1G2a7Ja/EMowKDoHQfJOdaUs7b8cIFkhj/DGFm65FMRmY/9Zmgn4lwcmY44mAIb30NqvnTomake4X/aGyzPfS7WMXRqt6rJr4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772632131; c=relaxed/simple; bh=K9yAyQq7TVB5m2z7EEZuPp50xx9Dld0vnZ5yoZNf3K8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nV8YUeEEDRyZiS33tFOJMX19/pT9l/bDDrXljqKtlIBUGmnIYojg4FRqm5+/A4C6fFRNz5k0/bgV5t74CDvHWyy6lTY6/TpYjnYEF1zJL1b2dDUkDUGSPmUFjfiuEZzJ2g25SMe7IppZ2fW/ZKrqAHVWe/t3eHX2OqmOgoxmoww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VJ6KYkTO; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VJ6KYkTO" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-482f454be5bso72198925e9.0 for ; Wed, 04 Mar 2026 05:48:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772632129; x=1773236929; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=55t9FSDZQXeG7n+Yd3TCO52OZ2a8PizaEtr6ezSNM90=; b=VJ6KYkTO8OuqQ6dID7+9rZs0B9MrD6CoYQTorhBF1EZCoNSKtktrtbrmUGQRndpAhw pvqAmqevGniAmumCu+DciLgrWpDkllWhX1v6BV+Y5N0JHFcJHQo1wH2RohahnmhVx8QO 5JkxUn8vt3/UCcEkWQpBZbQDAHxzwHcmXCPsQw3BSip6ygdiXz5C6BNuCt5gesG/Qmyy MFtESkAkiVhyaUOfPoKFecOx6PCFFcBtOLCVtj6K2Do812SED/wV2BSvHis9fSylMgn5 YDrHOJQk4KG3Ierv+JB+13iCd3cp+iAYgCoUZmByHTNxKzMCBNgNmZZ3zrq9ZRnHp2Mo iAeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772632129; x=1773236929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=55t9FSDZQXeG7n+Yd3TCO52OZ2a8PizaEtr6ezSNM90=; b=wLflA5IKitxHVAp/0n1sCOquXLOKICbCOizRYa0Tt2tZkLXaD0my1n9B3XFqLGvNd1 mmj7zvvz9IoszYTlOHjytTficg/mGjG1vxLwu/f0YjoDyWvMWkTjp/AKk+R9hE+ifLiS ea+Pu0xOwD50JgOfmtP0ki0OnhFDiO7P0E/ReU+PcBwWOz4iiwL6ZXLqIsXG5FQgFUW2 nk+XKAVUk285Cy3t7WU8wjmJ/JYYkH6om9dFy3QlZiEMQpo8HNzroSGotqXbJSc8+B6Q g1ZH538Ti7OOcULrB8vs+frbcB+lLKriEw2ruLkQLRJ+LUmreAeSlpVrY/knfeL5ZDJP JYjw== X-Forwarded-Encrypted: i=1; AJvYcCUUV+rztko7g+B5OXHrfbITsvSoYy6Fu98yeY9v1FiJI4K+TqVIMQ7gN8TYwTZ51+4kap4fdUxE5vGPzWk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5ZvX5CCAhRhtpViERghk9hh8e+edtZc0WKxr6IuHhriN4fIeb z8ZejJLvu+VrnEa+MiEWP9SFVs8IpDOBxOLGyEozuv/oMmCdjeTqPxIJ X-Gm-Gg: ATEYQzz62ttrP4nPJuoWgQVPMbaxNx0ZiN9OdB82W9Hwrq2SllMCKr7zZPFM2DUKTIk yDVC4aYvN+EzmUsgFtlLuMaB4MUTyrqLMeM5dagXs+steGOVeuSnP/BvLamNnPrxfUQhPO80Urw XEaTLCyZn8XiZb4pXsGvHt/zLOR0iN4oPth6jFGboUvLPqGJ+BAeRVardHXAqhv6FrlWpiPMVCx oTtjR29dGYYzY/SdjW3GDBm1vySCf35ebP3nP8OeYAlqtLLD4x6XqoKuj+ZYZQ+0EEMu1UxVL0i ubsiFveXKv+koqNlcfE/3Vag1FzXfNKCl8kcC++8p/XsCynPbrftY2HaP+2ahee8SnbGzXaHhOG VtMXTOIjfgSFsKmXYo5KjLdWdq6XBhZekK2Akh+SjmkpnkTSkRrL/0iTdfMJG5TsWkXkT5vozs/ 7TTV/fF+1YKtAcY4UQzP6WECXp/QY5ge0= X-Received: by 2002:a05:600c:1383:b0:47e:e48f:43b5 with SMTP id 5b1f17b1804b1-48513eae55dmr110310985e9.18.1772632128767; Wed, 04 Mar 2026 05:48:48 -0800 (PST) Received: from biju.lan ([2a00:23c4:a758:8a01:de3f:f927:40ff:12a6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439c65e0b23sm7105229f8f.32.2026.03.04.05.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 05:48:48 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Boris Brezillon , Rob Herring , Steven Price , =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Biju Das , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , Biju Das , linux-renesas-soc@vger.kernel.org Subject: [PATCH 2/4] drm/panfrost: Drop redundant optional clock checks in runtime PM Date: Wed, 4 Mar 2026 13:48:37 +0000 Message-ID: <20260304134845.267030-3-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260304134845.267030-1-biju.das.jz@bp.renesas.com> References: <20260304134845.267030-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Biju Das The clk_enable() and clk_disable() APIs already handle NULL clock pointers gracefully =E2=80=94 clk_enable() returns 0 and clk_disable() returns immed= iately when passed a NULL or optional clock. The explicit if (pfdev->bus_clock) guards around these calls in the runtime suspend/resume paths are therefore unnecessary. Remove them to simplify the code. Signed-off-by: Biju Das Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_device.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/p= anfrost/panfrost_device.c index dedc13e56631..01e702a0b2f0 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -429,11 +429,9 @@ static int panfrost_device_runtime_resume(struct devic= e *dev) if (ret) goto err_clk; =20 - if (pfdev->bus_clock) { - ret =3D clk_enable(pfdev->bus_clock); - if (ret) - goto err_bus_clk; - } + ret =3D clk_enable(pfdev->bus_clock); + if (ret) + goto err_bus_clk; } =20 panfrost_device_reset(pfdev, true); @@ -464,9 +462,7 @@ static int panfrost_device_runtime_suspend(struct devic= e *dev) panfrost_gpu_power_off(pfdev); =20 if (pfdev->comp->pm_features & BIT(GPU_PM_RT)) { - if (pfdev->bus_clock) - clk_disable(pfdev->bus_clock); - + clk_disable(pfdev->bus_clock); clk_disable(pfdev->clock); reset_control_assert(pfdev->rstc); } --=20 2.43.0