From nobody Wed Apr 15 16:26:17 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0B55298CBE for ; Wed, 4 Mar 2026 13:07:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772629645; cv=none; b=uMUO7gH+Xz82nB3/wvx3QbjVpD3ZR5iTsunhHCAPSUWh83jKHDyG8KjoRk2pZ8C9LeXS3hbwy5dev6zE2bF/EIhZsq05FVbqwyhdNA5Q99NmPK9eoV1tVwG6YSlUS0RtyuayrWgeX6k/HpQbfWtfqiAYnyFlidffws2oSno0ILI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772629645; c=relaxed/simple; bh=KvhN5EIM3XXPaotrLaYPSuOdgBSYq4SNpSPqi8ZqfN8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Av8KHznJGP3sE6/DwcWCOFDgHhH3tSzQycJbRu1SBtB3zsd1MYxYZ5LqQCPoJ/yogM49zrKPh0VghotdlGcbSXnGObYqsSv4xAYwIGjwvqaThB4uiA9rtEbyGlasds8odcnsPaROQoKEeu3+SZpFs9g0/TQnK57prWZam29yfE0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bJgHZ2YN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ufi9ipDk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bJgHZ2YN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ufi9ipDk" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 624CxeC61203427 for ; Wed, 4 Mar 2026 13:07:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=K4gYoo9JoJP OJ5mTuliJj+hphclVDgk4+5Zp53bnrEg=; b=bJgHZ2YNtRjhg6ZNGKNu2y4jQWV 6RTo0IzyHTPTEUIcoQ9lI2wzYZhBEKeT1CiKLTf24CQbEdW+TpHTblxcvhgKFUp1 VkItVJfjhAo3P0HANGFx1kyXtKcBVBjaoJwhxLEoMr24mgndGSNgN69+8q6PJwaR epa8+tscQWZVAXUVObi0Omb/sTwMfep293ADC7493PtmvAd5tghTBLnkMGcYvSvR qMH6EIqTpo/XLJl0iy7Cx+qqVXCKe1uUQQaKjG+0vNM7gwPc4nhD2kJAwLvDEEve gSu1mtEKGhNHheSO06u9bBLQsg9u7c0FPcRNSqVpw9YjkXVZmIDEWE1ilQQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpf9c1a8v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 13:07:23 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c70ed6c849so1009813385a.1 for ; Wed, 04 Mar 2026 05:07:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772629642; x=1773234442; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K4gYoo9JoJPOJ5mTuliJj+hphclVDgk4+5Zp53bnrEg=; b=Ufi9ipDklVsKQO7cF/i5cac1ETpF+1RuMeO5J3mbO9Y/10vLXsd6dhHoXLD+Gmt3dJ h9IOCYqAOOiNQw+HDngw5EVz2+nnw3X7BkY7yJEmT9mD+2A5jXsajnuJlL3oPbSxuJzY zRQ3BiNj5UjwIOTU+Hjbij2vZXLToNIeURrBOeV7E6WKZqZSSB0paQLv2bDtQD6t7iFd QP9J8qsthWdGK2MVO0Aq7FyrM3XrKKjkh73I/7W2IwpkV5ZBfWFI2rlrovh001xqLc9Y 1S7+NsABzCUreTQZEb2l8HArsF9iYHV02/O6OqpVdY87KQVPt8uzvcfCdSOeKZQIgGro qj2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772629642; x=1773234442; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=K4gYoo9JoJPOJ5mTuliJj+hphclVDgk4+5Zp53bnrEg=; b=s1qWsLoAVC2CrLxid/u4T98hJvNU2KyM9mdABH+7mjrR2gPrdhtiUdGwsmZ5qGZbrU 8f0e8Om9on9sr0EcGFBVW5RxSSdbkdxaBaiEasME1SgNXnIQz0pXNm5AT9sfhRIxdE3G sNpfUMH55xyPM6Gqe55lEBvwUXj43dGbXk37+0AqqQg80zIAcM64QgEnrMhevqTmEB7L wQ27azGRbLOo86IqQeKD3GEF7+xwUJD5e6bgoYHZzKWwU89iH6k4LcoJCHWmCQ0GxKwg lMyr+vSWuFZSgpvyIy+oUXQAIu9J+avmwsGVPNUOCTWBaAxSZMx2r2dyd3Zjp3qQ2OhN Xt1A== X-Forwarded-Encrypted: i=1; AJvYcCWBLktZb246RQPuQzOsQZwzdPzUlhdna7XW7sgkHNY5j4YB2m2amSCyoHIbxj0O/83Jp4ALH2H4iSGrW0Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyJjNIYiwcUrOxosljnymBxiIBB+0yyhA+GDP9CyDE/zay3MPCD KOTWcvryW6U4Y6Zg7pKY68hhx+jB9eoZacjGI1j4m/InRCjnq4gHiGER2CtGBk+XGY7/ryv5fKk ketRRAjzDq1p8+Lbxi9vJMIDWnFaVKB5n/3xTfXocwSv3VUacNRxPa8/nQqWdqhHlrTw= X-Gm-Gg: ATEYQzz4ehI88DRQsFI8JHn5XnWfIg7P2w5YqA7npqsg5ANbRvSuss8eGS2BU0HtAve sNGalKWsMoExT/13SMpUDtgN2EuWXByBqfpcTITRnAresDevOxT8piFUQTca9y4Y9Ed8rzPJ7FB l5aC8BliTIjVukU8hha5/ErSdUaXcqq8DhnRiWw+Fqp4xsHWWSX60XHWLvmaASGlaXzX1Sv8NMj A4UYXJ6W5TwCIdYw7FrGhCaavTv0nRXieuDmJCPqrQeZTqYvL9UuC2vUrxdQgvgMxuQgHcLE+se pU8LMe7yTn3/12mWWJWEQZvHeqlfrmTWDVKbMPL4ySx7lQT7L414O7ivMeJKigRlnJxainSB77P oxScTrtHjx6tChZ0PO0TP62RjUx0f9jGE4n6Z6wzgS4tMpFGnj1641Zk= X-Received: by 2002:a05:620a:4727:b0:8c7:1a0d:7d9d with SMTP id af79cd13be357-8cd5afd2111mr209563385a.81.1772629642214; Wed, 04 Mar 2026 05:07:22 -0800 (PST) X-Received: by 2002:a05:620a:4727:b0:8c7:1a0d:7d9d with SMTP id af79cd13be357-8cd5afd2111mr209558085a.81.1772629641720; Wed, 04 Mar 2026 05:07:21 -0800 (PST) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485188122a6sm49969745e9.12.2026.03.04.05.07.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 05:07:21 -0800 (PST) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH v3 04/14] ASoC: qcom: q6apm-lpass-dai: Fix multiple graph opens Date: Wed, 4 Mar 2026 13:07:02 +0000 Message-ID: <20260304130712.222246-5-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260304130712.222246-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260304130712.222246-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDEwNSBTYWx0ZWRfX+O1uxt9SsKwI 8N9tCJpj0sco3FNUO+lOU9PLAu7o9kmAjQpZIklZtPmKLcSHSzElEIJJIPNoBDfUO8mJQMOCeH2 HuAJwMxfyOEZ39TwjzUK04l4o5WDrFhJ9P0S3cM36FjRsPq7U/MZkqm77mk6GYRU+9AALqCKTd5 O0msKypEYlYYACJ7qWgM29fQXqIiHh584FBx9Iw/z9dN0lXyEr50L+ufBK/w1hJGG0b8cVNeVrB B1HJ392gNZv2Q/Ux5UyB50Qnq5Um5okFpihvK02uqJbK5XX4o8tb5PFPOomZ6ik4x5m+0a61YZG QPGxmEgO6B5G/BSzk+SiDcsQLvPFcSfDPxfk2I+SMgh9nwYWBuQqrmd9ymCh5XWuFAf8Ejffals YPcR+8t55pOCVte6czXTktugtLEJabikGAjXviPDdZrvtLMvGrz8OgVvcktHKoBRoyiMcUCSH5s 9G77EtAQwvIyuiizqSg== X-Proofpoint-GUID: b4j9eBJ-gppTiXhKdIaXiFHXM1yZ0Mba X-Authority-Analysis: v=2.4 cv=S4LUAYsP c=1 sm=1 tr=0 ts=69a82e8b cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=M_mAHeyD2EURj3i0m2kA:9 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: b4j9eBJ-gppTiXhKdIaXiFHXM1yZ0Mba X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_06,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 impostorscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040105 Content-Type: text/plain; charset="utf-8" As prepare can be called mulitple times, this can result in multiple graph opens for playback path. This will result in a memory leaks, fix this by adding a check before opening. Fixes: be1fae62cf25 ("ASoC: q6apm-lpass-dai: close graph on prepare errors") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6= /q6apm-lpass-dais.c index 528756f1332b..f68d4b4974f3 100644 --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c @@ -181,7 +181,7 @@ static int q6apm_lpass_dai_prepare(struct snd_pcm_subst= ream *substream, struct s * It is recommend to load DSP with source graph first and then sink * graph, so sequence for playback and capture will be different */ - if (substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK) { + if (substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK && dai_data->graph= [dai->id] =3D=3D NULL) { graph =3D q6apm_graph_open(dai->dev, NULL, dai->dev, graph_id); if (IS_ERR(graph)) { dev_err(dai->dev, "Failed to open graph (%d)\n", graph_id); --=20 2.47.3