From nobody Wed Apr 15 13:22:51 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86A3E2E8B9B for ; Wed, 4 Mar 2026 13:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772629650; cv=none; b=EQBw+I58D3fhBUcDWSGVyw9mpzgARtWzM1K1CI9PZPIdN1vh0edgzL7dRabXS35dpRGgRTPpzS9vFhhehjd4XP+e0Ka2/80x5fr2sj2Vw/7sJ49Yy7QABTOeMGP0SR0eAuhCJyKrI6x7Pj4jhWyPk9HcfNXSY7YlaDpdQ8miLsI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772629650; c=relaxed/simple; bh=6jShP5otc7Z/xglFZY5mqaUqDhEckaI1JOm+jwe6kcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pfMa/3JzPU5NJlcP6lqIS2Fof8rzMUwVLA0M7mlQa14sJFnH+KwFiWy66HyPKq3JDIug6UrNhrvnwxtEXNfx6QhrX0W+dfyR4YDhWBSj+3dJJw6bDQ1/eQ9iz6sdPq+17sc0iXS7DTNjaCGKuoN8AMEdTS4Bpb1SVhi3AVtgquA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JnuxjyGn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RlWkTHUW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JnuxjyGn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RlWkTHUW" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 624CKbFe2275163 for ; Wed, 4 Mar 2026 13:07:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=xKWL+GAYqNp +tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=JnuxjyGn0g8xI2Fhz/yc/us5pm5 dQ1wXrsyOsZJiOhLb1UBZSyE8HP2SeUjDUV4tROqakBkBXIG8HzAaCR0yNKvy+Rn 83GU+s13of1G0m7YuQCDKz1iR5C8D18Ekag0bUFPqOGBxiyzuie1oR8Mby3zJrq1 s34xcFGScVL+ME4neSTUfy5hkxXRoyhCwVTOCjBva1dirb0va2Gfs/t+1pgebIge yHRwwy1vnFfPeiy2Km/u6nA9qbX9fJJHbJiATqItumoZtA5dXkqPutwj8SGE0VyH 1RWZUu4B6+F1dup5Ix48PvHXW6WkgILxPe43ajEumCiOpnp06qq/5nn5g2w== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cpc4msw6b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 13:07:26 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cb413d0002so4795515485a.1 for ; Wed, 04 Mar 2026 05:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772629646; x=1773234446; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=RlWkTHUWzkwFdv8Td7O4/YCe8YbQx7pzhG+DshTM9hWBqY7wBkBX9QFSAQNQ5eTdl6 IbG07p1zOd9PbxX081yp1ew7JUiWlioY877OGczaiG7hb4L3lyng5mxHbEwP+20164Sz vr5DCSRUxSB+YGxZpGlQMbZ8ENC88aUli6DFvqNlkdXYRysiNxHZ2XOE3KTnFt8alotE 4HcKiA++5lX/CCc6bl73AJBgz8V3EtrRr1LErbT+4Zo8Ao7uf9oGCbwsh8icxgVhakmy wbGzXrpcNlhX9YIMe/cjR+clK99i6k1sbqPI+Nj3UY0zf95AKBBLlKDegHelaxKG8L5S cEQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772629646; x=1773234446; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=tGpwtvsyhJXrvPNAUuQnLwiL9zS9fh/+N109cHvFDvEvfFdoMlxp9lc+SaTHoKmiWu ZKR01ygK+wh9A3POJ3FgNOMOnbeFpRhXoCcyNUaChs9TNS/p4U7TvAHsvYbY0V+3Oq/V XnFNcTivEFauW0Bug7PRyjlti7cOZZDO+ymHHF9Ur0/1uhjzjssKrpVuy/j1o3BSiT8k z22QRwlvhHTIwg9+N7g4n4+0/M2LlP89Z9v9jdGUJkQ7HXhXhfb6A0Q/UKCVM6zqKRxW rLu0+97oMXi0nv3tCaNm/FP9sWlZXx//j0ebaH9wnmQl9druqlX0dGsVmH0C2ZImZ+QA Go0g== X-Forwarded-Encrypted: i=1; AJvYcCVqGubZNCaMGtMQwV4MhkLimfDndcY1bDJf2l7Yr4SMVNsl0/3ETYqLMUEK0QaRK/ODwch1DNs35YDNS44=@vger.kernel.org X-Gm-Message-State: AOJu0YxlKz3Tzr/8jvxb+0CmN38RIex6XuTRWvJpufQxd5EWsT7TNibF Cc198CWLq5VHVAy147igPSFbr48+e5OrN1KOCPfLyOVYw/nIInmS0kpe015AO8n8a0Bfw36KYRh 3ZqHDQzXGT0cNZPbqQ45Je1YDRw3AIxIvBGen2lVtF+nRxOV+9KN30QgKSsTeFq092kU= X-Gm-Gg: ATEYQzyRcuBUry/UujeXFvq7YpmrkMMTaquPkUMQMoQZBIrQ5zY9WpwxvnHVyjrI7V4 gmbsCY0XfNfJSZxb/NAwDzYSVBT1lrqaiaAWofrxLnyp1ySDuShvulNLsWaT17M4jqcxefs+2nI WXPVOOnl2H6ZXsw9lxKQ27CnJYPAdA+CaaYqJQ5MgquwxggoCu6jSQhg5W0XTwWnqLLbUbZjkF6 5wvOcQCboQj+gXqjFxk7a9EcAWnxaTBPi9gKMe6jrPta6wAnsu1pc+MMy6UD5VC5oIIP352E7I1 cJQVi4n08A+pBD2f/g+tfsD6PPl7R0d74cRH1x8OZpwyGtUrfyWsg043dvvNnUc/f/gXDr3jIYm QNehP/dceJ8Imre8mhMB82pWRqwFM6VgtSGIZbQOb0muCUKI/nG+5ID8= X-Received: by 2002:a05:620a:45a8:b0:8c6:c983:dddb with SMTP id af79cd13be357-8cd505e251fmr619635285a.0.1772629645726; Wed, 04 Mar 2026 05:07:25 -0800 (PST) X-Received: by 2002:a05:620a:45a8:b0:8c6:c983:dddb with SMTP id af79cd13be357-8cd505e251fmr619592585a.0.1772629640326; Wed, 04 Mar 2026 05:07:20 -0800 (PST) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-485188122a6sm49969745e9.12.2026.03.04.05.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 05:07:19 -0800 (PST) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, Srinivas Kandagatla Subject: [PATCH v3 03/14] ASoC: qcom: qdsp6: topology: check widget type before accessing data Date: Wed, 4 Mar 2026 13:07:01 +0000 Message-ID: <20260304130712.222246-4-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260304130712.222246-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260304130712.222246-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: EU1AUxHBJFSRv80wDSs_Hze4NI67I6jN X-Proofpoint-GUID: EU1AUxHBJFSRv80wDSs_Hze4NI67I6jN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDEwNSBTYWx0ZWRfX1E66BSbQhfrK 1TrHK+FG1hvNwGvNbFX5xBa1nf8iXsF25hMDbslATj0vhPxa6aLI3RPCFTAIMSMgXcb27E0pE4x vqj3bE91iP7rgcWeaXaKLocJlX9YttvkU6T3kKue2tnWZ34IRlU+lbG9zKwO4+iOpKuur8/JMhl xWNJsJ3S+UzK0ibK64aaSm6eC1QMESA/p1irYH+GIwOoQDQ5/wL7VdJASXU8JyGhlxw7yEFuWmC YigSQ47Y1XN7b0qIHIGDVx5o/MIwJwsDLiO1g7r1QMIz+3roKe4mX6T/w4i2cXfIZpckddzHOfI 2/kCXJft9mvtO8buWTUBwVkTqhZQaKX2toF8g4dt3Up3w3WqdeCwuMR0GF+oKhGHCOe9Eimwul9 J62g+cRNjxMrKCN+q/w+1dZHhoVnAbZHHL8t/YigIri6MkX+fNgf+WuQz+DPO8T2O4D6ASd3DDq 57Nh0PtSnRHqfKt/duw== X-Authority-Analysis: v=2.4 cv=C67kCAP+ c=1 sm=1 tr=0 ts=69a82e8e cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=5HTw2GpdgXbBP0wXRk4A:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_06,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 phishscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 spamscore=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040105 Content-Type: text/plain; charset="utf-8" Check widget type before accessing the private data, as this could a virtual widget which is no associated with a dsp graph, container and module. Accessing witout check could lead to incorrect memory access. Fixes: 36ad9bf1d93d ("ASoC: qdsp6: audioreach: add topology support") Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/topology.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topolog= y.c index e732fac9b8ca..1f69fba6de26 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -952,9 +952,6 @@ static int audioreach_widget_unload(struct snd_soc_comp= onent *scomp, struct audioreach_container *cont; struct audioreach_module *mod; =20 - mod =3D dobj->private; - cont =3D mod->container; - if (w->id =3D=3D snd_soc_dapm_mixer) { /* virtual widget */ struct snd_ar_control *scontrol =3D dobj->private; @@ -963,6 +960,11 @@ static int audioreach_widget_unload(struct snd_soc_com= ponent *scomp, kfree(scontrol); return 0; } + mod =3D dobj->private; + if (!mod) + return 0; + + cont =3D mod->container; =20 mutex_lock(&apm->lock); idr_remove(&apm->modules_idr, mod->instance_id); --=20 2.47.3