From nobody Thu Apr 2 08:09:44 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5996C37EFE5 for ; Wed, 4 Mar 2026 11:33:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772624004; cv=none; b=nRC92DtMnQavTsmWf50hUQy/eGzCe+O9gFPMDdaAl4MK4qs3FqMROeDrMapYYEKGUUuY8SfYZ0mmGVAr1qyGzjT8SkkoKghsxiArjZ5U/wlYNrSMQoaTq72h4IdXDPkKRH7wzraTnoDeh3foe0CgrUvwjTVJcUMda2kIcTLZjYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772624004; c=relaxed/simple; bh=7J8BI+Rcemp+dYpWVwgeZFFbGVyLChkGx1Fiw53IZOs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=COKSYkD0GbdDYOl73h3mBQ1Q6pX9OpGWxSu/+hFg93iOrwL0u7jq0HTsFE6z/be4639rKqq058tSwNGp//bplMmFmxVmLnD//Y0sUeiz4QHscawxd/9nPJ0PVxjQSkzRf5e2tet5pmVdMY3SMS5c5PCVkZ2vLipY4PB1TYi+GmE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f7ZgGzRt; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f7ZgGzRt" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48371bb515eso101045715e9.1 for ; Wed, 04 Mar 2026 03:33:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772624002; x=1773228802; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=du9uP6OMevudrQRpbTDGPlPaVO3wZDGVzS8mohLVAmo=; b=f7ZgGzRtQlvtjD3fbG3OyDbAO/ulW/6bWssmLr1rX6Pnnu2VVxpqkOZszYKdS6z96U 1ZF1oAvdo13zrcVpfCJXNxJvKN6b7YBvNpWVhpB0Vj7Ogy9F7nRdg9+Zrvm5XKIJxZuB gWi7+csSXYNYF26Ege0xNHGQTM9Ohz268PrpX5JKn+SOSFf8zx300wE3FI898FbnrUYq SGNDrpvCmb3s4qCOnQ5kCCsjhqoelHXjJRiHFI7jcRKCN3R9l+m26+Ur2XplcHwJ3l5u vIZXVDtIIFGVE7Xroa17PyEspqUfD9eAT7X7TGDRj2H9vMTT/Dktevy8PZ8vvW0B1Qvr qWXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772624002; x=1773228802; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=du9uP6OMevudrQRpbTDGPlPaVO3wZDGVzS8mohLVAmo=; b=RX8w3bpuqT746viUUw8F71egTywOF9dzIZa88GoHa+M+VmknCuMpIDAZcy8wXlXPDC RRDINF3QR16UoNnLqpmhBSqrZ72So9DrtsGkBcicip0+buuADoVteNJZVuCELxcSBKXf Imh4sk3mnTGjiuXhURpj5aJB8hBsc/I1lwNO6zHHtHNPuyDZaiQRzzsCPJUbNsuIurA+ YgyE772opxWJFnkdI7fGFhU+8ERgKh3I1zF0gH2ljQSHuswk8TLgmw7FMJGI+xfDqDj6 RDNZjKLWrWT9Z6OjJn1bkklwnAbja+AOPZR9Z+Q6mHK4k3Hb0H9UBYudOFUtqYX3udAW 11WQ== X-Gm-Message-State: AOJu0YyDRi4rPa1pQC3IuDVHfVCwsUpcTUccHTbGnm8nR7lIoFUNoJTx gPSzSgm7AWIwAK2wJSBoZqwx/Pm5sftveqrqOCwFiKLdeMsmYgz3/HX5 X-Gm-Gg: ATEYQzzt1BdrGhSwZ6l1zjQhmsg/sk6Z17XZRPnTTUX64CjHIG20XrM8U/Wdww41fy2 3ua8ZsIwXLtMbLpbXD47KYlP2fVpbr1kIa7JPC73BdD3fmSgUjrtEZ6FZ2ci8sFE22ovaTeNqLD 9YD3zlqVtjPUpN/JulSEhsXzGrFvYa++29HzBWc83R4zTIcy2J91tLf9pWkhPbcnH60IkNjM/hY s/nAF245gE1k0mruNkL6I2QgyFMCbjXJ7cAOVawjicuTUDP9XEBHzl3h/x4FF22f1CNG+tcWqA8 8vtnB4esSdtvDH1uDZnA2nuUdVVptOyLJtJBEFJjcg4RTKOZMp7BlK8H4ZbKJd66sj+tz5BXqoc Jjvtj35kxJTL2GoxsZ1tRIneYr8oc19mpYZH/y/y0WtwiPBRPh/WlvHZKfEj7hOeF3HGqlzX8l1 nd22gNi6v+s8wE6MS99m99VnaHKplBMroGj2FkJqv2GoH9ijoPndxCxdLyQ782HUAlwMNR6Bu6C 5ANdE3q8w7/BGr1h0/7F0+MdsX5kuLQ+E411Vbe8GpntRtl4v/eFwH4xA== X-Received: by 2002:a05:6000:2211:b0:439:b932:b445 with SMTP id ffacd0b85a97d-439c7f98243mr3379166f8f.2.1772624001639; Wed, 04 Mar 2026 03:33:21 -0800 (PST) Received: from iku.example.org ([2a06:5906:61b:2d00:bddd:d1ed:d1ee:a876]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b03db76bsm27345379f8f.18.2026.03.04.03.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 03:33:21 -0800 (PST) From: Prabhakar X-Google-Original-From: Prabhakar To: Thomas Gleixner , Geert Uytterhoeven , Philipp Zabel , Magnus Damm Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 4/7] irqchip/renesas-rzv2h: Clarify IRQ range definitions and tighten TINT validation Date: Wed, 4 Mar 2026 11:33:14 +0000 Message-ID: <20260304113317.129339-5-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260304113317.129339-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260304113317.129339-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Introduce ICU_IRQ_LAST and ICU_TINT_LAST macros to make range boundaries explicit and reduce the chance of off-by-one errors. Extract the TINT information up front in rzv2h_icu_alloc() and validate the resulting hardware IRQ against the full TINT range [ICU_TINT_START, ICU_TINT_LAST]. Signed-off-by: Lad Prabhakar --- v4->v5: - No change. v3->v4: - New patch. --- drivers/irqchip/irq-renesas-rzv2h.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-rene= sas-rzv2h.c index 444da7804f15..ce7d61b14ab6 100644 --- a/drivers/irqchip/irq-renesas-rzv2h.c +++ b/drivers/irqchip/irq-renesas-rzv2h.c @@ -25,9 +25,11 @@ /* DT "interrupts" indexes */ #define ICU_IRQ_START 1 #define ICU_IRQ_COUNT 16 -#define ICU_TINT_START (ICU_IRQ_START + ICU_IRQ_COUNT) +#define ICU_IRQ_LAST (ICU_IRQ_START + ICU_IRQ_COUNT - 1) +#define ICU_TINT_START (ICU_IRQ_LAST + 1) #define ICU_TINT_COUNT 32 -#define ICU_NUM_IRQ (ICU_TINT_START + ICU_TINT_COUNT) +#define ICU_TINT_LAST (ICU_TINT_START + ICU_TINT_COUNT - 1) +#define ICU_NUM_IRQ (ICU_TINT_LAST + 1) =20 /* Registers */ #define ICU_NSCNT 0x00 @@ -508,11 +510,11 @@ static int rzv2h_icu_alloc(struct irq_domain *domain,= unsigned int virq, unsigne * hwirq is embedded in bits 0-15. * TINT is embedded in bits 16-31. */ - if (hwirq >=3D ICU_TINT_START) { - tint =3D ICU_TINT_EXTRACT_GPIOINT(hwirq); + tint =3D ICU_TINT_EXTRACT_GPIOINT(hwirq); + if (tint || (hwirq >=3D ICU_TINT_START && hwirq <=3D ICU_TINT_LAST)) { hwirq =3D ICU_TINT_EXTRACT_HWIRQ(hwirq); =20 - if (hwirq < ICU_TINT_START) + if (hwirq < ICU_TINT_START || hwirq > ICU_TINT_LAST) return -EINVAL; } =20 --=20 2.53.0