From nobody Thu Apr 2 09:45:02 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C960F350A37 for ; Wed, 4 Mar 2026 11:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772624005; cv=none; b=sUE6PWqT/RqbDPvWXW0vxK4qutEc3g43KiZSh5wQh+CTLm3tmz1axEYOO63lnACTiVfxevxWlci4xYjQ1GQFJRfUCu3gJGhSJ3gvPPe+qh13culsRYZC1B/odhGBWw5Ki0Bcduf88N1q6aKLU1faBqAPK9PJidUo9qDa03F4JPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772624005; c=relaxed/simple; bh=HVot++CFYbj2fq3XhHb/ZARcDp+BpxyBrOr/jpWSvOY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CLDKaAzRMwy1BRwKIsH8Bxhawu/KobCfQfv3SC0WuiRhCAI6OqS8cjM8nhryfk5QWd7MLVoNXgIE13k0FdpzNaA6MvhfwEX+VZ5ReLTrltxY4JY/ith/cyWu9kv1L8x8v9GUg3SQQ96G7zMzUElckqYmWto0gVfccpSf2C3HF28= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Bti/6ZHL; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Bti/6ZHL" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-48374014a77so82014285e9.3 for ; Wed, 04 Mar 2026 03:33:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772624001; x=1773228801; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=95xYVWddCpQ/gguGzPSMWB2CI8VDmnrGAS6VKDyvCuU=; b=Bti/6ZHLkU2hkKGMS+EVmOKMcVCZQOrqUSqGFBzWNwM0lGyNmSX6GeGhz46fDlUVwJ E/Zjjx4GcuuIK5JPNsPTh2tu7Vz2zsvvoLPw0UvkDVrnydrl51wk5gfONtG1uaK/n+US 8R7DYp2OE4Er2QPEs8Ue256k6uHBRdB03hmdYS6WGcty48y1g4Ibz7fxNtEjJYXuatD1 hOnY3eLXEb3n7XuqmZ0MXozO4JU16v3uesDQwxVHKwqaxAQIJcCn0X0Kv4+gPcYWwC+Q 01ctH6BJwTBN6dQM0wy8rarD7RRsikXyCpNvhF478W9QrwvMV1LB3+3foFCfrGjB3IZt zgVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772624001; x=1773228801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=95xYVWddCpQ/gguGzPSMWB2CI8VDmnrGAS6VKDyvCuU=; b=ocC06GQs7LXBmVl26oGtD5OvdLPBYHZemSLGu9vt4wBEEiELLeHYfg46Ljq4myENfl HDD6dt6TTfTYdPREsMvQzrTA8GQJ3ELAV044fBbW3H87anhwX6rkFBIvqaRdi07s3a+0 pTFNgDYccRFUbKMQXxoJZSxNoNJ2pILtz9yuGS6ROw2iMMQ4U8Y7f4gVS8aIe97beLVa egVCwLn9PYkom4o33LawWhkLms5FZPNP32Qq7/YZ4VMTUXsuEHUtwahKp0CdbthfdgW0 DvB8H+BoZfyd1uQ62keb97kdLHkSwxIqE9uJqbuRAGG04Yq82/CyUEVOBRx7M63XXyoL fkiQ== X-Gm-Message-State: AOJu0YzWfqmi1bVyAk1QeIuKluAy+92VutHeahAk9LxwzjXJl5/M6a+W UyknZDxRqZ89ewtcJ1Buo0+2TxpPaiTpzNFSBnQoY5TgSja/9JcrwSBv X-Gm-Gg: ATEYQzzXTri44rQMS81xd3EZFfBRCk+ZVApmhBhlmSq/J1LJmDynk9HZX1MYZzbWI3E XN1jbXe0HpPq9vSSJdgc0kDPgVT9O5xICvlrut4BSfpFHTDFre4TXuOKdjSEU/TYUpxVo6TWnJY lo86dY83vMnqt36i6a1fUvVuauarNcrRd0YvztyfzTVfQgHW/qZ7VBa/fwPIrzxuHmLA3eo3DKf heM1BbCbCmrvbbshJ4OJpThp267+lWFTC2vfVuIu/McGMQvwEdlCgi+00HyV4NYpM7aQ9Dih1HW tBeMUDxI9O1RFPR+v67Wrt6DOwofUp4059SjOsz7JAiOSBI6ywljU27dWj6S5kZoMfA0le9F3i6 k2yuB6y6x98MWm0RD5EbQYaJxWU5d1JQwNCm1t/E6PU/ycQ6X015QI+6Q2ZrOtGCiLpJ2UMF2oj IF+Ug9faZFziUTubJZPN/IIDjOcPAP4hQTUQQKZ+FenN9z0+NmlujGlIj69f0bnHC9+sSrxy1Dc bRyliTwn+pKm1lkzLbVYmHPui8NZpZrSsi10hBrlS6WUYM= X-Received: by 2002:a05:600c:6098:b0:471:1717:411 with SMTP id 5b1f17b1804b1-48519888e49mr25537925e9.24.1772624001206; Wed, 04 Mar 2026 03:33:21 -0800 (PST) Received: from iku.example.org ([2a06:5906:61b:2d00:bddd:d1ed:d1ee:a876]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b03db76bsm27345379f8f.18.2026.03.04.03.33.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 03:33:20 -0800 (PST) From: Prabhakar X-Google-Original-From: Prabhakar To: Thomas Gleixner , Geert Uytterhoeven , Philipp Zabel , Magnus Damm Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 3/7] irqchip/renesas-rzv2h: Switch to using dev_err_probe() Date: Wed, 4 Mar 2026 11:33:13 +0000 Message-ID: <20260304113317.129339-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260304113317.129339-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260304113317.129339-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Make use of dev_err_probe() to simplify rzv2h_icu_probe_common(). Keep dev_err() for -ENOMEM paths, as dev_err_probe() does not print for allocation failures, ensuring they remain visible in logs. Signed-off-by: Lad Prabhakar --- v2->v5: - No change. --- drivers/irqchip/irq-renesas-rzv2h.c | 31 ++++++++++------------------- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-rene= sas-rzv2h.c index 766b981cf3d8..444da7804f15 100644 --- a/drivers/irqchip/irq-renesas-rzv2h.c +++ b/drivers/irqchip/irq-renesas-rzv2h.c @@ -560,10 +560,8 @@ static int rzv2h_icu_probe_common(struct platform_devi= ce *pdev, struct device_no int ret; =20 parent_domain =3D irq_find_host(parent); - if (!parent_domain) { - dev_err(dev, "cannot find parent domain\n"); - return -ENODEV; - } + if (!parent_domain) + return dev_err_probe(dev, -ENODEV, "cannot find parent domain\n"); =20 rzv2h_icu_data =3D devm_kzalloc(dev, sizeof(*rzv2h_icu_data), GFP_KERNEL); if (!rzv2h_icu_data) @@ -576,29 +574,20 @@ static int rzv2h_icu_probe_common(struct platform_dev= ice *pdev, struct device_no return PTR_ERR(rzv2h_icu_data->base); =20 ret =3D rzv2h_icu_parse_interrupts(rzv2h_icu_data, node); - if (ret) { - dev_err(dev, "cannot parse interrupts: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "cannot parse interrupts\n"); =20 resetn =3D devm_reset_control_get_exclusive_deasserted(dev, NULL); - if (IS_ERR(resetn)) { - ret =3D PTR_ERR(resetn); - dev_err(dev, "failed to acquire deasserted reset: %d\n", ret); - return ret; - } + if (IS_ERR(resetn)) + return dev_err_probe(dev, PTR_ERR(resetn), "failed to acquire deasserted= reset\n"); =20 ret =3D devm_pm_runtime_enable(dev); - if (ret < 0) { - dev_err(dev, "devm_pm_runtime_enable failed, %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "devm_pm_runtime_enable failed\n"); =20 ret =3D pm_runtime_resume_and_get(dev); - if (ret < 0) { - dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "pm_runtime_resume_and_get failed\n"); =20 raw_spin_lock_init(&rzv2h_icu_data->lock); =20 --=20 2.53.0