From nobody Thu Apr 2 08:10:17 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3C2D34C816 for ; Wed, 4 Mar 2026 11:33:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772624004; cv=none; b=uqxc7BW5chF+MmuWTvaIZRF2+LQwX5UbMd07+JUNg1AgRuvQ22pNIYxzpxf5FyatwnG7t34TL7cVDC4zOaMLApeyOSHJU0IaNE4Ue05qhS5IfkHn1kjKfRkVMAjZHDFmaec8ZJlStMw9AZP1hs9d5w88bFuPx0MNtvXy6+VXBy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772624004; c=relaxed/simple; bh=g0JpY4qqML6uYgF5lgCUFPoSd6CF+LvzL45sjQkSO9A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K/mQ/oa2Gd6oe2iyf/FEp1pHYwscQjgB0UtWTY47n1q8p6p+PYQob+LqaFpYVxcDUk9BYg3R85mJd3pvhHSjMFLUgH5LTU7+q3VHzxuyAcuadspN6g4qzeTvNQ/WezV4p+Fa2n74Fei1UELsPjcPmyBViAucQZE10pL5C3mhcd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X+dbLhB+; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X+dbLhB+" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4836d4c26d3so51740745e9.2 for ; Wed, 04 Mar 2026 03:33:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772624001; x=1773228801; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FqDJQzyt/HO+E5E3p1uBbxbxOJuRk+sIa+A/ceu5jZ8=; b=X+dbLhB+03ljqQz07xGQLp1lbiLbHItZpNwX98I+AfzjRyo0vm9af7zWkrRCZtZnJm ORB6yzNSbBengvI7xU2uehdJv5LWPJM6DYGdLgwKUy0QoFRW5eHGqBw10nbbtS9yXwMS b/HPXvRzJ8zTIpfGysHmMETqUsRutEBLuGBm+RFFPQPd/r+aXt4JAzO3sPX5HWOxTDgd AF8OSJye/z63RA2RX9nLXXxkGDnmkW/iTqXCH85aFyQd/RMj4htFtPKmVZovXidBFvEu JLj1R0A8wYCv02Rp1ymxumtzrehBIOT6bMRVWk9d1UE73B2/iyJ9EgMLDDzpLldC4Mrj AkBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772624001; x=1773228801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FqDJQzyt/HO+E5E3p1uBbxbxOJuRk+sIa+A/ceu5jZ8=; b=svL/Jbd49dcpGrmI29z+MazV+mJMCAOvRZxweCNJp/oDDj58SqGnL15LgEyzjppQFX Isj9b/IBmtlQpl1u6y2YA2FDM7ZS9r8EFZ3q6QipmnkWiPGRTDW8v2Xbh/jU63J/Od+/ ZqIT7SHb6Ll6LQpklOvqkLdL00svJkUKhjC7QrDb5njJmLFlj8Uago1yWaWMzBGNrB6+ KCaN9OsjhO3cGCk0veSzKstF/h/RXhTl8XOhr8m2z6fvnGmyiQV372adUGLmkLOvi8Z0 lRbV3HwlfLkAH3MV8KhpLvQQ0JCmSPTm4T+vxeeFkL1aFO4A5+xAsjJLd1TGRBtel+3l kSmQ== X-Gm-Message-State: AOJu0YxhK84DklkDfmBfo5C46WX/87ekNFlw7rtSww7cF7/Mpbe4BNBG oew3JlbkxXZkAIgatPDMy48GHvZdsgS4KpTN59nQLzSZVpRestFjaGIIKnm5trCUh1w= X-Gm-Gg: ATEYQzxC7B7wVPLNvE2u4SifbWi0dCpzE7FbYZ/g4tZep4WXBTv9iFf3PAL/5Tl/FRJ 3TKhxgDN46OmDk7DFkVRV1RkP6bisfTFYy3RkPOqyfve2+PrOwPSr2DzyQelkNtKfxMQp2bkVE6 j4QtwMYNLbvGeHk0TLQXTrIbRElqQRHxGamMmg1hF1VtDBu8I9aP3LI6bkEiC/dJfeYCKMxpOE3 fAaaZgddeyEhfaxH2xxAApJ8HJUJQuOpG4c1Y6U7piXCnlz15GdCC0yTxVZ38YorQkrIvxrmZAb urCdPRgjR6BDXiw0EP7A77l8n6a0NYs+DlIM++3eTUxTfrX4m7mFXrFX3woVY8u7nqagfPJwnh6 RE0qUANHVbdNYpEDxSDBjtmX6FEduf82Ni5VFjqk/JnESIVL7L9XzT0Z9QwcbN4fSLN6hI+C3AU 0ZONDdAhODgHEF424MF8qxAasVQNo5nDqmtDCfUITBmhLAtppTNI3EuY7ZPYr3Y9GEI+YKBHRRU glpAat2+Ic4Rmy6vdVV3KUfwgX3KYg8OwNCbZySDJZK9R46WETfJ5refw== X-Received: by 2002:a05:600c:45c6:b0:480:6999:27ec with SMTP id 5b1f17b1804b1-4851984b278mr29785695e9.13.1772624000723; Wed, 04 Mar 2026 03:33:20 -0800 (PST) Received: from iku.example.org ([2a06:5906:61b:2d00:bddd:d1ed:d1ee:a876]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439b03db76bsm27345379f8f.18.2026.03.04.03.33.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 03:33:19 -0800 (PST) From: Prabhakar X-Google-Original-From: Prabhakar To: Thomas Gleixner , Geert Uytterhoeven , Philipp Zabel , Magnus Damm Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v5 2/7] irqchip/renesas-rzv2h: Use local device pointer in ICU probe Date: Wed, 4 Mar 2026 11:33:12 +0000 Message-ID: <20260304113317.129339-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260304113317.129339-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260304113317.129339-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Use a local struct device pointer in rzv2h_icu_probe_common() to avoid repeated dereferencing of pdev->dev. Signed-off-by: Lad Prabhakar --- v2->v5: - No change. --- drivers/irqchip/irq-renesas-rzv2h.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-rene= sas-rzv2h.c index 20c0cd11ef25..766b981cf3d8 100644 --- a/drivers/irqchip/irq-renesas-rzv2h.c +++ b/drivers/irqchip/irq-renesas-rzv2h.c @@ -555,57 +555,58 @@ static int rzv2h_icu_probe_common(struct platform_dev= ice *pdev, struct device_no { struct irq_domain *irq_domain, *parent_domain; struct device_node *node =3D pdev->dev.of_node; + struct device *dev =3D &pdev->dev; struct reset_control *resetn; int ret; =20 parent_domain =3D irq_find_host(parent); if (!parent_domain) { - dev_err(&pdev->dev, "cannot find parent domain\n"); + dev_err(dev, "cannot find parent domain\n"); return -ENODEV; } =20 - rzv2h_icu_data =3D devm_kzalloc(&pdev->dev, sizeof(*rzv2h_icu_data), GFP_= KERNEL); + rzv2h_icu_data =3D devm_kzalloc(dev, sizeof(*rzv2h_icu_data), GFP_KERNEL); if (!rzv2h_icu_data) return -ENOMEM; =20 platform_set_drvdata(pdev, rzv2h_icu_data); =20 - rzv2h_icu_data->base =3D devm_of_iomap(&pdev->dev, node, 0, NULL); + rzv2h_icu_data->base =3D devm_of_iomap(dev, node, 0, NULL); if (IS_ERR(rzv2h_icu_data->base)) return PTR_ERR(rzv2h_icu_data->base); =20 ret =3D rzv2h_icu_parse_interrupts(rzv2h_icu_data, node); if (ret) { - dev_err(&pdev->dev, "cannot parse interrupts: %d\n", ret); + dev_err(dev, "cannot parse interrupts: %d\n", ret); return ret; } =20 - resetn =3D devm_reset_control_get_exclusive_deasserted(&pdev->dev, NULL); + resetn =3D devm_reset_control_get_exclusive_deasserted(dev, NULL); if (IS_ERR(resetn)) { ret =3D PTR_ERR(resetn); - dev_err(&pdev->dev, "failed to acquire deasserted reset: %d\n", ret); + dev_err(dev, "failed to acquire deasserted reset: %d\n", ret); return ret; } =20 - ret =3D devm_pm_runtime_enable(&pdev->dev); + ret =3D devm_pm_runtime_enable(dev); if (ret < 0) { - dev_err(&pdev->dev, "devm_pm_runtime_enable failed, %d\n", ret); + dev_err(dev, "devm_pm_runtime_enable failed, %d\n", ret); return ret; } =20 - ret =3D pm_runtime_resume_and_get(&pdev->dev); + ret =3D pm_runtime_resume_and_get(dev); if (ret < 0) { - dev_err(&pdev->dev, "pm_runtime_resume_and_get failed: %d\n", ret); + dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret); return ret; } =20 raw_spin_lock_init(&rzv2h_icu_data->lock); =20 irq_domain =3D irq_domain_create_hierarchy(parent_domain, 0, ICU_NUM_IRQ, - dev_fwnode(&pdev->dev), &rzv2h_icu_domain_ops, + dev_fwnode(dev), &rzv2h_icu_domain_ops, rzv2h_icu_data); if (!irq_domain) { - dev_err(&pdev->dev, "failed to add irq domain\n"); + dev_err(dev, "failed to add irq domain\n"); ret =3D -ENOMEM; goto pm_put; } @@ -616,12 +617,12 @@ static int rzv2h_icu_probe_common(struct platform_dev= ice *pdev, struct device_no =20 /* * coccicheck complains about a missing put_device call before returning,= but it's a false - * positive. We still need &pdev->dev after successfully returning from t= his function. + * positive. We still need dev after successfully returning from this fun= ction. */ return 0; =20 pm_put: - pm_runtime_put(&pdev->dev); + pm_runtime_put(dev); =20 return ret; } --=20 2.53.0