From nobody Wed Apr 15 13:17:35 2026 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B40D386C19 for ; Wed, 4 Mar 2026 08:45:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613962; cv=none; b=VKDBZTEtZhdO2teZQbXge+3OXY12gt1P4sL8jEffGduQxR6lFXFOHHtWAAGjmpRp/5p9zXMYazOrSH6b5b9DvmOGb1kHtcZN99b9//JlgyyPiB3qr6QcVvQCtlKu7XE/8XZgszC7At3tA7ur/O/Q/IwKVHiYKm9yjSR8Pg2IRDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613962; c=relaxed/simple; bh=/mgLq6MyipgAXakM35FmxxzZYKnWCLgWV+pnzFPnrtE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=B7V4vdZ+WMir5pD80nz54rz2JEnBgGswtVQx5SezIIfXMcqDKze39W6Po8FzyOM1aJaFfbDHOhYSLd/8YinFrEmmhPQjcSCs6ZsSg+EtgFxzZEKsfHTEdQRMcPvyw/VC/QpOuWHFo6474OZ1HdrHWfmOEWOCD3fyErHvdTw5sIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZVvfFKiN; arc=none smtp.client-ip=209.85.214.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZVvfFKiN" Received: by mail-pl1-f196.google.com with SMTP id d9443c01a7336-2ae3afe0192so1278245ad.0 for ; Wed, 04 Mar 2026 00:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772613957; x=1773218757; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GtmuCRd6e+N3D2PnsalDY4juU7geywSEbJtG8JH60jw=; b=ZVvfFKiNihAMkJuozvL1NpQlLJpdq4kpWhsJD3pR54hr7HCksIwSkv/ZhrljvOm40w f1WGAk+XI0VKkTEM/ZUyuE84JpKA53IqgAdGeeqMaJPGbj3eF9l/4ZkU+JX8WWIK2H1s 7/kB3EUtZ1/6qLd/PQrmcAVM+JwEuKHu6sdsB91fP412rrSWW/istEzwC38HLwXk5395 Ea49TITSt6bHJqez7Ha417Cq8encM1w3uLBeUJKhRlCff5IhEUPCVLYwolt5gwU5NXIB ihMq8EG5OkbMpMz0MKorUgQmCeswYxzk8MdcBhmmHxI2tanEOr+U6nwR4c8XpCXWKg3d OuRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772613957; x=1773218757; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GtmuCRd6e+N3D2PnsalDY4juU7geywSEbJtG8JH60jw=; b=o+OK/219sswBP+0TOeV4mWvWiIZaQx9cnda/VTJ8tXv1AOO/e8mTtmXbGVSe8YZ8YJ knRVIgVD2196fC5zFlpp8PeIK1p7eiuci8Ns6LHv11n5aeRx6T6m1gPThse/MG/XuJ6q 4wmVUsAo48fFFQoxhIoWKkMxkcvucaSkWJgDEBzZWkvKtaeL71H6nD6PkK5jfoZg0F+e +a6QmxCI1nJwORZRvof22ec2WtK4X54ZSD5aU0blIKdt2dxV/xyCUeJ0vEZ9K3uZtDsJ Nfy+7tubGSD1b0emLedWSkzit8PwZZxOdBiO4Zs6dLYid56cbsSo1bGmjaE1Vjdad9kW Nt9A== X-Forwarded-Encrypted: i=1; AJvYcCV7pCdYGY0V2iZ6cHzQyGY9VZUi60L/BYmmQ8ahn3YYKEJn4YJ0rWoqnSiCdYhKSKGKUGI81VWBamFZaVA=@vger.kernel.org X-Gm-Message-State: AOJu0YwXF0cAiwoQbgfwmYBKky1sigGZmPSVvhdxp599qQPLm+y8G+cb b5admO+vgrSxc0F+SESaN50r3wGAqtUYdVFopdZeZtFzA3EJuE/0Pq7C X-Gm-Gg: ATEYQzyCPyHl55Cl6DA+a7YLW3f0mgteZHHWSZvEYySOTHgWQ1N6tqTPH+86mHXd06G jd64X338GFKI8J5EpMmV9hpMYtSl7OpV8iZhpy7BWZQw62O5lLMLMt0dn+R7kKEO044zyn810Ox tAvQ+KBBVYF7cxNvlN3i6/7YZw8XS/INnZW9hv9BjNf047Z3pb3xTHpY9zZISGjmQdeZPmMWIML AdrVzJ3s1KGqgaOizvL220TP1y8ZhoMXWOjP8JP1D+bjMfBx311ssqfCuRdzt2dDYY5XPp/3RfB GFmIF63g+K6JpI0jg1CSPzzl+PMh77dl0GXjyDSFF8BrkCZYonkcKU6MKjEqeun8U++ylILpACs NaY1uLlknoLwYUch2IvaCsfol7LAlsyg897NfHS2nyVEsbz+8/8a8L0UClhsh1F2x52iinF9TYt LgbUTDpVIh5PaOTYr/+zGJROHH42NOXqX8gCnz5eeQvI2BrVwTgu2a7VDld5EI+BcXl6TCgfNi1 +KpC8Go4Mw5A2I= X-Received: by 2002:a17:903:2443:b0:2ae:5127:3d55 with SMTP id d9443c01a7336-2ae6ab18e06mr9614875ad.5.1772613957289; Wed, 04 Mar 2026 00:45:57 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3d1b2c5esm122010285ad.6.2026.03.04.00.45.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 00:45:57 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 1/6] staging: sm750fb: hw_sm750le_de_wait: return -ETIMEDOUT on timeout Date: Wed, 4 Mar 2026 14:15:40 +0530 Message-Id: <20260304084545.156170-2-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304084545.156170-1-officialsohamkute@gmail.com> References: <20260304084545.156170-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return -ETIMEDOUT instead of -1 when the DE engine poll loop times out. The callers check for non-zero return value and propagate the error code back to their callers. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/s= m750_hw.c index ce46f240cbaf..e4b6b254335e 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -518,7 +518,7 @@ int hw_sm750le_de_wait(void) return 0; } /* timeout error */ - return -1; + return -ETIMEDOUT; } =20 int hw_sm750_de_wait(void) @@ -536,7 +536,7 @@ int hw_sm750_de_wait(void) return 0; } /* timeout error */ - return -1; + return -ETIMEDOUT; } =20 int hw_sm750_pan_display(struct lynxfb_crtc *crtc, --=20 2.34.1 From nobody Wed Apr 15 13:17:35 2026 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50D2A3932C4 for ; Wed, 4 Mar 2026 08:46:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613967; cv=none; b=oa3Vv3DJmyPiQCRWpl6T3hv3kTijBOz7rDy/gPZmkCckvzVuzVHGKmGH3keWCsp2u9wYOZV8St/Y8x5yN3U5BhvZEnG6A1mcJ4B0/4lbiQZeE2CEOaGDj098VOxxKlVGo0AzRE2/bGWvCg8jqKYdjTe/QGj/CADSuWdA+dnkCCo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613967; c=relaxed/simple; bh=26HnA6jr8Gpj2ARL5WF/0FOSAJ8I03Q+Uhhb0MqsB6w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QVmOZbyWulgo2jMaaw/8/5m/4Aq+l6wF1qwQZQaae5Qcmfw0bQ/GiwGibyUy7Ig4UDnJi8gTAiQzKIvz4joJQPI+ZgEhvW0zrRa7cm4UxzX8qH9Ta/HpSdiQNkVycMD2oCiWYs/KKq5DkwUv67ueEcjMSMFL6iWsiunfvVX9U7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TxQKvVuq; arc=none smtp.client-ip=209.85.216.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TxQKvVuq" Received: by mail-pj1-f67.google.com with SMTP id 98e67ed59e1d1-3598d3ec542so238250a91.0 for ; Wed, 04 Mar 2026 00:46:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772613962; x=1773218762; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q74EyZl/rBv7dMbdQMZD34TxKD7igp3TSZElWe8rZoE=; b=TxQKvVuqq7zSLV5s8Ttzu1il9h3jCVq9caKlWO7oBzahGucKSuBZmU+C+jVAOzftG/ okPCRkOEgRg6+FK3gTLJfgO1SRH6GKWNt1KijXzjZDUk2MGEHpFP4Q64OTJhmqcW8V38 ZlqJaOxdcpbqPsN5RKc5Cj38axWTAO6ZzGiT0J/Ln8mbXjgSrZcPb32jPa9Ast5qIugV qh3iPmJ8tS+bR7PfwKZHjWmqMbAVTb+kryde0lrQhE8LchXIkAKqExro8EYBRXlaZecx nWhYr8dtD0atlj68264OHP+2b4AoLHYqwU3RiQb8BC7CMz4h9kQWkJ3mkFL+hFGDHYXy K++Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772613962; x=1773218762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=q74EyZl/rBv7dMbdQMZD34TxKD7igp3TSZElWe8rZoE=; b=bg7Zl8cC09b299pcpCX0gZTceRdW3Mj5Ide1MgMCrT0zBJ3teq8rmt/3xZL7IQ5460 /k9J3pG1dVqQEOXbqvMTFAlQyHUFz2Ce2JlfvQhd10x3EMRmmxNRAtUVz2Y/p91ksFjp QVPQHeWwuoI0gwFutWIdy45cHZlSyepjgz/wTGatqQeOnQzc06QTvbGqh0CP6LXaSqQN Za5Z/rDxGoLJihr/BG1bppeXL2MODqcU6NmmmrvbdBV0KSNzt1GEHn5GQenr9SlyuXCw XJ+lCmau+Ccnm8FFEwvCRmCvPxnF27Ml+6WfrpLCMXt0b5usL6whykrHG8w8ILqvIrA2 FNxQ== X-Forwarded-Encrypted: i=1; AJvYcCXS2j1yVQk6W3ff7yaDYM7mxHwBkC27xWytaTNRwHc+Y8xItmfvcJQc4mWS3i5EbuBXd6t778K6CiaIkz0=@vger.kernel.org X-Gm-Message-State: AOJu0YxxEA3myAn1oFin65E+AT90pWCauphxuS3Qj5UR2jZbpN8kw6m8 b0piq5BoHoAqxS0MVUjsvpfOZxa6dC5pJCNMOLy3VtvbBeR8F2ivj4VN X-Gm-Gg: ATEYQzxGUE47GoPJyr1y99BHmmqLNsBvFC9xC40upQlvdaFC0GvSBzVlBpCODxIcF5M 34bwpu+MgfM+689TAjhuMth2z1+foO0fxunvs7mB4NDI+5bY8CDVgmrClnKMGugF4JbXCrn21tC qsdPHSfWfKx3rMa4UXgx3uNqDRrEQ/6PIjXcCwiY/EmPs3DCRm2R+bzhkml9tvI/gvtzRSmo4NI 78ofYZB+npWwqw5awcJ/5z8/EFgsWIOiht0Genvmoj6xFyiWejztUALvwiHcOQ6PmrrTVsGeTRC PtpZWABLRLRiEw01bzjhUIaL/odGYEuh3LuVHZhrcEEihlWHz19yPq0VefPEqduUM0jAbbtKQCK BUBXuVyTC+L6cvlJS2qrnNK8HXSIhAh/D0YEtukLk7WgLQ24GSKXEFsfqOj2RiMUcpe3rFPjApY EH/k+5SmI0B8Bl0R56VAfbU9G8/QIBFuNcNG2rYiUqdb08m1gee1zdPC9QV1dOBtM4PiUgikHiS T6BiozysYXwN+w= X-Received: by 2002:a17:903:2f8c:b0:2ae:63b5:1785 with SMTP id d9443c01a7336-2ae6ab6c988mr9891635ad.8.1772613962439; Wed, 04 Mar 2026 00:46:02 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3d1b2c5esm122010285ad.6.2026.03.04.00.45.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 00:46:02 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 2/6] staging: sm750fb: sm750_hw_fillrect: propagate de_wait() error Date: Wed, 4 Mar 2026 14:15:41 +0530 Message-Id: <20260304084545.156170-3-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304084545.156170-1-officialsohamkute@gmail.com> References: <20260304084545.156170-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Propagate the error from accel->de_wait() instead of returning -1. The caller treats all non-zero return values as failure. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/sm750_accel.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750f= b/sm750_accel.c index 046b9282b24a..1bd0502db039 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -90,14 +90,12 @@ int sm750_hw_fillrect(struct lynx_accel *accel, u32 color, u32 rop) { u32 de_ctrl; + int ret; =20 - if (accel->de_wait() !=3D 0) { - /* - * int time wait and always busy,seems hardware - * got something error - */ + ret =3D accel->de_wait(); + if (ret) { pr_debug("De engine always busy\n"); - return -1; + return ret; } =20 write_dpr(accel, DE_WINDOW_DESTINATION_BASE, base); /* dpr40 */ --=20 2.34.1 From nobody Wed Apr 15 13:17:35 2026 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6572386C30 for ; Wed, 4 Mar 2026 08:46:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613969; cv=none; b=SCteSLEs1sw0GkLOdvSRznSpO8fOMUY1JDVLi6+Jdg/ZMxBmrzg9K4sqdfQz6iWhWNktltH3wq8sq4j3uy2yqevQLu5uGTy1NKJn2YGU0pl1kY4TzB9CcFNLfrCswHUP30FmIP3HhSJAScqSv2yAcPCXUEQqPNv6Ra7P/rByP40= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613969; c=relaxed/simple; bh=3F2Xe9MSsTeaAIiOzoWVA5GTBbp73iMfn/lprySLtwU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lPGJR8KiKWTPY108Icx7Da/F2sBPhcIiJ2XNOxnMmeEZHD5MjPHlk9pscyRHnCPgGUWHMzCekBVElqISX0SPy5o1Brw+DrTxWH8g/VNMuOlEOV6QT8+XLyh7ob7DRZG5CcecQmwb/mlAmaVgDD2ued6i+BbdguzpXCfxOUvSL7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CEEw+BF1; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CEEw+BF1" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-824acdfb73dso410573b3a.2 for ; Wed, 04 Mar 2026 00:46:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772613968; x=1773218768; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oYEhFSH2QiR/Cp+sFvQyOBwINQ7A/pZyDrDPlhVTTes=; b=CEEw+BF1Kp3Rwp1yWgV7nkxNxshSh/jY5M1BAEoFCImbBjd1yXN5FZkCEMe0Kj4Tjx ozqZHGVNy7mdzwTOJgAgZCII4Mw6UV/0qpYDiSZHtchV4EjftPupEwN37wks2XV+AqbQ YkLNeDooSk+uP8WkyhGDo9dz4ZHfTI8lX4/KDpa9+szy2ofqMFGo//spV/dG8pbnnb/B 8wbnMZC6dSBahdWVqTG4c715VrhPWqzT6W6xT5fVC8946lFRyiuD8QayeqdbKg0tZ+uD 1ESQsE67+qm7RQqRt+MgHqOVsUCm97fyZ17ihmIHn4S/I+pSdRu+/M3XFgsq6rGSakTi cDOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772613968; x=1773218768; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oYEhFSH2QiR/Cp+sFvQyOBwINQ7A/pZyDrDPlhVTTes=; b=LPW1BlN9X3WeWOakNQBxTyFHqIed1fitndQdDISgW31f/rUVugJLCHFhsn1fxe7nhr MogY+bZmAFXxGsgXuuIzhRqCRnbj55OB60RkE47ai0xHiXYxqPPnbG7minAzPlWbmz3g h69EFGX5kHJxjwUAtQCGb6lt3of6z9YK7R+q2bKwjoi2usKSFyVOTpKZyDHK3T+4WphX IW6M3SgOzbtTsjdJb5G3gDGznNwX9iEs2y5K2ytNt9UKk//PafnRZmecY0gABLRni3ri sp7u6rtHHjhSG61nIYO0RX2WZft9xlgQ/VlwedYVZeUAVFmxTcB4q5c3cynKChMVcq3n Wtlw== X-Forwarded-Encrypted: i=1; AJvYcCW01AIMUTFUQO6eTxy9b6+GWG2e1zeN1J/9xWoD7aC+Ekmh49PZYM0Xlw2DI+REB0Bi+XaAi5VOBwUBuqA=@vger.kernel.org X-Gm-Message-State: AOJu0YwefXFXJ7ncVy0DydGMJZPGViUCTDUEBOm65c+zZ+i6ZhVdvABM QnZ/kMLcfdaED+kBxIWOsxhfna/F7CloEHHwwgGDiUILcjPl7I/UlyX4 X-Gm-Gg: ATEYQzyzhgFYrSVoV+W0JXs+M5Ce5Yi25Mn2gmmodNG/pE9aDP8+CXW+l01J33Mk1oM 3wl3IF4lhSKA/AINPFDb7fTVaM5l/K5uW3FoyhvhIK/IL/BS/+QfO6NAKw3QCT4uNodo5GE3EF4 baOZNBGgRs/qmMoKDwWZe+rGWQ4no0PyrfVaRr/Tkli4pn2G0uOzBSlPdfep0jxlb2HdIv8+eb6 CLIely5mdZe2qKT3kybGO3vzGVoRxmW1n22P73EuEg3GCpziOCfbcZq4rXb9Nk2RJgKkILHHkze LJu593rBMSLS39UwFC5P9Mz5Jgy4jPlKgxVtqWLhbvAb4R4Jt5ijCxK4pmsM8RgYEsZD24XruMX dQT9n07wjstnt4uxnRGOSO+wjUnQrzZrrN80HGpgCKSP4aMnDjCTZaGbr5XGZs+7o/EV0TnLP2T EDd1Uzw62Qtl/AfJG9Nwict8tYcegHjtBW0s4J+WQHQNlejH9OeSUVEpI6G0QTzVyLHIUSBi+gL f9gAPllAiboF+U= X-Received: by 2002:a17:902:cf04:b0:2ae:3f3f:67c4 with SMTP id d9443c01a7336-2ae6a8c0867mr11344515ad.0.1772613968144; Wed, 04 Mar 2026 00:46:08 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3d1b2c5esm122010285ad.6.2026.03.04.00.46.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 00:46:07 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 3/6] staging: sm750fb: sm750_hw_copyarea: propagate de_wait() error Date: Wed, 4 Mar 2026 14:15:42 +0530 Message-Id: <20260304084545.156170-4-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304084545.156170-1-officialsohamkute@gmail.com> References: <20260304084545.156170-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Propagate the error from accel->de_wait() instead of returning -1. The caller treats all non-zero return values as failure. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/sm750_accel.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750f= b/sm750_accel.c index 1bd0502db039..f2fde011e7ca 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -152,6 +152,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int rop2) { unsigned int nDirection, de_ctrl; + int ret; =20 nDirection =3D LEFT_TO_RIGHT; /* Direction of ROP2 operation: 1 =3D Left to Right, (-1) =3D Right to Le= ft */ @@ -261,8 +262,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, DE_WINDOW_WIDTH_DST_MASK) | (sPitch / Bpp & DE_WINDOW_WIDTH_SRC_MASK)); /* dpr3c */ =20 - if (accel->de_wait() !=3D 0) - return -1; + ret =3D accel->de_wait(); + if (ret) + return ret; =20 write_dpr(accel, DE_SOURCE, ((sx << DE_SOURCE_X_K1_SHIFT) & DE_SOURCE_X_K1_MASK) | --=20 2.34.1 From nobody Wed Apr 15 13:17:35 2026 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D96E539478D for ; Wed, 4 Mar 2026 08:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613975; cv=none; b=bzIoeQFKy4eAIjkc2Puq/jL+h4FgllGf1WGaHwcm7r0+S4IxmvKFduBUMOlmgAZI5wD+rdESSJTroVUtVpWpYGSSjrahrYyqGJm26ynewXdaYaDIDvQv6JlrjrnB5VI3TL4KvTV8VU5gD/DCioxYTvRhP4njYyk06UrC3NcmssE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613975; c=relaxed/simple; bh=ch9Bjf3rYYQFZ3B+gWt24r/KcnGxHyK/TdO8+vbOhlU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZY2ChjbM+z5ePjpuaeGFoRFd8bj83MGIHzi8/WKQ/pVDi+kBB7xZA6iRWzu1MnWOlfF6AknVQnByyPRP+AjnR0bQCr9C40kcXJrtwCNWuGO1RjDXJPxgvkQZ+zUn6XRnKVKtuAqgb0uhch0P82G+lwAHhL1bUzcfMvmpHmwSEIM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dRsAwE/B; arc=none smtp.client-ip=209.85.215.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dRsAwE/B" Received: by mail-pg1-f196.google.com with SMTP id 41be03b00d2f7-c73770b3f15so116729a12.2 for ; Wed, 04 Mar 2026 00:46:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772613972; x=1773218772; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ntj2ZFCjKKBGx8d4Pk8uGSO7QWDo31vg+Q85kRhTYF4=; b=dRsAwE/Bu+CHc9Ff6N87USgYCEVQ/4pkRF16NWK+TojYpCQ+LBzuVF/sZbDV7No5Hl n6fmy/p8MxB9TymrbFJ/+jJnJTmAWnZ144556plJQJn1EyLTOzlbsdsDdlnqoL/qU6u8 2KqzgVjJkzqvC4UNa9YGGWf4qW3DK/jt3PciQ9ZWi2OqOdrRyi0S2bTNlTQ9IsUourJf tSCfnphAr3q/3IzG7Zzh3dgWGM0+eooCN8DmWyQWEmDB77xI+hkRtooGHoLTseY+60Tx 29SHWGFhjjS/V/ZmBTGD2V5L0Zr2t6ut06ZR77QY6SRu8V1wtvkgZcGKBGGk/ZJ+RnWB hAsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772613972; x=1773218772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ntj2ZFCjKKBGx8d4Pk8uGSO7QWDo31vg+Q85kRhTYF4=; b=XBK/ZTdY4Ip9qahLKghDFRQdUIKdCGMgpSXzd2+5M1xzXvLaPmMsBJauM5obhYc0w7 YiCTpMGksZmctI1smbsP8XBda3qqvgwaNbtTIUiRyWgEeDSunjyZtXxfjUwmqoj44vAV jyvhIONT3lGPjp6tTUSAryqPF8BFK/tg1fgU/Z0zClMrp9RaYOajkWERmQPpWvG/IBPv ZcwZqY2hwFblAxkyDobJXQ3E1SoVMt9zs9lI4TddS/lPBbv/86wjCtvQtWRfzOnJaSdN t6X4085/M9IN8CiLy89yTenX9lwaoLlxOe9V5O8Y6O/Pf7/Ct+1OOSFXnQq+4PlEmJAv hqVA== X-Forwarded-Encrypted: i=1; AJvYcCUczWDMs26k6dYouJnU50n9PIVVPlpK6kSH6jMWd9Vgqn6PiDilT1wv43clr5G8AaWHujbXhr9/i4eT5aM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2z8TRLPQp8ga12sa2+7XYcxLYf4/91S0GMbylXoAzstfrZ209 AeAKppoaGloNwbVbRTHagyCoyOZHT116cE3Jlotg1YjeTfbN2unL3rBe X-Gm-Gg: ATEYQzy9xwSF7NE42c8VLBSWEhwGTDUbZ8zTGpc0wTl/QP0KoAqNxCzUWsgqNMi88jZ nvRrqPWckHrSGomYTNN9vOTB9Q+7q0LPc6Y0jnrxw2uN5DZugpehL4r1m87c2QqM5UQsQlU7iOW 6x+uaAVVtXOCIzRrg0rvu1bbjimPOvw3Xgpv5a3LX8yF80xl7TnpeLDsTKahyHeEaTTT1p0x9BQ GWfUdzTgU1zkRbEGLof9x4LfeJUJH+PBkoAaF+hjadz2fLBxzH5YqoFlSn7Ty3QWjnz/Ocllm1O faXwO8CMigWEV48lcOBW7UNU7ZUIb5l0xu/RJjYwvhd6dvV/4V+ThtHR5NX6nc73XiFhSos2owD rWKd7RodKlltt8LNt2o4TG4X+0lNCxmNrrYCAcRScyACSghErGOcO0H5b4dmBpbSH1BtVje79ZR YdjDLkHR+nEca6FwvbzQ584DV2GZiWU6wrhrWx7a5CAaq3jB0Ga1/0+QUCyImH6blrxMU6PTdI0 MyjGb9wr6yujPc= X-Received: by 2002:a17:902:d50f:b0:2ae:59e0:5127 with SMTP id d9443c01a7336-2ae6ab51eeamr11142715ad.3.1772613972063; Wed, 04 Mar 2026 00:46:12 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3d1b2c5esm122010285ad.6.2026.03.04.00.46.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 00:46:11 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 4/6] staging: sm750fb: sm750_hw_imageblit: propagate de_wait() error Date: Wed, 4 Mar 2026 14:15:43 +0530 Message-Id: <20260304084545.156170-5-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304084545.156170-1-officialsohamkute@gmail.com> References: <20260304084545.156170-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Propagate the error from accel->de_wait() instead of returning -1. The caller treats all non-zero return values as failure. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/sm750_accel.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750f= b/sm750_accel.c index f2fde011e7ca..7d11810864ae 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -325,15 +325,16 @@ int sm750_hw_imageblit(struct lynx_accel *accel, cons= t char *pSrcbuf, unsigned int ulBytesRemain; unsigned int de_ctrl =3D 0; unsigned char ajRemain[4]; - int i, j; + int i, j, ret; =20 startBit &=3D 7; /* Just make sure the start bit is within legal range */ ulBytesPerScan =3D (width + startBit + 7) / 8; ul4BytesPerScan =3D ulBytesPerScan & ~3; ulBytesRemain =3D ulBytesPerScan & 3; =20 - if (accel->de_wait() !=3D 0) - return -1; + ret =3D accel->de_wait(); + if (ret) + return ret; =20 /* * 2D Source Base. --=20 2.34.1 From nobody Wed Apr 15 13:17:35 2026 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FFAE37EFEE for ; Wed, 4 Mar 2026 08:46:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613979; cv=none; b=VrXMGFyvncsWQX/7dZGRTj9mLFw16JrqRlSStHvnomwMXKrc2jQChU4Q8aiE1lUppr0l6iZDtjRwE/lISxDlB588iGPUx9kNltmYWwYWj/KLjtm4cKMjv/WzvowD4lQC1/RK3BhLTvnE904z53LB9uhwFR3lELcvUMdtg43pRg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613979; c=relaxed/simple; bh=YBpifJqm/54bZf8fKNduKAhexgzSPQz3kLt7ReTQDcU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=s6PaOR1wA0lwzGtVehm7tHDHWjhnKoR0/ogl0+9ETeduDgGiDeJLU5pK3H3sZ2DKv0M1sLN25mCrdz41BPsRB/5tInSgF6pu5lnRStixV9Ei7CvYuaX3abWWP/Xn6InGyJm5o+qlabf57e7rEBhE/6+qukEhQIVXarryWtMwNOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NjrYWGon; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NjrYWGon" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-824a8039d9fso461118b3a.0 for ; Wed, 04 Mar 2026 00:46:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772613977; x=1773218777; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GMIriR80Bv2/px5vVUBdIIwvGCQt0tK9lk6zU9lA43M=; b=NjrYWGonEefk6v3d3hoeJW6vyX9BN1D9lW+yptdkHHA3O0+D7Je3sRv0IKCpamr+xd 6Zdm4wxLj7NdPOYS7U1GECSaSYzUA8ljyoiuAXzpSlcVzv5zczUMt4kYSpj1wGyMqf24 528jVV2yAdGn4ijsLI2cKaUd6zBzI++MNCmgDLOUIKm8lhesEM1prVaHMYJ++Y3Inrvh mEIfRPmzpXxS+yZsTFCBaXu77i/4t5x85xuGRcSOSh8TqNw/vPxe5s8yuk0Fg2pDAvUw dew/aOTKGlA6D/HUeYlRPoxqIpz27xxGgF6UEgG9gzaMuvDy2HJ5IoZ10TjRejo4Cqfh y+Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772613977; x=1773218777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GMIriR80Bv2/px5vVUBdIIwvGCQt0tK9lk6zU9lA43M=; b=jPyyFl3te6sqVLsTqepGf1mrWq+CBSjA3ojpUGwcTtHDgQ7OzpyuUavvyBazamFZ/9 +Q6iOZQsSvH/gyIjJRcCxZ3qMzpgQ4FpR17iTB3HF1zYjRjlaZi2OlJp69JciTeU6EQi XCL2yX4FQezmELc1VkuM5C5UKCZzZTSWJ+RPBD8xV0VE76pCvsRlZ7AnDXh3PyqoBQIV HhMNuVD5ZoIuJuZatOrv0etKEnsIdakLSRslYxk5tX4L4mJJ32xMhL55f0WhoUmIjfCa PzuO68DX2OAFdhghioQJVonBuiqav94QYziv7RW3Q/jDEJA57DpqQXqNgFHZeqCkuB7+ ecFQ== X-Forwarded-Encrypted: i=1; AJvYcCUty83ijepTWzScJXkGhSKrOV+7SfWUMm0n0SoxYQO07zbkitqpERPTQGQlCdWOtKT598yKdfMefiGl6Po=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2g7WmIe5ASpOI61FafnUpyWPMFEV8/HOXRLDVnvt3ZLPcXfH2 wb/mZGwLsVbC9xpoqeFBdcNjzG+/lyVcUrjxQCE05YnHAkHCTgjEBGJR X-Gm-Gg: ATEYQzw95JeTXmUSyxZlDImLAv6eHf7rYuhKlvo03q3t17ylVQ9Tl9Wiy/bu2w4Pj4E RXlCK3ZakrS6ztBS3XsWuQAjoj6pB7dils1KKhYq7n5FEWsKxgBPoR/x0Khj1IdBELC4TVQ7TOX jC+DqsU50+JHqosjXpe1OFb7BBQf7GAOquTjqFS+9GV7x5CTc+XG5t5hU8rtexZuO2F0IiWHKpY 2SJVG5G8cnAn1OnUkqMyPI92WJzJLl3oGN5dv19p5njsZFrLx2y76gLU9gzuKvJeoNxZSfl8NFz 2KGE2VUJddpHYPAu9wjOcnqOw8FLhKrLs8NzVp5x2EXqXJd0Ugkg9gMFEdEHyBO4egRnfMURpK3 FoxSim3qSl7GF+Jjlg36aCSFDh9K43UWaB5GvOFv2L5OGxm+F6MG0+srYQTMvEBu9J1e9s/ZDz9 Kdpota/IBUkJM1DVbFb/LLFpu9IA5ZIZQtarFa/O6CxHy8FV11L9t9Vs0UtFQJtWGLSHj9PzIM4 4Cxwuc6ghjM1a0= X-Received: by 2002:a17:902:e851:b0:2ae:5038:6998 with SMTP id d9443c01a7336-2ae6ab75e62mr10505315ad.8.1772613976792; Wed, 04 Mar 2026 00:46:16 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3d1b2c5esm122010285ad.6.2026.03.04.00.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 00:46:16 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 5/6] staging: sm750fb: sw_i2c_write_byte: return -ETIMEDOUT on timeout Date: Wed, 4 Mar 2026 14:15:44 +0530 Message-Id: <20260304084545.156170-6-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304084545.156170-1-officialsohamkute@gmail.com> References: <20260304084545.156170-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return -ETIMEDOUT instead of -1 when the I2C byte write times out. The callers check for non-zero return value and treat it as failure. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/ddk750_swi2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750= fb/ddk750_swi2c.c index 0ef8d4ff2ef9..a17f758dda6c 100644 --- a/drivers/staging/sm750fb/ddk750_swi2c.c +++ b/drivers/staging/sm750fb/ddk750_swi2c.c @@ -294,7 +294,7 @@ static long sw_i2c_write_byte(unsigned char data) if (i < 0xff) return 0; else - return -1; + return -ETIMEDOUT; } =20 /* --=20 2.34.1 From nobody Wed Apr 15 13:17:35 2026 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5ABD388399 for ; Wed, 4 Mar 2026 08:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613982; cv=none; b=QULHRHL/XZ0DANg3mqxffLK9ujprgIJx5bIuWBkz748zwvPFh2sqHW6bbeaUVOxBvg9UAqzsoxyLWBgN44h1wtYhweLwOZY3+S1vx89+dX8FF8jey/9toqmlDsdMosQeBz3aZJBTHXVZiQHDc7+cmGwpS/YPH65f54G3R6MS3Gc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772613982; c=relaxed/simple; bh=NjIHanfcZCN7Q8bPlLToej7iNBvOlqyNwUhyWxKm2yQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FVNfoMLuNbrSf1oS7/WjzyPRkKczgWycKRHPsIrJ8K3tp42G73urM9MvHjonhLX+aZmdnn06zkRkpeBYBdMq+XFZGuZTaMZNawR0G+KEf8z5u6WYKn8JtgQUpLy3PXQd2ON5cLlzN0hBtcN24/h3C4RBaz45RVPEamtjAkEy4uc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GD+X9K0I; arc=none smtp.client-ip=209.85.215.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GD+X9K0I" Received: by mail-pg1-f193.google.com with SMTP id 41be03b00d2f7-c7382963b67so25687a12.0 for ; Wed, 04 Mar 2026 00:46:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772613981; x=1773218781; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q4Tsr0TiaAL9EgCXS3kDx+w3w2NKKVy8Enr91haZmsQ=; b=GD+X9K0I6Sv8qPDaWsAwEtRUJQx3PtLe0zojOAcXxC/EBcJR6gWO6pGKt2q7p+pRVc ViFtBPkkRypkiRy0LEb77kvjt36tZ6TWFAM3GA9Hwgg8znj/kuZOGIRVn0FzXqmakbEK P2pFxysOHTZ6sbh+YXCfaGCBTyRWse5gXzYLyT1od8R499zU/IBUgiuUir+XhpMG63Kw GcfSCawUPiMMLUQ9H8uRfIyg+cc8lpU9vdBi8E8cfcP6QY5yq0Dhi1/QKm4kfgmAfinO t7zlQph5KmXDp87AYG/SmesI5rjmb0wqX3qtQBobhaD9c9ZeNkx8ClJcmXpvEm+/sgPu txpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772613981; x=1773218781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Q4Tsr0TiaAL9EgCXS3kDx+w3w2NKKVy8Enr91haZmsQ=; b=Pmri8HthU5QWpxR98sQDA0w1FtFUFQ9foQHS5K9MdQq9iclAiMIJq4DMSfrTEuDGsf DVShE0KsLP5WfAA2cdf0FC57hQ+s55zXKBeIq2T8D2X8awopOkC0Zj3ohTMmgyakcQk6 Zf5D96J0geVhJ/KPP6h8Z0rYCmp4elF/Codt/Yy0hxb097XjGkWClk3ChULqBKKwLDI5 mGXM24+OssDGLpgpWgr7kTpXOD5htEc8i4LMcNoqK1HveE2eZKpCQTymA8WyEU9M3UY9 +DaXbcXYO+PxAOKNLOPvrVPjREQtgmv4fdyxas+AuPv0BE+eg6IlfIvF5/A0jg7keaHq QEjA== X-Forwarded-Encrypted: i=1; AJvYcCUn1x3pwQHjAdwiAlt6QuR9zCOT8HSfyGksrUc4QE6yUjVxSL3YlkGj1i+g4+/OtuVTVwXPu171ZYJeETI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7ER6Ww7HSUHd6ptn4dGpCFn8o0ESOHBx7fH9wfXmuPqAUD2tj tskE5x2H6hWxp7TGslP4KDZAGoiXO5DDyymm8uKcgWleZ3eWE1W1s4l3 X-Gm-Gg: ATEYQzytkJDl0gC3+A3EuI3VvEflwO1igNcgyDccMQr1LiVBsm2aPFI/ePaPzu2VCsG +Fu2p+ZWoz9tNYmXo+nD0lprpz+6pXKA2JufFAJ3Jgo5bFwpoRtqMmcUhuhfyhFhPB5n7b0GEn4 /4N3RJWa1Q2yKHtQRFliJQdHvCuZj4pwVP0NyvFVdyrC5Hnpp5hh9Qb6TkbPFj3llNdQv4P/Qyi P0YX8ICFcDgehLALZ6kyRjzlm/LRhVWEZZU4m4YSps/9G0/jqwnwSTupW7FvqKQ+J/2KxF1V3vO mHpnwGjo32FONPYppsmqy8S1jjxIpeneu7jhLunLQV3BDqlgLLJiM+4F3vQUCJsAephD9m6TXup jlQVyn351ocDSsnsQ76ijLpyanMunbxLT48lHiY6g43mawkTcwpItyUsY0+akwmDuJ5GmUrS/NE Kr38Ryhbeyt/bBwUCvbSLYbv1AzASWfvmVRMb6NgNSsrCHWGmdcYVJeuUjSvLD+TN89BGd7hNGz 5ksFJ6+KlaVRsk= X-Received: by 2002:a17:903:2c50:b0:2a9:5b48:2b1f with SMTP id d9443c01a7336-2ae6a89797fmr10736535ad.0.1772613981282; Wed, 04 Mar 2026 00:46:21 -0800 (PST) Received: from cute.. ([2405:201:31:d01f:950d:ab7d:5e5c:5244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3d1b2c5esm122010285ad.6.2026.03.04.00.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 00:46:21 -0800 (PST) From: Soham Kute To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dan.carpenter@linaro.org, Soham Kute Subject: [PATCH 6/6] staging: sm750fb: sm750_sw_i2c_init: return -EINVAL for invalid GPIO Date: Wed, 4 Mar 2026 14:15:45 +0530 Message-Id: <20260304084545.156170-7-officialsohamkute@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260304084545.156170-1-officialsohamkute@gmail.com> References: <20260304084545.156170-1-officialsohamkute@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return -EINVAL instead of -1 when the GPIO pin number is out of range. The caller checks for non-zero return value as failure. Signed-off-by: Soham Kute --- drivers/staging/sm750fb/ddk750_swi2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750= fb/ddk750_swi2c.c index a17f758dda6c..d90a93ab8fdc 100644 --- a/drivers/staging/sm750fb/ddk750_swi2c.c +++ b/drivers/staging/sm750fb/ddk750_swi2c.c @@ -394,7 +394,7 @@ long sm750_sw_i2c_init(unsigned char clk_gpio, unsigned= char data_gpio) * range is only from [0..63] */ if ((clk_gpio > 31) || (data_gpio > 31)) - return -1; + return -EINVAL; =20 if (sm750_get_chip_type() =3D=3D SM750LE) return sm750le_i2c_init(clk_gpio, data_gpio); --=20 2.34.1