From nobody Wed Apr 15 17:51:43 2026 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFAAC34B1BE for ; Wed, 4 Mar 2026 07:36:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772609775; cv=none; b=W09PC6/nAJUEApvBxfTLS890Dvcy4zJUDzQHpcg/iqz1ZF5Kh72vz7SGqhZ8NCVD2436MO0Hgw4VY548Hn1FaMzDo5k344FsPaihHcGABKbuo+w9lqekUcTDwulZODAQpbwkNb74ceX/w5Ho9AZkVPN2VQqgDfksD7ZZrJRuG9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772609775; c=relaxed/simple; bh=GUi9iRwTf4ZFEs3U2Iil4IHwEQGUGzOmPWn7Txv8Qyk=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=ivxTb7c9VsL+cbr+y8Ld2CZH5kIsH2an8I/a/qwltgFdc8PU3tzOSWMoVRQuXxFMF7WW2iMOAoPerebQBVlevYYbcaxygOQ83Xp9/wFvJaztMRrStwrG8pt1XCpHTw8xdcLQd4BgQ+h/s3qcTWv/AF8GnLXirWoeZEYXDOwuPec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=s1nqVhDh; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="s1nqVhDh" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-3598733bec0so18396372a91.2 for ; Tue, 03 Mar 2026 23:36:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772609774; x=1773214574; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=yrFMT0TXW/spEw/ZubXnVYULM8dGErCPWbCJGWKhVQg=; b=s1nqVhDhEZGHYE9uxo3L4+YY1BQ7WvadfBKyEQSoqLnNt3hG1CU4g0Rw5VsEfiVrRz lhvRfoalyz6jmvPzZr2XiyIaYG6Xk0qTiI1NV6HTeBhRlQkZAyL7VNciutb+EgsqxO0f A0d0Yq4BViSzynqyUxg/dMYNuqRcXjelTBUUT3foP9HUP/OvrrDjH7z8RzTwKeBlZAgt NLNvekD1ezxj/kCC6KfKK16rSntZxbFzeeXVnh8sTL63by74jIRVCKzzm3kIY7Yvrs4d 6CCRtjDyqMRTn//AWMUCng6X9Gh7/HwUxcgcTZBaY11oWvEBVX4kghJWKhsy5mjwsBRI APnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772609774; x=1773214574; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yrFMT0TXW/spEw/ZubXnVYULM8dGErCPWbCJGWKhVQg=; b=ZAfxL2+Khv3JFZ7OrwVeA45I2eImc9Ec3Zf4CXtJXy/9w3CytSbmFrMRXNdzNO4SPn ZjK9piLGSOTOw+39d3epGcTn6o6F80RekdzVRfBUrez/vpk3gHoTCLxi9HMxuWm802TR BeuelONyLILvnGWgv3dzQeQxtl/8wosJyDz95qcUiCtCrrYBZJsCgQYKKLg5qNBDAN0V cPdopxMvfnJv/TPZ43isvzqugvRCTF3L5BvL7kjN+XXU2O0zF0NCIdfg/FnYMeblxbyH aDzeHRmwY16OAKpkQSCefYaZurhJbTvLywsXigw8GJCheP9w9L/Fe87J21kGXHyrT9s3 VTgw== X-Gm-Message-State: AOJu0Yy8e5RKedzrrMFxsvveJZsf11mbRKOyMkPUdxzEYzqNKJdaoMtp QhVervLdSnSwYm9lIecaxc8Qx0MEkZ3xmFiChH5kPHvdJGt6sWPaYEGm7yFzfZS7l1mdhgvQi4K 3zuD7oZasvcdwsFRE04rpsK5Cew== X-Received: from pga18.prod.google.com ([2002:a05:6a02:4f92:b0:bd9:a349:94c0]) (user=joonwonkang job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:4c13:b0:366:14ac:e1df with SMTP id adf61e73a8af0-3982e21120emr1272175637.69.1772609773929; Tue, 03 Mar 2026 23:36:13 -0800 (PST) Date: Wed, 4 Mar 2026 07:36:09 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog Message-ID: <20260304073609.3228532-1-joonwonkang@google.com> Subject: [PATCH 5.10] mailbox: Prevent out-of-bounds access in of_mbox_index_xlate() From: Joonwon Kang To: stable@vger.kernel.org, jassisinghbrar@gmail.com Cc: linux-kernel@vger.kernel.org, sashal@kernel.org, Joonwon Kang Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" [ Upstream commit fcd7f96c783626c07ee3ed75fa3739a8a2052310 ] Although it is guided that `#mbox-cells` must be at least 1, there are many instances of `#mbox-cells =3D <0>;` in the device tree. If that is the case and the corresponding mailbox controller does not provide `fw_xlate` and of_xlate` function pointers, `of_mbox_index_xlate()` will be used by default and out-of-bounds accesses could occur due to lack of bounds check in that function. Cc: stable@vger.kernel.org Signed-off-by: Joonwon Kang Signed-off-by: Jassi Brar [ changed sp->nargs to sp->args_count in the code and fw_mbox_index_xlate() to of_mbox_index_xlate() in the commit message. ] Signed-off-by: Joonwon Kang --- drivers/mailbox/mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index d3d26a2c9895..66cdadbd3d75 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -498,12 +498,10 @@ static struct mbox_chan * of_mbox_index_xlate(struct mbox_controller *mbox, const struct of_phandle_args *sp) { - int ind =3D sp->args[0]; - - if (ind >=3D mbox->num_chans) + if (sp->args_count < 1 || sp->args[0] >=3D mbox->num_chans) return ERR_PTR(-EINVAL); =20 - return &mbox->chans[ind]; + return &mbox->chans[sp->args[0]]; } =20 /** --=20 2.53.0.473.g4a7958ca14-goog