From nobody Fri Apr 17 10:44:44 2026 Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11F4236D501 for ; Wed, 4 Mar 2026 07:35:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772609746; cv=none; b=ob0nijuy+LOuJl/RuFVGLM8ON/0njuomZpGIwKB23hULyT3GN9HpjmbkGJBVk1IZzcD6dUGsg/a0ZTi2ASt8ljmt5bRwjBBjAnU7Gri9GIRQl+aBgbvNeiq2cNmn8E+TNUcQqPhrxqx2/QtSYMiJKNIfwe/Atvdt4+IK2mm1EHs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772609746; c=relaxed/simple; bh=GUi9iRwTf4ZFEs3U2Iil4IHwEQGUGzOmPWn7Txv8Qyk=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=tFAXqTbxy2sEv5esofmS/cFltxNZluJ8i/lpcNJ7BJIPFqjWmaNWczqjit1jX05YBXyaAPEVc9gbLR/z6MZPPCmsnYyUSd0+9jx/1AMxA/cuoEqu7+kmN7i3FxSVO87k2aLDIfmBAKyw4K++I6qciBdvLffkVG0NVTmSGFWa5Yc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=EaSNec+7; arc=none smtp.client-ip=209.85.215.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EaSNec+7" Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-c6e1d32a128so3983796a12.3 for ; Tue, 03 Mar 2026 23:35:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772609744; x=1773214544; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=yrFMT0TXW/spEw/ZubXnVYULM8dGErCPWbCJGWKhVQg=; b=EaSNec+7E5RtJh2mEhqE+BlpT9Szd1Q7GnxcYsc2ROflWyx1KnmNTC2/nYV8SUlgXy 8iErm1y0X99O5o6DG7JUaBoycFImdYJhYxwrTJKCDyDHJeF8hCQmek7t2aSa/5pC/CtS SLZ5fVfQoxfSe7sOdeqAa8jhqT+HvQOlpeDsuYEiyQ9ZYnAvcnf+0GwFYZahtpJw494x dZamhcTP0UpVltveH5xsaqVlNpj/Z8xDjN0M3lO61xyNTdysMJZyXybenq/rlwbTq4I8 2RcH/cuD+DBfLkk78KBNi9DbP8XTGmgy6wdTj+Zz4gfWvW7Z6hV0v5B+Kl89f6SqkGtr UjRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772609744; x=1773214544; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yrFMT0TXW/spEw/ZubXnVYULM8dGErCPWbCJGWKhVQg=; b=kUapR6i6kY9PrUIYJyNMEBOZ3cxm5SKci9rFjijFiJidwXr0S273uBPnh6p8+sxcf5 zQrbJ47vuFvOkDfpXJ9mBXuZDor8ax1ZFZH5y/vjwoFX3upige11S5X+hQVbcUtzKTEe H1knrfCf9IyAQpeKlZT437SVyYBBneCJGxbjW9wAPhzabWWfZSlRHhIizcwp6tcvB6JD 0gC4V8tkz1vcyLPWvhnotkLtubURBxi3w/02GNTaOid8pxsvjziONbEuEzbDyDU8QCaw kToo1mgSfivfD/Sa5UNQ/5ebsOsV4vC7Az2QRxfqoXtinE83sR4G8woyMdNLuVEp4Id3 Sb8w== X-Gm-Message-State: AOJu0YwgR1xhBMivJuzXDxtqIcKDXerUVLz83Ar8t7IDSn5zyeQ1E60t tR+s6h+L67F1fCEeX83PRmq62OpgLHm14BPuMnlM3O91A37s1xeSfN3Rd0XVdBGpHN+KirEpfy+ U1qdZqdWk27Mce4SgO97CjzwTqw== X-Received: from pfbdf5.prod.google.com ([2002:a05:6a00:4705:b0:823:1513:f42d]) (user=joonwonkang job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4f8b:b0:823:1c2f:e9d5 with SMTP id d2e1a72fcca58-82972bcc3eemr1222981b3a.26.1772609744179; Tue, 03 Mar 2026 23:35:44 -0800 (PST) Date: Wed, 4 Mar 2026 07:35:40 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog Message-ID: <20260304073540.3227944-1-joonwonkang@google.com> Subject: [PATCH 5.15] mailbox: Prevent out-of-bounds access in of_mbox_index_xlate() From: Joonwon Kang To: stable@vger.kernel.org, jassisinghbrar@gmail.com Cc: linux-kernel@vger.kernel.org, sashal@kernel.org, Joonwon Kang Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" [ Upstream commit fcd7f96c783626c07ee3ed75fa3739a8a2052310 ] Although it is guided that `#mbox-cells` must be at least 1, there are many instances of `#mbox-cells =3D <0>;` in the device tree. If that is the case and the corresponding mailbox controller does not provide `fw_xlate` and of_xlate` function pointers, `of_mbox_index_xlate()` will be used by default and out-of-bounds accesses could occur due to lack of bounds check in that function. Cc: stable@vger.kernel.org Signed-off-by: Joonwon Kang Signed-off-by: Jassi Brar [ changed sp->nargs to sp->args_count in the code and fw_mbox_index_xlate() to of_mbox_index_xlate() in the commit message. ] Signed-off-by: Joonwon Kang --- drivers/mailbox/mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index d3d26a2c9895..66cdadbd3d75 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -498,12 +498,10 @@ static struct mbox_chan * of_mbox_index_xlate(struct mbox_controller *mbox, const struct of_phandle_args *sp) { - int ind =3D sp->args[0]; - - if (ind >=3D mbox->num_chans) + if (sp->args_count < 1 || sp->args[0] >=3D mbox->num_chans) return ERR_PTR(-EINVAL); =20 - return &mbox->chans[ind]; + return &mbox->chans[sp->args[0]]; } =20 /** --=20 2.53.0.473.g4a7958ca14-goog