From nobody Wed Apr 15 12:56:21 2026 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CF5C36AB47 for ; Wed, 4 Mar 2026 07:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772609648; cv=none; b=LSkZxhcEeEkPPM2TPde5hXBXY0Q6LFTASF4xG5CEwjiBAjSTnp6c/RqKZuo/+EKh9NX22NRqb01RAB3nk41H46PspeXKZmhO/GLVZzHeh83UYhiq43ceizG06skyIJ/pZBZ2cjlKgPwSIHq+KKgPMLXf7W5jdE81eMM26vtFp4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772609648; c=relaxed/simple; bh=GUi9iRwTf4ZFEs3U2Iil4IHwEQGUGzOmPWn7Txv8Qyk=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=HsSF1nCemc/QxMT3J78+d3DzEJx5kd1DPT9D6NuARSAku+dkmGgUK1Tm2eRErVAOZl1096iIiAuBz6fuzpKssZuyk5xskNYLba5ImBv7qI/HDLkOo/wWv00XVUsga/1qyD5jrV3vSxtPKLNF3LT5Uc8DFDBJFBvc3/+3Xk7of3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dd9Lj9xb; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dd9Lj9xb" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-3594620fe97so32154022a91.1 for ; Tue, 03 Mar 2026 23:34:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772609645; x=1773214445; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=yrFMT0TXW/spEw/ZubXnVYULM8dGErCPWbCJGWKhVQg=; b=dd9Lj9xbciCTfRV+n5hZPybizGEAXFTcZ2nOOqekyibcxd3f10n+y2NG0x7UpPp47j Z5MppcQDMPk2WyN0gnWv0GXjQwcz18vYPkq7poMNHPqOYLrWf6Hhx33rWOCvxu/JQLJb 1fmwmaWh3xHSfMR1LEzB4Rg/5uYLO8/S5QSVoEWjJapqo0x4nw+7YsiR+qS/a6XAoRmN 39RSsSL8TSyLm5Xgs7/cmm4ByiFer0RhvS+IirC4hEEVEWWEV9DeOqaZF2HpPSgLZsGC SsFiE1wwYw1vcf85YkEq2+txxpDTwwNF3kwcxK0zNGP8/uFh6Ty+Oxp6CkvWV0B5JERb TDOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772609645; x=1773214445; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yrFMT0TXW/spEw/ZubXnVYULM8dGErCPWbCJGWKhVQg=; b=eXv+w1KVtNhLOmVcbGqx+tTlNqq0O8MFysRXrc2rWqQPzEK60pC5UHBGsrX5daVutV KKBcbp+45PSz/qFutdY0SYaeafLZhwhKbK+jAXXCm76vqcWudK8VZGpY9sV/HxetAUBT EXGgP+CEqZi2+YXa3YWJgnugFOxsVr1YIZWp0z0dna8CltUvmNXUXxaIpCb2kiXxuk27 Ac3Pm0cC/fvrxReSGHzgKS6i03frN9MxnA2TEKPKolnTD6pyR2Ae7uuc3nQMaPZ++Rh0 Sdrr9JaOf17x9UN6dWR75yAN+ii6WMF6GlY7gIqHG4PHmIkAyAbaf8U/qA1cxxt/OhNl G42Q== X-Gm-Message-State: AOJu0Yx09iyOxaiclyasJ7gJ+B4048wZn4sPc/z0tdnbFp3j1jsHtUYs WqIscKpq9SnN+KQrO+UHOZlke/x+swv8CSzptbBQ6nVWw0PpBpThdHQV4UbD2A6ZIIXjveyYYzo mKrznlBgz/or2HMtu0VzxZkLFsQ== X-Received: from pgvc14.prod.google.com ([2002:a65:618e:0:b0:c73:7fff:ccbc]) (user=joonwonkang job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:a124:b0:366:5d1a:c737 with SMTP id adf61e73a8af0-3982deccfb6mr1136843637.16.1772609645297; Tue, 03 Mar 2026 23:34:05 -0800 (PST) Date: Wed, 4 Mar 2026 07:33:59 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.53.0.473.g4a7958ca14-goog Message-ID: <20260304073359.3226109-1-joonwonkang@google.com> Subject: [PATCH 6.12] mailbox: Prevent out-of-bounds access in of_mbox_index_xlate() From: Joonwon Kang To: stable@vger.kernel.org, jassisinghbrar@gmail.com Cc: linux-kernel@vger.kernel.org, sashal@kernel.org, Joonwon Kang Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" [ Upstream commit fcd7f96c783626c07ee3ed75fa3739a8a2052310 ] Although it is guided that `#mbox-cells` must be at least 1, there are many instances of `#mbox-cells =3D <0>;` in the device tree. If that is the case and the corresponding mailbox controller does not provide `fw_xlate` and of_xlate` function pointers, `of_mbox_index_xlate()` will be used by default and out-of-bounds accesses could occur due to lack of bounds check in that function. Cc: stable@vger.kernel.org Signed-off-by: Joonwon Kang Signed-off-by: Jassi Brar [ changed sp->nargs to sp->args_count in the code and fw_mbox_index_xlate() to of_mbox_index_xlate() in the commit message. ] Signed-off-by: Joonwon Kang --- drivers/mailbox/mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index d3d26a2c9895..66cdadbd3d75 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c @@ -498,12 +498,10 @@ static struct mbox_chan * of_mbox_index_xlate(struct mbox_controller *mbox, const struct of_phandle_args *sp) { - int ind =3D sp->args[0]; - - if (ind >=3D mbox->num_chans) + if (sp->args_count < 1 || sp->args[0] >=3D mbox->num_chans) return ERR_PTR(-EINVAL); =20 - return &mbox->chans[ind]; + return &mbox->chans[sp->args[0]]; } =20 /** --=20 2.53.0.473.g4a7958ca14-goog