From nobody Fri Apr 17 12:52:00 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABECA3101A0 for ; Wed, 4 Mar 2026 06:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772606965; cv=none; b=QpyCXO8Ua1X7DTfMRQE9eVeMrgbeqBJhqr9EiW1H0/o2KypqvoX4Hch1FiLfTGe2zvKrKTcH0LjlmN/iRe4GPaFmmJXSNDlosgKZCJ/RwHeuwYSDxAwfqkF8rVostVimKIJQdjp3QDsTlR9R7fF2WQfpGXGyBXkdirW5OZMFfvQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772606965; c=relaxed/simple; bh=Cxr/PMSO6d3bL/WkDFCeUdTM8tyJIHNVjYWfwPDDpgY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dAptJGJ2HbNf5XTFjYVZvLB9EXhdquCRSwmhKPt8oRBiuvR2OX7dzxgIBPS2rlHvP7Mc8B6g4nL7L5kQavPMRBAiRJn02ObU7rYbuNBbmhMGmSDPCwS08klX9Y8+92j0QxCe3HBiIyuWiDCdBFhAbxmc5UIxGmOlXv8UT/HCDxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eIB0uhyd; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eIB0uhyd" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2a871daa98fso49545895ad.1 for ; Tue, 03 Mar 2026 22:49:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772606964; x=1773211764; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QOdPWjybRYp/bon5UOZwZfLAsanM1s0IJ7xyUwzxd4o=; b=eIB0uhydP7wD2DySTrRYgCZFaezmWrOXDVIF0wrvFO1gCB2e9oYfI+FIIRLj4aYgst FJc2lEfReotZDVJlANZLtiGyFsqyt676DITOoR456dZzjyLbl9C+NurGSQC59sUKhKGX 3Xn+1ruBix6Sf3DWsKMTB1a1tgd/MOBfUexoQsmUSAWDx3vNQ5XkD3zPbJSa/VkZ84XG K3drDEIk7PJX2NWucXU4CVXdpMLz0zreDOUTq9lobvM3solH+29B04xmXGJ+ROvD3R+5 QNK4kMUQdnNrL99fuFHMK9YZyHYkgau3xHeSW9+PByDG1FMoXOFjaaSn+NxQv4aCcw8y J5sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772606964; x=1773211764; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QOdPWjybRYp/bon5UOZwZfLAsanM1s0IJ7xyUwzxd4o=; b=AlsHsYfKfhBZbEk9UaCjLQGssfaSQmNfndundnp0E/MLnXGc3vYpqtbHNchVFMG7Sx YNqJEMqzgHFPj5QERIRm2vhDhWLkmzgSl/5gjvURkkNvmkFKIJK5qvE0AXefOcatADn4 BVJ+p3+IIODpYx9bI8uDR6hJ/NtELwfaAF68ah+ab8xVuifi7vk5FtBoIHRHB7rTO1Zm xbbp1yrlu2rIqJKJdTeiYO9WoNskrjZkT1uAIhuQLZwN8DNjRhJE9Y37uQQV61bRxMDp qvO1HzO53qV25UinwJgUytL2yxOPl/OCyYycZsg37h1CkJ29hpAgRb28ztDE6VO/8SlM dJxA== X-Forwarded-Encrypted: i=1; AJvYcCVDov8FcJgppGtkIEycWtUfPO9bHZ/zPtqG2+FO3PILr5GmfL5z4wRXMp1fZUTd0A6stx0vYmfC2fJ/0us=@vger.kernel.org X-Gm-Message-State: AOJu0YzweBzwkgoXUuI8uUt/gpaTTwJZr95MJJkA67n0jtJRDHh9/07h LMPNR3DCu1O3mwOT8rOi5e2mBZxURPhSQeLIzCXlNFIMFYLi5/fShHrp X-Gm-Gg: ATEYQzx1H5AXIyK3QSVdnJ2yjmSSAPh6Jk92VSLHJ4n85jdHJtSx7ltZxvNi+oHpSqt qqDUEw41pMvdsqcVASFTxpTToW7Yhg5ay7uAJOWFQ8ZJQ+3QyJwwevmqTS6poezsc2fzSTYZvzU rDxp0pD8kTNzf7kcvf6jINTUlT36kTJeOsqmBtMu2WLRF6rwK7L7O2TBUdnKH0a6xFUR8uuDBlZ hZPYQPro8EcIfwd8Ak87EWcwzLYrCjH/dD28dOer/p5Zn+ALvPXZQVxB1upHoj2Rl29GQT720ZW A+AboVu+43c4cBfkeA9d79aAh9bWNpnr+HGNXhQU/2Ca9Gc5z3SyQoN5xoy+bpeZOYh6jA4J0S1 KG4Tkgq9r6i8HXzRWe4KMcey7tTVSud40ibJxlMRcFgquBb/TnLLRfch5TdLI8xuUsH9EKdaBw4 4JJJtX+ZoKFwcC9qO7gn3CjdwEs+jeGuPkm86KlFSiCCKPIdTLzfZB8tAiCJP1XnLUzK+0QtmIq k4hLUho0Rke1kc1 X-Received: by 2002:a17:902:f541:b0:2ae:3a1e:3490 with SMTP id d9443c01a7336-2ae6ab10e95mr13158015ad.38.1772606963968; Tue, 03 Mar 2026 22:49:23 -0800 (PST) Received: from tower (c-73-37-64-97.hsd1.or.comcast.net. [73.37.64.97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2adfb5c0f2fsm265327635ad.20.2026.03.03.22.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 22:49:23 -0800 (PST) From: Mark Adamenko To: linux-usb@vger.kernel.org Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Mark Adamenko Subject: [PATCH v2] usb: core: remove unnecessary goto in usb_create_newid_files() Date: Tue, 3 Mar 2026 22:46:46 -0800 Message-ID: <20260304064646.6612-1-marusik.adamenko@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The goto to 'exit' only returns the already initialized variable 'error', which would be 0. At that point it could not yet be anything else. Replacing with an early return 0 removes the need for the label entirely. Signed-off-by: Mark Adamenko --- drivers/usb/core/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index 2574e65bc640..752ff84a8dc1 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -186,7 +186,7 @@ static int usb_create_newid_files(struct usb_driver *us= b_drv) int error =3D 0; =20 if (usb_drv->no_dynamic_id) - goto exit; + return 0; =20 if (usb_drv->probe !=3D NULL) { error =3D driver_create_file(&usb_drv->driver, @@ -199,7 +199,7 @@ static int usb_create_newid_files(struct usb_driver *us= b_drv) &driver_attr_new_id); } } -exit: + return error; } =20 --=20 2.53.0