From nobody Wed Apr 15 16:30:05 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 578BE37FF66 for ; Wed, 4 Mar 2026 06:26:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772605609; cv=none; b=q4JuiwdMhWuYIix4o/fVY9Cdp3X7R9dFH/7W2KXPEvwB9vWWw1JrvkN5nQSzXQMtvFEkwMuExm+PhoINh0AVmpu9aM3gnTZz56UvmLGuPWUvLNBr5oWIwygLqU/tCpU8QBJkSp1e5ZmBo9Okg6eKQUkbdAUGAz6eL525BiWkyqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772605609; c=relaxed/simple; bh=h+mTLN6n6mBPr7PqYqmQSCCs2jhafXeB0NRdyOd/a60=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VKGEFSfBkVA5yAJW65zXOjAHD+GFvSnz1aaZm9Prx18Sq7YLuQoPykM5pvtjEZOLjCSSmzThBraV1r5wwnesmBiiJxFgu83PlYKxOm61Srl7Bb0JHRkdec2LtO0jErafqAXdf+YUqlY13LStqjTVwzf/rrGERrJJ6+j91KfvMEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DF3PXUcm; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DF3PXUcm" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-8272c559597so6494210b3a.1 for ; Tue, 03 Mar 2026 22:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772605608; x=1773210408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UNQTswAIlkxtACM2d1rPkaE1OkOxjlH5iieRYDqA/Dk=; b=DF3PXUcmwq1QXhhXy6OADy9cp8wt2DPYOeTzubiRlQWtQ+uQotZQEqOqPIC6GuEd1b aKoNV8rxmW4/zSXS9mHjItZEQhUfHvVNeYlbzmeFR8Zt8fBqvtBSyzIDf9zpriyRCwmQ 6fEYLL0Pslpyr80rRtA5P2zlW6RgbiCT6bFJaiMtKVKwIylWm87L3llLHWRm2PcvAZwT RxbsgHZa3ga8NyhTAS70ByN+rGn1FgY1M4dtabTc/1AivRqE6DIvmk4Yb5+umtY1lBHc 2Uw2VVF/JNVA3n43P95xlN26J3JXMr3hriomPAC7bZke2CuCO2FcCCtt+vfbAVn2vyLt s0eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772605608; x=1773210408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UNQTswAIlkxtACM2d1rPkaE1OkOxjlH5iieRYDqA/Dk=; b=dztSX2xB1jGhK3v/oTHkADTsiSthF4caxS+f2HSd/VABnHcN6jUt8oyq4IywH8D97o z22ceZ9sCr1BHFRjcC2YbN5k+TGurhXazYpUqC4Bs9hNhCDf9/heaqcRU5LBn0748L5a +VeQFcn3XiU7Qi7AbO2tON6w/AAgZQ2dosIjjIfokRXJlP5Vwm/VsVUIvBFsSfyRTNJc CKtSB4VXs7gdkKQr9WMhNHNwrpUm1scGDRtRwE3Pz3j8uUuWUE4xehJiZjZf28g/ze74 StptUSR/jnHSyxdEJKT4kljEjEdufcl6XAsYeSJgDySSmS/U85t12FZb3Rzch8QKBd30 PB6w== X-Forwarded-Encrypted: i=1; AJvYcCW6UGqwd8fEgN8VSfeGr+AjdbqhqiTPg5b1UXkilCoBosIWupGQwOCT8hRDd2nETc2XtARIdwIsg9wYJhs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywk5/96H/mm4XIqHqWr7xUSvAUVVc2oxMXmDZ9JfzUQvEM+5eGk Bj5Npy9b1PBTaZbHv0r2Otack9fM1vdZalfHyhde+l1wJT+H/STJ012x X-Gm-Gg: ATEYQzx9mlBb1/Hvmv7JAf9jwN0ie8qhsIJ6o9t8MyJtlRnyzTghtjxs9XxXJ4/3zj+ 6X4W2NfVNt7q/UvT4iqkxRfF7TlSJmJJ4vZYCRjjDPUL213ryaEF1OcIFNHCxLNImJLscZp5/5W 4MUUuVWjt63dsOE0fiBDKicbRvP747lPPzDiiqSkiiQcprh0ulZUnoC8ZK/m9KCXUNKC7bKyVjt ca6sIXuV0FNgQtoQwT/aVJz1SSt2xsIRreRkaZHjxRSDAidF7+LWFOs5zxT+AIFQsjEzRYmWIX6 4ojOrQdBzaJCXjJZfoqouKpt9nmteVSAlgTtWPqx36ncZ0qLWAIg3sdchfXEG5b7umvWiM0KeHJ uxhT8/cN6E5xDWd6dt5eBupkTP5LCYg1Wpy8nq2wpRsWSQubRSqgaQAFA+NCX9jaUJhDbqCSfkW DmCnPkn13USwXmFQwCN3idDOXMQl/wjXvx1MQCgPr8/UTVUrpFun6xvA== X-Received: by 2002:a05:6a00:340a:b0:81c:4a92:25a2 with SMTP id d2e1a72fcca58-82972c8324dmr849629b3a.46.1772605607659; Tue, 03 Mar 2026 22:26:47 -0800 (PST) Received: from ZC-202510311500 ([61.185.217.216]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82739d544ffsm17933355b3a.12.2026.03.03.22.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 22:26:47 -0800 (PST) From: hechushiguitu666@gmail.com To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, "haoyu.lu" Subject: [PATCH v2] PCI: probe: Use helper macros and constants Date: Wed, 4 Mar 2026 14:26:38 +0800 Message-ID: <20260304062638.1782-1-hechushiguitu666@gmail.com> X-Mailer: git-send-email 2.53.0.windows.1 In-Reply-To: <20260303073655.2047-1-hechushiguitu666@gmail.com> References: <20260303073655.2047-1-hechushiguitu666@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "haoyu.lu" Replace direct resource array access with the pci_resource_n() helper macro and use MSEC_PER_SEC instead of the bare number 1000. Changes in v2: - Use pci_resource_n() for resource array access (Bjorn) - Use MSEC_PER_SEC (Bjorn) Signed-off-by: haoyu.lu --- drivers/pci/probe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index bccc7a4bdd79..d5b27d03355c 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -119,7 +119,7 @@ static u64 pci_size(u64 base, u64 maxbase, u64 mask) * Get the lowest of them to find the decode size, and from that * the extent. */ - size =3D size & ~(size-1); + size =3D size & ~(size - 1); =20 /* * base =3D=3D maxbase can be valid only if the BAR has already been @@ -594,7 +594,7 @@ void pci_read_bridge_bases(struct pci_bus *child) =20 pci_bus_remove_resources(child); for (i =3D 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) - child->resource[i] =3D &dev->resource[PCI_BRIDGE_RESOURCES+i]; + child->resource[i] =3D pci_resource_n(dev, PCI_BRIDGE_RESOURCES + i); =20 pci_read_bridge_io(child->self, child->resource[PCI_BUS_BRIDGE_IO_WINDOW], false); @@ -2600,7 +2600,7 @@ static struct pci_dev *pci_scan_device(struct pci_bus= *bus, int devfn) struct pci_dev *dev; u32 l; =20 - if (!pci_bus_read_dev_vendor_id(bus, devfn, &l, 60*1000)) + if (!pci_bus_read_dev_vendor_id(bus, devfn, &l, 60 * MSEC_PER_SEC)) return NULL; =20 dev =3D pci_alloc_dev(bus); --=20 2.53.0.windows.1