From nobody Wed Apr 15 13:30:04 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99B6E1DF25C for ; Wed, 4 Mar 2026 04:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772598880; cv=none; b=Of5qUfRYSULvZB7HkLJ9VWiLU89SbNUruF5qRIL//T46O8v+yTAIMbs7hgasPx+BAuKJx7TcP9fbHACo5X0PlnnAenOR3EfGpGtIdzY1yTsOSK0SqiWNZuJliUCHVzL9vIZ3qQKeBmplBpKUnAOpzUZyo4qPO2BgvgHNpuYHxCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772598880; c=relaxed/simple; bh=X+WIB/W8YuPByuWc0i01EfTLZ1hpPln25a3bGKeHO6I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RgpfRMXuwo3f4scQHCzhh/ij6OP1XQ1ckRc1Q+spweAQ/qqPhz/v3orEPzci5vo+ZX80QnJDR6yQY6YeNSIjHKHNLd+593BgX2PqiS10joRL/DUtz68IyTtxagF4VtPdByStFrSZKsyU4q1uyO7O5R/iy+gTGG8X0E/y/xoRpcY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g3zYi7AT; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g3zYi7AT" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2ae505619baso17276445ad.2 for ; Tue, 03 Mar 2026 20:34:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772598879; x=1773203679; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=h4+RxyEzVVfMeQjameS7WuxM58R+fJWfpg/21/ewVWI=; b=g3zYi7ATkp3IIiuF58Y+42B+FJOA0iA1APvRRnmsCiHZaA1i1SGt2BKPN0wcWPZLip CrUElSXVixsEoKqREgXg42+/ML73uXzy/5V5S3CvbJoFTFCDbPVOAnCNnN6HjAAH0aTQ kgSf/yDVKOYcxZbgL1pOu/uj8wAhiWW5paB+l8tm0bxZMtb6flGLpa/p0dE+jJoGszwy JSr61S8oT3vjKUKOPdU8Ehr6b5L1N7wUzvzXMazj78dRdRU+7U54JO6xFmMO1NXohw1d BFvncA8BRgI5ZA10evVro8lC/k7Uja3KUMnzbFTEr1LZS6FJ2+P/Vg/5TCqXYR9mLOIR OqCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772598879; x=1773203679; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h4+RxyEzVVfMeQjameS7WuxM58R+fJWfpg/21/ewVWI=; b=mNDJg1taLAps31Mxwrq5t24x2aosnRkndN1XDaygNQEIWjQs+3M9KOUgVER9D07PWS +YsSrMVKqt2sbPRf1GhJnGAACfAwW1vpsgIX6uEXCSbYaZja6Jn1J7PBV8un5G5rUQ/O Idqn4yqG3ZgRumdlzmoQzSSXCg9qYbADTKbNnUtjXIRJXAPD2bxVMeUFdpKOWQgEUGW8 u0LXEi/e4VJHMRVMmwKjCN38PeH1Bn6rgVu1mpCRA4Hoj3B3bKnjZxJKmZL+GmrdbDoT BJ/pHR8xwVzUf2nXWNKu5L+Towxt6sPkWIwIJku/aFOFMscDRg7972BX1GY9y+HtQ00U 6dWQ== X-Forwarded-Encrypted: i=1; AJvYcCWqZbqGMxaeydeqdtZ8gQ2GI01zs9WIj2FeC+62ZMOvAc1cMz75x2YQGCcHBCM6imXDALWNdPcf4I7p44w=@vger.kernel.org X-Gm-Message-State: AOJu0YxLMEqnK3F8US53m4su6eo/Qfj1nQT12VJlY/wNXFd6vY3EqJKi lYjdMCskLqzl/6PNvBX5Efh2Kv1nsts5Ab/5cnoK3uaCguscY+Qlu3/8 X-Gm-Gg: ATEYQzzJOQ9LyXHFcnDDkFQ3BtW4FPVXc6dvgn2096sAKfiJQVELhupYh/5IOkLJ0rG uTvx6JABgjAzezkBLwlFSpsNWN+wR8Eqb2pf9K1gnrFAynAGGujiimoOFyu1uvbsN8QEA8XJHlv UZ2bUf6j2hCIV5aF8w+IsnY/DmLQqc9iJfU9fc5CpRlzDyL1w3ZAzp6dB1FasjCXLMvgsCzkcsM 7HWJzXSJwOolaMChnAZSHe4aVlzVrf/JBTOf73ggV6Q8jjQPEQ0SsW+Xd2zP6YDhFRZgkSH+fra Wmg/vTYFFPX2A68XqC4/HwutUrxhE6yAvI3h/WDsbt7owqZDJbmv8NLvl6b/dTddUCcQeRnD9Zy 5rWu9l9nRkJezGPpAiyYwSb2bGcHeUIG1+B/QogvaHxkPJydKO9Dvak6EiGYYA+hHZ6u94lRCtj 4pbgAd1QuK/Dq2NDjvc4dkYgs9V7bAyiZXUnscIJlm4qcbbmGvqN14dA3Ih/UvmXmy X-Received: by 2002:a17:903:1a67:b0:2ae:57cc:63d7 with SMTP id d9443c01a7336-2ae6a9de1a3mr7732125ad.7.1772598878948; Tue, 03 Mar 2026 20:34:38 -0800 (PST) Received: from ryzen ([2601:644:8000:56f5::8bd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae4651e409sm115173435ad.44.2026.03.03.20.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 20:34:38 -0800 (PST) From: Rosen Penev To: linux-phy@lists.infradead.org Cc: Chunfeng Yun , Vinod Koul , Neil Armstrong , Matthias Brugger , AngeloGioacchino Del Regno , Kees Cook , "Gustavo A. R. Silva" , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek USB3 PHY DRIVER), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek USB3 PHY DRIVER), linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support), linux-hardening@vger.kernel.org (open list:KERNEL HARDENING (not covered by other areas):Keyword:\b__counted_by(_le|_be)?\b) Subject: [PATCH] phy: mediatek: xsphy: reduce main allocation Date: Tue, 3 Mar 2026 20:34:20 -0800 Message-ID: <20260304043420.14151-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Instead of kzalloc and kcalloc, we can use a flex array to reduce to a single allocation. Also added __counted_by() for extra possible analysis. Signed-off-by: Rosen Penev Reviewed-by: Gustavo A. R. Silva --- drivers/phy/mediatek/phy-mtk-xsphy.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/phy/mediatek/phy-mtk-xsphy.c b/drivers/phy/mediatek/ph= y-mtk-xsphy.c index c0ddb9273cc3..cc1d66954212 100644 --- a/drivers/phy/mediatek/phy-mtk-xsphy.c +++ b/drivers/phy/mediatek/phy-mtk-xsphy.c @@ -112,10 +112,10 @@ struct xsphy_instance { struct mtk_xsphy { struct device *dev; void __iomem *glb_base; /* only shared u3 sif */ - struct xsphy_instance **phys; - int nphys; int src_ref_clk; /* MHZ, reference clock for slew rate calibrate */ int src_coef; /* coefficient for slew rate calibrate */ + int nphys; + struct xsphy_instance *phys[] __counted_by(nphys); }; =20 static void u2_phy_slew_rate_calibrate(struct mtk_xsphy *xsphy, @@ -515,18 +515,15 @@ static int mtk_xsphy_probe(struct platform_device *pd= ev) struct resource *glb_res; struct mtk_xsphy *xsphy; struct resource res; + size_t nphys; int port; =20 - xsphy =3D devm_kzalloc(dev, sizeof(*xsphy), GFP_KERNEL); + nphys =3D of_get_child_count(np); + xsphy =3D devm_kzalloc(dev, struct_size(xsphy, phys, nphys), GFP_KERNEL); if (!xsphy) return -ENOMEM; =20 - xsphy->nphys =3D of_get_child_count(np); - xsphy->phys =3D devm_kcalloc(dev, xsphy->nphys, - sizeof(*xsphy->phys), GFP_KERNEL); - if (!xsphy->phys) - return -ENOMEM; - + xsphy->nphys =3D nphys; xsphy->dev =3D dev; platform_set_drvdata(pdev, xsphy); =20 --=20 2.53.0