From nobody Wed Apr 15 19:28:23 2026 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79289375F65 for ; Wed, 4 Mar 2026 04:17:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772597859; cv=none; b=os8sWA8bvMjD2jg5hLjs0XS4pb99gbVTekdWDd1DlbyrrHOdseArsyJ1298G/xSxYdG9KEL3GDScqQYuxRPddRB2Ax1TL42wN3V+yTiYBsmLfl5nxCNQZKFZE18JGdW4mFQvhCYSZ9IglFL3rBgIAAO+hCRDuktSsrzlRXKzmUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772597859; c=relaxed/simple; bh=ikTBZYdMphQUTYs7O5y++Y7AZTPNX+0kvonaTugzInk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pzGkxLLpf6UR87b1bpUeBVieskLTFznhsvte4E9l8Jprn98/sis49rA9yadFKm7by5J2AaR550A6Qw2YdkPd7JOa+3qf1/Xh31jseb94RiyANd0hfpjB5aXk9VyOTv7c6RRCh0L3ILJt0IGBybXetqQ9eTz/lCISZp/Qq7uVVQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hA8SHzz2; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hA8SHzz2" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-7986e0553b0so56160747b3.2 for ; Tue, 03 Mar 2026 20:17:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772597857; x=1773202657; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cj2evDlwnNkzABttd4YNchw6wVbpncuY/X8XS90rCSg=; b=hA8SHzz26d5W802FUdjWsWmPZqVA2daaoLeFGmcRxQqAEx0vC7WvnaNmUwgllKlkIa Uq2M4OIsI8n+5RQiK26Uq9N787A2acGWH21vE8hT8evy1MvteZGRARdV9KEZcCo5Bmkv crA2zkUWI5/64Rvol1H/QelH3pNXCN8dC+ZjvTcz8pSmgMkiWq/bPZseBgYYWzdHy225 azY9TXal/yyJZiEpm+NsGPKpeOOFts769ITZKLyE6e+cVV0kHBIanF7Gl/25gBotnP8B GxALPgKndHMTgOdI5c/F1hJK5HoYHWXbfmhEfWTZVJeOxwkRNcaS/nD5hf6Ian+3jNHr krQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772597857; x=1773202657; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cj2evDlwnNkzABttd4YNchw6wVbpncuY/X8XS90rCSg=; b=qK1Uuh1DHZbBCUBwGNMQfwMJ7tXKyxCv1sMsPPazEhQ5C6GWGN8a8xQmUYP87doO8y 443EwPmxTkeHPPFAR//Tet25fj8pMmDxOrRLcbvG7+H8tgk8v1eGKSwnwXvSuaKYZNRr zJInq67+hbkkVMyeGDFFfoOxtiohVY0IVjD/C0bbR3LUBgPBCmAPWWd+BqMXfBaJ9Ysg VkFteJpC4gPGx5zpTfMftIPA+h5xk6aw4ORq75MeYfJ2I8JYDFSrYzOWTGhi3OuhEosV ND9KHjZKPfb+VUkIfott68iFmDw89xZ+jqPW/8r9pFo8n4QGZqoTGV4ECNTtSxwwOEWd LD7w== X-Forwarded-Encrypted: i=1; AJvYcCXFo0lN2E/PDyGNCFqwp6LoqEE3ZMqLd/P+Lu0t6yTZMXUHJ4hd6wQ6n0wdCO/aNOwPIy6Sj1JqHVNmxJI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0QMtxHcJyeunPfmFYD75cEHuksL6arnvUDQzm+Hak7kUgPdN4 etaMWXKzZiW0lyKSLZgDGiqENf9xsLJrjq4u5M3W8i8GQBYKXuWbhpuP X-Gm-Gg: ATEYQzztWhmoanvUN6ijWEOHTfI1v8/YFRckCag5B6wZZRb78DhhTEaNoqT/uXoiSdn K+gHYGks+9vXhFJp6Iy9+zSIW+R4jSay/hdCtt6KaTanmsTi1fTIbbLFA4u7ehMdFHc4yZdgqSA ImzVe1ZvyPbsOJSQycvJT0C+SNzo73psgldHtP+uMYbhtS88n9cFQvAJqjK3I/gROolh/PYLK8C JJQraOMR1F4Spfhw/VcdGMVAT6Ag0eJl5vAPJYbvCr99UnQEjDSAr7/LjJ2oMiqmd1A9GUQEem4 lZ+wfK0WJXh5dUgG3dsx+cXISHiFoQouHjShY/knlfjnzV/bMrq08e8MtYTEYAOd55RgLOWYOle LyOQWvSUKMJApaYFdpfuqpHR9fBc6cI8+tkGiOHEHvHrINtfK7cRbB87Z9mM6yu49vFslvyV7Se sAH0VJVFIqsLcyzDTV9nogFhuSKBsEEhuQYCH4ERz68sgWR5BQVijqhKQ7xCP1aRmn X-Received: by 2002:a05:690c:6983:b0:796:371c:7afd with SMTP id 00721157ae682-798c6b8a015mr5803047b3.13.1772597857322; Tue, 03 Mar 2026 20:17:37 -0800 (PST) Received: from ryzen ([2601:644:8000:56f5::8bd]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876ad9045sm69989297b3.16.2026.03.03.20.17.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 20:17:35 -0800 (PST) From: Rosen Penev To: linux-iio@vger.kernel.org Cc: Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rosen Penev , Xichao Zhao , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-amlogic@lists.infradead.org (open list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] iio: adc: meson: no devm for nvmem_cell_get Date: Tue, 3 Mar 2026 20:17:16 -0800 Message-ID: <20260304041716.7631-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is no reason to extend the lifetime of this post removal of the driver when it's only needed in one spot. Moved tsc_regmap assignment to avoid two nvmem_cell_put calls. Signed-off-by: Rosen Penev Reviewed-by: Andy Shevchenko --- drivers/iio/adc/meson_saradc.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c index 47cd350498a0..ed91edf0e391 100644 --- a/drivers/iio/adc/meson_saradc.c +++ b/drivers/iio/adc/meson_saradc.c @@ -792,7 +792,7 @@ static int meson_sar_adc_temp_sensor_init(struct iio_de= v *indio_dev) size_t read_len; int ret; =20 - temperature_calib =3D devm_nvmem_cell_get(dev, "temperature_calib"); + temperature_calib =3D nvmem_cell_get(dev, "temperature_calib"); if (IS_ERR(temperature_calib)) { ret =3D PTR_ERR(temperature_calib); =20 @@ -806,13 +806,9 @@ static int meson_sar_adc_temp_sensor_init(struct iio_d= ev *indio_dev) return dev_err_probe(dev, ret, "failed to get temperature_calib cell\n"); } =20 - priv->tsc_regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "amlog= ic,hhi-sysctrl"); - if (IS_ERR(priv->tsc_regmap)) - return dev_err_probe(dev, PTR_ERR(priv->tsc_regmap), - "failed to get amlogic,hhi-sysctrl regmap\n"); - read_len =3D MESON_SAR_ADC_EFUSE_BYTES; buf =3D nvmem_cell_read(temperature_calib, &read_len); + nvmem_cell_put(temperature_calib); if (IS_ERR(buf)) return dev_err_probe(dev, PTR_ERR(buf), "failed to read temperature_cali= b cell\n"); if (read_len !=3D MESON_SAR_ADC_EFUSE_BYTES) { @@ -820,6 +816,11 @@ static int meson_sar_adc_temp_sensor_init(struct iio_d= ev *indio_dev) return dev_err_probe(dev, -EINVAL, "invalid read size of temperature_cal= ib cell\n"); } =20 + priv->tsc_regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "amlog= ic,hhi-sysctrl"); + if (IS_ERR(priv->tsc_regmap)) + return dev_err_probe(dev, PTR_ERR(priv->tsc_regmap), + "failed to get amlogic,hhi-sysctrl regmap\n"); + trimming_bits =3D priv->param->temperature_trimming_bits; trimming_mask =3D BIT(trimming_bits) - 1; =20 --=20 2.53.0