From nobody Wed Apr 15 13:23:24 2026 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDB681E1A33 for ; Wed, 4 Mar 2026 04:16:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772597783; cv=none; b=t1pE6IvvYeeCwtiPFZHUqbXPUo3o95sRtBjgt+hrQYCxt7sFpqoIx4VPkvMM+c0geh39iFMvYMVwcQGcHt7CLcfZN7CcEpEkxgY0mhIilg4Btu2sXSlqYgrBAG9OzOQjyuPp0fs+fi17FF2A/kySgp/IJeOW+lg5lnKsQ6i9lGI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772597783; c=relaxed/simple; bh=ZKWajBMq/4M3N9gWk63dTrTJYx5Sp1WtUFiiakZsxZ8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=K78bZv0v22OsldUy76ZRW3P1CQNZ8wRaIoZumfpId9f20LOK6FCGhM93AatCNz/Gn32i+IUH1boOPr3BdLuVfQ8pwOo9XwK2b5cnreoA2MP8QF4YPmBezzpMrPh0uWsKNEkzdc4iRupASGy6rN5ih/72xcF6ZcTSJorcjeY7BEA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V1Qfvd9W; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V1Qfvd9W" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-79885f4a8ffso47012237b3.3 for ; Tue, 03 Mar 2026 20:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772597782; x=1773202582; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MkjQxqDNkwYe0v6cm54vnCU9hUuWR93LRR4ggzirqFk=; b=V1Qfvd9W7DqYqWI+i216Vh+NH66yV3tPsab6ClmjHYDSSZbIeLCgY8oNvf+stzfhlZ xBCE9dHjUYPHLAZEw0sbpd+Q0l+ZrChJ7bD7a754GqUqKO14NoIMjuFn0QgIIJbBVRTM pUA/1CfXEAmPYyxTa2JxFqWSxM6H3bSQkooguIGf/mFHhkIi+BHHvarMnTuAMjSaIkRl dUnW20qIehMy2PLjgmp55mnOUnZqSmBEg8lEM0m2x3EV0IdgJvrRAr2jvh9+Of2mGvN7 vaGMPcwJEuoGU1pj5R7lloNZp/Zr8R2vRVs5g2RV0oIjrUEPECp0RtC9cMMu2o6BRTLW 5Miw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772597782; x=1773202582; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MkjQxqDNkwYe0v6cm54vnCU9hUuWR93LRR4ggzirqFk=; b=ZBp40+ybn/mpSiqta79lN6iXz61hVEI23d6G4eoJzn6d+CR6JtuDQ3mQlovLC2YVtW VDEXGF2+TtRhmGkgjaeF4MzN/J7jl6yxCC8zo4JskTG4Gmz2HsB8djCvkxxNmygmvNH9 2vUAJXwiA4xvACLIUrZs0CFX9AfocR8b4MuESWp682B5ibcAMC5PEUwL9NbXsrBQ580I LSNgYoNBb8+n00f0wVkGq5TMuAHWrs9ZiI/NT1d6poAbNGFAm9ViJTmrGXzM5vl3GUfz yaXd02s1B1U+IzOz/zKH7Uj21UryACvHA3MvctqlHJ1tjx1ef89c/acH5x5pyt46yoPs FAGw== X-Forwarded-Encrypted: i=1; AJvYcCW1MEWUlpx8KLDQIwH/wPcoYq7Dl8ZYZ2cmMWh9BC0/2UWOD19eyns97seoWim1675/1rH9Ogd7pZVgQLs=@vger.kernel.org X-Gm-Message-State: AOJu0YyOUCjnd8Be/7DZRLNxLehiC/PVz5IiGsldT0pQCrRUuFOM/bSn 7p20tuSADmDq4whNeeXOGuoYPEu3hmsao6Ajz2UY6JTrFWb0gKXru//g X-Gm-Gg: ATEYQzwbz2Y3Tnwa8iOX/gxlKLFWAvGSszPRc94V0tAqhrJJszh70aLTy0r2pMoMb9I /uH0dcIP9YgiFiM3eXt2B3Hpnv19raKu+k4sKTQJFPVJeiaC4s3a3XOrhwuiJjCMD46Gruee1jp TCeKf/WnY0TKaNgujpBIq2KkqPgfkFSmZQ4CZgT3aIZxuAm7fAgQWSl+YrwMxj4Ogwo9o75aCv8 cRliYRbulpd4M3PWIb/CwS7/daJt5MRiAzrz2Kmx2WzAPjTMiZHSpKolMCUlHrpijQ1lgFJKaGj 5v8kkL6jCBLCe0sZGnf7aYnCVzraZdrLrPjSzpLJFJFRCU3IgmDptqF0X6JuURL2xyuuB7gFZrX 6BWpMC0gAle+3TJ/JW6dSkLJBoT40EphlaeOB5ohoGkrZMAS3mA6QvY4/U0/RGuap8Viw/Mtgf+ 2FE39NxJozlsdlKD8fwR8+pk/H3qR1PdU+5FrNsHBAAc6ehG/Q+mU0rQ== X-Received: by 2002:a05:690c:c4f1:b0:798:56eb:f238 with SMTP id 00721157ae682-798c6cc63d4mr5262807b3.36.1772597781827; Tue, 03 Mar 2026 20:16:21 -0800 (PST) Received: from ryzen ([2601:644:8000:56f5::8bd]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876ca7354sm68570967b3.52.2026.03.03.20.16.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 20:16:20 -0800 (PST) From: Rosen Penev To: linux-phy@lists.infradead.org Cc: Vinod Koul , Neil Armstrong , Kunihiko Hayashi , Masami Hiramatsu , Rosen Penev , linux-arm-kernel@lists.infradead.org (moderated list:ARM/UNIPHIER ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] phy: uniphier-usb3: no devm for nvmem_cell_get Date: Tue, 3 Mar 2026 20:16:02 -0800 Message-ID: <20260304041602.7539-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is absolutely no reason to extend the lifetime of nvmem_cell_get to after removal of the driver. Use and free right after use. Signed-off-by: Rosen Penev Reviewed-by: Kunihiko Hayashi --- drivers/phy/socionext/phy-uniphier-usb3hs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/phy/socionext/phy-uniphier-usb3hs.c b/drivers/phy/soci= onext/phy-uniphier-usb3hs.c index 8c8673df0084..c8971eee3640 100644 --- a/drivers/phy/socionext/phy-uniphier-usb3hs.c +++ b/drivers/phy/socionext/phy-uniphier-usb3hs.c @@ -104,11 +104,12 @@ static int uniphier_u3hsphy_get_nvparam(struct uniphi= er_u3hsphy_priv *priv, struct nvmem_cell *cell; u8 *buf; =20 - cell =3D devm_nvmem_cell_get(priv->dev, name); + cell =3D nvmem_cell_get(priv->dev, name); if (IS_ERR(cell)) return PTR_ERR(cell); =20 buf =3D nvmem_cell_read(cell, NULL); + nvmem_cell_put(cell); if (IS_ERR(buf)) return PTR_ERR(buf); =20 --=20 2.53.0