From nobody Wed Apr 15 13:22:07 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 456CB378D6C for ; Wed, 4 Mar 2026 03:46:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772595973; cv=none; b=lNEBPVZJ8ZINFZwSBZdgPoqxUcKkHY9rkpnzTDgXOtAoDmkThps399exgXIowuEgaNwga6Zadc/wZWkqVq6s0qvyY5PqBtbCGagVQwRHWDzYGvXmcwKl0bDrR8eWAvMwXrNv9heI3834NZvy9oMaP3rE4Vkyagv5ckQWq/oyjPo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772595973; c=relaxed/simple; bh=h+mTLN6n6mBPr7PqYqmQSCCs2jhafXeB0NRdyOd/a60=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cDd292uTkk1cs6XSlEPh08/9O8pTRfb2VLHPaR4FBzZTZUrDk0J+gyJi/E4LeO9cAX/qNEdHoFjNsnLvgTn+56/Ph+FdpOG34qxSnqgklV1h8yJ2s/7O9jcg6eIHSwkhG+/jtXy88o73kANzdz1ZVq2S1HbpmaY0eGGuglIu+xg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OBbNteYp; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OBbNteYp" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3585ec417f6so2714219a91.1 for ; Tue, 03 Mar 2026 19:46:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772595971; x=1773200771; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UNQTswAIlkxtACM2d1rPkaE1OkOxjlH5iieRYDqA/Dk=; b=OBbNteYpY1DBBXckQkQx4cC1VHUezD5E0OaN6uyerrRWL0XhbOo1es6evUjMW1xUgl teAFFzf3R26V7LxgoAD4PPEpbRL/p24Xhad1aTJr2C7fFjJwWwPUYognXQcTxViky7SA QxgOQiFlJYTOiWPfJoLbrfWZh4AyVkckAcvY3HwCXFr0JRtDta+CwAkofpaAlODWf7cu aWnOMMEoMO5r1b+KR1LqSwG1VhfeUHVcKILR8abAp5N7fGkfM0/1TFRXL3RegczxRN7H jF8Ce+3JVf3fVJCDGGDGHVBhgb5rQQ9YS/GyxwWXOzD+FHtlM02FVm6RDOBYKzvZbEpF 2d3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772595971; x=1773200771; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UNQTswAIlkxtACM2d1rPkaE1OkOxjlH5iieRYDqA/Dk=; b=PED6HPZJnaAWVeuSbiNPo9P7TuQSrTohD3XaQqud4mdbwOb58tOkkfhpCCOMyZaLbi d+YHSJV38VfpJ1gTQdaX6dbujpHyJyvrqDQVTq8r5aRtZw1ffrYChWmMzkJdEmmluMEn XcaaHmySwP444178wmwHHF3PgMarx886Tq8NUGCc52AYTlB9sVeXOg1qbskfqDUxZeeQ DlA463V4TW5UXvaJuhMdPZY9M3jorCDmCphy5XfnRVUMvlJaiAK/JyzoT+P/DNQFQWRf Ijru+5HRpwPQUA8+O3eel9JbDbRucLQ1+/4RuYrfwHoH8zZXDwbLJLx/Kept4hjLneo9 P7Sw== X-Forwarded-Encrypted: i=1; AJvYcCUdSgjzIiaWBOK1vgOcvDBzipw8FVk2wla06Kg7X8/6MXSkK8vKFV11Uj5DyDFqBM7FR+H1J+0bqeDONGU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/+yjjkR7vrDD8nhXx+XB9v+6cIBqaVCYYaBEoNP5ggnSpaaik jAzX2nzE3U9Kb8/QG4WmRQf7wCYU3XTz1wlzDautELdeENrgIw5RpmuVCwFQV72I X-Gm-Gg: ATEYQzw6GmgeZeZgIw/pFcTMc6kKs+rPIVtVRGNIH8lm5YgFfSYMT7rmZp9/FBtOWb0 QSPTbuzXh/95eWdLyupjrXiS8W9mWP7M94MAV7ItkMTT1xDs6lSQ92oe5txnUDt6Zcmq+Vl35Q+ BD5woEN2i+njL2LgrVu0LQ790JGowIbgDjuinIpCdM5rRFZoHuZqeYgPu0zMORbH5ycJmtrwKJx h9DliihN4c/7Ab4jHxfyOPiIU84SIPoqRibEqzUSHfDQWsMJX333afu+BAg64S5DmG5PH/3gSEr MO2vErNWwFbXH6Y4X+h6Veh4qwCPY14SeRgbMQZMdpeqL94cyyaK4Z0MdpCQZpkOfHWZ0bX3fLd bmkfnY2px6aCiAcwEjGzQfqNK2m8s4faWbxEqG1QD7aJTSXV0w22/0hrp0tiIMrq5Nvw2SyF5uf jbd42SifLL0V4sB4xe6iweE5N5ttoPxj/qEUMXcrI/O+yT+UqI+W2Ba2hBbcuwC0g= X-Received: by 2002:a17:90b:4e88:b0:359:8c5a:a564 with SMTP id 98e67ed59e1d1-359a6d8efbfmr685242a91.13.1772595971456; Tue, 03 Mar 2026 19:46:11 -0800 (PST) Received: from ZC-202510311500 ([123.139.95.92]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-359a8f3c1absm5742a91.4.2026.03.03.19.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 19:46:11 -0800 (PST) From: hechushiguitu666@gmail.com To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, "haoyu.lu" Subject: [PATCH v2] PCI: probe: Use helper macros and constants Date: Wed, 4 Mar 2026 11:46:04 +0800 Message-ID: <20260304034604.1598-1-hechushiguitu666@gmail.com> X-Mailer: git-send-email 2.53.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "haoyu.lu" Replace direct resource array access with the pci_resource_n() helper macro and use MSEC_PER_SEC instead of the bare number 1000. Changes in v2: - Use pci_resource_n() for resource array access (Bjorn) - Use MSEC_PER_SEC (Bjorn) Signed-off-by: haoyu.lu --- drivers/pci/probe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index bccc7a4bdd79..d5b27d03355c 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -119,7 +119,7 @@ static u64 pci_size(u64 base, u64 maxbase, u64 mask) * Get the lowest of them to find the decode size, and from that * the extent. */ - size =3D size & ~(size-1); + size =3D size & ~(size - 1); =20 /* * base =3D=3D maxbase can be valid only if the BAR has already been @@ -594,7 +594,7 @@ void pci_read_bridge_bases(struct pci_bus *child) =20 pci_bus_remove_resources(child); for (i =3D 0; i < PCI_BRIDGE_RESOURCE_NUM; i++) - child->resource[i] =3D &dev->resource[PCI_BRIDGE_RESOURCES+i]; + child->resource[i] =3D pci_resource_n(dev, PCI_BRIDGE_RESOURCES + i); =20 pci_read_bridge_io(child->self, child->resource[PCI_BUS_BRIDGE_IO_WINDOW], false); @@ -2600,7 +2600,7 @@ static struct pci_dev *pci_scan_device(struct pci_bus= *bus, int devfn) struct pci_dev *dev; u32 l; =20 - if (!pci_bus_read_dev_vendor_id(bus, devfn, &l, 60*1000)) + if (!pci_bus_read_dev_vendor_id(bus, devfn, &l, 60 * MSEC_PER_SEC)) return NULL; =20 dev =3D pci_alloc_dev(bus); --=20 2.53.0.windows.1