From nobody Wed Apr 15 16:32:39 2026 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2693536655E for ; Wed, 4 Mar 2026 03:34:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772595265; cv=none; b=RVjVp+9lKV9/q7xMYp81cMwylJMUzbK8j2StTXYEMn7FZAwxdSsyi5bKNGxhXXCZs4IGSvpuGSfMvA6ZXau8So6FaHVoS4i9M5C8JyeW1BKI4xIXIfjk/oiaixifNc4QyqTUekr2zYg1EL5O2TCDWX/3T4P/RYhFxP8Ve4X0M08= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772595265; c=relaxed/simple; bh=R2M2fHHkAPwgqw+I1TxObtsEQQvziTwqQOcXHWNyRzo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=laPljHPzl0ScQ7BiRHYlvfWH6kq9dKxidw7IcgT2224YNAw8XlrJO2M243x6aDsa/VT1537csvq2KGVc3RWWxmRe+EZpEtz2BEDis+GHyb6LQ60yEBhrMrOhOWjgDyM8RyZWJv1FWDxAt4osm4M1xUl1Hx4PrW0nDLKobVsHltk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EZQnwEyt; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EZQnwEyt" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-359866a1d02so2794745a91.0 for ; Tue, 03 Mar 2026 19:34:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772595263; x=1773200063; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6CW6uN7WcGPQ9ejL+45MIV9ogicIgXHxX+5ZMFH2olI=; b=EZQnwEytx4wtGqIbaRPGhfYQHGvl9wA4cN3T63R7ork9iyREMtAK9mHEG/3orspJBa KhUg9/HORv5FW9jrjpoewWv0mzqp12Yh2RleKRBUl1+QxbLXEAsTSc9DTBUmPUxdDWba 6oCpVvSxxfZqDJ5pdhQUaNN5H/O02rhSyNTt9ddmbAVWW6cuUOKLS8YJdmbxCxhM61st 0VN4avVy0nbcdxaVKdiIrLUbu1QejZY5ZgS983WFTyR6OD+ym6ws2T5t6oIk6kYcfVX9 +ibwfu6vP5TdNPH+pt3LuUXczF0jjFvypVj7yAOq1X6p6epQeksjVwTzd5riWutIamH/ KkKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772595263; x=1773200063; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6CW6uN7WcGPQ9ejL+45MIV9ogicIgXHxX+5ZMFH2olI=; b=aBHf13KQYm1MY4IiuR9coOdDtcIoDhLFoczo0Vybiivao12qI0gsIdEo5XneVjYNmq bvkQWkuY8U1KxH3FwBgcjwApkRUDRn/+j3mDQhDgGDZk0j97fOcw+CBJifwYKmIQzwjS OI9PrUufxRyZzoPKoH7ndOuDQiEgp5p1p4EL/Wb32Q8SsC9Gp34HczjQ7ZE9m6LMmCZ4 jbwX0MMnoArA1CRJTv+4IevHIoqqLnDu5p0WgoNqSgFiWCm9U2JwlIkVWMfSvsSqwls5 RFhiKuA7lPWhFFvygB+no02qVIx8LMinx8ziSPNqhJMmJ0r5dUmi38ivXWZp0KLsfIqv z0yw== X-Forwarded-Encrypted: i=1; AJvYcCU9ugpbRpLjCmMAHrvKSWCB5kaq5eLulcABYY68Z2fx6Iu+u2g2sA6CeIq9Q1vFs0k3t8nMzgGDT0f+Vg4=@vger.kernel.org X-Gm-Message-State: AOJu0YyS1lqD9/qFoNJdKxLvr6rmRYMUES+LpfyzNOGwKDcNeP6B702y h7QH74uGfPUuSfMdj2Vl9qxH0JyVgds682sQTDR7Vn2bVCSCqEUGIzHq X-Gm-Gg: ATEYQzzngRm6Q3tGZe2vxlxP+/h1dr5V7hEgDh/V9MM7467xtlqHrxGhKDCnkcA+JTC pF96rseiOtHiUiRI0c0GcoE74Enq3zaTPfFK72Sw6Y7gCnnxKajWR4IdGcLs1QuJ/ip6P1euOxV c8I6VpoB29IWZOS1sFINn3BKP27ShYhldPbyr3v6xkVntJvnC63Yo+Ls0Kwrw9y+9gZH8/LMVyB rrpwVAnS4XpzbYXcC2ExHxrlSwFN8B44ZGLuB1fZUMMPsJP+oLP/dyOYPpiPS2Vb95Q+H9+Cajj YujdhDiRqMd4aTwhrbIS2TNNZlvaImcOKonlmRGtQ3Jon6qgoB2/uwqsjd3f8rGxDbir6I0dFJJ VGxG2iLxu4/4OCqZWuSbTePrWkMSNSXFHEoYX+voB6tzG7Otcskpi6YtxKy1JkcygUgbAx0Ndv8 Lxut7LQ1IsK7lJZfgY3jSDwGRwsKAT8vzPxSQy6MN8amzO8QlRdnSwVvtjTDdAThhYcm5DkBfO8 eMOISV+zz8ZLEp+ X-Received: by 2002:a17:90b:288d:b0:345:badf:f1b7 with SMTP id 98e67ed59e1d1-359a6a6423emr556197a91.28.1772595263344; Tue, 03 Mar 2026 19:34:23 -0800 (PST) Received: from tower (c-73-37-64-97.hsd1.or.comcast.net. [73.37.64.97]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3599c3acea3sm3814047a91.16.2026.03.03.19.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 19:34:22 -0800 (PST) From: Mark Adamenko To: linux-usb@vger.kernel.org Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Mark Adamenko Subject: [PATCH] usb: core: remove unnecessary goto in usb_create_newid_files() Date: Tue, 3 Mar 2026 19:34:18 -0800 Message-ID: <20260304033418.49357-1-marusik.adamenko@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The goto to 'exit' only returns the already initialized variable 'error', which would be 0. At that point it could not yet be anything else. Replacing with an early return 0 removes the need for the label entirely. Signed-off-by: Mark Adamenko --- drivers/usb/core/driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c index 2574e65bc640..571b7d78e814 100644 --- a/drivers/usb/core/driver.c +++ b/drivers/usb/core/driver.c @@ -186,7 +186,7 @@ static int usb_create_newid_files(struct usb_driver *us= b_drv) int error =3D 0; =20 if (usb_drv->no_dynamic_id) - goto exit; + return error; =20 if (usb_drv->probe !=3D NULL) { error =3D driver_create_file(&usb_drv->driver, @@ -199,8 +199,6 @@ static int usb_create_newid_files(struct usb_driver *us= b_drv) &driver_attr_new_id); } } -exit: - return error; } =20 static void usb_remove_newid_files(struct usb_driver *usb_drv) --=20 2.53.0