From nobody Fri Apr 17 09:22:29 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8F2F18FDBD for ; Wed, 4 Mar 2026 12:47:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772628468; cv=none; b=G1ShMHJjL0xUXCTryAuq2hlMLrnCGHXpuG/rooyDrsxb48pR3x+YinM3quLXQVIhlBid9HvpfP6PiU4B262noZYvixYnK4quxya588NXR7q2qGczXGMaRLQ3uyhFmaU/0JmM/kzHGE00TO2Dd8vKft3ODBS92lViBbhg7E9aS1M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772628468; c=relaxed/simple; bh=I4vOzBPfyRSgU37i3aopPtXd8O/uvXcLF9y6LnFAAr8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tRKQQr8MOpbqkHWzp/9jzzYxHrBSqFB4VYbrvKjJUSJBU5WKlE0FdQjh1hKlEvizVYnV6lsQ2KIKQBZ/poN55r4kS352EExFcEZPwcTQOMA9drThLxEVHPaQidf4h4m3k+wudxxnJhpxWcTF9T7wLCTh5A19ve3H954WhczbXM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JB+hiRac; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JB+hiRac" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-35980423087so1909913a91.3 for ; Wed, 04 Mar 2026 04:47:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772628467; x=1773233267; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tH0w/azYrKeQPVCZ1zt90CBX6B2rnF1FZuHhCMgUyjQ=; b=JB+hiRacDbzsZbe5rAi5HzMOUoPScV5gZfK0T5aj163OOqFOAvZDwd96cvdeljSP/V eY+OFp2imE0RJaH096Mi3XqumtsHaCkONi4nKmRcw2jGO4A+P+nHoFirynhYjZbFSWin FyP9MUr3M9XdX1RcCXP06kVZmg0QnVqfS6kC11CbqSH1EAMgjGNYYTdYrHw1i14ucnDc uwMMwfVAtLbK80bmir8LoTasJwCzrBLlFp8O18fCbflUhbGpEhTzWmd6ylAstzyBmiPK NPiLRuHqVM/s3GuiilKlqs3wwuqBjDLqbvwVeZoZXObJ28gXNmbkmy1NZpTxKYEZ9ai6 TUWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772628467; x=1773233267; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tH0w/azYrKeQPVCZ1zt90CBX6B2rnF1FZuHhCMgUyjQ=; b=CIUzXSSYDFMhVLDOKfokMtN/AfCU8rThK93HN5x/IVuzlEvWZWIB1lO6FvXK1XPgno zrTERaFq5pFuxQruBtegj4EN4AxryUrRlzT1bOPf5JYx55Lo/J2GuuQ77MH2PA3YmXvl RcrRSisRN1e7SBD87JIK/POW14MCvt6GP+zVWQtwQaEwPukLnw1WA827VqkwiGXHvDVM Nm028Mznqk1aajsnsnmERGRAlY4nynULx5JQB8xrd4o6smU9ZTMfsFZT9scFUS+229oK u+oxlqZcuTjRT9NHA34nDt4qCSLM2JwAPNOKxTBLAMZ611ALGcxHAXM6x/3fsKrRSSOh zd6A== X-Forwarded-Encrypted: i=1; AJvYcCV9tNmxTNek5igSJLQmICY7Vox2GZcsUD32vspfqA3GKLIf2pxrPKgQlPwmuReRoRdKywcEdmH0m5tXJRg=@vger.kernel.org X-Gm-Message-State: AOJu0YxXew9GJ6wItb9cfxaOnt93O3Hbc2fdYgJKkJ6fNI/ifZRdwVvv 7r/8qbWzsR87CHMfNvvJpwW2bEAW+WtoJ84VmPBE19WnlnA8Xsa4zM4G X-Gm-Gg: ATEYQzxs7/F4zADg11VIuQnHN+1rvXBq8A0SHN0BADGf79sUkxsgaRIt59JmtK7qj6J 3hRuRf/K5wwmeLvPNPUnCeWyjSsXnOQuw/7iGKGzjO9939Jw0WbwiWn8BgzqcZXRzISxlwk2cj9 lss5s4nlXLYxFS8x/gwRBu5sTduFZs0CSiK9voDk2RpSV0SDoPF4Ect6QCf+C5Wy1VV9DfO9Enq pPXSVd3yY5L1n5iPXxpZ2MVvk1atNRQHC3NUypIoJ9bwZP5N5JOXssW+dw5ZBO5kRUdUEPdAl2o ertTpDHl85k80aLcdG9SksSa/gfNxCrLkzs67H4Uj1eTkr/nG5+hqkwfA8oKJP9ec11Oz3rujNh bNNwHFwrB3fus3AcjzFvkXrtTzPtPykYIrFzMWRFvb1JMMy7b2WnRhce4R1jcF6sa/KG60V60qp 26dbFTRlbnDgwMeVtRuMyw/lOTYX5EBLLVCvr6 X-Received: by 2002:a17:90b:4b0b:b0:341:6164:c27d with SMTP id 98e67ed59e1d1-359a69a9621mr1926831a91.3.1772628466940; Wed, 04 Mar 2026 04:47:46 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9009:3f2:c48d:9c04:d04e:c13a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3599c4c0625sm5000450a91.13.2026.03.04.04.47.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 04:47:46 -0800 (PST) From: Felix Gu Date: Wed, 04 Mar 2026 20:47:20 +0800 Subject: [PATCH v2 2/3] spi: nxp-fspi: Use reinit_completion() for repeated operations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260304-spi-nxp-v2-2-cd7d7726a27e@gmail.com> References: <20260304-spi-nxp-v2-0-cd7d7726a27e@gmail.com> In-Reply-To: <20260304-spi-nxp-v2-0-cd7d7726a27e@gmail.com> To: Han Xu , Haibo Chen , Mark Brown , Frank Li , Yogesh Gaur , Yogesh Narayan Gaur , Boris Brezillon , Frieder Schrempf Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1772628443; l=1518; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=I4vOzBPfyRSgU37i3aopPtXd8O/uvXcLF9y6LnFAAr8=; b=+d38z2mcF5Zfsco/fBNqzjJQTm1HzU5pjmt2nyVbqbt58+MfVPZ6k2e7b+nSvIsSE44r17bZb Ff7Z2kvb1uZDFhgUbIYroXvqGEJXEHeLroYd5j1pY8Eco6ed7Inrp1l X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The driver currently calls init_completion() during every spi_mem_op. Tchnically it may work, but it's not the recommended pattern. According to the kernel documentation: Calling init_completion() on the same completion object twice is most likely a bug as it re-initializes the queue to an empty queue and enqueued tasks could get "lost" - use reinit_completion() in that case, but be aware of other races. So moves the initial initialization to probe function and uses reinit_completion() for subsequent operations. Fixes: a5356aef6a90 ("spi: spi-mem: Add driver for NXP FlexSPI controller") Signed-off-by: Felix Gu --- drivers/spi/spi-nxp-fspi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index 320b3d93df57..1e36ae084dd8 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -996,7 +996,7 @@ static int nxp_fspi_do_op(struct nxp_fspi *f, const str= uct spi_mem_op *op) reg =3D reg | FSPI_IPRXFCR_CLR; fspi_writel(f, reg, base + FSPI_IPRXFCR); =20 - init_completion(&f->c); + reinit_completion(&f->c); =20 fspi_writel(f, op->addr.val, base + FSPI_IPCR0); /* @@ -1365,6 +1365,7 @@ static int nxp_fspi_probe(struct platform_device *pde= v) if (ret < 0) return dev_err_probe(dev, ret, "Failed to disable clock"); =20 + init_completion(&f->c); ret =3D devm_request_irq(dev, irq, nxp_fspi_irq_handler, 0, pdev->name, f); if (ret) --=20 2.43.0