From nobody Wed Apr 15 23:37:47 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D779C3B8D4A; Wed, 4 Mar 2026 14:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772636152; cv=pass; b=txOFdrZZo4ZLAlRpNURp2Zio5oEjR/y0FcNRj31VWT+OezNXIsaHfnQiTOwwYSyY62nAVfCWRxKMQaX+aVB0l5We3f+Zx2Ffkm151sowNClAePBXCwI3G1jpbDUx/4G9TvOPDvzSJ7LmtQR1FsISEtx+dz0yKVEz0dfHvi1SMHo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772636152; c=relaxed/simple; bh=3sdJ8Inl96te4tlpaOox2ZvL1mqgSf+fpGhMrDws1WA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uamQ+/mIgFZluHagZxKHKzzfw+Hc7y+F0AtVqY7a8OUInEXSjHvQUHPWlTC5sjY72w4392mqNNnqe/ntc6Id/EsmPjzfbHNc92HyB1wTml9yjQs2+7Pt3le0ntBLlOhT3dCy70PfefvKQCCPtTHw2JfxLvVdq0MefhvlrRq5Ik8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=QWpoKgiM; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="QWpoKgiM" ARC-Seal: i=1; a=rsa-sha256; t=1772636120; cv=none; d=zohomail.com; s=zohoarc; b=H5vHLo+wjN9eQ6bUhbPaMw6/r3093kPjNR8+edIEXNDh6yALiBehEoV/DiLaXmfD7p37g88fyDxXMhq2kTn06Kn/2YRcJ03f/MeZ75XLP+cLOpQE9ZKFHHPDmE/HJRrRu0XvD/2a1QP6bxQHTjiJoZbA8Lf9qBbYwmAmq6BOVq4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772636120; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=hsx+CocyBqdf6D/6cx+8FPrIo3A+2D1IPs0Z8LAjm+g=; b=HkDd6rqn4UMhzvUWD+QZKDEdOrzSJ+0chLWo/38NlN41PFTlM64LSzcJj2qAZeAbfefBxhL1mKvZMea0q5lUiClyfx1h01RpGP/hpnURo13EQv+7YthatLE3P7Er3ci85S/VoaGdvcwVW6z0o5xOYG/9RRWdE9qYFN9NJjJ+kTk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1772636120; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=hsx+CocyBqdf6D/6cx+8FPrIo3A+2D1IPs0Z8LAjm+g=; b=QWpoKgiMmdgDEk5KI5JSdCc+kJhQ/Tg0NkoWHS/SeDDEw0K3uDBs457yFZccj64R eF1O6Xej2jZuKEQ5xjtXGg6A524Cu3t1vgU57e3wuXYmQL+vHwlMC5/cXoZHl5IYEtw +3w8D3QN976m9ObHoo8ZEXAMNA/639EiHJJSGFHU= Received: by mx.zohomail.com with SMTPS id 1772636119779465.1226935811138; Wed, 4 Mar 2026 06:55:19 -0800 (PST) From: Nicolas Frattaroli Date: Wed, 04 Mar 2026 15:53:25 +0100 Subject: [PATCH v8 20/23] scsi: ufs: mediatek: Back up idle timer in per-instance struct Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260304-mt8196-ufs-v8-20-5b0eac23314f@collabora.com> References: <20260304-mt8196-ufs-v8-0-5b0eac23314f@collabora.com> In-Reply-To: <20260304-mt8196-ufs-v8-0-5b0eac23314f@collabora.com> To: Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Peter Wang , Stanley Jhu , "James E.J. Bottomley" , "Martin K. Petersen" , Philipp Zabel , Liam Girdwood , Mark Brown , Chaotian Jing , Neil Armstrong Cc: Louis-Alexis Eyraud , kernel@collabora.com, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 The MediaTek UFS driver uses a function-scope static variable to back up a hardware register across a power change in the ufs_mtk_pwr_change_notify function. This is dangerous, as it's only correct if only ever one instance of the driver is loaded, which isn't true if there's more than one device on a SoC that needs it, or it otherwise gets loaded a second time. Back it up into a member of the host struct instead, as this struct is per-instance. Rework the function to not use a pointless "ret" local as well. Fixes: f5ca8d0c7a63 ("scsi: ufs: host: mediatek: Disable auto-hibern8 durin= g power mode changes") Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Nicolas Frattaroli --- drivers/ufs/host/ufs-mediatek.c | 20 ++++++++------------ drivers/ufs/host/ufs-mediatek.h | 1 + 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediate= k.c index c4e70fb99e82..cb105b9afc24 100644 --- a/drivers/ufs/host/ufs-mediatek.c +++ b/drivers/ufs/host/ufs-mediatek.c @@ -1398,28 +1398,24 @@ static int ufs_mtk_pwr_change_notify(struct ufs_hba= *hba, const struct ufs_pa_layer_attr *dev_max_params, struct ufs_pa_layer_attr *dev_req_params) { - int ret =3D 0; - static u32 reg; + struct ufs_mtk_host *host =3D ufshcd_get_variant(hba); =20 switch (stage) { case PRE_CHANGE: if (ufshcd_is_auto_hibern8_supported(hba)) { - reg =3D ufshcd_readl(hba, REG_AUTO_HIBERNATE_IDLE_TIMER); + host->hibernate_idle_timer =3D ufshcd_readl( + hba, REG_AUTO_HIBERNATE_IDLE_TIMER); ufs_mtk_auto_hibern8_disable(hba); } - ret =3D ufs_mtk_pre_pwr_change(hba, dev_max_params, - dev_req_params); - break; + return ufs_mtk_pre_pwr_change(hba, dev_max_params, dev_req_params); case POST_CHANGE: if (ufshcd_is_auto_hibern8_supported(hba)) - ufshcd_writel(hba, reg, REG_AUTO_HIBERNATE_IDLE_TIMER); - break; - default: - ret =3D -EINVAL; - break; + ufshcd_writel(hba, host->hibernate_idle_timer, + REG_AUTO_HIBERNATE_IDLE_TIMER); + return 0; } =20 - return ret; + return -EINVAL; } =20 static int ufs_mtk_unipro_set_lpm(struct ufs_hba *hba, bool lpm) diff --git a/drivers/ufs/host/ufs-mediatek.h b/drivers/ufs/host/ufs-mediate= k.h index fa27ab4d6d6c..e5a3f70e7024 100644 --- a/drivers/ufs/host/ufs-mediatek.h +++ b/drivers/ufs/host/ufs-mediatek.h @@ -187,6 +187,7 @@ struct ufs_mtk_host { u16 ref_clk_gating_wait_us; u32 ip_ver; bool legacy_ip_ver; + u32 hibernate_idle_timer; =20 bool mcq_set_intr; bool is_mcq_intr_enabled; --=20 2.53.0