From nobody Fri Apr 10 04:21:42 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3559344DB6; Wed, 4 Mar 2026 15:26:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772637975; cv=none; b=K7n+/cA7M6Z07EIC2/tydTL9EpsbanCWwF0RkztIMf8FsVrMcbu2cHbni6fp+BAwwhdFOKwU2eI3shD05x83TE/0U8Rc3vQqmOhLlEJJlV9OqyId3lknGZFB0jw7G6aWt67vsDbyXz3YQ7GpmrKNizQKHUD3+78hW/T4MdlMcpk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772637975; c=relaxed/simple; bh=SGp8w+BficYHO7a2Mudr7CsHQw+9zgg5XylVp0D6w9M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cZmhPKwqf2MMC/7mDJdR45J8qyO/nMmju+6osylgy5tgNJp595SEiiMYaseV+htO/up9VUB6RL+2ml8e6EylJ+leRTuIDGD3Lo+5rp1eq3L3VxUzGzFFcOceqjI7ooQSnfJ+cbAcykYGjn4vlkhZ470oAWC/qRRGIEC87vaEPjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=27ZQJdit; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="27ZQJdit" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 9850AC143ED; Wed, 4 Mar 2026 15:26:30 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 6F7EA5FF5C; Wed, 4 Mar 2026 15:26:12 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E2D68103697AE; Wed, 4 Mar 2026 16:26:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1772637971; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=dXTSa7BaT59UEneJorn5bp8FmJZ+icUDt/kGdiKrt48=; b=27ZQJditsQPnSlpvnD+SRTNqOYpXgaqWRiCDHeBzHp7mM3JyjVRsKbTG5THB1HSHae4X0s FHndPQV+U1uRU9iIOzotflCBAyollqYyGIiH0IDEIHMDJEDbqof4NZHviUx1g2lWYr21N6 91pOKqEBTF3ftoMzuU0CL11suhfOA3gpHL0boJftiPrGOdfyFpXgrCj6kpOlkhRIu1Cjdy 8Vylmkk9zcK/kQ98cwSpBcMuKYmNVXHcDFFfNpOC+8zBXNaA4FJxOa/Zx0meIyFzJz3Y6q GrDyoVTop0ZSaXiQoftqpTbXrL8Eo/yObXwchqj4e+MsZswKo+TKSm/zj2PTwA== From: =?utf-8?q?Beno=C3=AEt_Monin?= Date: Wed, 04 Mar 2026 16:25:21 +0100 Subject: [PATCH v4 07/10] clk: eyeq: Convert clocks declaration to eqc_clock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260304-clk-eyeq7-v4-7-9d6bd9d24bec@bootlin.com> References: <20260304-clk-eyeq7-v4-0-9d6bd9d24bec@bootlin.com> In-Reply-To: <20260304-clk-eyeq7-v4-0-9d6bd9d24bec@bootlin.com> To: Vladimir Kondratiev , Gregory CLEMENT , =?utf-8?q?Th=C3=A9o_Lebrun?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti Cc: Thomas Petazzoni , Tawfik Bayouk , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-mips@vger.kernel.org, =?utf-8?q?Beno=C3=AEt_Monin?= X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 Convert all declarations of PLLs, dividers, and fixed factors to struct eqc_clock for the EyeQ5, EyeQ6H, EyeQ6L, and EyeQ6Lplus, both for the match data used during probe and the early match data used in early initialization. Tested on the EyeQ5, EyeQ6H and EyeQ6Lplus evaluation boards. For the EyeQ6Lplus and EyeQ6H, the clock tree is unchanged. For the EyeQ5, this change allows us to set the parent of some probed dividers and fixed factors by name as they refer to clocks registered in early init. While these clocks were previously orphaned, they were not yet used by a peripheral. Signed-off-by: Beno=C3=AEt Monin --- drivers/clk/clk-eyeq.c | 354 +++++++++++++++++++--------------------------= ---- 1 file changed, 135 insertions(+), 219 deletions(-) diff --git a/drivers/clk/clk-eyeq.c b/drivers/clk/clk-eyeq.c index 623b1d3f041d..7f9f4f68366e 100644 --- a/drivers/clk/clk-eyeq.c +++ b/drivers/clk/clk-eyeq.c @@ -572,23 +572,6 @@ static int eqc_probe(struct platform_device *pdev) .pll.reg =3D _reg, \ } =20 -/* Required early for GIC timer (pll-cpu) and UARTs (pll-per). */ -static const struct eqc_pll eqc_eyeq5_early_plls[] =3D { - { .index =3D EQ5C_PLL_CPU, .name =3D "pll-cpu", .reg64 =3D 0x02C }, - { .index =3D EQ5C_PLL_PER, .name =3D "pll-per", .reg64 =3D 0x05C }, -}; - -static const struct eqc_pll eqc_eyeq5_plls[] =3D { - { .index =3D EQ5C_PLL_VMP, .name =3D "pll-vmp", .reg64 =3D 0x034 }, - { .index =3D EQ5C_PLL_PMA, .name =3D "pll-pma", .reg64 =3D 0x03C }, - { .index =3D EQ5C_PLL_VDI, .name =3D "pll-vdi", .reg64 =3D 0x044 }, - { .index =3D EQ5C_PLL_DDR0, .name =3D "pll-ddr0", .reg64 =3D 0x04C }, - { .index =3D EQ5C_PLL_PCI, .name =3D "pll-pci", .reg64 =3D 0x054 }, - { .index =3D EQ5C_PLL_PMAC, .name =3D "pll-pmac", .reg64 =3D 0x064 }, - { .index =3D EQ5C_PLL_MPC, .name =3D "pll-mpc", .reg64 =3D 0x06C }, - { .index =3D EQ5C_PLL_DDR1, .name =3D "pll-ddr1", .reg64 =3D 0x074 }, -}; - enum { /* * EQ5C_PLL_CPU children. @@ -626,263 +609,206 @@ enum { EQ5C_PER_FCMU_A, }; =20 -static const struct eqc_fixed_factor eqc_eyeq5_early_fixed_factors[] =3D { - /* EQ5C_PLL_CPU children */ - { EQ5C_CPU_OCC, "occ-cpu", 1, 1, EQ5C_PLL_CPU }, - { EQ5C_CPU_SI_CSS0, "si-css0", 1, 1, EQ5C_CPU_OCC }, - { EQ5C_CPU_CORE0, "core0", 1, 1, EQ5C_CPU_SI_CSS0 }, - { EQ5C_CPU_CORE1, "core1", 1, 1, EQ5C_CPU_SI_CSS0 }, - { EQ5C_CPU_CORE2, "core2", 1, 1, EQ5C_CPU_SI_CSS0 }, - { EQ5C_CPU_CORE3, "core3", 1, 1, EQ5C_CPU_SI_CSS0 }, +/* Required early for GIC timer (pll-cpu) and UARTs (pll-per). */ +static const struct eqc_clock eqc_eyeq5_early_clks[] =3D { + PLL_FRACG(EQ5C_PLL_CPU, PARENT_BY_FWNAME, "pll-cpu", "ref", 0x02C), + PLL_FRACG(EQ5C_PLL_PER, PARENT_BY_FWNAME, "pll-per", "ref", 0x05C), =20 - /* EQ5C_PLL_PER children */ - { EQ5C_PER_OCC, "occ-periph", 1, 16, EQ5C_PLL_PER }, - { EQ5C_PER_UART, "uart", 1, 1, EQ5C_PER_OCC }, + FF(EQ5C_CPU_OCC, EQ5C_PLL_CPU, "occ-cpu", NULL, 1, 1), + FF(EQ5C_CPU_SI_CSS0, EQ5C_CPU_OCC, "si-css0", NULL, 1, 1), + FF(EQ5C_CPU_CORE0, EQ5C_CPU_SI_CSS0, "core0", NULL, 1, 1), + FF(EQ5C_CPU_CORE1, EQ5C_CPU_SI_CSS0, "core1", NULL, 1, 1), + FF(EQ5C_CPU_CORE2, EQ5C_CPU_SI_CSS0, "core2", NULL, 1, 1), + FF(EQ5C_CPU_CORE3, EQ5C_CPU_SI_CSS0, "core3", NULL, 1, 1), + + FF(EQ5C_PER_OCC, EQ5C_PLL_PER, "occ-periph", NULL, 1, 16), + FF(EQ5C_PER_UART, EQ5C_PER_OCC, "uart", NULL, 1, 1), }; =20 -static const struct eqc_fixed_factor eqc_eyeq5_fixed_factors[] =3D { - /* EQ5C_PLL_CPU children */ - { EQ5C_CPU_CPC, "cpc", 1, 1, EQ5C_CPU_SI_CSS0 }, - { EQ5C_CPU_CM, "cm", 1, 1, EQ5C_CPU_SI_CSS0 }, - { EQ5C_CPU_MEM, "mem", 1, 1, EQ5C_CPU_SI_CSS0 }, - { EQ5C_CPU_OCC_ISRAM, "occ-isram", 1, 2, EQ5C_PLL_CPU }, - { EQ5C_CPU_ISRAM, "isram", 1, 1, EQ5C_CPU_OCC_ISRAM }, - { EQ5C_CPU_OCC_DBU, "occ-dbu", 1, 10, EQ5C_PLL_CPU }, - { EQ5C_CPU_SI_DBU_TP, "si-dbu-tp", 1, 1, EQ5C_CPU_OCC_DBU }, +static const struct eqc_clock eqc_eyeq5_clks[] =3D { + PLL_FRACG(EQ5C_PLL_VMP, PARENT_BY_FWNAME, "pll-vmp", "ref", 0x034), + PLL_FRACG(EQ5C_PLL_PMA, PARENT_BY_FWNAME, "pll-pma", "ref", 0x03C), + PLL_FRACG(EQ5C_PLL_VDI, PARENT_BY_FWNAME, "pll-vdi", "ref", 0x044), + PLL_FRACG(EQ5C_PLL_DDR0, PARENT_BY_FWNAME, "pll-ddr0", "ref", 0x04C), + PLL_FRACG(EQ5C_PLL_PCI, PARENT_BY_FWNAME, "pll-pci", "ref", 0x054), + PLL_FRACG(EQ5C_PLL_PMAC, PARENT_BY_FWNAME, "pll-pmac", "ref", 0x064), + PLL_FRACG(EQ5C_PLL_MPC, PARENT_BY_FWNAME, "pll-mpc", "ref", 0x06C), + PLL_FRACG(EQ5C_PLL_DDR1, PARENT_BY_FWNAME, "pll-ddr1", "ref", 0x074), =20 - /* EQ5C_PLL_VDI children */ - { EQ5C_VDI_OCC_VDI, "occ-vdi", 1, 2, EQ5C_PLL_VDI }, - { EQ5C_VDI_VDI, "vdi", 1, 1, EQ5C_VDI_OCC_VDI }, - { EQ5C_VDI_OCC_CAN_SER, "occ-can-ser", 1, 16, EQ5C_PLL_VDI }, - { EQ5C_VDI_CAN_SER, "can-ser", 1, 1, EQ5C_VDI_OCC_CAN_SER }, - { EQ5C_VDI_I2C_SER, "i2c-ser", 1, 20, EQ5C_PLL_VDI }, + DIV(EQ5C_DIV_OSPI, PARENT_BY_NAME, "div-ospi", "pll-per", 0x11C, 0, 4, NU= LL), =20 - /* EQ5C_PLL_PER children */ - { EQ5C_PER_PERIPH, "periph", 1, 1, EQ5C_PER_OCC }, - { EQ5C_PER_CAN, "can", 1, 1, EQ5C_PER_OCC }, - { EQ5C_PER_SPI, "spi", 1, 1, EQ5C_PER_OCC }, - { EQ5C_PER_I2C, "i2c", 1, 1, EQ5C_PER_OCC }, - { EQ5C_PER_TIMER, "timer", 1, 1, EQ5C_PER_OCC }, - { EQ5C_PER_GPIO, "gpio", 1, 1, EQ5C_PER_OCC }, - { EQ5C_PER_EMMC, "emmc-sys", 1, 10, EQ5C_PLL_PER }, - { EQ5C_PER_CCF, "ccf-ctrl", 1, 4, EQ5C_PLL_PER }, - { EQ5C_PER_OCC_MJPEG, "occ-mjpeg", 1, 2, EQ5C_PLL_PER }, - { EQ5C_PER_HSM, "hsm", 1, 1, EQ5C_PER_OCC_MJPEG }, - { EQ5C_PER_MJPEG, "mjpeg", 1, 1, EQ5C_PER_OCC_MJPEG }, - { EQ5C_PER_FCMU_A, "fcmu-a", 1, 20, EQ5C_PLL_PER }, - { EQ5C_PER_OCC_PCI, "occ-pci-sys", 1, 8, EQ5C_PLL_PER }, -}; + FF(EQ5C_CPU_CPC, PARENT_BY_NAME, "cpc", "si-css0", 1, 1), + FF(EQ5C_CPU_CM, PARENT_BY_NAME, "cm", "si-css0", 1, 1), + FF(EQ5C_CPU_MEM, PARENT_BY_NAME, "mem", "si-css0", 1, 1), + FF(EQ5C_CPU_OCC_ISRAM, PARENT_BY_NAME, "occ-isram", "pll-cpu", 1, 2), + FF(EQ5C_CPU_ISRAM, EQ5C_CPU_OCC_ISRAM, "isram", NULL, 1, 1), + FF(EQ5C_CPU_OCC_DBU, PARENT_BY_NAME, "occ-dbu", "pll-cpu", 1, 10), + FF(EQ5C_CPU_SI_DBU_TP, EQ5C_CPU_OCC_DBU, "si-dbu-tp", NULL, 1, 1), =20 -static const struct eqc_div eqc_eyeq5_divs[] =3D { - { - .index =3D EQ5C_DIV_OSPI, - .name =3D "div-ospi", - .parent =3D EQ5C_PLL_PER, - .reg =3D 0x11C, - .shift =3D 0, - .width =3D 4, - }, + FF(EQ5C_VDI_OCC_VDI, PARENT_BY_NAME, "occ-vdi", "pll-vdi", 1, 2), + FF(EQ5C_VDI_VDI, EQ5C_VDI_OCC_VDI, "vdi", NULL, 1, 1), + FF(EQ5C_VDI_OCC_CAN_SER, PARENT_BY_NAME, "occ-can-ser", "pll-vdi", 1, 16), + FF(EQ5C_VDI_CAN_SER, EQ5C_VDI_OCC_CAN_SER, "can-ser", NULL, 1, 1), + FF(EQ5C_VDI_I2C_SER, PARENT_BY_NAME, "i2c-ser", "pll-vdi", 1, 20), + + FF(EQ5C_PER_PERIPH, PARENT_BY_NAME, "periph", "occ-periph", 1, 1), + FF(EQ5C_PER_CAN, PARENT_BY_NAME, "can", "occ-periph", 1, 1), + FF(EQ5C_PER_SPI, PARENT_BY_NAME, "spi", "occ-periph", 1, 1), + FF(EQ5C_PER_I2C, PARENT_BY_NAME, "i2c", "occ-periph", 1, 1), + FF(EQ5C_PER_TIMER, PARENT_BY_NAME, "timer", "occ-periph", 1, 1), + FF(EQ5C_PER_GPIO, PARENT_BY_NAME, "gpio", "occ-periph", 1, 1), + FF(EQ5C_PER_EMMC, PARENT_BY_NAME, "emmc-sys", "pll-per", 1, 10), + FF(EQ5C_PER_CCF, PARENT_BY_NAME, "ccf-ctrl", "pll-per", 1, 4), + FF(EQ5C_PER_OCC_MJPEG, PARENT_BY_NAME, "occ-mjpeg", "pll-per", 1, 2), + FF(EQ5C_PER_HSM, EQ5C_PER_OCC_MJPEG, "hsm", NULL, 1, 1), + FF(EQ5C_PER_MJPEG, EQ5C_PER_OCC_MJPEG, "mjpeg", NULL, 1, 1), + FF(EQ5C_PER_FCMU_A, PARENT_BY_NAME, "fcmu-a", "pll-per", 1, 20), + FF(EQ5C_PER_OCC_PCI, PARENT_BY_NAME, "occ-pci-sys", "pll-per", 1, 8), }; =20 static const struct eqc_early_match_data eqc_eyeq5_early_match_data __init= const =3D { - .early_pll_count =3D ARRAY_SIZE(eqc_eyeq5_early_plls), - .early_plls =3D eqc_eyeq5_early_plls, + .early_clk_count =3D ARRAY_SIZE(eqc_eyeq5_early_clks), + .early_clks =3D eqc_eyeq5_early_clks, =20 - .early_fixed_factor_count =3D ARRAY_SIZE(eqc_eyeq5_early_fixed_factors), - .early_fixed_factors =3D eqc_eyeq5_early_fixed_factors, - - .late_clk_count =3D ARRAY_SIZE(eqc_eyeq5_plls) + ARRAY_SIZE(eqc_eyeq5_di= vs) + - ARRAY_SIZE(eqc_eyeq5_fixed_factors), + .late_clk_count =3D ARRAY_SIZE(eqc_eyeq5_clks), }; =20 static const struct eqc_match_data eqc_eyeq5_match_data =3D { - .pll_count =3D ARRAY_SIZE(eqc_eyeq5_plls), - .plls =3D eqc_eyeq5_plls, - - .div_count =3D ARRAY_SIZE(eqc_eyeq5_divs), - .divs =3D eqc_eyeq5_divs, - - .fixed_factor_count =3D ARRAY_SIZE(eqc_eyeq5_fixed_factors), - .fixed_factors =3D eqc_eyeq5_fixed_factors, + .clk_count =3D ARRAY_SIZE(eqc_eyeq5_clks), + .clks =3D eqc_eyeq5_clks, =20 .reset_auxdev_name =3D "reset", .pinctrl_auxdev_name =3D "pinctrl", .eth_phy_auxdev_name =3D "phy", =20 - .early_clk_count =3D ARRAY_SIZE(eqc_eyeq5_early_plls) + - ARRAY_SIZE(eqc_eyeq5_early_fixed_factors), + .early_clk_count =3D ARRAY_SIZE(eqc_eyeq5_early_clks), }; =20 -static const struct eqc_pll eqc_eyeq6l_plls[] =3D { - { .index =3D EQ6LC_PLL_DDR, .name =3D "pll-ddr", .reg64 =3D 0x02C }, - { .index =3D EQ6LC_PLL_CPU, .name =3D "pll-cpu", .reg64 =3D 0x034 }, /* a= lso acc */ - { .index =3D EQ6LC_PLL_PER, .name =3D "pll-per", .reg64 =3D 0x03C }, - { .index =3D EQ6LC_PLL_VDI, .name =3D "pll-vdi", .reg64 =3D 0x044 }, +static const struct eqc_clock eqc_eyeq6l_clks[] =3D { + PLL_FRACG(EQ6LC_PLL_DDR, PARENT_BY_FWNAME, "pll-ddr", "ref", 0x02C), + PLL_FRACG(EQ6LC_PLL_CPU, PARENT_BY_FWNAME, "pll-cpu", "ref", 0x034), + PLL_FRACG(EQ6LC_PLL_PER, PARENT_BY_FWNAME, "pll-per", "ref", 0x03C), + PLL_FRACG(EQ6LC_PLL_VDI, PARENT_BY_FWNAME, "pll-vdi", "ref", 0x044), }; =20 static const struct eqc_match_data eqc_eyeq6l_match_data =3D { - .pll_count =3D ARRAY_SIZE(eqc_eyeq6l_plls), - .plls =3D eqc_eyeq6l_plls, + .clk_count =3D ARRAY_SIZE(eqc_eyeq6l_clks), + .clks =3D eqc_eyeq6l_clks, =20 .reset_auxdev_name =3D "reset", }; =20 -static const struct eqc_pll eqc_eyeq6lplus_early_plls[] =3D { - { .index =3D EQ6LPC_PLL_CPU, .name =3D "pll-cpu", .reg64 =3D 0x058 }, +static const struct eqc_clock eqc_eyeq6lplus_early_clks[] =3D { + PLL_FRACG(EQ6LPC_PLL_CPU, PARENT_BY_FWNAME, "pll-cpu", "ref", 0x058), + + FF(EQ6LPC_CPU_OCC, EQ6LPC_PLL_CPU, "occ-cpu", NULL, 1, 1), }; =20 -static const struct eqc_pll eqc_eyeq6lplus_plls[] =3D { - { .index =3D EQ6LPC_PLL_DDR, .name =3D "pll-ddr", .reg64 =3D 0x02C }, - { .index =3D EQ6LPC_PLL_ACC, .name =3D "pll-acc", .reg64 =3D 0x034 }, - { .index =3D EQ6LPC_PLL_PER, .name =3D "pll-per", .reg64 =3D 0x03C }, - { .index =3D EQ6LPC_PLL_VDI, .name =3D "pll-vdi", .reg64 =3D 0x044 }, -}; +static const struct eqc_clock eqc_eyeq6lplus_clks[] =3D { + PLL_FRACG(EQ6LPC_PLL_DDR, PARENT_BY_FWNAME, "pll-ddr", "ref", 0x02C), + PLL_FRACG(EQ6LPC_PLL_ACC, PARENT_BY_FWNAME, "pll-acc", "ref", 0x034), + PLL_FRACG(EQ6LPC_PLL_PER, PARENT_BY_FWNAME, "pll-per", "ref", 0x03C), + PLL_FRACG(EQ6LPC_PLL_VDI, PARENT_BY_FWNAME, "pll-vdi", "ref", 0x044), =20 -static const struct eqc_fixed_factor eqc_eyeq6lplus_early_fixed_factors[] = =3D { - { EQ6LPC_CPU_OCC, "occ-cpu", 1, 1, EQ6LPC_PLL_CPU }, -}; + FF(EQ6LPC_DDR_OCC, EQ6LPC_PLL_DDR, "occ-ddr", NULL, 1, 1), =20 -static const struct eqc_fixed_factor eqc_eyeq6lplus_fixed_factors[] =3D { - { EQ6LPC_DDR_OCC, "occ-ddr", 1, 1, EQ6LPC_PLL_DDR }, + FF(EQ6LPC_ACC_VDI, EQ6LPC_PLL_ACC, "vdi-div", NULL, 1, 10), + FF(EQ6LPC_ACC_OCC, EQ6LPC_PLL_ACC, "occ-acc", NULL, 1, 1), + FF(EQ6LPC_ACC_FCMU, EQ6LPC_ACC_OCC, "fcmu-a-clk", NULL, 1, 10), =20 - { EQ6LPC_ACC_VDI, "vdi-div", 1, 10, EQ6LPC_PLL_ACC }, - { EQ6LPC_ACC_OCC, "occ-acc", 1, 1, EQ6LPC_PLL_ACC }, - { EQ6LPC_ACC_FCMU, "fcmu-a-clk", 1, 10, EQ6LPC_ACC_OCC }, + FF(EQ6LPC_PER_OCC, EQ6LPC_PLL_PER, "occ-per", NULL, 1, 1), + FF(EQ6LPC_PER_I2C_SER, EQ6LPC_PER_OCC, "i2c-ser-clk", NULL, 1, 10), + FF(EQ6LPC_PER_PCLK, EQ6LPC_PER_OCC, "pclk", NULL, 1, 4), + FF(EQ6LPC_PER_TSU, EQ6LPC_PER_OCC, "tsu-clk", NULL, 1, 8), + FF(EQ6LPC_PER_OSPI, EQ6LPC_PER_OCC, "ospi-ref-clk", NULL, 1, 10), + FF(EQ6LPC_PER_GPIO, EQ6LPC_PER_OCC, "gpio-clk", NULL, 1, 4), + FF(EQ6LPC_PER_TIMER, EQ6LPC_PER_OCC, "timer-clk", NULL, 1, 4), + FF(EQ6LPC_PER_I2C, EQ6LPC_PER_OCC, "i2c-clk", NULL, 1, 4), + FF(EQ6LPC_PER_UART, EQ6LPC_PER_OCC, "uart-clk", NULL, 1, 4), + FF(EQ6LPC_PER_SPI, EQ6LPC_PER_OCC, "spi-clk", NULL, 1, 4), + FF(EQ6LPC_PER_PERIPH, EQ6LPC_PER_OCC, "periph-clk", NULL, 1, 1), =20 - { EQ6LPC_PER_OCC, "occ-per", 1, 1, EQ6LPC_PLL_PER }, - { EQ6LPC_PER_I2C_SER, "i2c-ser-clk", 1, 10, EQ6LPC_PER_OCC }, - { EQ6LPC_PER_PCLK, "pclk", 1, 4, EQ6LPC_PER_OCC }, - { EQ6LPC_PER_TSU, "tsu-clk", 1, 8, EQ6LPC_PER_OCC }, - { EQ6LPC_PER_OSPI, "ospi-ref-clk", 1, 10, EQ6LPC_PER_OCC }, - { EQ6LPC_PER_GPIO, "gpio-clk", 1, 4, EQ6LPC_PER_OCC }, - { EQ6LPC_PER_TIMER, "timer-clk", 1, 4, EQ6LPC_PER_OCC }, - { EQ6LPC_PER_I2C, "i2c-clk", 1, 4, EQ6LPC_PER_OCC }, - { EQ6LPC_PER_UART, "uart-clk", 1, 4, EQ6LPC_PER_OCC }, - { EQ6LPC_PER_SPI, "spi-clk", 1, 4, EQ6LPC_PER_OCC }, - { EQ6LPC_PER_PERIPH, "periph-clk", 1, 1, EQ6LPC_PER_OCC }, - - { EQ6LPC_VDI_OCC, "occ-vdi", 1, 1, EQ6LPC_PLL_VDI }, + FF(EQ6LPC_VDI_OCC, EQ6LPC_PLL_VDI, "occ-vdi", NULL, 1, 1), }; =20 static const struct eqc_early_match_data eqc_eyeq6lplus_early_match_data _= _initconst =3D { - .early_pll_count =3D ARRAY_SIZE(eqc_eyeq6lplus_early_plls), - .early_plls =3D eqc_eyeq6lplus_early_plls, + .early_clk_count =3D ARRAY_SIZE(eqc_eyeq6lplus_early_clks), + .early_clks =3D eqc_eyeq6lplus_early_clks, =20 - .early_fixed_factor_count =3D ARRAY_SIZE(eqc_eyeq6lplus_early_fixed= _factors), - .early_fixed_factors =3D eqc_eyeq6lplus_early_fixed_factors, - - .late_clk_count =3D ARRAY_SIZE(eqc_eyeq6lplus_plls) + - ARRAY_SIZE(eqc_eyeq6lplus_fixed_factors), + .late_clk_count =3D ARRAY_SIZE(eqc_eyeq6lplus_clks), }; =20 static const struct eqc_match_data eqc_eyeq6lplus_match_data =3D { - .pll_count =3D ARRAY_SIZE(eqc_eyeq6lplus_plls), - .plls =3D eqc_eyeq6lplus_plls, - - .fixed_factor_count =3D ARRAY_SIZE(eqc_eyeq6lplus_fixed_factors), - .fixed_factors =3D eqc_eyeq6lplus_fixed_factors, + .clk_count =3D ARRAY_SIZE(eqc_eyeq6lplus_clks), + .clks =3D eqc_eyeq6lplus_clks, =20 .reset_auxdev_name =3D "reset", .pinctrl_auxdev_name =3D "pinctrl", =20 - .early_clk_count =3D ARRAY_SIZE(eqc_eyeq6lplus_early_plls) + - ARRAY_SIZE(eqc_eyeq6lplus_early_fixed_factors), + .early_clk_count =3D ARRAY_SIZE(eqc_eyeq6lplus_early_clks), }; =20 static const struct eqc_match_data eqc_eyeq6h_west_match_data =3D { .reset_auxdev_name =3D "reset_west", }; =20 -static const struct eqc_pll eqc_eyeq6h_east_plls[] =3D { - { .index =3D 0, .name =3D "pll-east", .reg64 =3D 0x074 }, +static const struct eqc_clock eqc_eyeq6h_east_clks[] =3D { + PLL_FRACG(0, PARENT_BY_FWNAME, "pll-east", "ref", 0x074), }; =20 static const struct eqc_match_data eqc_eyeq6h_east_match_data =3D { - .pll_count =3D ARRAY_SIZE(eqc_eyeq6h_east_plls), - .plls =3D eqc_eyeq6h_east_plls, + .clk_count =3D ARRAY_SIZE(eqc_eyeq6h_east_clks), + .clks =3D eqc_eyeq6h_east_clks, =20 .reset_auxdev_name =3D "reset_east", }; =20 -static const struct eqc_pll eqc_eyeq6h_south_plls[] =3D { - { .index =3D EQ6HC_SOUTH_PLL_VDI, .name =3D "pll-vdi", .reg64 =3D 0x000= }, - { .index =3D EQ6HC_SOUTH_PLL_PCIE, .name =3D "pll-pcie", .reg64 =3D 0x008= }, - { .index =3D EQ6HC_SOUTH_PLL_PER, .name =3D "pll-per", .reg64 =3D 0x010= }, - { .index =3D EQ6HC_SOUTH_PLL_ISP, .name =3D "pll-isp", .reg64 =3D 0x018= }, -}; +static const struct eqc_clock eqc_eyeq6h_south_clks[] =3D { + PLL_FRACG(EQ6HC_SOUTH_PLL_VDI, PARENT_BY_FWNAME, "pll-vdi", "ref", 0x000), + PLL_FRACG(EQ6HC_SOUTH_PLL_PCIE, PARENT_BY_FWNAME, "pll-pcie", "ref", 0x00= 8), + PLL_FRACG(EQ6HC_SOUTH_PLL_PER, PARENT_BY_FWNAME, "pll-per", "ref", 0x010), + PLL_FRACG(EQ6HC_SOUTH_PLL_ISP, PARENT_BY_FWNAME, "pll-isp", "ref", 0x018), =20 -static const struct eqc_div eqc_eyeq6h_south_divs[] =3D { - { - .index =3D EQ6HC_SOUTH_DIV_EMMC, - .name =3D "div-emmc", - .parent =3D EQ6HC_SOUTH_PLL_PER, - .reg =3D 0x070, - .shift =3D 4, - .width =3D 4, - }, - { - .index =3D EQ6HC_SOUTH_DIV_OSPI_REF, - .name =3D "div-ospi-ref", - .parent =3D EQ6HC_SOUTH_PLL_PER, - .reg =3D 0x090, - .shift =3D 4, - .width =3D 4, - }, - { - .index =3D EQ6HC_SOUTH_DIV_OSPI_SYS, - .name =3D "div-ospi-sys", - .parent =3D EQ6HC_SOUTH_PLL_PER, - .reg =3D 0x090, - .shift =3D 8, - .width =3D 1, - }, - { - .index =3D EQ6HC_SOUTH_DIV_TSU, - .name =3D "div-tsu", - .parent =3D EQ6HC_SOUTH_PLL_PCIE, - .reg =3D 0x098, - .shift =3D 4, - .width =3D 8, - }, + DIV(EQ6HC_SOUTH_DIV_EMMC, EQ6HC_SOUTH_PLL_PER, "div-emmc", NULL, 0x070, 4= , 4, NULL), + DIV(EQ6HC_SOUTH_DIV_OSPI_REF, EQ6HC_SOUTH_PLL_PER, "div-ospi-ref", NULL, = 0x090, 4, 4, NULL), + DIV(EQ6HC_SOUTH_DIV_OSPI_SYS, EQ6HC_SOUTH_PLL_PER, "div-ospi-sys", NULL, = 0x090, 8, 1, NULL), + DIV(EQ6HC_SOUTH_DIV_TSU, EQ6HC_SOUTH_PLL_PCIE, "div-tsu", NULL, 0x098, 4,= 8, NULL), }; =20 static const struct eqc_match_data eqc_eyeq6h_south_match_data =3D { - .pll_count =3D ARRAY_SIZE(eqc_eyeq6h_south_plls), - .plls =3D eqc_eyeq6h_south_plls, - - .div_count =3D ARRAY_SIZE(eqc_eyeq6h_south_divs), - .divs =3D eqc_eyeq6h_south_divs, + .clk_count =3D ARRAY_SIZE(eqc_eyeq6h_south_clks), + .clks =3D eqc_eyeq6h_south_clks, }; =20 -static const struct eqc_pll eqc_eyeq6h_ddr0_plls[] =3D { - { .index =3D 0, .name =3D "pll-ddr0", .reg64 =3D 0x074 }, +static const struct eqc_clock eqc_eyeq6h_ddr0_clks[] =3D { + PLL_FRACG(0, PARENT_BY_FWNAME, "pll-ddr0", "ref", 0x074), }; =20 static const struct eqc_match_data eqc_eyeq6h_ddr0_match_data =3D { - .pll_count =3D ARRAY_SIZE(eqc_eyeq6h_ddr0_plls), - .plls =3D eqc_eyeq6h_ddr0_plls, + .clk_count =3D ARRAY_SIZE(eqc_eyeq6h_ddr0_clks), + .clks =3D eqc_eyeq6h_ddr0_clks, }; =20 -static const struct eqc_pll eqc_eyeq6h_ddr1_plls[] =3D { - { .index =3D 0, .name =3D "pll-ddr1", .reg64 =3D 0x074 }, +static const struct eqc_clock eqc_eyeq6h_ddr1_clks[] =3D { + PLL_FRACG(0, PARENT_BY_FWNAME, "pll-ddr1", "ref", 0x074), }; =20 static const struct eqc_match_data eqc_eyeq6h_ddr1_match_data =3D { - .pll_count =3D ARRAY_SIZE(eqc_eyeq6h_ddr1_plls), - .plls =3D eqc_eyeq6h_ddr1_plls, + .clk_count =3D ARRAY_SIZE(eqc_eyeq6h_ddr1_clks), + .clks =3D eqc_eyeq6h_ddr1_clks, }; =20 -static const struct eqc_pll eqc_eyeq6h_acc_plls[] =3D { - { .index =3D EQ6HC_ACC_PLL_XNN, .name =3D "pll-xnn", .reg64 =3D 0x040 }, - { .index =3D EQ6HC_ACC_PLL_VMP, .name =3D "pll-vmp", .reg64 =3D 0x050 }, - { .index =3D EQ6HC_ACC_PLL_PMA, .name =3D "pll-pma", .reg64 =3D 0x05C }, - { .index =3D EQ6HC_ACC_PLL_MPC, .name =3D "pll-mpc", .reg64 =3D 0x068 }, - { .index =3D EQ6HC_ACC_PLL_NOC, .name =3D "pll-noc", .reg64 =3D 0x070 }, +static const struct eqc_clock eqc_eyeq6h_acc_clks[] =3D { + PLL_FRACG(EQ6HC_ACC_PLL_XNN, PARENT_BY_FWNAME, "pll-xnn", "ref", 0x040), + PLL_FRACG(EQ6HC_ACC_PLL_VMP, PARENT_BY_FWNAME, "pll-vmp", "ref", 0x050), + PLL_FRACG(EQ6HC_ACC_PLL_PMA, PARENT_BY_FWNAME, "pll-pma", "ref", 0x05C), + PLL_FRACG(EQ6HC_ACC_PLL_MPC, PARENT_BY_FWNAME, "pll-mpc", "ref", 0x068), + PLL_FRACG(EQ6HC_ACC_PLL_NOC, PARENT_BY_FWNAME, "pll-noc", "ref", 0x070), }; =20 static const struct eqc_match_data eqc_eyeq6h_acc_match_data =3D { - .pll_count =3D ARRAY_SIZE(eqc_eyeq6h_acc_plls), - .plls =3D eqc_eyeq6h_acc_plls, + .clk_count =3D ARRAY_SIZE(eqc_eyeq6h_acc_clks), + .clks =3D eqc_eyeq6h_acc_clks, =20 .reset_auxdev_name =3D "reset_acc", }; @@ -911,38 +837,28 @@ static struct platform_driver eqc_driver =3D { builtin_platform_driver(eqc_driver); =20 /* Required early for GIC timer. */ -static const struct eqc_pll eqc_eyeq6h_central_early_plls[] =3D { - { .index =3D EQ6HC_CENTRAL_PLL_CPU, .name =3D "pll-cpu", .reg64 =3D 0x02C= }, -}; +static const struct eqc_clock eqc_eyeq6h_central_early_clks[] =3D { + PLL_FRACG(EQ6HC_CENTRAL_PLL_CPU, PARENT_BY_FWNAME, "pll-cpu", "ref", 0x02= C), =20 -static const struct eqc_fixed_factor eqc_eyeq6h_central_early_fixed_factor= s[] =3D { - { EQ6HC_CENTRAL_CPU_OCC, "occ-cpu", 1, 1, EQ6HC_CENTRAL_PLL_CPU }, + FF(EQ6HC_CENTRAL_CPU_OCC, EQ6HC_CENTRAL_PLL_CPU, "occ-cpu", NULL, 1, 1), }; =20 static const struct eqc_early_match_data eqc_eyeq6h_central_early_match_da= ta __initconst =3D { - .early_pll_count =3D ARRAY_SIZE(eqc_eyeq6h_central_early_plls), - .early_plls =3D eqc_eyeq6h_central_early_plls, - - .early_fixed_factor_count =3D ARRAY_SIZE(eqc_eyeq6h_central_early_fixed_f= actors), - .early_fixed_factors =3D eqc_eyeq6h_central_early_fixed_factors, + .early_clk_count =3D ARRAY_SIZE(eqc_eyeq6h_central_early_clks), + .early_clks =3D eqc_eyeq6h_central_early_clks, }; =20 /* Required early for UART. */ -static const struct eqc_pll eqc_eyeq6h_west_early_plls[] =3D { - { .index =3D EQ6HC_WEST_PLL_PER, .name =3D "pll-west", .reg64 =3D 0x074 }, -}; +static const struct eqc_clock eqc_eyeq6h_west_early_clks[] =3D { + PLL_FRACG(EQ6HC_WEST_PLL_PER, PARENT_BY_FWNAME, "pll-west", "ref", 0x074), =20 -static const struct eqc_fixed_factor eqc_eyeq6h_west_early_fixed_factors[]= =3D { - { EQ6HC_WEST_PER_OCC, "west-per-occ", 1, 10, EQ6HC_WEST_PLL_PER }, - { EQ6HC_WEST_PER_UART, "west-per-uart", 1, 1, EQ6HC_WEST_PER_OCC }, + FF(EQ6HC_WEST_PER_OCC, EQ6HC_WEST_PLL_PER, "west-per-occ", NULL, 1, 10), + FF(EQ6HC_WEST_PER_UART, EQ6HC_WEST_PER_OCC, "west-per-uart", NULL, 1, 1), }; =20 static const struct eqc_early_match_data eqc_eyeq6h_west_early_match_data = __initconst =3D { - .early_pll_count =3D ARRAY_SIZE(eqc_eyeq6h_west_early_plls), - .early_plls =3D eqc_eyeq6h_west_early_plls, - - .early_fixed_factor_count =3D ARRAY_SIZE(eqc_eyeq6h_west_early_fixed_fact= ors), - .early_fixed_factors =3D eqc_eyeq6h_west_early_fixed_factors, + .early_clk_count =3D ARRAY_SIZE(eqc_eyeq6h_west_early_clks), + .early_clks =3D eqc_eyeq6h_west_early_clks, }; =20 static void __init eqc_early_init(struct device_node *np, --=20 2.53.0