From nobody Wed Apr 15 13:22:04 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11022134.outbound.protection.outlook.com [40.93.195.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFDD7492536; Tue, 3 Mar 2026 21:37:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.134 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772573829; cv=fail; b=KegK15ZcqNF82AniVpGPKokB6WT2thlW78UoDIQ9L56+wEUGUPey19GySjqEr5kx0FVS3LiM3wQUnqgQYCAE5mrDYdOiVPY5afDbRgzDdbXm3BTVhvbU4umjtvVVfjdX9GnlHR16/tjkLEymfEPwGd3bNfgldjWBusbYInVqm1o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772573829; c=relaxed/simple; bh=ceV6hjKjYL+5l6kppiEZ4s4V+GjneS1zVroZzcpTalA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=XGRhugTLtbWf7oF/0qAkwWCzR8NIA5cwLOrLvrNFgOnhhuBL6IG4cz67VxCJE4+UPZMjhYmd56Fmod7ewGkks+Il+NWDbSx/kMAgJW1RcTKgsoZZZVx3lj4kCC67ItO+BT0spJNIKE5L9xHf1YiTGDj2vA8wLOQegiOW3TPGygI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=G1ceFZ8W; arc=fail smtp.client-ip=40.93.195.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="G1ceFZ8W" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hIdR9VLLcOWDQhslSLfcDEmER2EkLVIManTJRWrs6YNmvQ5RMpITjl1m5X4Wa0bbzrmEdE/IAMPBuOXXRFVSGmTvF70Jx9M0sJq+kgdFVjdl8Ww5WhC9mI/tENrJaV9C6TjHUH2QCj75A9xuAdwQfbathrxNkln6Q5iIMO3FJveoBtKQxpXZZzvT0w/xZvChC4atj/0xM3irdryztbtZU/cEcyH3yXFBRmLyj2uSy4SCN/CRm64eNXh/mskHBGwB3z+uyEqW6eE9I2SIPvW3zWklfPqrZCi+IgfaTaxAxu6C2cizmMkZCVIDqyQXlbYex3nDvxZej5Shj8Zc7d4nqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qEE6Z4QzDyMA7G8qrCVNDyCVPrrO/TKaY2u57rAHiAQ=; b=TJvj3O7P+CnFI65wFantkTq0oSsDmtluA9I8XBE91yOVXUWAmLywHMq76guEqIx3GYg3IpNTnNETeEc7hMEZQPKf8YVxuyuR3giFADN9hKvsFi2s2odGbZ2Yk0+LIyK7hJXMxybBFjAUytZiz/ur2ifIlKjCfWSeUASzm2QNbq2bhGJP7E4nSbbvtWySyszktKANjtMsAyfMDRn2Fbilj0z6nZPEKI9FCqNyoDubxMmv0jrdLAEz+VHkgnrJsU0dIh3G1kkqtL/7byQ7ONj+si8xWMo0MTanrqUxXV7LLgzyVznoMouLrjIZQiN2yFwq/bBxGYKkHHRnIMGUMe867A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qEE6Z4QzDyMA7G8qrCVNDyCVPrrO/TKaY2u57rAHiAQ=; b=G1ceFZ8WdboIXufrxRq1JXYl/C08OiDef55ZlfmgkHRLHwMyLh643/KjEphYDbi9ghDHZ4IgA4RvC4luG4kStd0uGvTyZ+Dd+cp5iMd68cXpYa32XkQxJIG55R/je7cl9RB/jrc+YG3vto7sk7n0uGFD6pMIVOBUAOePzBbRV3k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from BN3PR01MB9212.prod.exchangelabs.com (2603:10b6:408:2cb::8) by IA1PR01MB9169.prod.exchangelabs.com (2603:10b6:208:592::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.21; Tue, 3 Mar 2026 21:37:01 +0000 Received: from BN3PR01MB9212.prod.exchangelabs.com ([fe80::44f3:1050:dce8:1ea9]) by BN3PR01MB9212.prod.exchangelabs.com ([fe80::44f3:1050:dce8:1ea9%6]) with mapi id 15.20.9654.015; Tue, 3 Mar 2026 21:37:01 +0000 From: Adam Young To: Sudeep Holla , Jassi Brar , "Rafael J. Wysocki" , Len Brown , Robert Moore Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jeremy Kerr , Matt Johnston , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sudeep Holla , Jonathan Cameron , Huisong Li Subject: [net-next v32 1/2] mailbox: pcc: functions for reading and writing PCC extended data Date: Tue, 3 Mar 2026 16:36:45 -0500 Message-ID: <20260303213649.237851-2-admiyo@os.amperecomputing.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260303213649.237851-1-admiyo@os.amperecomputing.com> References: <20260303213649.237851-1-admiyo@os.amperecomputing.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CY5PR17CA0004.namprd17.prod.outlook.com (2603:10b6:930:17::35) To BN3PR01MB9212.prod.exchangelabs.com (2603:10b6:408:2cb::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PR01MB9212:EE_|IA1PR01MB9169:EE_ X-MS-Office365-Filtering-Correlation-Id: ae48492c-4268-4396-a9bd-08de796d00fd X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|10070799003|7416014|52116014|376014; X-Microsoft-Antispam-Message-Info: XTkps2tslMJixCCQqOeDHifAIPa7Jfrbusy0t2Atv3UUGpHI8k4MJSxVQM05/rqsEB0ZuFdEu5y/VcK4cwMe4zXB9D+LsOLkJrEIqX25flGhZCD4i5/a8270JuAi7ktpSi8mMy0IX6sBPCbu3H74Va5iaBOTat6NFp9BAnAV5cAi/tSV8wjPXY1QIG0veANqnP/QuXBbqI9KEUSbyrkBlILKQE3ksdcsuP2p9RcNj+tO8kE7nRDL3VzEu5pmxKpxlNFLfTH9sB1Ghbh9LUe2A0QB0yE52j8iwdL2ot4o2zEL+dzfyMMSTOZWo85O8ZmR81MIMJhOOlZAXTEi932c7bn+xgSlZAe7O5DfHEJ7/qaCdcBN2FE6zWRJe6ovY26BFmHI5bnYiwn8PKjv68phisdigOnYHdsHBlcQm/c4y63m24XuqcwJ7HJmpkoOFWGytJNl3cwjf9c4E5tqr6HgQqmQYEuqjyi9PW4cqustcxCBPkrDUJ3mv2/zO6SMOmt3U5kDy3QRKqST8ZweE4QRaGGiW8muJNepqRlx/O5XDEqGvPn7vLtL/WT+bcdcZc1Tc1fGwcGiBVKZmZJPb2K+4GVFE68UsCqGa/96au2AJ4CIYnqoPRHKN8RXYnsRMmdPDSSCl36tvcLL0e95IhF/CCzMp9mycPR1KyrOtLfYn4aQ5LHY/iI6eyh0hln6Ci9Buq1/Cb93lNGkwSdMfyh2lfnOXHsZVMp1DTeShKggnPw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN3PR01MB9212.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(10070799003)(7416014)(52116014)(376014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E7/WKrWguMtk1SuZ6hWOk1nW/SLuAyP8GmCJySNG3JdS1EPsSoYnBqvvLUWh?= =?us-ascii?Q?bqM08XFLi5+BvMux2ak4x5narCl3b3xNP0ptoNRm4+LXgEB8xOUeB3o6in12?= =?us-ascii?Q?CUsOdDdl8BQkH3HM4OydZoCvYZ7w7GZkWim8d+0dRgSfCzHdQ3n5E0V043Ck?= =?us-ascii?Q?IKB0zCmtolQiDED3Xc8vfjuZQCklcTcPqtpemTE7y3DgyD45BRyIzClZqa3A?= =?us-ascii?Q?4D9ValKSctyWnjyH1g9eCKgAIj3Ay4qkJIAoB/7q/mdlMzTeCU3UZjpbWEHr?= =?us-ascii?Q?2HlHvhgaQd9DlMcKzf6qX+y23SgOv1YA/aiStaK7JiFzU+5ax2RGub2LCxf4?= =?us-ascii?Q?YW+7yiuvCN/BoDIaMEhYqoHNeNnsuZpHOL2I/2odheWOsNPj4LbxOOyvUTaB?= =?us-ascii?Q?Xr4WrgQ1+1DtmaRJLTEJy6UtcYkRvv9po50IdWyGRsBDTsPDfC1hsAOz0/kE?= =?us-ascii?Q?yQs/jGCuftbcRPOlnbbyougYlZt2KhCQHECtJkC/oq60NkmKxl4YWkSc0vr1?= =?us-ascii?Q?uDg3OaXBi4D0cXj0rPyYDlHDcgOXV6qyr4GmpLlkjJkUe89BcO6DZDwY6GZL?= =?us-ascii?Q?L3kQ71luIs7bYcu0CmEaAlUBwr7QNgy0jbJzEi/bu8xCYer81KoLFBz77K8u?= =?us-ascii?Q?QbLaRxdnhG3A+7S0O/+SfvNWrlSzZ9GHdAoiV2pW/dm1hR2ZSxcYK+7fYHak?= =?us-ascii?Q?xT/KiGOAtJCBrSTKZecCfXjOvptp9RyUqMtACDFdYAtsaNyXOOGgEwO6x7M8?= =?us-ascii?Q?7te1HPRSMWIjtUdqrjW7jgjxLRdyEeWTDoRy0wSkwZha9wz1APxp/N/HpTc7?= =?us-ascii?Q?QPLCb4l4DHyMJF7QEJ5VKLIvoVN+nzyAk60Ypg6j6KOJnOl/3wnbO4udECzs?= =?us-ascii?Q?nKJ+dFlADte+Z0oIWEfQrzdLs0C7/b+nzZGvw4XyPOOgdvMRXyJfyB3+3Zzp?= =?us-ascii?Q?iOM7DlaIDDqTkZtdcNYepiya1QdAzeY7JMPD6TNySU30YoVQ9vBLyY1sBEfx?= =?us-ascii?Q?GDCPFa2lQBG11hZLfCA/6mSwXBdDF17nQeamPTUdW9lkeIoU0iD7phG9Ok7q?= =?us-ascii?Q?3N/i/zriCb+jtc8OBDUXpf+lKaS5krS/pGRng6IaFtZA3hf1GxH6WfmWs9L8?= =?us-ascii?Q?71YVIQxH4XctNKQ6vgDd92Y0YXsnm1mXQrfInDnPjQaqIh2gDdNQUyfx83a3?= =?us-ascii?Q?VSqzL1InmeSx6X4ChDVwFx9fxjHvNvYj1RXV3VS8f5ZNp8wGEU+zvHpLKJVI?= =?us-ascii?Q?gWrqsUtVd4V5sNMZCXNUmKHpFGk/oVlC6oZdRd9qUtdbeZps7Z00omfGpouz?= =?us-ascii?Q?9xpqlFNGsivvKoeWnjq+PceI2duiP7r37IBhgIag7F0vzV2GYlWJu+r8Fy8O?= =?us-ascii?Q?vsTs5teZzzF2AMtpxWQuf8NUfylKqTsgOH6cOjwU0GbMA5JE5jgXwBqmGaXW?= =?us-ascii?Q?MTYiAymjiW7eayHmRNkoPVK3XzW++A4efx6BrwFAlJJWEgshLgQ2wSPLPk1c?= =?us-ascii?Q?+wb8JZgg1SVKrzCnugQj9QUR94bxhWgwwMVl5GvSBkh1mvZ08lKdZwNn9XMb?= =?us-ascii?Q?NCFPj1zG/wjFhlqxUksEAaIdb7CJrve1BcNg0eS5X8qL7Wh40MF3j0o+mMAV?= =?us-ascii?Q?0MXTzRTAQTPjSdkmiAscrNr3T+lN7LzJRLQKinyyM9T175cxYqlnXOIMap10?= =?us-ascii?Q?Zs/PyLsSwO/Ij+FCW+uF23tb2F2c1IcYbiHKk9TW2U5dpNqZHuMlS51WGg+1?= =?us-ascii?Q?Fs27FwEvbLIjLAB8X/woQcLaxP57pfW/3SnoDi0rAmOIYq+5mjSKlnSGCF6R?= X-MS-Exchange-AntiSpam-MessageData-1: CKxZ7RhmszdI2hgyY6Mm9zJ1YzbRCnHMDUtJlkinBTXIrafhazmstl8u X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae48492c-4268-4396-a9bd-08de796d00fd X-MS-Exchange-CrossTenant-AuthSource: BN3PR01MB9212.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 21:37:01.0020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BJfU+jaq9yiXNFWhIYE4H1kzj9QHg1SSRAHD51TULzx7YZoJzq5LVhiMGlk9X+Sb7qg/8cjNh0d+8OYi8haqjIM4BZj7j5nX38lDmXAbBKjU/jsx/m8ErqNcusZVEGft X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR01MB9169 Content-Type: text/plain; charset="utf-8" Adds a function that allows a client to query the number of bytes available to read in order to preallocate buffers for reading. Adds a function that reads from the shared buffer into memory provided by the client. Adds a function that writes from client memory into the shared buffer. Signed-off-by: Adam Young --- drivers/mailbox/pcc.c | 86 +++++++++++++++++++++++++++++++++++++++++++ include/acpi/pcc.h | 22 +++++++++++ 2 files changed, 108 insertions(+) diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index 22e70af1ae5d..a8b377a64e05 100644 --- a/drivers/mailbox/pcc.c +++ b/drivers/mailbox/pcc.c @@ -419,6 +419,92 @@ void pcc_mbox_free_channel(struct pcc_mbox_chan *pchan) } EXPORT_SYMBOL_GPL(pcc_mbox_free_channel); =20 +/** + * pcc_mbox_query_bytes_available - count of bytes cwreadable in the share= d buffer + * + * @pchan: pointer to channel associated with buffer + * Return: the number of bytes available to read from the shared buffer + */ +int pcc_mbox_query_bytes_available(struct pcc_mbox_chan *pchan) +{ + struct acpi_pcct_ext_pcc_shared_memory pcc_header; + struct pcc_chan_info *pinfo =3D pchan->mchan->con_priv; + int data_len; + u64 val; + + pcc_chan_reg_read(&pinfo->cmd_complete, &val); + if (val) { + pr_info("%s Buffer not enabled for reading", __func__); + return -1; + } + memcpy_fromio(&pcc_header, pchan->shmem, + sizeof(pcc_header)); + data_len =3D pcc_header.length - sizeof(u32) + sizeof(pcc_header); + return data_len; +} +EXPORT_SYMBOL_GPL(pcc_mbox_query_bytes_available); + +/** + * pcc_mbox_read_from_buffer - Copy bytes from shared buffer into data + * + * @pchan: channel associated with the shared buffer + * @len: number of bytes to read + * @data: pointer to memory in which to write the data from the + * shared buffer + * + * Return: number of bytes read and written into daa + */ +int pcc_mbox_read_from_buffer(struct pcc_mbox_chan *pchan, int len, void *= data) +{ + struct pcc_chan_info *pinfo =3D pchan->mchan->con_priv; + int data_len; + u64 val; + + pcc_chan_reg_read(&pinfo->cmd_complete, &val); + if (val) { + pr_info("%s buffer not enabled for reading", __func__); + return -1; + } + data_len =3D pcc_mbox_query_bytes_available(pchan); + if (len < data_len) + data_len =3D len; + memcpy_fromio(data, pchan->shmem, len); + return len; +} +EXPORT_SYMBOL_GPL(pcc_mbox_read_from_buffer); + +/** + * pcc_mbox_write_to_buffer - copy the contents of the data + * pointer to the shared buffer. Confirms that the command + * flag has been set prior to writing. Data should be a + * properly formatted extended data buffer. + * pcc_mbox_write_to_buffer + * @pchan: channel + * @len: Length of the overall buffer passed in, including the + * Entire header. The length value in the shared buffer header + * Will be calculated from len. + * @data: Client specific data to be written to the shared buffer. + * Return: number of bytes written to the buffer. + */ +int pcc_mbox_write_to_buffer(struct pcc_mbox_chan *pchan, int len, void *d= ata) +{ + struct acpi_pcct_ext_pcc_shared_memory *pcc_header =3D data; + /* + * The PCC header length includes the command field + * but not the other values from the header. + */ + pcc_header->length =3D len - sizeof(struct acpi_pcct_ext_pcc_shared_memor= y) + sizeof(u32); + + if (len > pchan->shmem_size) + return 0; + + memcpy_toio(pchan->shmem, data, len); + + return len; +} +EXPORT_SYMBOL_GPL(pcc_mbox_write_to_buffer); + + /** * pcc_send_data - Called from Mailbox Controller code. Used * here only to ring the channel doorbell. The PCC client diff --git a/include/acpi/pcc.h b/include/acpi/pcc.h index 840bfc95bae3..9be1ae358056 100644 --- a/include/acpi/pcc.h +++ b/include/acpi/pcc.h @@ -37,6 +37,14 @@ struct pcc_mbox_chan { extern struct pcc_mbox_chan * pcc_mbox_request_channel(struct mbox_client *cl, int subspace_id); extern void pcc_mbox_free_channel(struct pcc_mbox_chan *chan); +extern +int pcc_mbox_write_to_buffer(struct pcc_mbox_chan *pchan, int len, void *d= ata); +extern +int pcc_mbox_query_bytes_available(struct pcc_mbox_chan *pchan); +extern +int pcc_mbox_read_from_buffer(struct pcc_mbox_chan *pchan, int len, + void *data); + #else static inline struct pcc_mbox_chan * pcc_mbox_request_channel(struct mbox_client *cl, int subspace_id) @@ -44,6 +52,20 @@ pcc_mbox_request_channel(struct mbox_client *cl, int sub= space_id) return ERR_PTR(-ENODEV); } static inline void pcc_mbox_free_channel(struct pcc_mbox_chan *chan) { } +static inline +int pcc_mbox_write_to_buffer(struct pcc_mbox_chan *pchan, int len, void *d= ata) +{ + return 0; +} +static inline int pcc_mbox_query_bytes_available(struct pcc_mbox_chan *pch= an); +{ + return 0; +} +static inline +int pcc_mbox_read_from_buffer(struct pcc_mbox_chan *pchan, int len, void *= data) +{ + return 0; +} #endif =20 #endif /* _PCC_H */ --=20 2.43.0 From nobody Wed Apr 15 13:22:04 2026 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11020101.outbound.protection.outlook.com [52.101.193.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A004F4DA535; Tue, 3 Mar 2026 21:37:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.101 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772573831; cv=fail; b=Q/DascuywYpft7fRc5Q66E+7zwEMsYVCJbjtvnLAYZpjuh3Zm3O2BFLTM148J7ZQpn9rFWUVRJi6sVZjxDYvvQLMm4eYIULR40pGiZ0qwJZFM1qiCGUn/MW9hZe+lx+ajuSQwlVoVLfjpTkXSBHpPLmBH/Bsn8ag44yt0UKahKA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772573831; c=relaxed/simple; bh=S4jnRYaUiPwgotwBbPyWc9LuGBLOAe39+qTZEI5WQvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=B/2FRoy5dMeRp/EdjOfjFRApHg6JutsLEOUc1xSzfvSS5Qcc/YKocD3wJp9AxYZZDtTYws+EXWGXWKT/+inHGEz/TWWbQGrCNLUyvGPfXM5lC2pVar0rjIoraz+rqnBiD8QVQ9FI0g05W7eFpUM6NqM6sUdaRFLeKwfLSOK5Nb8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=V4aKEUDd; arc=fail smtp.client-ip=52.101.193.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="V4aKEUDd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=f7zZCPfDsgcN68gfS1Kxfx7/Wlb0XkNEXKq1lblViPm+hWDaWYaEXyd0UIOEzU+NIEUJtOqj0ye0wwtJjah12rqewpQZrWWf9XJhiMJcDrobT0UQj94pokY/LhcmtUgruQK+iBQGRMe+kLFuTbe+9wwiHRBU8lufU58SNpU0gfRX3yJBKngJ7IDydv+2a8tUktQh0LK+h3w4UkZcyx/eo9F9rcAwqHYCvvuz351XIRQefgU6ypJplMans+HQ09KW1+3So6y5V/0QeIRcw129YPrurJar3/YLlJSVDbKBvNtAU7krVAfAVe7Jb/PS543f5OA1jU9P4OEs4uqgkgYvVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UWfHDE9i3qQbjbuD6cpNJFQQEXtuczteLVNRSzlCGbo=; b=VobbonT/3v9JjCqdYwsQch5KgVd73tmX4Baf5+9poa3G3U4QEo9pewPHt2/gYWSqHI1p9byXL5Zx6G3h9ud+DnH7RivZyA4uGa21mrVkZ1mtbT2uCr1ZrrZXPFWc6r62zr+aaJtxIpKNfuBfrVhyd/L8SghMdiKFs0kFIoQ9rPQbjZ82EjFT7W4f3A204uPpCDxqSo8j1Hn5rC0n2n443lhPPSsno12hKiLUELDG3AZncL9b9GAzVPVYBCrVQpVlDFtth+HKTab4aWWIeiK6gJ9l49yoj06kvoi65jTheAc6XqtRzPKyDW6HWjWd6GO4WFGQhGtMvy4Ve0hHa0xZPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UWfHDE9i3qQbjbuD6cpNJFQQEXtuczteLVNRSzlCGbo=; b=V4aKEUDdSJyePD2jPMPvajaedsrYbwH6MQVWgnBZ59dwaqui1qwWIN8zanFqbn6L8u2/gsZecpHdRXdOS7MLSSHd/Hx2BUjtrRBlRNOP9KNGeqxtdnOqGCn9BfzLoGnlSQMCVVcd6aTm/NRqVJhQF21zOfOEIQmzCMxIYmesuwg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from BN3PR01MB9212.prod.exchangelabs.com (2603:10b6:408:2cb::8) by CO1PR01MB8916.prod.exchangelabs.com (2603:10b6:303:26f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Tue, 3 Mar 2026 21:37:05 +0000 Received: from BN3PR01MB9212.prod.exchangelabs.com ([fe80::44f3:1050:dce8:1ea9]) by BN3PR01MB9212.prod.exchangelabs.com ([fe80::44f3:1050:dce8:1ea9%6]) with mapi id 15.20.9654.015; Tue, 3 Mar 2026 21:37:05 +0000 From: Adam Young To: Jeremy Kerr , Matt Johnston , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , Jonathan Cameron , Huisong Li Subject: [net-next v32 2/2] mctp pcc: Implement MCTP over PCC Transport Date: Tue, 3 Mar 2026 16:36:46 -0500 Message-ID: <20260303213649.237851-3-admiyo@os.amperecomputing.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260303213649.237851-1-admiyo@os.amperecomputing.com> References: <20260303213649.237851-1-admiyo@os.amperecomputing.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CY5PR17CA0023.namprd17.prod.outlook.com (2603:10b6:930:17::25) To BN3PR01MB9212.prod.exchangelabs.com (2603:10b6:408:2cb::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PR01MB9212:EE_|CO1PR01MB8916:EE_ X-MS-Office365-Filtering-Correlation-Id: eb81c2bc-d01b-4f2c-0b4b-08de796d03be X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|7416014|1800799024|52116014|376014|366016; X-Microsoft-Antispam-Message-Info: f5Qhzf0BhDC5biiDsLn8/odM7fc72cb52BXAy8mToPytMUNqgmfBRqvapst4cBiquou/0aPFE7BPJqiXJl68NMyVORgpp3V6QHz2yq8SdsZ0hZuPk/yKGdAAi8xC6RNAjt3Wfrxjut4/PweowWaJOO6t/mur68Zne5sN0/wuP0HEjIwoS9fCcj185MERD3THzDmdZaw3GJ5pYhIlR/R6/IYxhm7nGFj36OR8lZFrE4WOlh59OJ4K9OZz5wUyOr88WC29AMQAA/dIswbSTZJgtPCbLBM3lsN14cxtnGQ6ccJs2EoyACJLCPxV6lxqXBvQ1X2aQNbbdhLVIXK+Q0cnAI9AhmaR1ncaNeWbrRj/yvkTKZJXtfqO/C6WbHMJlzUojq4WPA2wtsM6j5LHfIiyd94DQ4Ne8rSJzXu0SChJIUX4GMI6WTWk1bXeiMAy39UfFRshjKPi1r6z+PrTy3WRCMCuNFIli1+BosdXcSbWXRnRmcxcBJoaWZdE8gtuP9/5qGbHiAFIvAo8gC1jjqgy+7C9tp06YhL4cWVb8lETwCh0wD0hI6ykidtySDFEGQbwNC7CNUTpUuLPCnwIZoaiueWjcWBzV4IGdygR4ob3syt1BOL89l70E/YBwT3+1NaH9Db3kddLgY4Uxmzd/EsdcH+Ck+N22sLu1OFnIfg42PbO3cUBLum/ZjrBHXTcFd/f30oP5uGWEq+9YZZjsYP0NmVCJi1S9sVHYuRyf4GnmdE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN3PR01MB9212.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(7416014)(1800799024)(52116014)(376014)(366016);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n6Ixdw31ntivZWtBqskm5hjA8Mhxalo40jVt8JlJJgHSYlNubhV2f1mfDX1T?= =?us-ascii?Q?o8WDXqhPpYj00Tlyn5Iawn7yMxdG0JnHw9407OjCoeG8u9VKtXkJeRk+ya+Y?= =?us-ascii?Q?dM5ZfhVtgZjN+aql6NZ26HxB/JDIjFgVJgxAdXaLG6WBrD5+y2Dj16awBbMF?= =?us-ascii?Q?JkJP7xCis9lbPkVrOeYnppxSsSejznztv6Q7QFwmqa7LYI/ZEXuN4Ee2LFvA?= =?us-ascii?Q?VOFGlvNjI/eVgorhAdafOeddXwidkDSVysbmcFNBF6XLdk6j9ENO99SSQsxu?= =?us-ascii?Q?4TLuRcpy0ruGISA5CVXknMSE6o7XoMTOCApu/lRQeIS+UhJtH3sRQab1kE05?= =?us-ascii?Q?ImK9zwSZJ7XZO/fvUNFfEF+npLywjiAMbDTLXVm7pB/3m2pZH3xn/yxwYuiZ?= =?us-ascii?Q?EbVWIiGw5Kk4H+zyDsK0GGhHmlBtImok1PBRmcK4qfch737qceAbRDbWI2mH?= =?us-ascii?Q?nlJ32qa26WwPg3LZ5DZq8XoNIO5zxQmQMh3k88W6U3ZhQg44hQim+jBwjnSz?= =?us-ascii?Q?08zBOrJv7HAaRLgLk1KBdfpmFskdqmI+y1ZQHemSzi6oqUx3/IC/0dkc+sSY?= =?us-ascii?Q?od8PdvuyY9/H/TXLdsbavljpR+PjQIo1iP9eOXLqJ9oWWyk4EEiQ39TW1E3z?= =?us-ascii?Q?OCh6lAv7aayd/nmjFePsCCXCPIybmZtJZFvUcZV/xTiPkaB+MqK8/uRJasrQ?= =?us-ascii?Q?IPIXKRK2AswGtnXx1HJs4XrvCzmaBM4ma+3HPqrP7n5qGKUjmdjD19HuTxMY?= =?us-ascii?Q?NMo9b84MBImgfEWcZSgc/AOQHnSGJBaWkn3GVhuI2j58yaPNgwi22VzlYZhh?= =?us-ascii?Q?DJ4VYJXlQphc9A0B/IusXIw13N7pf8lsXiRjFQUOj3YLheP8fKO7t83PpuF1?= =?us-ascii?Q?eTzgHtNRLwupbLLn0KmIIKod+Y7cCBYhJuPaHlR/plv3v54faxYRnA0tEwed?= =?us-ascii?Q?sW/mpqkMvm3mfKQ2kzBkRVZYS/ZLNI0Z07w/HrLl+1ep/Kx6fg0d7icLMcbf?= =?us-ascii?Q?aa29zlmBG0gbIyYbiQyIrYjQsNOxVFYBcjkBS66/M8nZ+FaRBXs2S9fYXZRw?= =?us-ascii?Q?6290HNNLtaO2ASlPe7NGAo9vglYpG2KvRoHRoJrPnd9xNoEiXCpELsaFh2M+?= =?us-ascii?Q?nn7TNTenOzTtPar5xYLpaYEB7n68NaaRorB8630dxrGB2vHti/BPyyq9XcPI?= =?us-ascii?Q?ddBs7ugt/5sU4IXDsBwW5C+cCh/zfxT7MeWlry+IIUoZMtFEkZg7LE8xAP3z?= =?us-ascii?Q?z3TyQzSWwH5QKeUsmI/RNFGK1jpZ0om2PHGEYU6ZZNcQwwl+4K7C6cCMqCCY?= =?us-ascii?Q?K0Ar9JuaKWA8iYkGhEwm7UG9gPOx5dGjXOKm9EJFV1omSJ8+55OKR225a/lA?= =?us-ascii?Q?sL5lt2hlrC2jrz404ZUwb/ymQey/8vJia9iMWRHMWqFf/k/xHWZyt5ChTgRP?= =?us-ascii?Q?++ptcEIct7rYSoU1Kre/93iandWkl0EDT6lNGzI5QSyoKrdObVCMaTYPGYRu?= =?us-ascii?Q?l1eINhZZqYqjqiVHD9hD0x3/kzYAKekVRtTNr0dcgxR+QZuit00236sV6BHP?= =?us-ascii?Q?Y7AlvjXRH12ldGcZBBhG9Fus5jbKL34FV8Klx7aHShvGwmk1RxXasbWgSAGQ?= =?us-ascii?Q?RrYN6O3VKBaJnRYwI5Sc9P8bhNTlXhyvWld4HxdvP/KHAfXTVyAPqkRNUkvl?= =?us-ascii?Q?RCGbvQpvQGqUnfadNtQEyCTsWcVPKUkIghYLCfn+4/Yk+tG5onC9GEGSvM+b?= =?us-ascii?Q?HUcvDQWzgBA40Y/DEzW0JJT3BGWDbnVJrodFpcdPRLCqXHdquMLoSQm4yFpb?= X-MS-Exchange-AntiSpam-MessageData-1: V6H+8NLtI//WQzhU6C7EKOYVJgHMYxIJd5mZf//OM5c2hcKYqoeBEKUp X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb81c2bc-d01b-4f2c-0b4b-08de796d03be X-MS-Exchange-CrossTenant-AuthSource: BN3PR01MB9212.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 21:37:05.6720 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /+tuHfeNpwkFTIel1nxWuH3Wo99ypk0fdj3HQcEnTcLgGx/DkytVKG/CrIPYIuZASkE071JrY1FENLlgD629alg1nmJ+qjYcDHwF886tLGraYsdNcip1hK3wrMx0M4pL X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR01MB8916 Content-Type: text/plain; charset="utf-8" Implementation of network driver for Management Component Transport Protocol(MCTP) over Platform Communication Channel(PCC) DMTF DSP:0292 https://www.dmtf.org/sites/default/files/standards/documents/\ DSP0292_1.0.0WIP50.pdf MCTP devices are specified via ACPI by entries in DSDT/SSDT and reference channels specified in the PCCT. Messages are sent on a type 3 and received on a type 4 channel. Communication with other devices use the PCC based doorbell mechanism; a shared memory segment with a corresponding interrupt and a memory register used to trigger remote interrupts. This driver takes advantage of PCC mailbox shared functions management. Unlike the existing Type 2 drivers, the mssg parameter is actively used. The data section of the struct sk_buff that contains the outgoing packet is sent to the mailbox, already properly formatted as a PCC exctended message. The driver makes use of the pcc mailbox buffer management helpers. These allow the network driver to use common code for the reading and wrting from the shared memory buffer to the mailbox driver, attempting to get a single implementation of the PCC protocol for Type3/4. If the mailbox ring buffer is full, the driver stops the incoming packet queues until a message has been sent, freeing space in the ring buffer. When the Type 3 channel outbox receives a txdone response interrupt, it consumes the outgoing sk_buff, allowing it to be freed. Bringing up an interface creates the channel between the network driver and the mailbox driver. This enables communication with the remote endpoint, to include the receipt of new messages. Bringing down an interface removes the channel, and no new messages can be delivered. Stopping the interface also frees any packets that are cached in the mailbox ringbuffer. Signed-off-by: Adam Young --- MAINTAINERS | 5 + drivers/net/mctp/Kconfig | 13 ++ drivers/net/mctp/Makefile | 1 + drivers/net/mctp/mctp-pcc.c | 322 ++++++++++++++++++++++++++++++++++++ 4 files changed, 341 insertions(+) create mode 100644 drivers/net/mctp/mctp-pcc.c diff --git a/MAINTAINERS b/MAINTAINERS index 2265e2c9bfbe..16610b0fa58d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15292,6 +15292,11 @@ F: include/net/mctpdevice.h F: include/net/netns/mctp.h F: net/mctp/ =20 +MANAGEMENT COMPONENT TRANSPORT PROTOCOL (MCTP) over PCC (MCTP-PCC) Driver +M: Adam Young +S: Maintained +F: drivers/net/mctp/mctp-pcc.c + MAPLE TREE M: Liam R. Howlett R: Alice Ryhl diff --git a/drivers/net/mctp/Kconfig b/drivers/net/mctp/Kconfig index cf325ab0b1ef..77cd4091050c 100644 --- a/drivers/net/mctp/Kconfig +++ b/drivers/net/mctp/Kconfig @@ -47,6 +47,19 @@ config MCTP_TRANSPORT_I3C A MCTP protocol network device is created for each I3C bus having a "mctp-controller" devicetree property. =20 +config MCTP_TRANSPORT_PCC + tristate "MCTP PCC transport" + depends on ACPI + help + Provides a driver to access MCTP devices over PCC transport, + A MCTP protocol network device is created via ACPI for each + entry in the DSDT/SSDT that matches the identifier. The Platform + communication channels are selected from the corresponding + entries in the PCCT. + + Say y here if you need to connect to MCTP endpoints over PCC. To + compile as a module, use m; the module will be called mctp-pcc. + config MCTP_TRANSPORT_USB tristate "MCTP USB transport" depends on USB diff --git a/drivers/net/mctp/Makefile b/drivers/net/mctp/Makefile index c36006849a1e..0a591299ffa9 100644 --- a/drivers/net/mctp/Makefile +++ b/drivers/net/mctp/Makefile @@ -1,4 +1,5 @@ obj-$(CONFIG_MCTP_SERIAL) +=3D mctp-serial.o obj-$(CONFIG_MCTP_TRANSPORT_I2C) +=3D mctp-i2c.o obj-$(CONFIG_MCTP_TRANSPORT_I3C) +=3D mctp-i3c.o +obj-$(CONFIG_MCTP_TRANSPORT_PCC) +=3D mctp-pcc.o obj-$(CONFIG_MCTP_TRANSPORT_USB) +=3D mctp-usb.o diff --git a/drivers/net/mctp/mctp-pcc.c b/drivers/net/mctp/mctp-pcc.c new file mode 100644 index 000000000000..d0e7699ebe82 --- /dev/null +++ b/drivers/net/mctp/mctp-pcc.c @@ -0,0 +1,322 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * mctp-pcc.c - Driver for MCTP over PCC. + * Copyright (c) 2024-2025, Ampere Computing LLC + * + */ + +/* Implementation of MCTP over PCC DMTF Specification DSP0256 + * https://www.dmtf.org/sites/default/files/standards/documents/DSP0292_1.= 0.0WIP50.pdf + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include +#include + +#define MCTP_SIGNATURE "MCTP" +#define MCTP_SIGNATURE_LENGTH (sizeof(MCTP_SIGNATURE) - 1) +#define MCTP_MIN_MTU 68 +#define PCC_DWORD_TYPE 0x0c + +struct mctp_pcc_mailbox { + u32 index; + struct pcc_mbox_chan *chan; + struct mbox_client client; +}; + +/* The netdev structure. One of these per PCC adapter. */ +struct mctp_pcc_ndev { + struct net_device *ndev; + struct acpi_device *acpi_device; + struct mctp_pcc_mailbox inbox; + struct mctp_pcc_mailbox outbox; +}; + +static void mctp_pcc_client_rx_callback(struct mbox_client *cl, void *mssg) +{ + struct acpi_pcct_ext_pcc_shared_memory pcc_header; + struct mctp_pcc_ndev *mctp_pcc_ndev; + struct mctp_pcc_mailbox *inbox; + struct mctp_skb_cb *cb; + struct sk_buff *skb; + int size; + + mctp_pcc_ndev =3D container_of(cl, struct mctp_pcc_ndev, inbox.client); + inbox =3D &mctp_pcc_ndev->inbox; + size =3D pcc_mbox_query_bytes_available(inbox->chan); + if (size =3D=3D 0) + return; + skb =3D netdev_alloc_skb(mctp_pcc_ndev->ndev, size); + if (!skb) { + dev_dstats_rx_dropped(mctp_pcc_ndev->ndev); + return; + } + skb_put(skb, size); + skb->protocol =3D htons(ETH_P_MCTP); + pcc_mbox_read_from_buffer(inbox->chan, size, skb->data); + dev_dstats_rx_add(mctp_pcc_ndev->ndev, skb->len); + skb_reset_mac_header(skb); + skb_pull(skb, sizeof(pcc_header)); + skb_reset_network_header(skb); + cb =3D __mctp_cb(skb); + cb->halen =3D 0; + netif_rx(skb); +} + +static netdev_tx_t mctp_pcc_tx(struct sk_buff *skb, struct net_device *nde= v) +{ + struct acpi_pcct_ext_pcc_shared_memory *pcc_header; + struct mctp_pcc_ndev *mpnd =3D netdev_priv(ndev); + int len =3D skb->len; + int rc; + + rc =3D skb_cow_head(skb, sizeof(*pcc_header)); + if (rc) { + dev_dstats_tx_dropped(ndev); + kfree_skb(skb); + return NETDEV_TX_OK; + } + + pcc_header =3D skb_push(skb, sizeof(*pcc_header)); + pcc_header->signature =3D PCC_SIGNATURE | mpnd->outbox.index; + pcc_header->flags =3D PCC_CMD_COMPLETION_NOTIFY; + memcpy(&pcc_header->command, MCTP_SIGNATURE, MCTP_SIGNATURE_LENGTH); + pcc_header->length =3D len + MCTP_SIGNATURE_LENGTH; + + rc =3D mbox_send_message(mpnd->outbox.chan->mchan, skb); + if (rc < 0) { + netif_stop_queue(ndev); + return NETDEV_TX_BUSY; + } + + dev_dstats_tx_add(ndev, len); + return NETDEV_TX_OK; +} + +static void mctp_pcc_tx_prepare(struct mbox_client *cl, void *mssg) +{ + struct mctp_pcc_ndev *mctp_pcc_ndev; + struct mctp_pcc_mailbox *outbox; + struct sk_buff *skb =3D mssg; + int len_sent; + + mctp_pcc_ndev =3D container_of(cl, struct mctp_pcc_ndev, outbox.client); + outbox =3D &mctp_pcc_ndev->outbox; + + if (!skb) + return; + + len_sent =3D pcc_mbox_write_to_buffer(outbox->chan, skb->len, skb->data); + if (len_sent =3D=3D 0) + netdev_info(mctp_pcc_ndev->ndev, "packet dropped"); +} + +static void mctp_pcc_tx_done(struct mbox_client *c, void *mssg, int r) +{ + struct mctp_pcc_ndev *mctp_pcc_ndev; + struct sk_buff *skb =3D mssg; + + mctp_pcc_ndev =3D container_of(c, struct mctp_pcc_ndev, outbox.client); + dev_consume_skb_any(skb); + netif_wake_queue(mctp_pcc_ndev->ndev); +} + +static int mctp_pcc_ndo_open(struct net_device *ndev) +{ + struct mctp_pcc_ndev *mctp_pcc_ndev =3D netdev_priv(ndev); + struct mctp_pcc_mailbox *outbox, *inbox; + + outbox =3D &mctp_pcc_ndev->outbox; + inbox =3D &mctp_pcc_ndev->inbox; + + outbox->chan =3D pcc_mbox_request_channel(&outbox->client, outbox->index); + if (IS_ERR(outbox->chan)) + return PTR_ERR(outbox->chan); + + inbox->client.rx_callback =3D mctp_pcc_client_rx_callback; + inbox->chan =3D pcc_mbox_request_channel(&inbox->client, inbox->index); + if (IS_ERR(inbox->chan)) { + pcc_mbox_free_channel(outbox->chan); + return PTR_ERR(inbox->chan); + } + return 0; +} + +static int mctp_pcc_ndo_stop(struct net_device *ndev) +{ + struct mctp_pcc_ndev *mctp_pcc_ndev =3D netdev_priv(ndev); + + pcc_mbox_free_channel(mctp_pcc_ndev->outbox.chan); + pcc_mbox_free_channel(mctp_pcc_ndev->inbox.chan); + return 0; +} + +static const struct net_device_ops mctp_pcc_netdev_ops =3D { + .ndo_open =3D mctp_pcc_ndo_open, + .ndo_stop =3D mctp_pcc_ndo_stop, + .ndo_start_xmit =3D mctp_pcc_tx, +}; + +static void mctp_pcc_setup(struct net_device *ndev) +{ + ndev->type =3D ARPHRD_MCTP; + ndev->hard_header_len =3D sizeof(struct acpi_pcct_ext_pcc_shared_memory); + ndev->tx_queue_len =3D 0; + ndev->flags =3D IFF_NOARP; + ndev->netdev_ops =3D &mctp_pcc_netdev_ops; + ndev->needs_free_netdev =3D true; + ndev->pcpu_stat_type =3D NETDEV_PCPU_STAT_DSTATS; +} + +struct mctp_pcc_lookup_context { + int index; + u32 inbox_index; + u32 outbox_index; +}; + +static acpi_status lookup_pcct_indices(struct acpi_resource *ares, + void *context) +{ + struct mctp_pcc_lookup_context *luc =3D context; + struct acpi_resource_address32 *addr; + + if (ares->type !=3D PCC_DWORD_TYPE) + return AE_OK; + + addr =3D ACPI_CAST_PTR(struct acpi_resource_address32, &ares->data); + switch (luc->index) { + case 0: + luc->outbox_index =3D addr[0].address.minimum; + break; + case 1: + luc->inbox_index =3D addr[0].address.minimum; + break; + } + luc->index++; + return AE_OK; +} + +static void mctp_cleanup_netdev(void *data) +{ + struct net_device *ndev =3D data; + + mctp_unregister_netdev(ndev); +} + +static int initialize_MTU(struct net_device *ndev) +{ + struct mctp_pcc_ndev *mctp_pcc_ndev; + struct mctp_pcc_mailbox *outbox; + struct pcc_mbox_chan *pchan; + int mctp_pcc_mtu; + + mctp_pcc_mtu =3D MCTP_MIN_MTU; + mctp_pcc_ndev =3D netdev_priv(ndev); + outbox =3D &mctp_pcc_ndev->outbox; + + pchan =3D pcc_mbox_request_channel(&outbox->client, outbox->index); + if (IS_ERR(pchan)) + return -1; + + mctp_pcc_mtu =3D pchan->shmem_size; + pcc_mbox_free_channel(pchan); + + mctp_pcc_mtu =3D mctp_pcc_mtu - sizeof(struct acpi_pcct_ext_pcc_shared_me= mory); + ndev->mtu =3D MCTP_MIN_MTU; + ndev->max_mtu =3D mctp_pcc_mtu; + ndev->min_mtu =3D MCTP_MIN_MTU; + + return 0; +} + +static int mctp_pcc_driver_add(struct acpi_device *acpi_dev) +{ + struct mctp_pcc_lookup_context context =3D {0}; + struct mctp_pcc_ndev *mctp_pcc_ndev; + struct device *dev =3D &acpi_dev->dev; + struct net_device *ndev; + acpi_handle dev_handle; + acpi_status status; + char name[32]; + int rc; + + dev_dbg(dev, "Adding mctp_pcc device for HID %s\n", + acpi_device_hid(acpi_dev)); + dev_handle =3D acpi_device_handle(acpi_dev); + status =3D acpi_walk_resources(dev_handle, "_CRS", lookup_pcct_indices, + &context); + if (!ACPI_SUCCESS(status)) { + dev_err(dev, "FAILED to lookup PCC indexes from CRS\n"); + return -EINVAL; + } + + snprintf(name, sizeof(name), "mctppcc%d", context.inbox_index); + ndev =3D alloc_netdev(sizeof(*mctp_pcc_ndev), name, NET_NAME_PREDICTABLE, + mctp_pcc_setup); + if (!ndev) + return -ENOMEM; + + mctp_pcc_ndev =3D netdev_priv(ndev); + + mctp_pcc_ndev->inbox.index =3D context.inbox_index; + mctp_pcc_ndev->inbox.client.dev =3D dev; + mctp_pcc_ndev->outbox.index =3D context.outbox_index; + mctp_pcc_ndev->outbox.client.dev =3D dev; + + mctp_pcc_ndev->outbox.client.tx_prepare =3D mctp_pcc_tx_prepare; + mctp_pcc_ndev->outbox.client.tx_done =3D mctp_pcc_tx_done; + mctp_pcc_ndev->acpi_device =3D acpi_dev; + mctp_pcc_ndev->ndev =3D ndev; + acpi_dev->driver_data =3D mctp_pcc_ndev; + + rc =3D initialize_MTU(ndev); + if (rc) + goto free_netdev; + + rc =3D mctp_register_netdev(ndev, NULL, MCTP_PHYS_BINDING_PCC); + if (rc) + goto free_netdev; + + return devm_add_action_or_reset(dev, mctp_cleanup_netdev, ndev); +free_netdev: + free_netdev(ndev); + return rc; +} + +static const struct acpi_device_id mctp_pcc_device_ids[] =3D { + { "DMT0001" }, + {} +}; + +static struct acpi_driver mctp_pcc_driver =3D { + .name =3D "mctp_pcc", + .class =3D "Unknown", + .ids =3D mctp_pcc_device_ids, + .ops =3D { + .add =3D mctp_pcc_driver_add, + }, +}; + +module_acpi_driver(mctp_pcc_driver); + +MODULE_DEVICE_TABLE(acpi, mctp_pcc_device_ids); + +MODULE_DESCRIPTION("MCTP PCC ACPI device"); +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Adam Young "); --=20 2.43.0